maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Check for the current version of foreman when deciding to install (#14682)

Browse source 
* Check for the current version of foreman when deciding to install

0.87.1 was current when this was added, but `gem install foreman` now
installs 0.87.2, so this check always fails (I do not have the older
version present).

I'm suspecting we either don't want to version pin this test (assume
whatever version of foreman installed is fine) or we need to use
something like the Gemfile to have dependabot keep this version info
in sync with the upstream.

All I do here is update the current release version to test against.

* Remove foreman version constraint

If any version of (very stable) foreman is installed, assume it's
recent enough to run the (also very stable) Procfile

Only install foreman gem if it's not installed. Updates are on the user.
This commit is contained in:
Daniel Uber 2021-09-08 09:31:23 -05:00 • committed by GitHub
parent a3da4f9bc4
commit 1253d90114
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
bin/setup
View file

@ -20,7 +20,7 @@ FileUtils.chdir APP_ROOT do
system! "bundle config --local ignore_messages.rpush true"
system("bundle check") || system!("bundle install")
system! "gem list \"^foreman$\" -v 0.87.1 -i --silent || gem install foreman"
system! "gem list \"^foreman$\" -i --silent || gem install foreman"
# Install JavaScript dependencies if using Yarn
system("bin/yarn")