From 1253d90114c0c795b36de31d10ab2476b716125d Mon Sep 17 00:00:00 2001 From: Daniel Uber Date: Wed, 8 Sep 2021 09:31:23 -0500 Subject: [PATCH] Check for the current version of foreman when deciding to install (#14682) * Check for the current version of foreman when deciding to install 0.87.1 was current when this was added, but `gem install foreman` now installs 0.87.2, so this check always fails (I do not have the older version present). I'm suspecting we either don't want to version pin this test (assume whatever version of foreman installed is fine) or we need to use something like the Gemfile to have dependabot keep this version info in sync with the upstream. All I do here is update the current release version to test against. * Remove foreman version constraint If any version of (very stable) foreman is installed, assume it's recent enough to run the (also very stable) Procfile Only install foreman gem if it's not installed. Updates are on the user. --- bin/setup | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/setup b/bin/setup index e0fb2b846..2c1679c5d 100755 --- a/bin/setup +++ b/bin/setup @@ -20,7 +20,7 @@ FileUtils.chdir APP_ROOT do system! "bundle config --local ignore_messages.rpush true" system("bundle check") || system!("bundle install") - system! "gem list \"^foreman$\" -v 0.87.1 -i --silent || gem install foreman" + system! "gem list \"^foreman$\" -i --silent || gem install foreman" # Install JavaScript dependencies if using Yarn system("bin/yarn")