Commit graph

3330 commits

Author SHA1 Message Date
Ben Halpern
c817ac0192
Fix missing series in article edit form (v2) (#4867) [deploy] 2019-11-22 08:33:55 -05:00
Jacob Herrington
c6c5421163 Javascript automated testing and a11y doc (#4873)
* Add jext-axe package and introduce a11y testing

Automated a11y testing is NOT comprehensive. We cannot expect this to
even scratch the surface of potential a11y issues.

However, we can expect to find a percentage of issues that are currently
flying under the radar. Adopting some automation around a11y testing
also allows us to use CI to find a11y regressions -- which should be
really handy.

I've never really used Jest before, and Preact seems to make it a little
more complicated, but as far as I can tell, this is a decent way to add
at least some minor automated a11y testing.

* Add doc about automated a11y tests
2019-11-22 08:32:01 -05:00
Spencer
e5ee2f9013 Mod tooling: add tags via /mod (#4750) [deploy]
* added tests to specs

* added view logic

* added controller/model functionality

* minor tweak to tagadjustment view

* adjusted mod view to reduce query

* added instance variables to controller

* show already adjusted tags in mod view

* removed unnecessary ifs from mods controller

* catch and display errors to tag adjustment forms

* update specs and refactor
2019-11-21 16:32:32 -05:00
Jacob Herrington
10426fbef5 Delete a commented out test (#4875) 2019-11-21 15:14:12 -05:00
dependabot-preview[bot]
5d688fc0a6 Bump acts-as-taggable-on from 6.0.0 to 6.5.0 (#4854) 2019-11-21 14:56:28 -05:00
shaneblackburn
9d7817b025 Disable like button b/w click & backend response (#4869) [deploy] 2019-11-21 12:31:40 -06:00
rhymes
c8903876c6 Upgrade docs Ruby version to 2.6.5, same as the main app (#4872) 2019-11-21 08:16:13 -05:00
John Curcio
157a6f1ef1 Add pagination to followers and following page in dashboard (#258) (#4375) [deploy]
* Add infinite scroll to followers list (#258)

* Refactor fetchNext function for clarity (#258)

* Sepparate following tab into multiple tabs to support infinite scroll (#258)

* Add infinite scroll to following pages (#258)

* Add tests to infinite scroll api

* Refactor dashboard loading text

* Refactor infine scroll function

* Fix duplicated entries problem in infinite scrolling

* Switch randomized attributes to sequential to avoid InvalidRecord error

* Add acceptance tests for infinite scroll

* Remove unused following method

* parameterize limit per page for followers and followings

* Split follows endpoint into followers and followings

* Authenticate user with api key in followers and followings

* Split followers endpoint into users and organizations

* Add redundant html to sublist partial

* Speed up infinite scroll tests

* Refactor api json responses to use partials

* Authenticate api user before follows create

* Resolve conflicts on scrolling js

* Improve partials organization and fix organization username bug

* Improve readability of unauthorized test

* Use let! to create scrolling test data

* Fix not working podcasts link

* Refactor initScrolling to remove linting errors

* Fix codeclimate coding style issue

* Test tags forms and podcasts hyperlinks

* Fix eslint issue with double equals

* Improve before_action usage and readability
2019-11-20 18:21:18 -05:00
Bolarinwa Balogun
4536d35716 Fix broken layout from "additional config/settings" overlap (#4858) [deploy]
* Fix broken layout from "additional config/settings" overlap

* Resolve bugs by adding important state fields
2019-11-20 14:34:30 -05:00
Helmi Hidzir
4e4762e3a1 Add - to support dash character in JSitor liquid tag (#4830) [deploy]
* Add - to support dash character in JSitor liquid tag

* Edit spec/liquid_tags/jsitor_tag_spec.rb

* Add support for link with hyphen id in jsitor liquid tag
2019-11-20 13:36:51 -05:00
rhymes
0ef4ce4250 Adjust type tags for RSpec (#4864) 2019-11-20 13:01:30 -05:00
Mac Siri
d2373b5678
Add Clipboard polyfill (#4824) [deploy] 2019-11-20 11:32:30 -05:00
rhymes
b0eec90b24 Add additional keys to site configuration (#4861) [deploy]
* Add rate_limit_follow_count_daily to SiteConfig

* Add favicon_url to SiteConfig

* Add logo_svg to SiteConfig

* Add staff_user_id to SiteConfig

* Add default_site_email to SiteConfig

* Add social_networks_handle to SiteConfig

* Add ga_view_id and ga_fetch_rate to SiteConfig

* Add mailchimp newsletters IDs to SiteConfig

* Add periodic_email_digest_max, periodic_email_digest_min to SiteConfig
2019-11-20 10:58:10 -05:00
Nico Domino
8140ab6330 Updated 'ten-x-hacker' var --theme-anchor-color (#4836) 2019-11-19 10:58:20 -05:00
rhymes
c15d48265a Routine rubocop fixes (#4859) 2019-11-19 10:46:47 -05:00
rhymes
05bd144cde Enable action_view.form_with_generates_ids (#4829) [deploy] 2019-11-19 09:32:48 -05:00
Anna Buianova
809dbceba7 Allow while displaying podcasts episodes processed html (#4816) 2019-11-19 09:23:19 -05:00
Keith Bennett
b9069a2feb Simplify sort tests in user_sorts_dashboard_articles_spec.rb (#4841) [deploy]
* Simplify sort tests.

* Rename some identifiers.
2019-11-18 18:52:30 -05:00
rohan-techfreak
bf867a624a Add lazy loading to iframes (#4673) 2019-11-18 18:31:56 -05:00
rhymes
c1aaf53a40 Add SiteConfig to internal and enable "main_social_image" (#4831) [deploy]
* Redirect /internal to /internal/articles avoiding annoying 404

* Set the navbar on two rows

* Add :main_social_image to SiteConfig and to the internal view

* Add simple tests

* Ameliorate the UI
2019-11-18 18:19:20 -05:00
dependabot-preview[bot]
c72cac60b8 Bump puma from 4.2.1 to 4.3.0 (#4779) [deploy]
Bumps [puma](https://github.com/puma/puma) from 4.2.1 to 4.3.0.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](https://github.com/puma/puma/compare/v4.2.1...v4.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-18 16:53:07 -05:00
dependabot-preview[bot]
22e0eb32a3 Bump cloudinary from 1.12.0 to 1.13.0 (#4850) [deploy]
Bumps [cloudinary](https://github.com/cloudinary/cloudinary_gem) from 1.12.0 to 1.13.0.
- [Release notes](https://github.com/cloudinary/cloudinary_gem/releases)
- [Changelog](https://github.com/cloudinary/cloudinary_gem/blob/master/CHANGELOG.md)
- [Commits](https://github.com/cloudinary/cloudinary_gem/compare/1.12.0...1.13.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-18 16:18:43 -05:00
dependabot-preview[bot]
24bd9206da Bump twilio-video from 1.19.2 to 1.20.0 (#4842)
Bumps [twilio-video](https://github.com/twilio/twilio-video.js) from 1.19.2 to 1.20.0.
- [Release notes](https://github.com/twilio/twilio-video.js/releases)
- [Changelog](https://github.com/twilio/twilio-video.js/blob/1.20.0/CHANGELOG.md)
- [Commits](https://github.com/twilio/twilio-video.js/compare/1.19.2...1.20.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-18 16:04:20 -05:00
dependabot-preview[bot]
3be3be2b72 Bump lint-staged from 9.4.2 to 9.4.3 (#4845)
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 9.4.2 to 9.4.3.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Commits](https://github.com/okonet/lint-staged/compare/v9.4.2...v9.4.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-18 16:00:56 -05:00
dependabot-preview[bot]
3c586ae759 Bump chart.js from 2.9.2 to 2.9.3 (#4846)
Bumps [chart.js](https://github.com/chartjs/Chart.js) from 2.9.2 to 2.9.3.
- [Release notes](https://github.com/chartjs/Chart.js/releases)
- [Commits](https://github.com/chartjs/Chart.js/compare/v2.9.2...v2.9.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-18 16:00:14 -05:00
dependabot-preview[bot]
ff65fddfd8 Bump rubocop from 0.75.1 to 0.76.0 (#4848)
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.75.1 to 0.76.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.75.1...v0.76.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-18 15:59:26 -05:00
dependabot-preview[bot]
933805063b Bump eslint-config-prettier from 6.5.0 to 6.6.0 (#4844)
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 6.5.0 to 6.6.0.
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-config-prettier/compare/v6.5.0...v6.6.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-18 15:58:03 -05:00
dependabot-preview[bot]
9990739012 Bump husky from 3.0.9 to 3.1.0 (#4847)
Bumps [husky](https://github.com/typicode/husky) from 3.0.9 to 3.1.0.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](https://github.com/typicode/husky/compare/v3.0.9...v3.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-18 15:57:37 -05:00
dependabot-preview[bot]
2366b2f076 Bump derailed_benchmarks from 1.4.1 to 1.4.2 (#4849)
Bumps [derailed_benchmarks](https://github.com/schneems/derailed_benchmarks) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/schneems/derailed_benchmarks/releases)
- [Changelog](https://github.com/schneems/derailed_benchmarks/blob/master/CHANGELOG.md)
- [Commits](https://github.com/schneems/derailed_benchmarks/compare/v1.4.1...v1.4.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-18 15:56:19 -05:00
dependabot-preview[bot]
57c94919a9 Bump libhoney from 1.14.0 to 1.14.1 (#4853)
Bumps [libhoney](https://github.com/honeycombio/libhoney-rb) from 1.14.0 to 1.14.1.
- [Release notes](https://github.com/honeycombio/libhoney-rb/releases)
- [Commits](https://github.com/honeycombio/libhoney-rb/compare/v1.14.0...v1.14.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-18 15:55:39 -05:00
dependabot-preview[bot]
a4a1f9bffc Bump honeycomb-beeline from 1.1.1 to 1.2.0 (#4852)
Bumps [honeycomb-beeline](https://github.com/honeycombio/beeline-ruby) from 1.1.1 to 1.2.0.
- [Release notes](https://github.com/honeycombio/beeline-ruby/releases)
- [Commits](https://github.com/honeycombio/beeline-ruby/compare/v1.1.1...v1.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-18 15:55:12 -05:00
dependabot-preview[bot]
90249e6b17 Bump webdrivers from 4.1.2 to 4.1.3 (#4851)
Bumps [webdrivers](https://github.com/titusfortner/webdrivers) from 4.1.2 to 4.1.3.
- [Release notes](https://github.com/titusfortner/webdrivers/releases)
- [Changelog](https://github.com/titusfortner/webdrivers/blob/master/CHANGELOG.md)
- [Commits](https://github.com/titusfortner/webdrivers/compare/v4.1.2...v4.1.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-18 15:54:40 -05:00
Lorna Tumuhairwe
c889e6b6c0 Center podcast page footer (#4797) [deploy] 2019-11-15 14:14:14 -05:00
jeffin sam
da2fa608c2 Move social_image cache to Redis (#4818) 2019-11-15 14:03:41 -05:00
jeffin sam
e92b005d02 Move caching of reaction to rediscache (#4819) 2019-11-15 13:38:46 -05:00
jeffin sam
7cc5ef5e40 Write to RedisCache to avoid cache miss in add html_css_to_image (#4821) [deploy] 2019-11-15 13:09:18 -05:00
jeffin sam
fbbb02e241 Move bufferized tags to RedisCache (#4817) 2019-11-14 17:37:20 -05:00
Molly Struve
672d64c2ca
Avoid N+1 queries when sending notifications for reactions (#4822) [deploy] 2019-11-14 14:36:20 -06:00
rhymes
2ca23c8983 Enable AES-256-GCM on encrypted cookies (#4216) [deploy] 2019-11-14 13:08:47 -05:00
Molly Struve
09de46c92a Remove Scout APM now that we have Honeycomb in place for detailed request monitoring (#4815) [deploy] 2019-11-14 11:03:10 -05:00
Molly Struve
d1b82dfdaf Move cached_followed_tag_names to Redis (#4812)
* Move cached_followed_tag_names to Redis and change key to use following_tags_count rather than updated_at

* use last_followed_at for cache key as well

* format last_followed_at with rfc3339
2019-11-14 09:57:33 -05:00
aRtoo
9b5b2ee98d Redo JSitor (#4762) [deploy]
* Redo JSitor
- can now accept full url with params
- added more test
- redo jsitor guide

* Jsitor redo guide
- moved below JSFiddle
- add more instructions

* Refactor JSitor liquid tag
- Change the iframe size to 400
- can accept ID with or without params
- added ID_REGEX to check for id
- add more information on error
- added more test
  - test for id with invalid link
  - test for id with params
  - test for id without params

* Refactor
- simplified regex, removed unnecessary groupings
- changed method name from link_valid? to validate_link
- changed error message
2019-11-14 09:17:47 -05:00
Ben Halpern
015b4bbc87
Update docs with more architecture info (#4813) 2019-11-14 08:58:47 -05:00
Anna Buianova
41ab013050 Normalize podcast url before checking for reachability (#4806)
* Normalize podcast url before checking for reachability

* Added to_s when normalizing episode url and simplified tests
2019-11-14 08:58:29 -05:00
Molly Struve
880f60beff
Move user_data async controller cache to Redis (#4809) [deploy] 2019-11-13 10:25:17 -06:00
Michael Kohl
b57ced5466 CacheBuster refactoring (#4766)
* Turn CacheBuster into a module

This class used no internal state, so repeatedly creating short-lived objects seems wasteful.

* Consistently use string interpolation and parenthesis

* Destructure arrays into meaningful names, formatting

* Fix request spec for internal classified listings controller

Interestingly this works when asserting directly on the module, but not on a double.
Asserting directly in the module seems sufficient for this test so the indirection
was removed.

* Turn CacheBuster into a module

This class used no internal state, so repeatedly creating short-lived objects seems wasteful.

* Fix specs after rebasing
2019-11-13 10:51:23 -05:00
jeffin sam
61788e5dec Add tag_colors cache to redis (#4716) [deploy] 2019-11-13 09:43:22 -06:00
Molly Struve
57250ade63
Expire Frequently Updated Cache Keys Sooner (#4793) [deploy] 2019-11-12 13:39:50 -06:00
Ben Halpern
af04fd7959
Add additional conditions to internal/reports page (#4800) [deploy]
* Add additional conditions to internal/reports page

* Add higher number for randomness
2019-11-12 13:19:08 -05:00
rhymes
9d347e5e81 Use REDIS_SESSIONS_URL and default to REDIS_URL (#4801) [deploy] 2019-11-12 12:45:35 -05:00