maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add - to support dash character in JSitor liquid tag (#4830) [deploy]

Browse source 
* Add - to support dash character in JSitor liquid tag

* Edit spec/liquid_tags/jsitor_tag_spec.rb

* Add support for link with hyphen id in jsitor liquid tag
This commit is contained in:
Helmi Hidzir 2019-11-21 02:36:51 +08:00 • committed by Ben Halpern
parent 0ef4ce4250
commit 4e4762e3a1
2 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/liquid_tags/jsitor_tag.rb
View file

@ -1,7 +1,7 @@
class JsitorTag < LiquidTagBase
PARTIAL = "liquids/jsitor".freeze
URL_REGEXP = /\A(https|http):\/\/jsitor\.com\/embed\/\w+[?a-zA-Z&]*\Z/.freeze
ID_REGEXP = /\A[\w&?]+\Z/.freeze
URL_REGEXP = /\A(https|http):\/\/jsitor\.com\/embed\/\w+[-?a-zA-Z&]*\Z/.freeze
ID_REGEXP = /\A[\w&?-]+\Z/.freeze
def initialize(tag_name, link, token)
super

14
spec/liquid_tags/jsitor_tag_spec.rb
View file

@ -53,6 +53,20 @@ RSpec.describe JsitorTag, type: :liquid_tag do
end.not_to raise_error(StandardError)
end
it "accepts jsitor link with hyphen id" do
link = "https://jsitor.com/embed/2o-syYxmi"
expect do
create_jsitor_liquid_tag(link)
end.not_to raise_error(StandardError)
end
it "accepts jsitor id with hyphen" do
link = "2o-syYxmi"
expect do
create_jsitor_liquid_tag(link)
end.not_to raise_error(StandardError)
end
it "doesnt accepts jsitor link with a / at the end" do
link = "https://jsitor.com/embed/1QgJVmCam/"
expect do