Commit graph

1588 commits

Author SHA1 Message Date
Vaidehi Joshi
c4d9c4aed9
Remove trailing slashes from URLs to improve SEO (#8836) [deploy] 2020-06-22 13:44:58 -07:00
Vaidehi Joshi
178ee374ff
Notify Honeybadger when no id can be found for a welcome notification (#8831)
* Notify Honeybadger when no id can be found for a welcome notification

Also add the event's target's text to the tracking data for a welcome notification's click event.

* Destructure text and title from event.target
2020-06-22 13:52:16 -04:00
Michael Kohl
019ce5e0d8
Add overflow-x to KaTeX liquid tag (#8818)
* Add overflow-x to KaTeX liquid tag

* Update approval snapshot

* Update approved file

Co-authored-by: rhymes <rhymesete@gmail.com>
2020-06-22 13:24:53 -04:00
ludwiczakpawel
8c83aa3365
Table component & Dashboard update (#8778)
* flare tag line height

* .

* .

* .

* .

* specs

* spec

* .

* spec
2020-06-22 18:47:17 +02:00
Molly Struve
3d4a079572
[deploy] Refactor: Remove Additional Content Box Code (#8776) 2020-06-22 10:36:23 -05:00
Michael Kohl
359f2cb2c5
Style hide link with Crayons (#8820) 2020-06-22 08:27:38 -04:00
Ben Halpern
6f735a5a27
[deploy] Fix div/aside mismatch (#8784) 2020-06-18 20:58:16 -04:00
Julianna Tetreault
426d3191e8
Add a Broadcast Show View (#8769) [deploy]
* Add #show to the Broadcasts::Controller and to routes.rb
  - Adds a show method to the Broadcasts Controller
  - Adds a show route to routes.rb

* Add a show view for Broadcasts
  - Adds show.html.erb to /internal/broadcasts
  - Repurposes code from index.html.erb for show view
  - Repurposes code from edit.html.erb for show view

* Rewrite /internal/broadcasts index to use a table
  - Formats /internal/broadcasts with a table
  - Removes on-hover functionality from show.html.erb

* Refactor Broadcast resources in routes.rb

* Redirect to #show on create and update for Broadcasts

* Add the Destroy Broadcast button to the Broadcast show view

* Remove style preventing Broadcast preview

* Add Broadcast styling back and add display: block to stylesheet

* Add display: flex to .broadcast-wrapper in layout.scss

* Remove superfluous slashes from opening tags
2020-06-18 15:51:45 -06:00
Vaidehi Joshi
904f0dac78
Add ahoy + welcome notification tracking (#8758) [deploy]
* Set up ahoy gem, add ahoy-js

* Import ahoy.js into base.js.erb

* Add trackNotification function to notifications/index.html.erb

* Add sanitized_broadcast_id helper

* Use sanitized_broadcast_id in broadcast partial

* Add specs around tracking welcome notifications

* Remove optional fields from Ahoy::Visit migration + table

* Fiddle with trait to see if it helps with CI failures

* Disable geocode tracking in ahoy

* Stub out SiteConfig in notifications page spec
2020-06-18 13:40:14 -07:00
Ben Halpern
0e765b47de
[deploy] Modify articles below content for SEO and efficiency (#8755)
* Modify articles below content for SEO and efficiency

* fix Travis and code climate failures

Co-authored-by: mstruve <mollylbs@gmail.com>
2020-06-18 15:04:29 -04:00
Nick Taylor
e117c7b766
nickytonline/comment subscription fix (#8768) 2020-06-18 11:26:48 -04:00
ludwiczakpawel
cb1f03ce9f
[deploy] CSS fixes (#8764)
* flare tag line height

* .

* fix editor overflow issue

* fix editor overflow issue

* themable actions colors

* name position
2020-06-18 09:16:13 -04:00
Michael Kohl
158b3f1307
Display 'Originally published' for canonical URLs (#8761) 2020-06-18 08:10:47 -04:00
rhymes
2fff21f652
Add email panel to settings/account (#8727)
* Use crayons

* Add spec for Identity.email

* Refactor panels and ifs

* Update app/views/users/_account_providers_emails.html.erb

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Update app/views/users/_account_providers_emails.html.erb

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Update app/views/users/_account_providers_emails.html.erb

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-06-18 13:08:46 +02:00
ludwiczakpawel
9c471640b6
Footer redesign (#8684)
* flare tag line height

* .

* init

* moar

* user siteconfig for mascot

* .
2020-06-18 12:52:03 +02:00
Ben Halpern
478b048fc5
[deploy] Fix article preamble style (#8756)
* Fix article preamble style

* Proper tests
2020-06-17 20:10:41 -04:00
Ben Halpern
fc667e5177
[deploy] Small css fixes (#8743)
* Small css fixes

* Update app/views/articles/_org_branding.html.erb

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-06-17 16:11:36 -04:00
Ben Halpern
2deadc2385
Change three-dots svg (#8746) 2020-06-17 15:53:55 -04:00
Andy Zhao
0a41ff658b
Only render div if the user is able to connect another auth (#8730)
* Only render div if the user is able to connect another auth

* Use generalized auth provider size instead

* Hide blank div in account page too
2020-06-17 14:57:20 -04:00
ludwiczakpawel
cd97ce10f0
[deploy] Ludwiczakpawel/hotfix article (#8738)
* flare tag line height

* .

* .'
'
2020-06-17 12:14:03 -04:00
Ben Halpern
329f1d3825
[deploy] Hide HTML Variant (#8731) 2020-06-17 11:14:21 -04:00
ludwiczakpawel
16f4d7d46a
[deploy] Article Design update (#8234)
* flare tag line height

* .

* init

* widgets

* widgets lists

* new tabs on home

* instantclick

* .

* rethinking css

* .

* .

* empty space

* init

* campaign widget

* .

* merge

* .

* update layout

* fix sidebars on home page

* .

* fix onboarding x

* test

* spec

* test

* toolbar fix

* more

* test

* better handling ads

* .

* spec

* card border

* .

* .

* actions bar

* cleanup

* animation

* test

* button width

* .

* better responsiveness and author boxes

* meta info

* padding

* better animation

* optimize videos

* fixes

* spec

* .

* codeblocks in comments

* whoops

* Use .present? correctly as it preloads items

* sticky nav

* Update app/views/articles/_sticky_nav.html.erb

I don't know what I'm doing but @benhalpern says so! e8c0f337a5 (r440248874)

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>

* Update app/views/articles/show.html.erb

I don't know what I'm doing but @benhalpern says so! e8c0f337a5 (r440247802)

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>

* little fixes

* Update app/assets/stylesheets/article-show.scss

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>

* pawel updating ruby code......

* actually better merge

* semantic updates

* .

Co-authored-by: rhymes <rhymesete@gmail.com>
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-06-17 09:57:57 -04:00
Ben Halpern
e6abadff6c
Generalize editor logo (#8720) 2020-06-17 10:51:50 +02:00
Jacob Herrington
ad9c7797ec
Fix accessibility warnings from axe (#8718) 2020-06-17 10:48:38 +02:00
Lisa Sy
5e1fc2c4cd
Update connect chat container (part 2) (#8717) [deploy]
* Update chat container of Connect

- Rename certain class names to improve BEM syntax and naming
- Update typography of message cells
- Update header of message area
- Use new 'info' icon to expand sidebar
- Update form fields for both writing and editing a message
- Implement Crayons styling for 'delete' modal

https://github.com/thepracticaldev/dev.to/issues/8437

* Update some tests aand class names

* Update tests

* Update info icon

* Update reference
2020-06-16 15:15:59 -07:00
Julianna Tetreault
58f9c303aa
Add active_status_updated_at to the Broadcasts Table (#8451) [deploy]
* Add last_active_at datetime to Broadcasts table

* Add last_active_at to Broadcast index view

* Add callback to Broadcast.rb to update last_active_at

* Add a data_update script to backfill the last_active_at column on the Broadcasts table

* Add a spec for updating the last_active_at timestamp in models/broadcast_spec.rb

* Format last_active_at timestamp via strftime in index.html.erb

* Remove data_update_script: backfill_last_active_at_for_broadcasts

* Remove ActiveRecord::Dirty method from broadcast.rb

* Adjust callback in broadcast.rb and last_active_at timestamp format in index.html.erb

* Adjust time in #update_last_active_at and add the safe navigation operator to index.html.erb
  * Accounts for nil last_active_at values in the view
  * Uses Time.current in place of Time.zone.now

* Remove last_active_at param from Broadcasts::Controller

* Add spec to broadcasts_spec.rb to test the updated attribute via a request

* Adjust current_time in broadcasts_spec.rb

* Adjust Timecop.freeze in broadcasts_spec.rb to resolve Travis faliure (fingers crossed)

* Adjust expectation to compare against last_active_at timestamp rather than current time

* Adds Timecop back and stores last_active_at timestamp to test against

* Rename last_active_at to active_status_updated_at on Broadcasts table
  - Renames last_active_at to active_status_updated_at in specs
  - Renames last_active_at to active_status_updated_at in model
  - Renames last_active_at to active_status_updated_at in view
  - Adjusts spelling in spec descriptions
  - Rewords active_status_updated_at in view to Last Active On
2020-06-16 13:04:14 -06:00
Raphael Noriode
9ada1dda10
Fix Colour Contrast on the User Profile Header (#8406) 2020-06-16 13:36:27 -04:00
Lisa Sy
bfe663f407
Update chat container of Connect (#8456)
* Update chat container of Connect

- Rename certain class names to improve BEM syntax and naming
- Update typography of message cells
- Update header of message area
- Use new 'info' icon to expand sidebar
- Update form fields for both writing and editing a message
- Implement Crayons styling for 'delete' modal

https://github.com/thepracticaldev/dev.to/issues/8437

* Update some tests aand class names

* Update tests
2020-06-16 10:23:56 -07:00
Ben Halpern
9187c0b6bf
[deploy] Add special footer mascot image to config (#8692) 2020-06-16 11:29:37 -04:00
Raphael Noriode
1dcd83746b
[deploy] Label Experience Level Scale in User Settings (#8454)
* Add labels to the experience levels in user settings

* modify helper methods to seperate module

* rename uxhelper to settingshelper for better understanding
2020-06-16 15:41:30 +02:00
Ben Halpern
b51647c59a
[deploy] Remove unnecessary comment links and clean up logic (#8686)
* Remove unnecessary comment links and clean up logic

* Fix links
2020-06-15 17:40:21 -04:00
narender2031
8b9670abd7
Skynox/fix eslint and redirection bug (#8513)
* Feature 🚀 : Ability to delete messages in chat channels

- Sending message ID to frontend
- Deleting Message
- Use pusher to delete message realtime

* Minor Bug 🐞: Show message action only for current user

- User can delete or edit their own messages

* Test cases added

* Bug 🐞: Update message id for receiver

Message id was not sent to receiver by pusher

* Refactoring🛠: Message controller refactoring

* Test Cases📝 : Specs for Delete message added

* Feature 🚀 : Ability to edit messages

* Test Cases📝 : Specs for Edit message added

* fix Content component esLint issue

* fix @all link

Co-authored-by: Sarthak Sharma <7lovesharma7@gmail.com>
2020-06-15 17:00:41 -04:00
Andy Zhao
3d5a5fc18e
[deploy] Always set the default email address to ENV variable (#8687)
* Always set the default email address to env variable

* Hide the default to prevent editing, and b/c it's shown above as readonly

* Check if email address param is present
2020-06-15 13:39:29 -04:00
Alberto Pérez de Rada Fiol
a878d42fa7
Fix liquid tags overflow (#8369)
* Fix liquid tags overflowing comment box in notifications

* Prevent tags from being too wide
2020-06-15 18:29:38 +02:00
ludwiczakpawel
75c81b542f
[deploy] Branded authentication buttons (#8679)
* flare tag line height

* .

* init styling

* social buttons

* no need for inverted

* other places

* more

* Fix specs

Co-authored-by: rhymes <rhymesete@gmail.com>
2020-06-15 17:34:07 +02:00
Maja Komel
d6fa1d3367
[deploy] Add button to unfollow tags and users from dashboard (#8448) 2020-06-15 17:25:41 +02:00
Rafi
239ced79ba
Adding aria-label for featured article (#8670) 2020-06-15 09:30:43 -04:00
Ben Halpern
c8ff41de1e
[deploy] Modify default size for onboarding graphic (#8444) 2020-06-12 13:14:09 -04:00
Ben Halpern
1b37edeeb8
[deploy] Allow admins to define onboarding images in config (#8431)
* Add config for onboarding

* Fix tests/snapshot

* Improved specs
2020-06-12 08:48:20 -04:00
Alberto Pérez de Rada Fiol
326e98a944
Fix erblint errors on the app/views/stories folder (#8404) 2020-06-12 11:21:07 +02:00
Alberto Pérez de Rada Fiol
5f75d2a49a
Fix erblint errors on the app/views/liquids folder (#8403)
* Fix erblint errors on the `app/views/liquids` folder

* Make tests pass

* Make failing test pass
2020-06-11 20:03:27 +02:00
Alberto Pérez de Rada Fiol
2ef30f6656
Fix remaining erblint errors (#8405)
* Fix remaining erblint errors

* Fix last error
2020-06-11 20:03:19 +02:00
Alberto Pérez de Rada Fiol
81f77715a6
Fix erblint errors on the app/views/mailers folder (#8402) 2020-06-11 11:34:52 -04:00
Alberto Pérez de Rada Fiol
c9bb331248
Fix erblint errors on the app/views/doorkeeper folder (#8399) 2020-06-11 11:34:31 -04:00
Vaidehi Joshi
e532ccbe42
Allow users to dismiss announcements (#8396) [deploy]
* Provide default crayon styles when creating banners

* Import crayons styles into /internal pages.
* Allow admins to use crayons banner styles when creating broadcasts.
* Preview banner styles with crayons.

* Add a "x" close button to announcements, fix styling to accommodate it

* Use constant and helper for broadcast banner styles

* Add VALID_BANNER_STYLES frozen constant to Broadcast class.
* Add banner_style helper for determining banner style class.

* Clean up preview CSS, import broadcast styles into preview

* Add close button click handler, clean up initializeBroadcast

* Add close functionality to announcement banner

Also hide announcement if the user has explicitly seen and "X"-ed out of it.

* Add system specs around rendering + dismissing broadcasts

* Add some (truly beautiful) JS documentation

* Add visible class to broadcast when previewed from internal
2020-06-11 08:24:43 -07:00
Alberto Pérez de Rada Fiol
2b30f769f3
Fix erblint errors on the app/views/layouts folder (#8400) 2020-06-11 16:58:50 +02:00
Alberto Pérez de Rada Fiol
2660c76fca
Fix erblint errors on the app/views/pages folder (#8401) 2020-06-11 15:46:50 +02:00
Dana Scheider
f6a4c844cd
Implement chronological sorting of search results (#8193)
* Implement search ordering by allowing sort_by and sort_direction
params to be passed through from the search form/page.

* Change ID of select to 'sort' instead of 'order' for consistency

* Fix styling and data attributes of select options

* Enable front end to pass sort_by and sort_direction params for searches to the back end

* Ensure that only query string params that are supposed to be changed are changed in each function

* Respond to review comments (additional commits to come but these were the quick changes)

* Move options for select into template

* Use addEventListener instead of using onchange in response to review comments

* Add tabs for sorting search results

* Finish implementing tabs for ordering search results

* Remove CSS rule applying to element that no longer exists

* Remove more rules created for an element that has been removed

* Remove more code added for the select dropdown that I've removed

* Remove duplicate jobs banner
2020-06-11 13:11:01 +02:00
Alberto Pérez de Rada Fiol
23fdc0ca6b
Fix erblint errors on the app/views/users folder (#8389)
* Fix erblint errors on the `app/views/users` folder

* Fix mistake
2020-06-10 17:38:32 -04:00
Jacob Herrington
54afa3ba91
Fix a11y issues flagged by axe on homepage (#8380)
* Fix a11y issues flagged by axe on homepage

This commit brings the number of violations found on homepage (local,
not prod) down from ~100 to ~10. It should have no serious impact on the
visual layout or design of the page.

* Change aria-labels to be consistent
2020-06-10 13:58:52 -05:00