maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix erblint errors on the app/views/liquids folder (#8403)

Browse source 
* Fix erblint errors on the `app/views/liquids` folder

* Make tests pass

* Make failing test pass
This commit is contained in:
Alberto Pérez de Rada Fiol 2020-06-11 20:03:27 +02:00 • committed by GitHub
parent 2ef30f6656
commit 5f75d2a49a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/views/liquids/_github_issue.html.erb
View file

@ -1,7 +1,7 @@
<div class="ltag_github-liquid-tag">
<h1>
<a href="<%= html_url %>">
<img class="github-logo" alt="GitHub logo" src="<%= ActionController::Base.helpers.asset_path('github-logo.svg') %>">
<img class="github-logo" alt="GitHub logo" src="<%= ActionController::Base.helpers.asset_path("github-logo.svg") %>">
<span class="issue-title">
<%= title %>
</span>

2
app/views/liquids/_instagram.html.erb
View file

@ -5,7 +5,7 @@
allowtransparency="true"
frameborder="0"
data-instgrm-payload-id="instagram-media-payload-0"
scrolling="no"
scrolling="no"
loading="lazy">
</iframe>
<script async defer src="https://platform.instagram.com/en_US/embeds.js"></script>

4
app/views/liquids/_kotlin.html.erb
View file

@ -3,5 +3,5 @@
allowtransparency="true"
scrolling="no"
frameborder="0"
loading="lazy"
></iframe>
loading="lazy">
</iframe>

2
app/views/liquids/_parler.html.erb
View file

@ -1,6 +1,6 @@
<iframe
width="<%= width %>"
height="<%= height %>"
src="https://api.parler.io/ss/player?url=<%= id %>"
src="https://api.parler.io/ss/player?url=<%= id %>"
loading="lazy">
</iframe>

2
app/views/liquids/_poll.html.erb
View file

@ -9,4 +9,4 @@
<% end %>
<li class="ltag-polloption-justshowmetheresults" id="showmethemoney-<%= poll.id %>" data-poll-id="<%= poll.id %>"><button>Just show me the results</button>
</ul>
</div>
</div>

4
app/views/liquids/_stackexchange.html.erb
View file

@ -6,11 +6,11 @@
<h1>
<img src="<%= ActionController::Base.helpers.asset_path(logo_to_use) %>" alt="">
<a href="<%= post_url %>" target="_blank" rel="noopener noreferrer">
<%= post_type == "question" ? "" : "<span class='title-flare'>answer</span> re: ".html_safe %> <%= CGI::unescapeHTML title %>
<%= post_type == "question" ? "" : "<span class='title-flare'>answer</span> re: ".html_safe %> <%= CGI.unescapeHTML title %>
</a>
</h1>
<div class="ltag__stackexchange--post-metadata">
<span><%= Time.at(created_at).strftime("%b %e '%y") %></span>
<span><%= Time.zone.at(created_at).strftime("%b %e '%y") %></span>
<% if post_type == "question" %>
<span>Comments: <%= comment_count %></span>
<span>Answers: <%= answer_count %></span>

3
spec/support/fixtures/approvals/kotlin_liquid_tag.approved.html
View file

@ -1,6 +1,7 @@
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<body>
<iframe src="https://play.kotlinlang.org/embed?short=owreUFFUG&amp;from&amp;to&amp;theme=darcula&amp;readOnly" allowtransparency="true" scrolling="no" frameborder="0" loading="lazy"></iframe>
<iframe src="https://play.kotlinlang.org/embed?short=owreUFFUG&amp;from&amp;to&amp;theme=darcula&amp;readOnly" allowtransparency="true" scrolling="no" frameborder="0" loading="lazy">
</iframe>
</body>
</html>