maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove trailing slashes from URLs to improve SEO (#8836) [deploy]

Browse source
This commit is contained in:
Vaidehi Joshi 2020-06-22 13:44:58 -07:00 • committed by GitHub
parent dac1bb1bc3
commit c4d9c4aed9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
26 changed files with 39 additions and 40 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/page_views_controller.rb
View file

@ -46,7 +46,7 @@ class PageViewsController < ApplicationMetalController
def update_organic_page_views
return if Rails.env.production? && rand(100) != 1 # We need to do this operation only once in a while.
page_views_from_google_com = @article.page_views.where(referrer: "https://www.google.com/")
page_views_from_google_com = @article.page_views.where(referrer: "https://www.google.com")
organic_count = page_views_from_google_com.sum(:counts_for_number_of_views)
@article.update_column(:organic_page_views_count, organic_count) if organic_count > @article.organic_page_views_count

17
app/javascript/crayons/guidelines/__stories__/guidelines.stories.jsx
View file

@ -149,7 +149,7 @@ export const Components = () => (
templates (*.html.erb files). We also build out parts of or sometimes
complete views using
{' '}
<a href="https://docs.dev.to/frontend/preact/">Preact</a>
<a href="https://docs.dev.to/frontend/preact">Preact</a>
, typically for
the logged on user experience. For example, the main page feed.
</p>
@ -161,7 +161,7 @@ export const Components = () => (
<p>
The entire design system uses the
{' '}
<a href="http://getbem.com/naming/">BEM</a>
<a href="http://getbem.com/naming">BEM</a>
{' '}
methodology for naming CSS
classes. Even Preact components under the hood use it.
@ -179,15 +179,14 @@ export const Components = () => (
and what
<strong>IS NOT</strong>
{' '}
a
Crayons component. It&#x27;s also practical because Crayons was
implemented when we already had tons of other frontend classes in the
codebase. It prevents overwriting styles by other CSS and it&#x27;s very
unlikely someone has ever created a
a Crayons component. It&#x27;s also practical
because Crayons was implemented when we already had tons of other frontend
classes in the codebase. It prevents overwriting styles by other CSS and
it&#x27;s very unlikely someone has ever created a
<code>.crayons-btn</code>
{' '}
style BUT
it&#x27;s very likely someone has created
style BUT it&#x27;s very likely someone has
created
<code>.btn</code>
{' '}
style...

6
app/javascript/listings/__tests__/ListingDashboard.test.jsx
View file

@ -232,7 +232,7 @@ describe('<ListingDashboard />', () => {
// listing category
const listing1CfpCategory = getByText('cfp', listing1GetByTextOptions);
expect(listing1CfpCategory.getAttribute('href')).toEqual('/listings/cfp/');
expect(listing1CfpCategory.getAttribute('href')).toEqual('/listings/cfp');
// tags
const listing1ComputerScienceTag = getByText(
@ -274,7 +274,7 @@ describe('<ListingDashboard />', () => {
);
expect(listing2EventsCategory.getAttribute('href')).toEqual(
'/listings/events/',
'/listings/events',
);
// tags
@ -323,7 +323,7 @@ describe('<ListingDashboard />', () => {
// listing category
const listing3CfpCategory = getByText('cfp', listing3GetByTextOptions);
expect(listing3CfpCategory.getAttribute('href')).toEqual('/listings/cfp/');
expect(listing3CfpCategory.getAttribute('href')).toEqual('/listings/cfp');
// has no tags

2
app/javascript/listings/dashboard/listingRow.jsx
View file

@ -45,7 +45,7 @@ export const ListingRow = ({ listing }) => {
{listingExpiry}
{listing.location && <Location location={listing.location} />}
<span className="dashboard-listing-category">
<a href={`/listings/${listing.category}/`}>{listing.category}</a>
<a href={`/listings/${listing.category}`}>{listing.category}</a>
</span>
<Tags tagList={listing.tag_list} />
<ActionButtons

2
app/labor/markdown_parser.rb
View file

@ -146,7 +146,7 @@ class MarkdownParser
def allowed_image_host?(src)
# GitHub camo image won't parse but should be safe to host direct
src.start_with?("https://camo.githubusercontent.com/")
src.start_with?("https://camo.githubusercontent.com")
end
def remove_nested_linebreak_in_list(html)

2
app/models/site_config.rb
View file

@ -45,7 +45,7 @@ class SiteConfig < RailsSettings::Base
field :periodic_email_digest_min, type: :integer, default: 2
# Jobs
field :jobs_url, type: :string, default: "https://jobs.dev.to/"
field :jobs_url, type: :string, default: "https://jobs.dev.to"
field :display_jobs_banner, type: :boolean, default: false
# Google Analytics Reporting API v4

4
app/views/articles/index.html.erb
View file

@ -47,7 +47,7 @@
<div class="flex-1 flex items-center justify-between">
<h2 class="fs-l fw-heavy">Posts</h2>
<nav class="crayons-tabs hidden s:flex">
<a href="<%= list_path %>/" class="crayons-tabs__item <%= "crayons-tabs__item--current" if %w[week month year infinity latest].exclude?(params[:timeframe]) %>">Feed</a>
<a href="<%= list_path %>" class="crayons-tabs__item <%= "crayons-tabs__item--current" if %w[week month year infinity latest].exclude?(params[:timeframe]) %>">Feed</a>
<a href="<%= list_path %>/top/week" class="crayons-tabs__item <%= "crayons-tabs__item--current" if timeframe_check("week") %>">Week</a>
<a href="<%= list_path %>/top/month" class="crayons-tabs__item <%= "crayons-tabs__item--current" if timeframe_check("month") %>">Month</a>
@ -58,7 +58,7 @@
</nav>
<select class="crayons-select s:hidden ml-2 s:ml-auto w-auto" id="feed-filter-select" aria-label="feed-filter-select">
<option value="<%= list_path %>/" <% if ["week", "month", "year", "infinity", "latest"].exclude?(params[:timeframe]) %> selected<% end %>>Feed</option>
<option value="<%= list_path %>" <% if ["week", "month", "year", "infinity", "latest"].exclude?(params[:timeframe]) %> selected<% end %>>Feed</option>
<option value="<%= list_path %>/top/week" <% if timeframe_check("week") %> selected<% end %>>Week</option>
<option value="<%= list_path %>/top/month" <% if timeframe_check("month") %> selected<% end %>>Month</option>
<option value="<%= list_path %>/top/year" <% if timeframe_check("year") %> selected<% end %>>Year</option>

2
app/views/articles/manage.html.erb
View file

@ -19,7 +19,7 @@
Make your own tweet about the post, describing personally why you wrote it or why people might find it useful. <a href="https://twitter.com/<%= SiteConfig.social_media_handles["twitter"] %>">@<%= SiteConfig.social_media_handles["twitter"] %></a> may retweet you.
</li>
<li>
Share to link aggregators such as <a href="https://www.reddit.com/">Reddit</a>. Try to choose the most topic-specific subreddits, such as <a href="https://www.reddit.com/r/javascript">/r/javascript</a> instead of <a href="https://www.reddit.com/r/programming">/r/programming</a>. <em>Warning: jerks and trolls may be lurking.</em>
Share to link aggregators such as <a href="https://www.reddit.com">Reddit</a>. Try to choose the most topic-specific subreddits, such as <a href="https://www.reddit.com/r/javascript">/r/javascript</a> instead of <a href="https://www.reddit.com/r/programming">/r/programming</a>. <em>Warning: jerks and trolls may be lurking.</em>
</li>
<li>
Share with your co-workers or local communities. Ask people to leave questions for you in the comments. It's a great way to spark additional discussion.

2
app/views/articles/tag_index.html.erb
View file

@ -59,7 +59,7 @@
<div class="on-page-nav-controls" id="on-page-nav-controls">
<div class="on-page-nav-label sub-home-nav">
<div class="wide-nav-links">
<a class="nav-chronofiter-link <%= "selected" if %w[week month year infinity latest].exclude?(params[:timeframe]) %>" href="<%= list_path %>/">
<a class="nav-chronofiter-link <%= "selected" if %w[week month year infinity latest].exclude?(params[:timeframe]) %>" href="<%= list_path %>">
FEED
</a>
<span class="separator"></span>

2
app/views/internal/pages/_form.html.erb
View file

@ -54,7 +54,7 @@
<%= link_to "Modify flag here", "/internal/feature_flags/features/#{@page.feature_flag_name}" %>
<% else %>
Everyone has access. Optionally guard access to this page by creating feature <code><%= @page.feature_flag_name %></code>
<%= link_to "here", "/internal/feature_flags/features/" %>
<%= link_to "here", "/internal/feature_flags/features" %>
<% end %>
</br>
</p>

2
app/views/pages/_coc_text.html.erb
View file

@ -39,5 +39,5 @@
<ul>
<li><a href="http://contributor-covenant.org/version/1/4">Contributor Covenant, version 1.4</a></li>
<li><a href="http://www.writespeakcode.com/code-of-conduct.html">Write/Speak/Code</a></li>
<li><a href="https://geekfeminism.org/about/code-of-conduct/">Geek Feminism</a></li>
<li><a href="https://geekfeminism.org/about/code-of-conduct">Geek Feminism</a></li>
</ul>

2
app/views/pages/_editor_frontmatter_help.html.erb
View file

@ -6,7 +6,7 @@
</div>
<ul>
<li>This editor is a markdown editor that uses <a href="https://jekyllrb.com/docs/frontmatter/">Jekyll front matter</a>.</li>
<li>This editor is a markdown editor that uses <a href="https://jekyllrb.com/docs/frontmatter">Jekyll front matter</a>.</li>
<li>Most of the time, you can write inline HTML directly into your posts.</li>
<li>We support native Liquid tags and created some fun custom ones, too! Trying embedding a Tweet or GitHub issue in your post.</li>
<li>Links to unpublished posts are shareable for feedback/review.</li>

4
app/views/pages/_editor_guide_text.html.erb
View file

@ -51,7 +51,7 @@
<pre>&lt;!-- This won't show up in the content! --&gt;</pre>
<h2 style="font-size:2.8em" id="liquidtags"><strong>🌊 Liquid Tags</strong></h2>
<p>We support native
<a href="https://shopify.github.io/liquid/" target="_blank" rel="noopener">Liquid tags</a> in our editor, but have created our own custom tags listed below:
<a href="https://shopify.github.io/liquid" target="_blank" rel="noopener">Liquid tags</a> in our editor, but have created our own custom tags listed below:
</p>
<h3><strong><%= community_name %> Article/Post Embed</strong></h3>
<p>All you need is the full link of the article:</p>
@ -90,7 +90,7 @@
<p>All you need is the Glitch project slug</p>
<code>{% glitch earthy-course %}</code>
<p>There are several
<a href="https://glitch.com/help/how-can-i-customize-a-glitch-app-embed/">optional attributes</a> you can use in your tag, just add them after the id, separated by spaces.
<a href="https://glitch.com/help/how-can-i-customize-a-glitch-app-embed">optional attributes</a> you can use in your tag, just add them after the id, separated by spaces.
</p>
<dl>
<dt><code>app</code></dt>

4
app/views/pages/_editor_liquid_help.html.erb
View file

@ -1,7 +1,7 @@
<div id="editor-liquid-help">
<div class="crayons-article">
<div class="crayons-article__body">
<p>We support native <a href="https://shopify.github.io/liquid/" target="_blank" rel="noopener">Liquid tags</a> in our editor, but have created our own custom tags listed below:</p>
<p>We support native <a href="https://shopify.github.io/liquid" target="_blank" rel="noopener">Liquid tags</a> in our editor, but have created our own custom tags listed below:</p>
<h3><%= community_name %> Article/Post Embed</h3>
<p>All you need is the full link of the article:</p>
<code>{% link https://dev.to/kazz/boost-your-productivity-using-markdown-1be %}</code>
@ -39,7 +39,7 @@
<p>All you need is the Glitch project slug</p>
<code>{% glitch earthy-course %}</code>
<p>There are several
<a href="https://glitch.com/help/how-can-i-customize-a-glitch-app-embed/">optional attributes</a> you can use in your tag, just add them after the id, separated by spaces.
<a href="https://glitch.com/help/how-can-i-customize-a-glitch-app-embed">optional attributes</a> you can use in your tag, just add them after the id, separated by spaces.
</p>
<ul>
<li><code>app</code> – Shows the app preview without the code.<br>

2
app/views/pages/_v1_editor_guide_preamble.html.erb
View file

@ -1,7 +1,7 @@
<h1><strong>Things to Know</strong></h1>
<ul>
<li>We use a markdown editor that uses <a href="https://jekyllrb.com/docs/frontmatter/">Jekyll front matter</a>.</li>
<li>We use a markdown editor that uses <a href="https://jekyllrb.com/docs/frontmatter">Jekyll front matter</a>.</li>
<li>Most of the time, you can write inline HTML directly into your posts.</li>
<li>We support native Liquid tags and created some fun custom ones, too! Trying embedding a Tweet or GitHub issue in your post.</li>
<li>Links to unpublished posts are shareable for feedback/review.</li>

2
app/views/pages/generator.html.erb
View file

@ -49,7 +49,7 @@
</pre>
<h3>Animal Codes</h3>
<p><i>The animal images are from the
<a href="https://etc.usf.edu/clipart/" target="_blank" rel="noopener">USF ClipArt ETC</a> project. They are used in this O RLY Cover Generator for the purposes of parody.</i>
<a href="https://etc.usf.edu/clipart" target="_blank" rel="noopener">USF ClipArt ETC</a> project. They are used in this O RLY Cover Generator for the purposes of parody.</i>
</p>
<div class="animal"><%= image_tag("1.png", alt: "grizzly bear") %>1</div>
<div class="animal"><%= image_tag("2.png", alt: "cat") %>2</div>

2
app/views/pages/markdown_basics.html.erb
View file

@ -41,7 +41,7 @@
<h2><strong><u>Liquid Tags</u></strong></h2>
<p>We support native
<a href="https://shopify.github.io/liquid/" target="_blank" rel="noopener">Liquid tags</a> in our editor, but have created our own custom tags listed below:
<a href="https://shopify.github.io/liquid" target="_blank" rel="noopener">Liquid tags</a> in our editor, but have created our own custom tags listed below:
</p>
<h3><strong>Twitter Embed</strong></h3>

2
app/views/pages/privacy.html.erb
View file

@ -125,7 +125,7 @@
<br>
<br>
This allows user behavior to be tracked after they have been redirected to our website by clicking on a Facebook ad. This enables us to measure the effectiveness of Facebook ads. The data collected in this way is anonymous to us, i.e. we do not see the personal data of individual users. However, this data is stored and processed by Facebook, which is why we are informing you, based on our knowledge of the situation. Facebook may link this information to your Facebook account and also use it for its own promotional purposes, in accordance with
<a href="https://www.facebook.com/about/privacy/">Facebook’s Data Usage Policy</a>. You can object to the collection of your data by Facebook pixel, or to the use of your data for the purpose of displaying Facebook ads by contacting the following address: https://www.facebook.com/settings?tab=ads.
<a href="https://www.facebook.com/about/privacy">Facebook’s Data Usage Policy</a>. You can object to the collection of your data by Facebook pixel, or to the use of your data for the purpose of displaying Facebook ads by contacting the following address: https://www.facebook.com/settings?tab=ads.
</p>
<p><strong>Tracking & Cookies</strong>
<br>

2
app/views/pages/rlyweb.html.erb
View file

@ -61,7 +61,7 @@
<div class="usage">
<h3>Animal Codes</h3>
<p><i>The animal images are from the
<a href="https://etc.usf.edu/clipart/" target="_blank" rel="noopener">USF ClipArt ETC</a> project. They are used in this O RLY Cover Generator for the purposes of parody.</i>
<a href="https://etc.usf.edu/clipart" target="_blank" rel="noopener">USF ClipArt ETC</a> project. They are used in this O RLY Cover Generator for the purposes of parody.</i>
</p>
<div class="animal"><%= image_tag("1.png", alt: "grizzly bear") %>1</div>
<div class="animal"><%= image_tag("2.png", alt: "cat") %>2</div>

2
app/views/stories/_narrow_nav_menu.html.erb
View file

@ -1,5 +1,5 @@
<div class="narrow-nav-menu" id="narrow-nav-menu" aria-label="feed-nav-menu">
<a href="<%= list_path %>/" class="<%= "selected" if %w[week month year infinity latest].exclude?(params[:timeframe]) %>">&lt;MY <%= community_name %> FEED&gt;</a>
<a href="<%= list_path %>" class="<%= "selected" if %w[week month year infinity latest].exclude?(params[:timeframe]) %>">&lt;MY <%= community_name %> FEED&gt;</a>
<a href="<%= list_path %>/top/week" class="<%= "selected" if timeframe_check("week") %>">&lt;PAST WEEK&gt;</a>
<a href="<%= list_path %>/top/month" class="<%= "selected" if timeframe_check("month") %>">&lt;PAST MONTH&gt;</a>
<a href="<%= list_path %>/top/year" class="<%= "selected" if timeframe_check("year") %>">&lt;PAST YEAR&gt;</a>

2
app/views/users/_account.html.erb
View file

@ -5,7 +5,7 @@
<div class="crayons-card mb-6 p-6 grid gap-6">
<header>
<h2 class="mb-2"><%= community_name %> API Keys</h2>
<p>You can generate personal API keys to use for authentication with the <%= community_name %> API. The API is still in early beta though. The <a href="https://docs.dev.to/api/"><%= community_name %> API documentation</a> contains further information.</a></p>
<p>You can generate personal API keys to use for authentication with the <%= community_name %> API. The API is still in early beta though. The <a href="https://docs.dev.to/api"><%= community_name %> API documentation</a> contains further information.</a></p>
</header>
<div>

2
app/views/users/_publishing_from_rss.html.erb
View file

@ -31,7 +31,7 @@
<%= form_for @user, html: { class: "grid gap-6" } do |f| %>
<div class="crayons-field">
<%= f.label :feed_url, "RSS Feed URL", class: "crayons-field__label" %>
<%= f.url_field :feed_url, placeholder: "https://yoursite.com/feed/", class: "crayons-textfield" %>
<%= f.url_field :feed_url, placeholder: "https://yoursite.com/feed", class: "crayons-textfield" %>
</div>
<div class="crayons-field crayons-field--checkbox">

2
config/initializers/s3_direct_upload.rb
View file

@ -3,5 +3,5 @@ S3DirectUpload.config do |c|
c.secret_access_key = ApplicationConfig["AWS_S3_VIDEO_KEY"] # your secret access key
c.bucket = ApplicationConfig["AWS_S3_INPUT_BUCKET"] # your bucket name
c.region = nil # region prefix. _Required_ for non-default AWS region, eg. "eu-west-1"
c.url = nil # S3 API endpoint (optional), eg. "https://#{c.bucket}.s3.amazonaws.com/"
c.url = nil # S3 API endpoint (optional), eg. "https://#{c.bucket}.s3.amazonaws.com"
end

2
public/404.html
View file

@ -94,7 +94,7 @@
<img class="tv__inner--special" src="https://i.imgur.com/Vyyjycv.gif" alt="404 not found image as TV static">
<img class="tv__inner" src="https://i.imgur.com/3v0LCiP.jpg" alt="404 not found DEV logo">
<br>
<p class="tv__inner--text">This page does not exist <br><br> <a href="https://dev.to/">Return to Home Page</a></p>
<p class="tv__inner--text">This page does not exist <br><br> <a href="https://dev.to">Return to Home Page</a></p>
</div>
</div>
</div>

2
spec/factories/users.rb
View file

@ -148,7 +148,7 @@ FactoryBot.define do
currently_hacking_on { "JSON-LD" }
mastodon_url { "https://mastodon.social/@test" }
facebook_url { "www.facebook.com/example" }
linkedin_url { "www.linkedin.com/company/example/" }
linkedin_url { "www.linkedin.com/company/example" }
youtube_url { "https://youtube.com/example" }
behance_url { "www.behance.net/#{username}" }
stackoverflow_url { "www.stackoverflow.com/example" }

4
spec/requests/page_views_spec.rb
View file

@ -70,12 +70,12 @@ RSpec.describe "PageViews", type: :request do
end
it "stores aggregate organic page views" do
post "/page_views", params: { article_id: article.id, referrer: "https://www.google.com/" }
post "/page_views", params: { article_id: article.id, referrer: "https://www.google.com" }
post "/page_views", params: { article_id: article.id }
expect(article.reload.organic_page_views_count).to eq(10)
expect(article.reload.organic_page_views_past_week_count).to eq(10)
expect(article.reload.organic_page_views_past_month_count).to eq(10)
post "/page_views", params: { article_id: article.id, referrer: "https://www.google.com/" }
post "/page_views", params: { article_id: article.id, referrer: "https://www.google.com" }
expect(article.reload.organic_page_views_count).to eq(20)
post "/page_views", params: { article_id: article.id }
expect(article.reload.organic_page_views_count).to eq(20)