From c4d9c4aed95b052771973b0baf722aeadc99a3fe Mon Sep 17 00:00:00 2001 From: Vaidehi Joshi Date: Mon, 22 Jun 2020 13:44:58 -0700 Subject: [PATCH] Remove trailing slashes from URLs to improve SEO (#8836) [deploy] --- app/controllers/page_views_controller.rb | 2 +- .../__stories__/guidelines.stories.jsx | 17 ++++++++--------- .../__tests__/ListingDashboard.test.jsx | 6 +++--- .../listings/dashboard/listingRow.jsx | 2 +- app/labor/markdown_parser.rb | 2 +- app/models/site_config.rb | 2 +- app/views/articles/index.html.erb | 4 ++-- app/views/articles/manage.html.erb | 2 +- app/views/articles/tag_index.html.erb | 2 +- app/views/internal/pages/_form.html.erb | 2 +- app/views/pages/_coc_text.html.erb | 2 +- .../pages/_editor_frontmatter_help.html.erb | 2 +- app/views/pages/_editor_guide_text.html.erb | 4 ++-- app/views/pages/_editor_liquid_help.html.erb | 4 ++-- .../pages/_v1_editor_guide_preamble.html.erb | 2 +- app/views/pages/generator.html.erb | 2 +- app/views/pages/markdown_basics.html.erb | 2 +- app/views/pages/privacy.html.erb | 2 +- app/views/pages/rlyweb.html.erb | 2 +- app/views/stories/_narrow_nav_menu.html.erb | 2 +- app/views/users/_account.html.erb | 2 +- app/views/users/_publishing_from_rss.html.erb | 2 +- config/initializers/s3_direct_upload.rb | 2 +- public/404.html | 2 +- spec/factories/users.rb | 2 +- spec/requests/page_views_spec.rb | 4 ++-- 26 files changed, 39 insertions(+), 40 deletions(-) diff --git a/app/controllers/page_views_controller.rb b/app/controllers/page_views_controller.rb index 9f9185f35..abf04d97b 100644 --- a/app/controllers/page_views_controller.rb +++ b/app/controllers/page_views_controller.rb @@ -46,7 +46,7 @@ class PageViewsController < ApplicationMetalController def update_organic_page_views return if Rails.env.production? && rand(100) != 1 # We need to do this operation only once in a while. - page_views_from_google_com = @article.page_views.where(referrer: "https://www.google.com/") + page_views_from_google_com = @article.page_views.where(referrer: "https://www.google.com") organic_count = page_views_from_google_com.sum(:counts_for_number_of_views) @article.update_column(:organic_page_views_count, organic_count) if organic_count > @article.organic_page_views_count diff --git a/app/javascript/crayons/guidelines/__stories__/guidelines.stories.jsx b/app/javascript/crayons/guidelines/__stories__/guidelines.stories.jsx index 46231d443..095e1d4f5 100644 --- a/app/javascript/crayons/guidelines/__stories__/guidelines.stories.jsx +++ b/app/javascript/crayons/guidelines/__stories__/guidelines.stories.jsx @@ -149,7 +149,7 @@ export const Components = () => ( templates (*.html.erb files). We also build out parts of or sometimes complete views using {' '} - Preact + Preact , typically for the logged on user experience. For example, the main page feed.

@@ -161,7 +161,7 @@ export const Components = () => (

The entire design system uses the {' '} - BEM + BEM {' '} methodology for naming CSS classes. Even Preact components under the hood use it. @@ -179,15 +179,14 @@ export const Components = () => ( and what IS NOT {' '} - a - Crayons component. It's also practical because Crayons was - implemented when we already had tons of other frontend classes in the - codebase. It prevents overwriting styles by other CSS and it's very - unlikely someone has ever created a + a Crayons component. It's also practical + because Crayons was implemented when we already had tons of other frontend + classes in the codebase. It prevents overwriting styles by other CSS and + it's very unlikely someone has ever created a .crayons-btn {' '} - style BUT - it's very likely someone has created + style BUT it's very likely someone has + created .btn {' '} style... diff --git a/app/javascript/listings/__tests__/ListingDashboard.test.jsx b/app/javascript/listings/__tests__/ListingDashboard.test.jsx index a8bc80d32..d6c8e4f67 100644 --- a/app/javascript/listings/__tests__/ListingDashboard.test.jsx +++ b/app/javascript/listings/__tests__/ListingDashboard.test.jsx @@ -232,7 +232,7 @@ describe('', () => { // listing category const listing1CfpCategory = getByText('cfp', listing1GetByTextOptions); - expect(listing1CfpCategory.getAttribute('href')).toEqual('/listings/cfp/'); + expect(listing1CfpCategory.getAttribute('href')).toEqual('/listings/cfp'); // tags const listing1ComputerScienceTag = getByText( @@ -274,7 +274,7 @@ describe('', () => { ); expect(listing2EventsCategory.getAttribute('href')).toEqual( - '/listings/events/', + '/listings/events', ); // tags @@ -323,7 +323,7 @@ describe('', () => { // listing category const listing3CfpCategory = getByText('cfp', listing3GetByTextOptions); - expect(listing3CfpCategory.getAttribute('href')).toEqual('/listings/cfp/'); + expect(listing3CfpCategory.getAttribute('href')).toEqual('/listings/cfp'); // has no tags diff --git a/app/javascript/listings/dashboard/listingRow.jsx b/app/javascript/listings/dashboard/listingRow.jsx index cfb4330d4..852153325 100644 --- a/app/javascript/listings/dashboard/listingRow.jsx +++ b/app/javascript/listings/dashboard/listingRow.jsx @@ -45,7 +45,7 @@ export const ListingRow = ({ listing }) => { {listingExpiry} {listing.location && } - {listing.category} + {listing.category}

Posts