Commit graph

2993 commits

Author SHA1 Message Date
aRtoo
bec5b79120 Fix Github Liquid Tag alignment in notifications page (#4270) [ci skip] 2019-10-08 13:43:26 -04:00
Mac Siri
56bdf6f846
Create scoped policy for internal/comment (#4311) 2019-10-08 12:33:59 -04:00
Sagar Choudhary
a8b61bf781 Refactor: initializeCreditsPage.js (#4312) [ci skip] 2019-10-08 12:33:28 -04:00
dependabot-preview[bot]
57942feb2c Bump sass-rails from 5.1.0 to 6.0.0 (#4288) [ci skip]
Bumps [sass-rails](https://github.com/rails/sass-rails) from 5.1.0 to 6.0.0.
- [Release notes](https://github.com/rails/sass-rails/releases)
- [Commits](https://github.com/rails/sass-rails/compare/v5.1.0...v6.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-08 11:47:53 -04:00
Glenn Carremans
179c3150dd [PWA] Add purpose tag to 192x192 (#4220) [ci skip] 2019-10-08 11:31:35 -04:00
Ben Halpern
c0faa20c90
Add more info to architecture (#4233)
* Add more info to architecture

* Fix various typos and improve clarity in docs
2019-10-08 11:29:44 -04:00
Victoria Fluharty
e111951ceb fixes bug in tag search feature (#4222)
* fixes bug in tag search feature
now allows user to type in full name of tag and it does not disappear
makes other changes to pass eslint failing tests
moves methods around according to eslint tests
makes use of prevState callback method due to eslint tests

* updates handleKeyDown method
removes complex logical expression comparison from !== to !=
changes made due to failing task in pull request

* removes commented out code that I added to test code
updates logic to fix searchResults
removes .filter()

* adds comments to fixed code for clarification
2019-10-08 09:40:53 -04:00
dependabot-preview[bot]
5511e9da63 Bump recaptcha from 5.1.0 to 5.1.1 (#4292)
Bumps [recaptcha](https://github.com/ambethia/recaptcha) from 5.1.0 to 5.1.1.
- [Release notes](https://github.com/ambethia/recaptcha/releases)
- [Changelog](https://github.com/ambethia/recaptcha/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ambethia/recaptcha/compare/v5.1.0...v5.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-08 09:10:09 -04:00
Yash Dave
49fbf280c3 Refactor initializeArticleReactions.js (#4303)
* Refactor initializeArticleReactions.js
- Refactors file according to eslint rules
- Add showModal and sendHapticMessage to globals
  in eslintrc.js
- Shorten initializeArticleReactions() by distributing
  parts of it into jumpToComments() and requestReactionCounts()
- requestReactionCounts() makes an ajax request to get the
  reaction counts
- jumpToComments() jumps to comments element directly if the
  element jump-to-comments is present

* Fix reactionOnClick function to work correctly
- Move sendHapticMessage and showModal global declaration to file
- name function on reaction button on click as addReactionOnClick
  which then calls reactToArticle()
2019-10-08 08:41:43 -04:00
Karin Hendrikse
a9adeee11f [SPEC] Add tests for sidebarUser component (#4301) [ci skip] 2019-10-07 16:01:59 -04:00
dependabot-preview[bot]
e6b1d6d882 Bump rubocop from 0.74.0 to 0.75.0 (#4287)
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.74.0 to 0.75.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.74.0...v0.75.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-07 15:44:43 -04:00
dependabot-preview[bot]
37a12d4bb2 Bump eslint-plugin-react from 7.14.3 to 7.16.0 (#4294) [ci skip]
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.14.3 to 7.16.0.
- [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases)
- [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yannickcr/eslint-plugin-react/compare/v7.14.3...v7.16.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-07 15:38:29 -04:00
dependabot-preview[bot]
3b383cb325 Bump stackprof from 0.2.12 to 0.2.13 (#4291) [ci skip]
Bumps [stackprof](https://github.com/tmm1/stackprof) from 0.2.12 to 0.2.13.
- [Release notes](https://github.com/tmm1/stackprof/releases)
- [Changelog](https://github.com/tmm1/stackprof/blob/master/CHANGELOG.md)
- [Commits](https://github.com/tmm1/stackprof/compare/v0.2.12...v0.2.13)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-07 15:25:53 -04:00
dependabot-preview[bot]
21b77dca6d Bump google-api-client from 0.31.0 to 0.32.1 (#4289) [ci skip]
Bumps [google-api-client](https://github.com/google/google-api-ruby-client) from 0.31.0 to 0.32.1.
- [Release notes](https://github.com/google/google-api-ruby-client/releases)
- [Changelog](https://github.com/googleapis/google-api-ruby-client/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/google-api-ruby-client/compare/0.31.0...0.32.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-07 15:14:15 -04:00
dependabot-preview[bot]
b6416f986f Bump faker from 2.4.0 to 2.5.0 (#4285) [ci skip]
Bumps [faker](https://github.com/faker-ruby/faker) from 2.4.0 to 2.5.0.
- [Release notes](https://github.com/faker-ruby/faker/releases)
- [Changelog](https://github.com/faker-ruby/faker/blob/master/CHANGELOG.md)
- [Commits](https://github.com/faker-ruby/faker/compare/v2.4.0...v2.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-07 15:13:18 -04:00
dependabot-preview[bot]
d63718e521 Bump lint-staged from 9.4.0 to 9.4.1 (#4295) [ci skip]
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 9.4.0 to 9.4.1.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Commits](https://github.com/okonet/lint-staged/compare/v9.4.0...v9.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-07 15:11:54 -04:00
dependabot-preview[bot]
236ce736fe Bump eslint-config-prettier from 6.3.0 to 6.4.0 (#4297) [ci skip]
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 6.3.0 to 6.4.0.
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-config-prettier/compare/v6.3.0...v6.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-07 15:10:43 -04:00
dependabot-preview[bot]
522f734f2f Bump husky from 3.0.7 to 3.0.8 (#4299) [ci skip]
Bumps [husky](https://github.com/typicode/husky) from 3.0.7 to 3.0.8.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](https://github.com/typicode/husky/compare/v3.0.7...v3.0.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-07 15:10:05 -04:00
dependabot-preview[bot]
2008f5c404 Bump rubocop-performance from 1.4.1 to 1.5.0 (#4286) [ci skip]
Bumps [rubocop-performance](https://github.com/rubocop-hq/rubocop-performance) from 1.4.1 to 1.5.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-performance/compare/v1.4.1...v1.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-07 15:06:01 -04:00
Mac Siri
db351b1d53 Update CODEOWNERS [ci skip] 2019-10-07 15:03:03 -04:00
Abbas
dce1b8d2da Update badge index's css (#4278) [ci skip] 2019-10-07 13:59:33 -04:00
Yehuda Neufeld
b5b98c3a37 added print styles to hide header & footer (#4249) 2019-10-07 12:57:36 -04:00
Mac Siri
a904c4f76a
Create CODEOWNERS (#4282) [ci skip] 2019-10-07 12:47:34 -04:00
Akshay Mahajan
7b95c0edd9 Remove invert filter from profile header social icons (#4225) [ci skip] 2019-10-07 10:27:59 -04:00
Anna Buianova
cbfe53e81b Rescue SocketError when trying to fetch a podcast (#4274) [ci skip] 2019-10-07 10:26:22 -04:00
Regina Alyssa
8b4f7faf6b Comment Social Preview (#4260)
* Add route for comment social preview

* Add method comment to social_previews_controller

* Add view for comment social preview

* Fix spacing in meta keywords

* Update comments page keywords

* Create helper for comment social media image

* Use comment social image, add published condition for article social image

* Add tests for comment social preview

* Remove not_found fallback for social previews controller

* Remove cached_tag_list

* Update typos of word 'image' in spec
2019-10-07 10:03:03 -04:00
Yash Dave
328d27ff41 Fix links without http(s) (#4155) [ci skip] 2019-10-07 09:52:07 -04:00
ΔNDRΞW
9338e30303 Remove unneeded margin-left in @media tag (#4153) [ci skip] 2019-10-07 09:50:20 -04:00
Adam Moore
0b8b00c96b Adjust notifcations menu's css (#4167) [ci skip] 2019-10-07 09:46:57 -04:00
Anna Buianova
a73a5c0f06 Bust non-article comment cache without issues (#4275) 2019-10-07 09:42:54 -04:00
Karin Hendrikse
14c9adefd5 Test: add test for opening help window on articleForm (#4237) 2019-10-07 08:49:44 -04:00
Glenn Carremans
580fd11bb9 Fix text color Load more listings button (#4246) 2019-10-06 18:13:10 -04:00
Araslanov Evgeny
2af439c261 Added link to podcats from episodes feed (#4205) 2019-10-06 17:37:09 -04:00
Jake Wesorick
8cc051e882 Add badges index page. (#4236)
* Add badges index page.

* remove empty style rule.

* Add spec for badges index. Fix case when not logged in.
2019-10-06 17:34:52 -04:00
Nick Taylor
30cc799240 Mini refactor to make var names clearer. (#4257) 2019-10-06 17:04:14 -04:00
Jacob Herrington
2b324df96f Remove commented out SCSS (#4256) 2019-10-06 17:03:32 -04:00
Attila Blascsak
66faaccdd8 Fix lints in notificationSubscriptionHander.js (#4172) [ci skip] 2019-10-04 13:08:59 -04:00
Akshay Mahajan
5d207c34c5 Fix embedded comment date alignmemt issue (#4209) 2019-10-04 09:42:30 -04:00
Jacob Herrington
8cebfd415d [DOC] Update DEV onboarding documentation (#4215) 2019-10-03 16:38:28 -04:00
Bradley Wells
30620d1d85 Make /credits more mobile friendly (#4213) [ci skip] 2019-10-03 16:21:12 -04:00
Melissa
9f37f27c2d Fix tabbing order of article engagement icons (#4192) [ci skip] 2019-10-03 16:05:07 -04:00
Paula
bff87da43c Add cybre.space instance (#4218) 2019-10-03 12:55:35 -04:00
Antony Garand
54c7e096c9 Remove useless argument in liquid template (#4200) [ci skip] 2019-10-03 12:52:56 -04:00
Enrico Grillo
ccfae978b5 [DOC] Standardize punctuation, period (#4176) [ci skip] 2019-10-03 11:54:04 -04:00
cyrillefr
82cca496fd Add collection ids to Api (reading + filtering) (#4180)
* Add collection ids to Api (reading + filtering)

  - refactored controller
  - modifyied views
  - added tests

* Add collection ids to Api (reading + filtering): requested changes

  - changed order in service
  - proper test in filtering
2019-10-03 11:26:39 -04:00
John Curcio
432d3348f6 Move user.follow delay calls to ActiveJob (#3136) (#4203)
* Move user.follow delay calls to ActiveJob (#3136)

* Pass ids to follow job instead of active records
2019-10-03 11:22:00 -04:00
Aswathprabhu
13ac7b43dd Remove code dupes in personalInfoForm (#4156) [ci skip] 2019-10-03 11:21:18 -04:00
Allan Klaus
4402cc212c Create tests to PingAdmins (#4169) [ci skip] 2019-10-03 11:18:53 -04:00
Chris Johnston
5da6c4e1c7 Add anchor and basic setup using docker (#4187) [ci skip] 2019-10-03 11:10:15 -04:00
Sebastián Chamena
2939a1cad4 Updates nio4r gem version (#4202) [ci skip] 2019-10-03 11:09:12 -04:00