maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove code dupes in personalInfoForm (#4156) [ci skip]

Browse source
This commit is contained in:
Aswathprabhu 2019-10-03 20:51:18 +05:30 • committed by Mac Siri
parent 4402cc212c
commit 13ac7b43dd
1 changed files with 36 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

68
app/javascript/onboarding/components/PersonalInfoForm.jsx
View file

@ -4,6 +4,21 @@ import PropTypes from 'prop-types';
import Navigation from './Navigation';
import { getContentOfToken } from '../utilities';
const setupFormTextField = ({ labelText = '', entityName = '', onChangeCallback }) => {
return (
<label htmlFor={entityName}>
{labelText}
<input
type="text"
name={entityName}
id={entityName}
onChange={onChangeCallback}
maxLength="60"
/>
</label>
)
}
class PersonalInfoForm extends Component {
constructor(props) {
super(props);
@ -81,38 +96,27 @@ class PersonalInfoForm extends Component {
<div className="onboarding-content about">
<h2>About You!</h2>
<form>
<label htmlFor="location">
Where are you located?
<input
type="text"
name="location"
id="location"
onChange={this.handleChange}
maxLength="60"
/>
</label>
<label htmlFor="employment_title">
What is your title?
<input
type="text"
name="employment_title"
id="employment_title"
onChange={this.handleChange}
maxLength="60"
/>
</label>
<label htmlFor="employer_name">
Where do you work?
<input
type="text"
name="employer_name"
id="employer_name"
onChange={this.handleChange}
maxLength="60"
/>
</label>
{
setupFormTextField({
labelText: 'Where are you located?',
entityName: 'location',
onChangeCallback: this.handleChange
})
}
{
setupFormTextField({
labelText: 'What is your title?',
entityName: 'employment_title',
onChangeCallback: this.handleChange
})
}
{
setupFormTextField({
labelText: 'Where do you work?',
entityName: 'employer_name',
onChangeCallback: this.handleChange
})
}
</form>
</div>
<Navigation prev={prev} next={this.onSubmit} />