Commit graph

189 commits

Author SHA1 Message Date
Julianna Tetreault
5daf162629
[deploy] Update "/internal/badges" route to "/internal/badge_achievements" (#9643)
* Update /internal/badges route to be /internal/badges/award
  -Updates the route
  -Redirects the old route, /internal/badges, to the new route

* Updates the redirect in #award_badges to correct route
  -Updates #award_badges in Internal::Badges::Controller
   to account for the new route, /internal/badges/award

* Adjust route to be /internal/badges/award in admin_awards_badges_spec.rb

* Adjust URL to be /internal/badges/award in badges_spec.rb

* Replace /internal/badges/award with /internal/badge_achievements to follow convention
  -Updates the old route in routes.rb
  -Updates the old route in #award_badges in Internal::Badges::Controller
  -Updates the old route in admin_awards_badges_spec.rb
  -Updates the old route in badges_spec.rb
2020-08-06 09:58:19 -04:00
Josh Puetz
cda18d0aa4
[deploy] Move Admin interface paths (#9576)
* Move administrate to /resource_admin

* Test fixes

* Update docs
2020-08-03 08:49:23 -04:00
Ben Halpern
5e6a651a4f
[deploy] Award badges asynchronously in internal (#9582)
* Award badges asynchronously in internal

* Spec fixes

Co-authored-by: mstruve <mollylbs@gmail.com>
2020-07-31 19:09:51 -04:00
Michael Kohl
1a6c6acd45
[deploy] Activate Devise::Lockable (#9535) 2020-07-30 10:28:51 -04:00
Takuma
2650092abb
[deploy] Fix showing unpublished article edit link (#9511)
* Fix showing unpublished article edit link

* Change if clauses to surround only edit link

* Fix: use ArticlePolicy.update? instead of checking article update authority manually
2020-07-30 15:18:30 +02:00
Alberto Pérez de Rada Fiol
115adbb1bd
[deploy] Add index and show pages for series (#9201)
* Add index and show pages for series

* Address code review

* Use `id` instead of `slug` to get collections

* Extract `collection_link` into the application helper

* Only count published articles

* Get rid of the `collection_link_class` method

* Add tests

* Fix test

* Use `**kwargs` instead of `options = {}`
2020-07-29 10:01:52 -04:00
Molly Struve
b40af82b66
Flaky Spec Fix:Remove let_it_be Test Prof Helper (#9556)
* Flaky Spec Fix:Remove let_it_be Test Prof Helper

* Spec cleanup and fixes
2020-07-29 11:31:01 +02:00
rhymes
5a2cae4fbb
Rubocop: enable and fix new Rails cops (#9537)
* Enable new Rails/* cops and use autocorrect on them

* Fixed Rails/PluckInWhere leftovers

* Fix Rails/DefaultScope

* Enable and fix Rails/PluckId

* Fix manual mistake with forcing autocorrection on Rails/PluckId

* Apply PR feedback to remove Rails/PluckId inline disables

* Apply PR feedback to get rid of Rails/PluckInWhere inline
2020-07-29 11:14:19 +02:00
Emma Goto
d98f143146
[deploy] Make UX settings save button sticky when modified (#9478)
* Add sticky footer to UX settings page  when changes are made

* Add missing spaces to html object
2020-07-27 12:52:21 -04:00
Molly Struve
4f20555221
[deploy] Optimization:Change Multiple Small Table Column IDs to Bigints (#9513) 2020-07-26 16:16:13 -05:00
Emma Goto
f6ee0f20e2
[deploy] Make profile settings save button sticky when modified (#9378)
* Make profile settings save button sticky when modified

* Replace querySelector with class selector, add newlines to end of files

* Make profile settings save button sticky when modified

* Replace querySelector with class selector, add newlines to end of files

* Add rspec test for sticky footer

* Move visit method to before block
2020-07-22 17:45:43 +02:00
Takuma
3fd01c326d
Bug Fix: Article Posted Date and Author Card Posted Date do not match (#9272)
* Refactor: move has_long_markdown from view to helper, and change it from variable to method

* Fix: Article Posted Date and Author Card Posted Date do not match #8789

* Add test case for Article Posted Date and Author Card Posted Date do not match #8789

* Use our custom URL helper module instead of manually constructing URL

* Move long_markdown? from ArticlesHelper to ArticleDecorator

* Change method name from has_long_markdown? to long_markdown?

* Add test suites for long_markdown? method to ArticleDecorator spec

* Use << over +=

* Fix typo

* Remove unnecessary cache
2020-07-22 16:34:55 +02:00
rhymes
88f0a0e58a
Rubocop: re-activate Style/RegexpLiteral and fix violations (#9418)
* Rubocop: re-activate Style/RegexpLiteral and fix violations

* Add 10 seconds default timeout to DB statements
2020-07-22 16:28:27 +02:00
Zach Attas
cc0231de77
Unflake system user_settings_response_templates_spec.rb (#8845) 2020-07-22 08:04:28 -05:00
Molly Struve
10788a5016
Flaky Spec Fix:Clear Elasticsearch FeedContent to avoid trying to load missing images (#9402) 2020-07-20 09:01:42 -05:00
Ridhwana
4359d5b09a
[deploy] Site Config: Get Started Section and Show Required Fields (#9289)
* chore: spike

* fix: update doesnt get to symbol

* spelling

* chore: some suggestions

* chore: change name

* chore: content tag and safe join

* chore: keep this open for now

* chore: code climate

* more code climate stuff

* chore: remove commas

* fix: tests

* feat: update the descriptions and placeholders

* chore: update all the variables

* chore: update lines

* feat: update ""

* chore: length line

* feat: content_tag

* chore: disable rubocop:disable Rails/OutputSafety

* feat: collapse the get started section if everything is filled out

* chore: comment

* some cleanup

* codeclimate :(
2020-07-20 08:20:15 -04:00
Pavel Tkachenko
9e94b80741
[deploy] Add local_date helper to handle dates with respect of user timezone (#9285)
* Add local_date helper to handle dates with respect of user timezone

* Fix date timezone bug for articles/show

* Fix date_helper to meet system specs requirements
2020-07-16 08:45:44 -06:00
rhymes
f1ec04a0c9
Rubocop: move dot in multi-line calls to leading position (#9262) 2020-07-16 15:51:11 +02:00
Molly Struve
5fcb788561
[deploy] Refactor: Remove Omniauth Error Logs, Send to Honeybadger (#9205) 2020-07-08 11:21:57 -05:00
rhymes
5b62811c98
[deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
Michael Kohl
fb27f52ed0
[deploy] Display banner if site hasn't been configured (PRE DEPLOYMENT TASKS) (#8435) 2020-07-07 07:37:04 -05:00
Molly Struve
85a10524d4
Change Highlight Tags to mark instead of em (#9098)
* Change Highlight Tags to mark instead of em

* Ensure User ID is never present and stub Sitconfig
2020-07-03 21:50:06 +02:00
Alberto Pérez de Rada Fiol
9b6ab40572
[deploy] Allow internal chat channels to be searched by their name (#9020)
* Allow internal chat channels to be searched by their name

* Add tests

* Fix test
2020-06-30 14:43:25 -05:00
Ben Halpern
8e0972dd33
[deploy] Remove sort links from tags for logged-out (SEO) (#8932)
* Remove sort links from tags for logged-out (SEO)

* Fix tests

* Fix tests take 2

* Final test fix

* Read error message more clearly

* Adjust tests

* Final test fix
2020-06-26 17:21:18 -04:00
rhymes
618a7b94fe
Fix available credits count in dashboard (#8928) 2020-06-26 16:18:04 +02:00
Vaidehi Joshi
d2ef01ecc2
Remove Percy (#8915)
We are no longer using the Percy service, so this code is not required anymore.
Removes the percy agent, the gem, and all references to Percy.snapshot and percy: true.
2020-06-25 11:19:58 -07:00
ludwiczakpawel
c9c88c7cc1
[deploy] Dashboard updates (#8879)
* flare tag line height

* .

* .

* .

* .

* specs

* spec

* .

* init

* .

* .

* js refactor

* js

* update spec

* Fix infinite scroll

* typo

* move IF

* pro analytics link fix

* Clean up tests

* Refactor adding of html

Co-authored-by: benhalpern <bendhalpern@gmail.com>
2020-06-25 13:10:17 -04:00
Molly Struve
757e611f6d
Spec Fix: Use Truncation For Tests Where Transactions Get Stuck (#8865) 2020-06-24 09:23:52 -05:00
Zach Attas
db468a6cfc
Adds ability to run spec not headlessly (#8844) 2020-06-23 08:37:37 -05:00
ludwiczakpawel
8c83aa3365
Table component & Dashboard update (#8778)
* flare tag line height

* .

* .

* .

* .

* specs

* spec

* .

* spec
2020-06-22 18:47:17 +02:00
Vaidehi Joshi
904f0dac78
Add ahoy + welcome notification tracking (#8758) [deploy]
* Set up ahoy gem, add ahoy-js

* Import ahoy.js into base.js.erb

* Add trackNotification function to notifications/index.html.erb

* Add sanitized_broadcast_id helper

* Use sanitized_broadcast_id in broadcast partial

* Add specs around tracking welcome notifications

* Remove optional fields from Ahoy::Visit migration + table

* Fiddle with trait to see if it helps with CI failures

* Disable geocode tracking in ahoy

* Stub out SiteConfig in notifications page spec
2020-06-18 13:40:14 -07:00
Molly Struve
6cc4c6fe4a
Flaky Spec Fix: Dont CGI Escape Title Compare (#8714) 2020-06-16 14:19:41 -05:00
rhymes
5d4f24c4ae
Remove Audit::Event::Util (#8704)
* Remove Audit::Event::Util

* Fix flaky spec
2020-06-16 12:50:53 -04:00
ludwiczakpawel
75c81b542f
[deploy] Branded authentication buttons (#8679)
* flare tag line height

* .

* init styling

* social buttons

* no need for inverted

* other places

* more

* Fix specs

Co-authored-by: rhymes <rhymesete@gmail.com>
2020-06-15 17:34:07 +02:00
Maja Komel
d6fa1d3367
[deploy] Add button to unfollow tags and users from dashboard (#8448) 2020-06-15 17:25:41 +02:00
Molly Struve
3f12b62910
Spec Cleanup: Stub Elasticsearch for js: true Specs that Dont Need it (#8453) 2020-06-12 15:43:59 -05:00
Vaidehi Joshi
38993608cf
Hide active announcements from logged-in users on the editor (#8427) [deploy] 2020-06-11 16:02:54 -07:00
Molly Struve
4f831a836b
Flaky Spec Fix: Stub Requests to Elasticsearch For some js: true Specs (#8426)
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-06-11 17:49:21 -05:00
Molly Struve
8400864273
Spec SpeedUp: Refactor and Combine Assertions for Viewing Articles by Timeframe Spec (#8422) 2020-06-11 16:48:11 -05:00
Vaidehi Joshi
a3665406d5
Hide site-wide messaging for opted-out users (#8409) [deploy] 2020-06-11 11:34:04 -07:00
Vaidehi Joshi
e532ccbe42
Allow users to dismiss announcements (#8396) [deploy]
* Provide default crayon styles when creating banners

* Import crayons styles into /internal pages.
* Allow admins to use crayons banner styles when creating broadcasts.
* Preview banner styles with crayons.

* Add a "x" close button to announcements, fix styling to accommodate it

* Use constant and helper for broadcast banner styles

* Add VALID_BANNER_STYLES frozen constant to Broadcast class.
* Add banner_style helper for determining banner style class.

* Clean up preview CSS, import broadcast styles into preview

* Add close button click handler, clean up initializeBroadcast

* Add close functionality to announcement banner

Also hide announcement if the user has explicitly seen and "X"-ed out of it.

* Add system specs around rendering + dismissing broadcasts

* Add some (truly beautiful) JS documentation

* Add visible class to broadcast when previewed from internal
2020-06-11 08:24:43 -07:00
Molly Struve
14e50630fd
Flaky Spec Fix: Clear Elasticsearch Data For js: true Specs to Fix Server Errors (#8388)
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-06-10 14:12:19 -05:00
Molly Struve
d5a106d11e
Spec Cleanup: Remove Unused and Redundant Code from Specs (#8385) 2020-06-10 16:59:31 +02:00
Molly Struve
a5f6183554
Flaky Spec Fix: Set Profile Image to Nil to Avoid Server Errors in js Specs (#8350) 2020-06-09 08:48:21 -05:00
Molly Struve
ee3792f447
[deploy] Use Javascript to Display Jobs Banner (#8303)
* Use Javascript to Display Jobs Banner

* one equal is enough

* stub SiteConfig values

* Return banner for all searches containing jobs, ensure banner is always at top, remove old job partial

* check for query before executing function
2020-06-08 18:58:00 -04:00
Molly Struve
232c67dd0a
Spec Speedup: Comment Out More Percy Only Specs (#8348) 2020-06-08 12:53:16 -05:00
Vaidehi Joshi
f04b0a7336
Display site-wide announcements (#8301)
* Serialize broadcast_data within AsyncInfoController::base_data

Adds a `broadcast:` key to our `base_data`, regardless of whether a user is logged in or not.
If a broadcast is not present, passes along a `nil` value.

* Initialize active broadcast (if present) when rendering main page

* Allow admins to preview a broadcast's processed_html when editing

* Add some fixed position styling to active broadcast

* Add system specs around broadcasts on homepage

* Use sanitize in place of html_safe when previewing broadcast

* Do not initialize broadcast if no broadcastData available

* Render default value on broadcast in options_for_select

* JS cleanup

* Unset fixed positioning for static navbar config

Also add some default styling for an active broadcast
2020-06-08 13:52:53 -04:00
Molly Struve
77543ff87d
[deploy] Spec Speed Up: Comment Out Percy Only Specs (#8347) 2020-06-08 10:54:39 -05:00
Molly Struve
dd1cfd33e0
Remove video_permissions Role Reference From Specs and Code (#8344) 2020-06-08 10:23:53 -05:00
Molly Struve
5d22e71ad6
nothing to see here....except maybe reverting a push to master (#8308)
🙈
2020-06-05 20:34:21 -05:00