Spec Speedup: Comment Out More Percy Only Specs (#8348)

This commit is contained in:
Molly Struve 2020-06-08 12:53:16 -05:00 committed by GitHub
parent f04b0a7336
commit 232c67dd0a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
15 changed files with 42 additions and 21 deletions

View file

@ -13,7 +13,8 @@ RSpec.describe "Creating an article with the editor", type: :system do
sign_in user
end
it "renders the page", js: true, percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page", js: true, percy: true do
visit new_path
fill_in "article_body_markdown", with: template
click_button "Save changes"

View file

@ -10,7 +10,8 @@ RSpec.describe "Deleting Article", type: :system do
click_on "DELETE"
end
it "renders the page", js: true, percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page", js: true, percy: true do
# Take snapshot before confirming deletion
Percy.snapshot(page, name: "Article: confirm deletion")
end

View file

@ -9,7 +9,8 @@ RSpec.describe "Editing with an editor", type: :system, js: true do
sign_in user
end
it "renders the page when user previews their changes", percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page when user previews their changes", percy: true do
visit "/#{user.username}/#{article.slug}/edit"
fill_in "article_body_markdown", with: template.gsub("Suspendisse", "Yooo")
click_button("Preview")
@ -37,7 +38,8 @@ RSpec.describe "Editing with an editor", type: :system, js: true do
expect(page).to have_text("Unpublished Post.")
end
it "renders the page when user unpublishes their post", percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page when user unpublishes their post", percy: true do
visit "/#{user.username}/#{article.slug}/edit"
fill_in "article_body_markdown", with: template.gsub("true", "false")
click_button("Save changes")

View file

@ -70,7 +70,8 @@ RSpec.describe "Views an article", type: :system do
let(:crossposted_article) { create(:article) }
let(:article2) { create(:article) }
it "renders the articles in ascending order considering crossposted_at", js: true, percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the articles in ascending order considering crossposted_at", js: true, percy: true do
visit article1.path
Percy.snapshot(page, name: "Articles: renders crossposted articles")
end

View file

@ -142,7 +142,8 @@ RSpec.describe "User visits articles by timeframe", type: :system do
context "when viewing articles for month" do
before { visit "/top/month" }
it "renders the page", percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page", percy: true do
Percy.snapshot(page, name: "Articles: /top/month")
end
@ -209,7 +210,8 @@ RSpec.describe "User visits articles by timeframe", type: :system do
context "when viewing articles for latest" do
before { visit "/latest" }
it "renders the page", percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page", percy: true do
Percy.snapshot(page, name: "Articles: /latest")
end

View file

@ -23,7 +23,8 @@ RSpec.describe "Editing A Comment", type: :system, js: true do
end
context "when user edits comment on the bottom of the article" do
it "renders the page", percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page", percy: true do
visit article.path.to_s
Percy.snapshot(page, name: "Edit comment: renders")
end

View file

@ -25,7 +25,8 @@ RSpec.describe "Admin awards badges", type: :system do
visit "/internal/badges"
end
it "renders the page", js: true, percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page", js: true, percy: true do
Percy.snapshot(page, name: "Admin: /internal/badges")
end

View file

@ -38,7 +38,8 @@ RSpec.describe "Admin bans user", type: :system do
expect(page).to have_content("User has been updated")
end
it "renders the page", js: true, percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page", js: true, percy: true do
Percy.snapshot(page, name: "Admin: /internal/users/:user_id/edit")
end

View file

@ -29,7 +29,8 @@ RSpec.describe "Admin creates new event", type: :system do
expect(page).to have_content("Create New Event")
end
it "renders the page", js: true, percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page", js: true, percy: true do
Percy.snapshot(page, name: "Admin: /internal/events shows published events")
end

View file

@ -14,7 +14,8 @@ RSpec.describe "Admin manages reports", type: :system do
visit internal_feedback_messages_path
end
it "renders the page", js: true, percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page", js: true, percy: true do
Percy.snapshot(page, name: "Admin: /internal/feedback_messages")
end
@ -34,7 +35,8 @@ RSpec.describe "Admin manages reports", type: :system do
clear_search_boxes
end
it "renders the page when searching reports", js: true, percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page when searching reports", js: true, percy: true do
fill_in "q_reporter_username_cont", with: user.username.to_s
click_on "Search"
@ -55,7 +57,8 @@ RSpec.describe "Admin manages reports", type: :system do
expect(page).to have_css("#edit_feedback_message_#{feedback_message3.id}")
end
it "renders the page when filtering", js: true, percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page when filtering", js: true, percy: true do
select "Invalid", from: "q[status_eq]"
click_on "Search"

View file

@ -32,7 +32,8 @@ RSpec.describe "Organization setting page(/settings/organization)", type: :syste
)
end
it "renders the page", js: true, percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page", js: true, percy: true do
visit "/settings/organization"
fill_in_org_form
click_button "Create Organization"

View file

@ -23,7 +23,8 @@ RSpec.describe "User edits their integrations", type: :system, js: true do
visit "/settings"
end
it "renders the page", percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page", percy: true do
click_link "Integrations"
Percy.snapshot(page, name: "Settings: /settings renders integrations")

View file

@ -11,7 +11,8 @@ RSpec.describe "User uses response templates settings", type: :system do
end
context "when user has a response template already" do
it "renders the page", js: true, percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page", js: true, percy: true do
visit "/settings/response-templates"
Percy.snapshot(page, name: "Settings: /response-templates renders")
@ -28,7 +29,8 @@ RSpec.describe "User uses response templates settings", type: :system do
expect(page).to have_current_path "/settings/response-templates/#{response_template.id}", ignore_query: true
end
it "renders the page when deleting a response template", js: true, percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page when deleting a response template", js: true, percy: true do
visit "/settings/response-templates"
accept_confirm { click_button "Remove" }

View file

@ -9,7 +9,8 @@ RSpec.describe "Looking For Work", type: :system do
visit "/settings"
end
it "renders the page", js: true, percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page", js: true, percy: true do
Percy.snapshot(page, name: "Logged in user: settings page")
end

View file

@ -47,7 +47,8 @@ RSpec.describe "Using the editor", type: :system do
end
describe "Submitting an article", js: true do
it "renders the page", percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page", percy: true do
fill_markdown_with(read_from_file(raw_text))
find("button", text: /\ASave changes\z/).click
Percy.snapshot(page, name: "Using the editor: submit an article")
@ -76,7 +77,8 @@ RSpec.describe "Using the editor", type: :system do
find("button", text: /\ASave changes\z/).click
end
it "renders the page", percy: true do
# TODO: Uncomment this spec when we decide to use percy again
xit "renders the page", percy: true do
Percy.snapshot(page, name: "Using the editor: publishing an article without a title")
end