Commit graph

9959 commits

Author SHA1 Message Date
dependabot[bot]
a9d01663a3
Bump @storybook/addon-storysource from 6.3.9 to 6.3.10 (#15013)
Bumps [@storybook/addon-storysource](https://github.com/storybookjs/storybook/tree/HEAD/addons/storysource) from 6.3.9 to 6.3.10.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.10/addons/storysource)

---
updated-dependencies:
- dependency-name: "@storybook/addon-storysource"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-12 09:55:11 +01:00
dependabot[bot]
0d6001dcd2
Bump @storybook/addon-links from 6.3.9 to 6.3.10 (#15016)
Bumps [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/addons/links) from 6.3.9 to 6.3.10.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.10/addons/links)

---
updated-dependencies:
- dependency-name: "@storybook/addon-links"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-12 09:29:50 +01:00
dependabot[bot]
d3ff4c2d85
Bump @storybook/preact from 6.3.9 to 6.3.10 (#15011)
Bumps [@storybook/preact](https://github.com/storybookjs/storybook/tree/HEAD/app/preact) from 6.3.9 to 6.3.10.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.10/app/preact)

---
updated-dependencies:
- dependency-name: "@storybook/preact"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-12 09:20:33 +01:00
dependabot[bot]
f6cd7d4ad9
Bump stripe from 5.38.0 to 5.39.0 (#15014)
Bumps [stripe](https://github.com/stripe/stripe-ruby) from 5.38.0 to 5.39.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases)
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/stripe/stripe-ruby/compare/v5.38.0...v5.39.0)

---
updated-dependencies:
- dependency-name: stripe
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-12 10:18:57 +02:00
VictorPS
39a62c4b3d
Internationalize hardcoded text for videos pages (#14960)
* Translation for "on Video"

* Moving dashboard.loading to core.loading to keep code DRY

* Translations for views/videos/new.html.erb

* Reverting the changes on app/views/dashboards/_sublist.html.erb

* Adding the dashboard.loading translations back

* Fixing some merge conflicts + sorting the dashboard translations

* Fixing the contact text on views/videos/new

* Using the full path instead of the lazy load
2021-10-12 12:09:55 +07:00
Michael Kohl
6753bd90c1
Fix tag dropdown (#14867) 2021-10-12 11:58:29 +07:00
Jamie Gaskins
70cf28ca7b
Fix rotation of images uploaded from iPhones (#15010)
* Fix rotation of images uploaded from iPhones

iPhones[1] take pictures in portrait mode with the orientation set to
90ºCCW. We noticed that uploading one of these images to a Forem
instance caused the image to be rotated when rendered. The current
theory is that Imgproxy is not maintaining the orientation value when
processing, which is solved by setting `auto_rotate: true` (serialized
into the Imgproxy URL as `ar:1`), according to the documentation.

See: 8e6585e28d/docs/generating_the_url_advanced.md (auto-rotate)

[1] This probably happens with other phones, but we discovered the issue
using an iPhone.

* Fix Imgproxy URL expectation for auto_rotate
2021-10-11 15:17:14 -04:00
dependabot[bot]
14259a2c41
Bump sidekiq-unique-jobs from 7.0.12 to 7.1.8 (#14995)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-11 11:11:26 -04:00
Ben Halpern
7003d9154d
Do not display skip link on mobile search page (#14999) 2021-10-11 10:02:18 -04:00
Papu Kumar(ReX)
33742e7907
Fix PropTypes Error Create New Post Page (#14969) 2021-10-11 09:48:24 -04:00
Tayllan
75df8e1f9e
Translate some labels from profile information (#15002)
* Translate some labels from profle information

* Fix some fr translations
2021-10-11 09:41:11 -04:00
Ashutosh Kumar
98b4391532
Fixed followers page html error (#15003)
* Fixed followers page html error

* Trigger Travis CI

Co-authored-by: rhymes <github@rhymes.dev>
2021-10-11 13:36:35 +01:00
dependabot[bot]
11f7d14ead
Bump flipper-active_record from 0.22.1 to 0.22.2 (#14996)
Bumps [flipper-active_record](https://github.com/jnunemaker/flipper) from 0.22.1 to 0.22.2.
- [Release notes](https://github.com/jnunemaker/flipper/releases)
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md)
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.22.1...v0.22.2)

---
updated-dependencies:
- dependency-name: flipper-active_record
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-08 15:34:55 -04:00
Jamie Gaskins
32ee50f278
Fix Sitemap for tags (#14989)
Set a NOT NULL constraint on tags timestamps

This commit also monkeypatches in a method for StrongMigrations to
disable a check temporarily. This migration is safe enough for DEV (it's
not ideal, but it'll only lock the table for a matter of milliseconds),
so we'll be fine disabling it but we don't want to disable the check
globally for all migrations in case there's a migration where this is
not safe.
2021-10-08 15:25:04 -04:00
Michael Kohl
e3abee660a
Add I18n date format example (#14973) 2021-10-08 15:08:56 -04:00
dependabot[bot]
b898bd3882
Bump flipper-ui from 0.22.1 to 0.22.2 (#14994)
Bumps [flipper-ui](https://github.com/jnunemaker/flipper) from 0.22.1 to 0.22.2.
- [Release notes](https://github.com/jnunemaker/flipper/releases)
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md)
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.22.1...v0.22.2)

---
updated-dependencies:
- dependency-name: flipper-ui
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-08 14:51:10 -04:00
dependabot[bot]
a32c368b73
Bump rpush from 6.0.0 to 6.0.1 (#14993)
Bumps [rpush](https://github.com/rpush/rpush) from 6.0.0 to 6.0.1.
- [Release notes](https://github.com/rpush/rpush/releases)
- [Changelog](https://github.com/rpush/rpush/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rpush/rpush/compare/v6.0.0...v6.0.1)

---
updated-dependencies:
- dependency-name: rpush
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-08 12:32:02 -06:00
Ben Halpern
3f921ec9c6
Fix profile image bug on email registration (#14991) 2021-10-08 14:30:57 -04:00
dependabot[bot]
baeabc058a
Bump flipper-active_support_cache_store from 0.22.1 to 0.22.2 (#14992)
Bumps [flipper-active_support_cache_store](https://github.com/jnunemaker/flipper) from 0.22.1 to 0.22.2.
- [Release notes](https://github.com/jnunemaker/flipper/releases)
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md)
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.22.1...v0.22.2)

---
updated-dependencies:
- dependency-name: flipper-active_support_cache_store
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-08 14:26:54 -04:00
Julianna Tetreault
df825e64fb
Forem Creator Cypress Setup (#14984)
* Adds loginCreator(); to commands.js and a creatorUser.js fixture

* Update cypress/support/commands.js

* Update cypress/support/commands.js

* Removes redundant loginUser(); function

* Remove superfluous back slashes from commands.js

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-10-08 11:05:12 -04:00
Bervianto Leo Pratama
acbda16b8a
Translate some texts from Dashboard Page (#14963)
* Extract some text from dashboard

* Fix template code

Signed-off-by: Bervianto Leo Pratama <bervianto.leo@gmail.com>

* Update translation for upload_a_video

* Fix wrong link

* Fix missing keys

* Seperate plural posts & followers
2021-10-08 13:55:21 +02:00
Lewis Sparlin
30b36ab014
I18n copy on Tags index page (#14891)
* Move hard-coded Tags index copy to [en,fr] locale files

* Use tags.pluralize for a better page title implementation

* Add better french translations

* Once more fr translation fix

* Remove .pluralize from title i18n
2021-10-08 10:21:06 +07:00
Jamie Gaskins
204ca4ae7e
Remove scheduled SitemapRefreshWorker job (#14986)
This worker no longer exists 
Force merged https://forem-team.slack.com/archives/CUJDU2R8D/p1633654148049700
2021-10-07 19:51:51 -05:00
Mac Siri
2bf4df65b1
Remove @forem/sre from locales changes (#14985) 2021-10-07 17:17:13 -04:00
Krystal Austin
5b251a7bb7
I18nize main_nav's "Home" (#14982) 2021-10-07 16:36:50 -04:00
dependabot[bot]
94acf00806
Bump amazing_print from 1.3.0 to 1.4.0 (#14980)
Bumps [amazing_print](https://github.com/amazing-print/amazing_print) from 1.3.0 to 1.4.0.
- [Release notes](https://github.com/amazing-print/amazing_print/releases)
- [Changelog](https://github.com/amazing-print/amazing_print/blob/master/CHANGELOG.md)
- [Commits](https://github.com/amazing-print/amazing_print/compare/v1.3.0...v1.4.0)

---
updated-dependencies:
- dependency-name: amazing_print
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-07 14:35:41 -06:00
dependabot[bot]
ef2a59ceea
Bump ddtrace from 0.52.0 to 0.53.0 (#14978)
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb) from 0.52.0 to 0.53.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases)
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md)
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.52.0...v0.53.0)

---
updated-dependencies:
- dependency-name: ddtrace
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-07 16:17:21 -04:00
dependabot[bot]
fb39da4440
Bump oj from 3.13.8 to 3.13.9 (#14979)
Bumps [oj](https://github.com/ohler55/oj) from 3.13.8 to 3.13.9.
- [Release notes](https://github.com/ohler55/oj/releases)
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ohler55/oj/compare/v3.13.8...v3.13.9)

---
updated-dependencies:
- dependency-name: oj
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-07 13:52:54 -05:00
dependabot[bot]
e6313c7298
Bump flipper from 0.22.1 to 0.22.2 (#14981)
Bumps [flipper](https://github.com/jnunemaker/flipper) from 0.22.1 to 0.22.2.
- [Release notes](https://github.com/jnunemaker/flipper/releases)
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md)
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.22.1...v0.22.2)

---
updated-dependencies:
- dependency-name: flipper
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-07 13:49:54 -05:00
Mir Bhatia
79afcba541
Add a notification on password reset (#14968) 2021-10-07 14:48:01 -04:00
Ben Halpern
b0a79da072
✂️✂️✂️ Remove boosted states from articles (legacy/dead code) (#14977)
* Remove boosted states from articles (legacy/dead code)

* Fix indentation
2021-10-07 14:39:34 -04:00
Ben Halpern
1d62d30853
Consolidate and internationalize various 'contact us' prompts (#14951)
* Consolidate and internationalize various 'contact us' prompts

* Update spec/requests/user/user_settings_spec.rb

Co-authored-by: Michael Kohl <citizen428@forem.com>

Co-authored-by: Michael Kohl <citizen428@forem.com>
2021-10-07 12:05:21 -04:00
Pramod
ce4ba84184
fix: accessibility issue with feeds comment section (#14958)
* fix: accessibility issue with feeds comment section

* fix: comments section name for logged out scenario and search results

* fix: review changes for logged in scenario

* fix: updated comments section aria label
2021-10-07 17:01:42 +01:00
Andy Zhao
f5d0c3be31
Fix small bugs related to identities when merging a user (#14885)
* Only prevent merge user if 2+ more identities, not 1+ more

* Refactor error messages into constants

* Skip only if no identities on deleted user

* Raise standard error instead of a string

* Add test to confirm correct identity was merged
2021-10-07 10:08:02 -04:00
Daniel Uber
412fa09026
Rename jest test from spec.js to test.js, so it actually runs (#14972)
* Rename jest test from spec.js to test.js, so it actually runs

* rename snapshot from spec.js.snap to test.js.snap
2021-10-07 08:13:47 -05:00
Ben Halpern
d85f07c00d
Fix legacy sitemap logic (#14926)
* Fix legacy sitemap logic

* Add aggregate failures

* Fix formatting

* Adjust robots.txt spec

* Fix index minimum to >=
2021-10-07 08:59:16 -04:00
Tayllan
fc77376c1b
Translate actions in articles view (#14911)
* Translate actions in articles view

* Move reactions to core.reactions namespace

* Add quotes to share_to in yml file

* Fix wrong translation in english locale

Co-authored-by: rhymes <github@rhymes.dev>
2021-10-07 12:08:14 +07:00
Nick Taylor
7e947ff2ca
Enabled Intellisense for the Cypress API (#14970) 2021-10-06 16:36:11 -04:00
Andy Zhao
0c28781c47
Remove tag categories from admin UI and remove aliased tags from /tags page (#14966)
* Don't show aliased tags in top 100 tags page

* Remove tag category from admin UI and controller params

* Fix styling of checkbox
2021-10-06 14:45:51 -04:00
dependabot[bot]
f93aa1a2e0
Bump rubocop-rails from 2.12.2 to 2.12.3 (#14967)
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.12.2 to 2.12.3.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.12.2...v2.12.3)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-06 14:32:51 -04:00
Monica Mateiu
bd0b4f1117
Tokenize settings menu and add French translations (#14905)
* tokenize settings menu and add French translations

* add quotes around tokens

* add tokens in alphabetical order

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2021-10-06 17:53:58 +02:00
Mohamed Asan N
cceb175d5d
Use section instead of header in dashboard pages (#14873)
* Use section instead of header

* Trigger Build

* Move section inside main

* Fix test case

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2021-10-06 17:12:43 +02:00
Alex
eed3c12f4d
Auto register Forems on Discover (#14962) 2021-10-06 10:51:15 -04:00
Jamie Gaskins
8e220dc97f
Add Rails cache instrumentation to Honeycomb (#14880)
It looks like Honeycomb uses ActiveSupport notifications to instrument
applications, based on the names of the `notification_events`. I pulled
this event name from the Rails guides:

https://guides.rubyonrails.org/active_support_instrumentation.html#active-support
2021-10-06 10:46:24 -04:00
Ben Halpern
7ffb5aa0fd
Change preview card hover delay (#14964) 2021-10-06 09:26:58 -04:00
Takuma
baab2c0930
Subscribe the newsletter if email_newsletter is changed (#14226)
* Check if email_newsletter is changed

* Check if Settings::General.mailchimp_api_key is defined

* Add spec for Users::NotificationSetting

* Remove spec for boolean column

http://www.chrisrolle.com/en/blog/boolean-attribute-validation

* Check if email is set when changing newsletter subscription setting

* Make it easy to read

* Remove specs for a case never happening
2021-10-06 12:30:22 +07:00
dependabot[bot]
7e23dccece
Bump doorkeeper from 5.5.3 to 5.5.4 (#14959)
Bumps [doorkeeper](https://github.com/doorkeeper-gem/doorkeeper) from 5.5.3 to 5.5.4.
- [Release notes](https://github.com/doorkeeper-gem/doorkeeper/releases)
- [Changelog](https://github.com/doorkeeper-gem/doorkeeper/blob/main/CHANGELOG.md)
- [Commits](https://github.com/doorkeeper-gem/doorkeeper/compare/v5.5.3...v5.5.4)

---
updated-dependencies:
- dependency-name: doorkeeper
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-05 18:29:14 -04:00
Jeremy Friesen
aff4754ad0
Adding jeremyf to core team (#14947)
Jeremy started at Forem on October 4, 2021
2021-10-05 14:38:20 -04:00
rhymes
e5226b9951
Upgrade Stimulus to 3.0 (#14869)
* Upgrade Stimulus to 3.0

* Remove unused variable

* Bump postcss from 8.3.8 to 8.3.9 (#14956)

Bumps [postcss](https://github.com/postcss/postcss) from 8.3.8 to 8.3.9.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/8.3.8...8.3.9)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-05 20:00:37 +02:00
dependabot[bot]
fb821cca41
Bump @rails/webpacker from 5.4.2 to 5.4.3 (#14948)
Bumps [@rails/webpacker](https://github.com/rails/webpacker) from 5.4.2 to 5.4.3.
- [Release notes](https://github.com/rails/webpacker/releases)
- [Changelog](https://github.com/rails/webpacker/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rails/webpacker/compare/v5.4.2...v5.4.3)

---
updated-dependencies:
- dependency-name: "@rails/webpacker"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-05 13:44:09 -04:00