Commit graph

7507 commits

Author SHA1 Message Date
Ben Halpern
f263e17a1f
Fix dataset check in JS (#20733)
* Fix dataset check in JS

* Email opt in quick fix

* Change test
2024-03-05 17:11:07 -05:00
Philip How
751e9d70d2
Show ⚠️ icon on /admin when an article is not indexed on search engines (#20713)
* Add in icon when an article is not indexed on admin

* tests

* rubocop

* rubocop
2024-03-05 21:34:20 +00:00
Philip How
7a873bd14c
Add a link icon to Mod Center to open article in new tab/window (#20672)
* add link icon to open article in new tab/window

* add label to icon

* add label to icon
2024-03-05 15:16:20 -05:00
Philip How
45a1bb20aa
Use request utility on actionsPanel (#20725) 2024-03-04 19:02:35 -05:00
Gabriel Quaresma
02459941a5
Profile bio does not recognize line breaks (#20572)
Co-authored-by: Mac Siri <mac@forem.com>
2024-03-04 20:37:16 +00:00
Ian Lourenço
bb6954bfb6
Fix: visual glitch with autocomplete component (#20611)
* fix: add display:block style to span and correct minor typo

* refactor: change posisiton and max-heigh on scss

* refactor: adapt message with conditional

---------

Co-authored-by: Mac Siri <mac@forem.com>
2024-03-04 19:47:32 +00:00
Gabriel Quaresma
ed584ff5dc
Fix successfully passing incorrect tests in actionsPanel.test.js (#20674)
* first commit

Co-authored-by: Guilherme Nunes <guilherme.nunes.lopes@gmail.com>

* feat: implementt rollbackReactionButtonsState

* test: write new test cases

* refactor: update rollbackReactionButtonsState

---------

Co-authored-by: Guilherme Nunes <guilherme.nunes.lopes@gmail.com>
Co-authored-by: Mac Siri <mac@forem.com>
2024-03-04 16:58:38 +00:00
Ben Halpern
0140a7631c
Adjust menu popup behavior contextually (#20718) 2024-03-01 17:27:50 -05:00
Ben Halpern
f2968baadb
Add optional client-side dismissal SKU for closable billboards (#20716)
* Add optional client-side dismissal SKU for closable billboards

* Safe nav
2024-03-01 16:13:19 -05:00
Anna Buianova
288c9ed31f
Fix articles counts based on display rules (#20669)
* Comment counts for signed in users

* Adjust comments count for articles

* Fixed counts for signed out users, added specs for Comments::Count

* Fixed counts for signed out and added specs for Comments::Count

* Removed debug info from the view

* Removed separate count for signed out users

* Remove irrelevant specs

* Remove unused scope
2024-03-01 07:54:15 -05:00
Philip How
fe213a81fa
Add Following Tags and Reconfigure Sidebar in Mod Center (#20694)
* reconfigure mod left sidebar, adding following tags

* add localization
2024-03-01 07:35:54 -05:00
Ben Halpern
c901eb48be
Apply efficiency adjustment to orgs as well (#20710) 2024-02-29 18:27:47 -05:00
Ben Halpern
2ad8b7a809
Fast follow on follow suggestion efficiency (#20709) 2024-02-29 18:05:21 -05:00
Ben Halpern
083732e2f3
Optimize and simplify onboarding recommendations (#20682)
* Improve performance of follow recs

* Finish and simplify

* Update tests

* Update tests

* Update tests

* Change onboardings_controller

* Adjust tests

* Change fallback to use score

* Adjust join
2024-02-29 15:57:52 -05:00
Anna Buianova
f8418a6415
Exclude articles from spammers and suspended users from /mod (#20692) 2024-02-28 17:36:56 +00:00
Ben Halpern
78f9bec3e7
Allow admin to declare whether to include the badge description in message (#20684)
* Allow admin to declare whether to include the badge description in badge achievement message

* Update spec/services/badges/award_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add proper acceptance to tests

* Tweak tests

* Switch to kwargs

* Clean up test acceptance

* Change interface

* Update spec/requests/admin/badge_achievements_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update app/services/badges/award.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Adjust interface

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-02-28 11:02:58 -05:00
Ben Halpern
585bea212d
Remove non-contextual content from signed-out version of page (#20686) 2024-02-27 15:15:05 -05:00
Ben Halpern
229c3fc3c0
Go to page you came from after onboarding when coming through billboard (#20675)
* Add proper location memory for onboarding

* Get test dates working as expected
2024-02-26 16:21:05 -05:00
Ben Halpern
4015b346e2
Finalize 'commnts to display' a/b test (#20679) 2024-02-26 11:06:17 -05:00
Ben Halpern
f88784cc35
Add configuration for admins to specify compliant email strategies (#20663)
* Add configuration for admins to specify compliant email strategies

* Add keys for test
2024-02-21 08:27:26 -08:00
Daniel M Brasil
406e3fec4d
Rremove de-indexing From Accounts With No Comments (#20660)
* remove de-indexing from accounts that have no comments

* add specs for Article#skip_indexing?
2024-02-21 10:54:02 +00:00
Ben Halpern
d8ed35a94e
Unwrap user before passing to field_test (#20667) 2024-02-20 16:28:52 -08:00
Ben Halpern
44809ce7e7
Add max style for fixed billboard (#20666) 2024-02-20 16:14:59 -08:00
Ben Halpern
223fb9cbfb
Add a/b test for feed style on new users (#20664)
* Add a/b test for feed style on new users

* Add current_user check

* Adjust to not look for current_user right away

* Move field test to the right place
2024-02-20 15:43:28 -08:00
Ben Halpern
17d81b6cb1
[Hotfix] Fix cache key (#20658)
* Fix cache key

* Small style tweak
2024-02-19 19:24:36 -08:00
Ben Halpern
caa7b5a63a
[Hot fix] Fix style bugs with registration page (#20656)
* Fix style bugs with registration page

* Small additonal style tweak

* Final style tweak
2024-02-19 18:48:50 -08:00
Ben Halpern
561bdb278c
Change value of signup in success score (#20647) 2024-02-18 10:30:59 -08:00
Ben Halpern
6ef9a83252
Make mobile runtime banner optional (#20637)
* Remove runtime banner

* Show/hide runtime banner setting

* Update app/views/layouts/application.html.erb

* Update app/views/layouts/application.html.erb

* Update app/views/layouts/application.html.erb
2024-02-16 10:45:41 -08:00
Anna Buianova
d0f3fb6fff
Optimize and test comments cache after score change (#20640)
* Add specs for caching article comments, use cache_key_with_version

* Optimize cache busting for spammer comments, reorganized related specs
2024-02-16 14:53:11 +00:00
Makar
c6cef39694
Persist selectedTag filtering of the reading list (#20601)
* persist selectedTag filtering of the reading list when coming back after reading an article

* bugfix -- could not filter back by all tags in mobile

* e2e tests for persisted filtering

---------

Co-authored-by: Mac Siri <mac@forem.com>
2024-02-16 13:06:21 +00:00
Ben Halpern
097057a8dc
New a/b tests for Feb 14 (#20632) 2024-02-14 15:57:41 -05:00
Ben Halpern
8eb41eef8e
Record billboard signup conversions (#20629)
* Record billboard signup conversions

* Update app/models/billboard_event.rb

* Modify click tracking
2024-02-14 14:18:57 -05:00
Ben Halpern
13c105a6b4
Use new_comment as the intersection object for delayed billboard (#20627) 2024-02-14 11:48:04 -05:00
Ben Halpern
205aee8c78
Add billboard for bottom of page with allowance to delay until after reading is finished. (#20616)
* Add delayed behavior

* Add special behavior to billboards

* Fix order for test

* Test clicking outside element when close event is present

* Update app/javascript/packs/billboardAfterRenderActions.js
2024-02-13 11:56:32 -05:00
Anna Buianova
fb09a75352
Update comment updated_at when changing score (#20622)
* Change comment updated_at when updating comment score

* Rubocop fixes
2024-02-13 13:17:24 +00:00
Mac Siri
248f0f55c0
Allow Slack::Messengers to be disabled (#20609) 2024-02-09 17:20:35 +00:00
Philip How
e2035e0c4a
update first post badge name (#20613) 2024-02-09 12:20:14 -05:00
Anna Buianova
e5064b418f
Hide super low score comments if they are child comments (#20612) 2024-02-09 16:24:13 +00:00
Philip How
0be9914aa0
Fix sending Category to SendGrid (#20597)
* add in header for digest emails

* add test

* try different json encoding

* Update app/mailers/digest_mailer.rb

Co-authored-by: Mac Siri <mac@forem.com>

---------

Co-authored-by: Mac Siri <mac@forem.com>
2024-02-08 18:09:57 +00:00
Ben Halpern
9ba5a5fab0
Add client geo to helper method (#20608) 2024-02-08 12:51:37 -05:00
Ben Halpern
1b083f39a4
Ensure at least 0 score for new badge award (#20605) 2024-02-08 17:00:10 +00:00
Ben Halpern
2f9769a89d
Add new sidebar billboard locations and remove legacy campaign area (#20562)
* Add new sidebar billboard locations

* Remove some specs

* Remove campaign tests

* Adjust tag-allowed billboards

* Fix up targeting functionality

* Fix sidebar third render
2024-02-08 16:55:48 +00:00
Philip How
55f191a5ec
Automated First Post Badge (#20600)
* award first post logic, schedule, and tests

* award first post logic, schedule, and tests
2024-02-08 10:11:40 -05:00
Anna Buianova
07ffb2e3be
Removed spammers from followers list (#20603)
* Remove spam and suspended users from followers list (api and dashboards)

* Fixed the api followers endpoint

* Fixed issue with follower_ids query
2024-02-08 13:57:15 +00:00
Ben Halpern
2d9c87d9d3
Add ability to view specific billboard via params in any context if it is live (#20599)
* Fix AudienceSegmentRefreshAllWorker args issue

* Add ability to view specific billboard via params if it is live

* Fix lingering

* Refactor to clean up
2024-02-07 15:11:22 -05:00
Anna Buianova
b43cb38d40
Remove notifications related to spammer actions (after the role is assigned) (#20593) 2024-02-07 17:36:19 +00:00
Philip How
a900050fdc
Add Sendgrid Category to Digest Emails (#20595)
* add in header for digest emails

* add test
2024-02-06 19:02:10 +00:00
Philip How
5bd5e5e1b6
fix image width in newsletter opt in step (#20590) 2024-02-05 12:38:52 -05:00
Ben Halpern
e26b27c7fa
New a/b test for Feb 5 (and add a variable too a hardcoded value) (#20588)
* Fix AudienceSegmentRefreshAllWorker args issue

* New a/b test for Feb 5 (and add a variable too a hardcoded value)
2024-02-05 15:46:03 +00:00
Anna Buianova
7125a62db0
Changed logic for hiding and displaying low-quality marker for comments based on their score (#20581)
* Specs for revised comments thresholds

* Changed thresholds for low quality comments

* Added specs for comments page

* Fixed /comments and related specs

* Reorganized code for comments trees

* Specs for podcasts episodes comments

* Refactored Comments::Tree

* Refactored Comments::Tree + added specs

* Made build_sort_query private
2024-02-05 09:27:24 -05:00