Commit graph

5024 commits

Author SHA1 Message Date
Ridhwana
a2f1a0049f
Removal of morrrre hardcoded dev.to links (#7390)
* feat: remove 90% of hardcoded dev.to links now

* chore: update tests

* chore: implement suggested changes

* chore: update url

* chore: update to use URL helper
2020-04-21 11:50:18 +02:00
Molly Struve
082d1395f6
[deploy] fix filtering by approved bug (#7391) 2020-04-20 19:56:13 -04:00
Julianna Tetreault
21cd5a3f72
[deploy] Replace Cover Image <div> Tags With <img> Tags (#7396)
* Replace cover image div tag with img tag in articles/show
  * Make cover images more semantic with img tag and src
  * Keep img styling for now

* Replace divs with inline img in _main_stories_feed.html.erb
  * Remove div in favor img tag to make more semantic
  * Add extra line at file end in _main_stories_feed.html.erb
  * Reword img alt text in articles/show.html.erb

* Remove unnecessary styling for cover images from stylesheets
  * Remove background image styling for main feed article
  * Remove background image styling for article show page
  * Adjust padding for main feed article
  * Adjust padding for article show page
  * Add 100% width to main feed article

* Adjust styling for article show pages
  * Add height to article show CSS
  * Adjust article show padding to be 0
  * Revert div to img change in _main_stories_feed.html.erb
  * Revert styling changes for articles.scss

* Add original styling back to article-show.scss
  * Add original styling for article show pages back
  * Hopefully avoid conflicts due to caching by keeping code

* Adjust team delightful TODO to be more explicit and readily accessible

* Update app/assets/stylesheets/article-show.scss

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-04-20 18:01:08 -04:00
Andy Zhao
f5c94391b7
[deploy] Revert "[deploy] Revert "[deploy] Buttons (#7361)" (#7399)" (#7400)
This reverts commit 028121b39d.
2020-04-20 16:40:50 -04:00
Molly Struve
028121b39d
[deploy] Revert "[deploy] Buttons (#7361)" (#7399)
This reverts commit a20e76995c.
2020-04-20 15:57:38 -04:00
ludwiczakpawel
a20e76995c
[deploy] Buttons (#7361)
* cleanup

* more cleanups

* copy fix + groups

* more buttons

* we are good.

* little shadow update

* .

* doc update

* themes

* stories

* button with icon

* html stories

* button groups

* comment subscription component

* Update small-bell.svg

* tests

* Fix polish locale in snapshots

Co-authored-by: rhymes <rhymesete@gmail.com>
2020-04-20 14:35:49 -04:00
Ben Halpern
c349792d8f
Incluse language about inclusive naming in contributing.md (#7376) 2020-04-20 12:59:49 -04:00
rhymes
b7e5aaef18
[deploy] Fix badges slug migration (#7392) 2020-04-20 10:55:24 -05:00
Molly Struve
4f374acbc5
[deploy] filter Elasticsearch by org id properly (#7389) 2020-04-20 10:01:30 -05:00
Molly Struve
2f6952ed38
raise AR not found error if Userblock is not found (#7388) 2020-04-20 09:56:21 -05:00
rhymes
e97d2ccf63
[deploy] Improve badge slug generation (#7386)
* Fix badge generation and add tests

* Add unique index to badges slug
2020-04-20 15:47:44 +02:00
Ridhwana
7bcacfa3a6
Update feedback messages to be general (#7373)
* feat: update feedback messages to be general

* spec: update the feedback test
2020-04-20 10:22:31 +02:00
ludwiczakpawel
d585c981db
[deploy] fixing svg (#7380) 2020-04-19 15:42:30 +02:00
Ben Halpern
2171fe3255
[deploy] Add missing parentheses to video html (#7379) 2020-04-18 16:34:48 -04:00
Ben Halpern
3d4944ebae
[deploy] Add video duration to search results (#7377) 2020-04-18 15:16:38 -04:00
Ben Halpern
803791e5b6
[deploy] Fix sort_by expectations with pagination (#7372)
* Fix sort_by expectations with pagination

* Add sort_direction to view

* Include sort_by in allowed json
2020-04-18 13:57:15 -04:00
Ben Halpern
a0504f5f77
[deploy] Include organization in feed_content results (#7374) 2020-04-18 13:07:59 -04:00
Ben Halpern
e0b932e569
[deploy] Fix response template non-logged-in navigation issue (#7370) 2020-04-17 17:53:28 -04:00
Ridhwana
6dbc838bae
[deploy] Update our mailers to be generalized (#7359)
* feat: make the from in the email to be dynamic

* feat: hardcoded mailer dev.to

* feat: oops hardcoded email addresses in the terms

* chore: remove some whitespace

* update editor guide

* feat: new reply email

* feat: new message mailer

* feat: new follower email

* feat: capitalize the button

* feat: rename the link

* feat: capitalize the button

* feat: generalize the urls

* feat: generalise the url

* feat: dynamic DEV

* feat: update the specs

* feat: DEV digest generalisation part 1

* fix: the method is accessed by tag_url and so the default parameter needs to be set at this level and not at self.tag

* fix: use the tag model instance instead of passing through just the tag name (so that we can use tag_url)

* chore: make code climate happy

* chore: more robocop

* feat: add a default url back for self.tag

* test: fix the feedback helper spec

* fix: spec to be general

* fix: oops :(

* refactor: user_settings_path

* chore: use code_of_conduct_path

* chore: robocop

* chore: use connect path

* chore; use the notifications symbol

* chore: misc path

* feat: simplify url

* feat/fix: change the order of the helpers and use user_url

* chore: user_url

* capitalise

* chore: update article path
2020-04-17 15:35:35 -04:00
Fernando Valverde
f2ee0378f9
[deploy] Decorator podcast episode metadata (#7303)
* Moves podcast episode metadata to decorator

* Updates the podcast episode metadata to use image_url

* Syntax tweaks, initializeMedia() fix for initialized audio & brought back use strict
2020-04-17 12:52:11 -06:00
Molly Struve
61b6f8ea3e
[deploy] record identity creation metrics (#7366) 2020-04-17 13:15:03 -05:00
Molly Struve
3832e9356d
rescue Addressable::URI::InvalidURIError and mark podcast ep unreachable (#7343) 2020-04-17 13:11:08 -05:00
rhymes
1b93666b3b
[deploy] Add user_id presence validation for Identity (#7365)
* Add user_id presence validation for Identity

* Remove duplicated validation

* Save user within build_user

* Fix typo

* Fix spec with in memory user
2020-04-17 20:02:26 +02:00
Molly Struve
8340051649
[deploy] properly parse params for feed content searching (#7367) 2020-04-17 12:23:24 -05:00
rhymes
f8a81956e2
Disable service worker on remaining hardcoded redirects (#7360)
* Disable service worker on shop redirect

* Add missing redirects exceptions
2020-04-17 18:53:44 +02:00
Nick Taylor
f0c4d56117
Added a theme switcher to Storybook. (#7364)
* Added the theme switcher to storybook.

* Renamed method to align it more with what it actually does.

* Renamed method to align it more with what it actually does.

* Changed order of themes in select to match order in UX settings.
2020-04-17 10:39:05 -04:00
rhymes
a2893056b6
Routine rubocop fixes (#7356)
* rubocop -a

* Fix stuff

* rubocop -a again

* autocorrect
2020-04-17 15:48:39 +02:00
Molly Struve
2c99424205
[deploy] Execute Feed Searches through Elasticsearch (Round 2) (#7231) 2020-04-17 08:38:07 -05:00
Molly Struve
2d40174a92
implement backend search functionality for readinglist Reactions (#7308) 2020-04-17 08:37:22 -05:00
rhymes
ccea13bc21
Hide the Shop in homepage if not present (#7358) 2020-04-17 13:28:27 +02:00
Molly Struve
51b9312cf1
silence duplicate data update scripts to optimize starting up a new env (#7340) 2020-04-17 12:30:56 +02:00
Molly Struve
7be90d1b4b
[deploy] overwrite name field for honeycomb when sending Elasticsearch requests (#7338) 2020-04-17 12:30:29 +02:00
Ben Halpern
2808a27c75
[deploy] Change window.currentUser to userData() (#7353) 2020-04-16 23:24:51 -04:00
Ben Halpern
13537fb8d4
[deploy] Fix connect edge cases (#7352) 2020-04-16 21:57:09 -04:00
Ben Halpern
2d978696c4
[deploy] Small connect js fixes (#7350) 2020-04-16 20:06:32 -04:00
Ben Halpern
697c0df5b1
[deploy] Manually create channel and add users for org channels (#7346) 2020-04-16 19:13:39 -04:00
Ben Halpern
03c28a5671
[deploy] Create private group chat channel for orgs (#7270)
* WIP chat channel for orgs

* Finalize

* Enable upsert functionality for role switch

* Private group chat

* Rearrange permissions code

* fix typo
2020-04-16 17:02:06 -04:00
Andy Zhao
2343785927
[deploy] Add type_of param to whitelist (#7342) 2020-04-16 16:52:32 -04:00
Andy Zhao
f5ec83653c
[deploy] Finalize and add response templates feature (#7068) 2020-04-16 15:53:29 -04:00
Alex
cc6249beff
[deploy] Update whitelisted params on Fastly on deployments (#7279)
* Add Fastly whitelisted params

* Create FastlyVCL::WhitelistedParams.update service

* Add specs

* Create rake task to call new service

* Add rake task to setup script

* Add documentatoin

* Move sort inside params_to_array method

* Rename VCL_REGEX to VCL_DELIMITER

* Add PR URL to docs

* Move snippet name to SNIPPET_NAME constant

* Refactor setting content

* Rename params_to_array to params_to_sorted_array

* Change guard and log success on update

- Return early if params are equal
- Log success message to Rails.logger on update
- Log params diff to Datadog

* Return true explicitly

* Move rake task execution from to release-tasks

* Remove unnecessary environment guard in task

* Remove duplicate code param

* Refactor string from build_content

* Remove reliance on sort

* Reorder logging to implicitly return true

* Update docs to reference release-script.sh

* Update docs

* Update whitelisted params

* Fix params_updated? bug and add more specs

* Remove duplicate param...oopsie!
2020-04-16 15:11:57 -04:00
dependabot-preview[bot]
2c034dcbac
[deploy] Bump ibm-openapi-validator from 0.26.0 to 0.26.1 (#7327)
Bumps [ibm-openapi-validator](https://github.com/IBM/openapi-validator) from 0.26.0 to 0.26.1.
- [Release notes](https://github.com/IBM/openapi-validator/releases)
- [Changelog](https://github.com/IBM/openapi-validator/blob/master/CHANGELOG.md)
- [Commits](https://github.com/IBM/openapi-validator/compare/v0.26.0...v0.26.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-04-16 14:19:47 -04:00
dependabot-preview[bot]
c246cb106f
Bump intersection-observer from 0.7.0 to 0.8.0 (#7322)
Bumps [intersection-observer](https://github.com/w3c/IntersectionObserver) from 0.7.0 to 0.8.0.
- [Release notes](https://github.com/w3c/IntersectionObserver/releases)
- [Commits](https://github.com/w3c/IntersectionObserver/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-16 14:18:53 -04:00
dependabot-preview[bot]
0e06ed1ad7
Bump lint-staged from 10.1.2 to 10.1.3 (#7330)
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 10.1.2 to 10.1.3.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Commits](https://github.com/okonet/lint-staged/compare/v10.1.2...v10.1.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-16 14:18:26 -04:00
dependabot-preview[bot]
17b4f80189
Bump core-js from 3.6.4 to 3.6.5 (#7328)
Bumps [core-js](https://github.com/zloirock/core-js) from 3.6.4 to 3.6.5.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/compare/v3.6.4...v3.6.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-16 14:18:20 -04:00
dependabot-preview[bot]
46b422022a
Bump husky from 4.2.3 to 4.2.5 (#7324)
Bumps [husky](https://github.com/typicode/husky) from 4.2.3 to 4.2.5.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](https://github.com/typicode/husky/compare/v4.2.3...v4.2.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-16 14:18:11 -04:00
dependabot-preview[bot]
ad4a4267d5
Bump css-loader from 3.5.1 to 3.5.2 (#7325)
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 3.5.1 to 3.5.2.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v3.5.1...v3.5.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-16 14:18:02 -04:00
dependabot-preview[bot]
8a966a780d
Bump style-loader from 1.1.3 to 1.1.4 (#7326)
Bumps [style-loader](https://github.com/webpack-contrib/style-loader) from 1.1.3 to 1.1.4.
- [Release notes](https://github.com/webpack-contrib/style-loader/releases)
- [Changelog](https://github.com/webpack-contrib/style-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/style-loader/compare/v1.1.3...v1.1.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-16 14:17:53 -04:00
rhymes
0a6be8b967
[deploy] Improve some validations (#7335)
* Validations

* Fix specs

* Revert twitter tag change
2020-04-16 18:59:12 +02:00
Molly Struve
8f6fb35404
flaky spec fix: compare org updated_at properly (#7336) 2020-04-16 11:37:07 -05:00
dependabot-preview[bot]
82d4dae2d1
[deploy] Bump rouge from 3.17.0 to 3.18.0 (#7320)
Bumps [rouge](https://github.com/rouge-ruby/rouge) from 3.17.0 to 3.18.0.
- [Release notes](https://github.com/rouge-ruby/rouge/releases)
- [Changelog](https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rouge-ruby/rouge/compare/v3.17.0...v3.18.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-16 10:44:50 -05:00