Commit graph

5122 commits

Author SHA1 Message Date
Molly Struve
8eb4612166
[deploy] fix podcast episode comment rendering and write a spec for it (#7547) 2020-04-27 14:56:03 -05:00
Vaidehi Joshi
54519dbf4e
Minor tweaks to onboarding UI (#7546) [deploy]
* Use accent-color in onboarding progress stepper

This looks much prettier with the default DEV theme when viewing onboarding.
Closes https://github.com/thepracticaldev/dev.to/issues/7545.

* Align onboarding checkboxes in their parent element

Use `display: flex`.
Closes https://github.com/thepracticaldev/dev.to/issues/7544.
2020-04-27 12:38:48 -07:00
Rafi
bdcfba7d70
[deploy] Saving youtube url (#7516)
* Saving youtube url

* Fixing description in the spec

* Optimizing youtube logo svg

* Fixing indentation of form
2020-04-27 14:14:07 -04:00
Andy Zhao
fded16b8dc
[deploy] Add a more helpful msg for response templates (#7543) 2020-04-27 13:28:28 -04:00
Alex
6bbe4e0533
[deploy] Change CarrierWave error code (#7539) 2020-04-27 13:27:04 -04:00
rhymes
8b82103fd0
Escape titles to avoid encoding issues (#7535) 2020-04-27 12:27:19 -04:00
Michael Wilde
dfd8b0bf86
[deploy] Fixed "Join the Welcome thread" spelling err (#7538)
Was "welcome thead" now is "welcome thread".  I noticed the spelling error show up as I recently just joined dev.to
2020-04-27 18:24:40 +02:00
Mac Siri
95981fa937
Remove index_chat_channels_on_slug from schema (#7528) 2020-04-27 18:23:38 +02:00
Lisa Sy
9de59c4107
Update sidebar filter menu on Notifications (#7394) 2020-04-27 12:17:20 -04:00
rhymes
2d26318cf9
[deploy] Replace (black|white)list with more inclusive language (#7459)
* Replace isBlacklisted

* Update fastly.rake task

* More renames

* Rename Faslty config file

* More changes

* Replace isForbiddenFromPreloading with isNotPreloadable

* Skip problematic test

* Re-enable
2020-04-27 18:00:12 +02:00
Molly Struve
b4644783ef
setup Elasticsearch before we setup the database for new dev environments (#7534) 2020-04-27 10:42:35 -05:00
Andy Zhao
ae4ba673c4
[deploy] Show reactable username for reactable_type == User (#7527)
* Show reactable username for reactable_type == User

* Add test for GET /internal/reports vomit reaction on user
2020-04-27 11:27:45 -04:00
Molly Struve
527c98fa01
[deploy] remove no longer used index! and check for main_image method in view (#7526) 2020-04-27 10:16:49 -05:00
rhymes
1c3b619583
[deploy] Fix settings billing section and other profile improvements (#7525)
* Truncate displayed username length to max length

* Better error notice

* Fix broken billing Stripe functionality

* Display server side credits purchasing errors

* Be explicit in the name of the partial

* Full name
2020-04-27 16:59:03 +02:00
rhymes
d87c3dbb18
[deploy] Improve comment posting error handling (#7519)
* Improve comment posting error handling

* Incorporate PR suggestions
2020-04-27 16:54:59 +02:00
Tam Chau
ffba42cf43
Add expires_in option for ActiveSupport::Cache::RedisStore#increment method (#7515)
* rails patch to fix expires_in for increment method

* fixup! rails patch to fix expires_in for increment method

correct test case

* fix redundant file name & class name

* add comment to explain monkey patch for RedisCacheStore#increment
2020-04-27 16:40:49 +02:00
Ridhwana
b9a8d87e95
[deploy] Refactor to create a helper for the mailer links (#7502)
* refactor: set the email_from to use in teh defaults

* chore: remove some new lines

* feat: add a mail link helper that can be used in the views

* feat: returns the default if it doesn't understand the parameter

* feat: Quick replacement of links

* feat: allow subject to be passed through

* chore: update all hrefs

* chore: remove rel attribute

* chore: mail link

* update spec

* chore: space

* chore: update some whitespaces and emails

* style

* chore: PR mail_link to email_link and the comment

* feat: PR suggestions for encoding

* feat: use mail_to
2020-04-27 09:18:16 -04:00
rhymes
9d1ad76a21
Fix reading list pagination (#7518) 2020-04-27 09:17:50 -04:00
Ben Halpern
3d985319dd
[deploy] Fix notice in accepting invites (#7522) 2020-04-26 21:40:51 -04:00
Ben Halpern
921b2e73b6
Line up params properly in Bufferizer (#7521) 2020-04-26 20:51:57 -04:00
Ben Halpern
9070174138
[deploy] Fix chatchannel pagination in connect (#7520) 2020-04-26 19:45:36 -04:00
Ben Halpern
d447d0cadf
[deploy] Update design and functionality of internal/articles (#7517)
* Update design and functionality of internal/articles

* Fix spec

* Update specs

* Fiddle with test

* Fix request spec
2020-04-26 18:27:09 -04:00
rhymes
6c3bd047a3
Create listings categories before listings in seed (#7512) 2020-04-26 19:35:13 +02:00
Ben Halpern
7a6e7301a1
[deploy] Small update to /connect design (#7510)
* Initial work

* Full screen mode adjustments

* Update snapshots
2020-04-26 13:26:49 -04:00
Sujith
28d24854c6
Modal not closing while choosing tag filter (#7497)
* modal not closing while choosing tag filter

Modal did not close upon choosing the filter tag.

* improved if condition  referring codeclimate

refactored if condition by declaring a static array list for checking target id exist in the array list

* removed unwanted function

Removing a function added by me
2020-04-26 12:55:34 +02:00
Lucas Hiago
d989b9d842
Add style for images on email to turn them responsiveness (#7247)
* Change property for max-width to turn more responsive

* Change css property for images to turn more responsive in mention email
2020-04-26 12:33:16 +02:00
Thai Pangsakulyanont
5d97ca86c5
Improve docker setup script (#7378)
* Add set -e to docker-setup script

* Add error handling for db setup stage

* Sometimes Elasticsearch takes time to boot up

* Also delete docker_data

* search:setup must come first

* Revert "Sometimes Elasticsearch takes time to boot up"

This reverts commit e975f6e5c3edad084d4f2c4d8718675bf5c8d07c.

Reason for revert:
Instead of using wait-on, we can use Docker’s health check instead

See review comment:
https://github.com/thepracticaldev/dev.to/pull/7378#discussion_r411839255

* Use wait-on without installing into package.json

* Add /usr/src/app/node_modules to volumes

Otherwise, webpacker will not run in docker-compose.

See: https://stackoverflow.com/questions/30043872/docker-compose-node-modules-not-present-in-a-volume-after-npm-install-succeeds
2020-04-24 18:45:27 -04:00
Molly Struve
a7e664fc9c
[deploy] Remove Algolia from User Model (#7454)
* Remove Algolia from User Model

* check banned on self for user

* fine have your redundant method

* remove a couple more unnecessary specs
2020-04-24 18:39:36 -04:00
Molly Struve
94f3a4b6fd
[deploy] Remove Algolia from Podcast Episodes (#7489) 2020-04-24 18:36:13 -04:00
Guilherme Vinicius Moreira
31c0b388e5
Refactor internal users index (#7457)
* Refactor internal users index

* Add table-hover to users table

* Add users query spec
2020-04-24 17:27:07 -04:00
rhymes
f5a6ff32cc
Finalize Slack messengers refactoring (#7484)
* Remove dead code

* Rename SlackBotPingWorker to Slack::Messengers::Worker

* Remove useless Slack mock

* Fix specs
2020-04-24 21:15:10 +02:00
Fernando Valverde
baac7997c3
[deploy] Send push to Android phones and use Pusher broadcasting (#6883) 2020-04-24 13:50:59 -04:00
Mac Siri
aa96a076d8
[deploy] Fix broken listing spec (#7504) 2020-04-24 13:12:50 -04:00
dependabot-preview[bot]
2bad54ec47
Bump prettier from 2.0.4 to 2.0.5 (#7465) 2020-04-24 11:36:48 -04:00
dependabot-preview[bot]
4c2903318f
Bump strong_migrations from 0.6.3 to 0.6.4 (#7476) 2020-04-24 11:36:13 -04:00
rhymes
0186fd9aee
Add Retry-After for API rate limit errors and document limits in API spec (#7444)
* Add correct rate limit exception to Articles::Updater

* Send Retry-After with HTTP 429 back to the client

* Update API specs for error 429

* Test build

* Fix spec

* Add retry after to ImageUploadsController and fix specs

* Generalize a bit
2020-04-24 17:35:28 +02:00
rhymes
1e5d831a3e
Remove unused markedjs (#7500) 2020-04-24 16:38:14 +02:00
Michael Kohl
f791e84f2d
Filter classified listings by published status for mods (#7432)
* Filter classified listings by published status for mods

* Change checkbox label, invert logic, respect checked status
2020-04-24 10:31:29 -04:00
Molly Struve
4ab202ab0a
[deploy] Execute Reading List searches in Elasticsearch (#7440)
* Execute Reading List searches in Elasticsearch

* add additional readinglist front tests
2020-04-24 10:30:17 -04:00
Mac Siri
57ae315c31
[deploy] Generalize Onboarding's task-card image (#7452)
* Generalize Onboarding's task-card image

* Rename SiteConfig's onboarding_taskcard_sticker

* Add & reorganize #config_params

* Update Internal::Config's view

* Add spec
2020-04-24 10:24:50 -04:00
Michael Kohl
02d23a0673
Refactor jbuilder (#7411)
* Refactor jbuilder for articles

* Refactor remaining jbuilder files

* Fix specs

* Remove content_truncated from response template JSON

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-04-24 12:49:12 +02:00
Vaidehi Joshi
e19eb60d1f
Add skip/continue functionality to onboarding navigation (#7488) [deploy]
* Dynamically render forward text in Navigation component

* Render either "Skip for now" or "Continue" on the FollowTags, ProfileForm, and FollowUsers components.
* Refactor the ProfileForm component to dynamically change the button text based on the form's state.

* Render specific button text for last onboarding slide

* Fix back arrow styles for accessibility

Also set an explicit width on the containing button around the svg.

* Use min-width to specify back-button size
2020-04-23 16:30:48 -07:00
Julianna Tetreault
2a74f6f811
Refactor SEO Optimized Images (#7494)
* Add seo_optimized_images method to article_json_ld
  * Add inline documentation for images in method
  * Add to stories_controller.rb with other JSON-LD

* Fix inconsistencies in stories_show_spec.rb tests
2020-04-23 19:26:29 -04:00
rhymes
db9186043e
Removed yarn integrity check (#7478) 2020-04-23 19:23:12 -04:00
Alex
8b51d8e4b8
[deploy] Fix Fastly rake task spec and Travis CI (#7487)
* Try changing exit to next

* Add breaking test

* Fix search.rake

* Remove test failure
2020-04-23 16:06:57 -04:00
Alex
b6664456c0
[deploy] Validate filenames server-side (#7405) 2020-04-23 14:30:59 -05:00
dependabot-preview[bot]
5c6d811fa8
Bump ruby-prof from 1.3.1 to 1.3.2 (#7474)
Bumps [ruby-prof](https://github.com/ruby-prof/ruby-prof) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/ruby-prof/ruby-prof/releases)
- [Changelog](https://github.com/ruby-prof/ruby-prof/blob/master/CHANGES)
- [Commits](https://github.com/ruby-prof/ruby-prof/compare/1.3.1...1.3.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-23 14:28:02 -05:00
dependabot-preview[bot]
04e8e8478c
Bump aws-sdk-lambda from 1.38.0 to 1.39.0 (#7473)
Bumps [aws-sdk-lambda](https://github.com/aws/aws-sdk-ruby) from 1.38.0 to 1.39.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-lambda/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/compare/v1.38.0...v1.39.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-23 14:27:09 -05:00
dependabot-preview[bot]
905e4849b4
Bump eslint-config-prettier from 6.10.1 to 6.11.0 (#7462)
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 6.10.1 to 6.11.0.
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-config-prettier/compare/v6.10.1...v6.11.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-23 15:19:52 -04:00
Alex
cc408d50e0
Fix Travis CI (#7486) 2020-04-23 13:23:34 -05:00