maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor SEO Optimized Images (#7494)

Browse source 
* Add seo_optimized_images method to article_json_ld
  * Add inline documentation for images in method
  * Add to stories_controller.rb with other JSON-LD

* Fix inconsistencies in stories_show_spec.rb tests
This commit is contained in:
Julianna Tetreault 2020-04-23 17:26:29 -06:00 • committed by GitHub
parent db9186043e
commit 2a74f6f811
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
app/controllers/stories_controller.rb
View file

@ -371,11 +371,7 @@ class StoriesController < ApplicationController
"@id": URL.article(@article)
},
"url": URL.article(@article),
"image": [
ApplicationController.helpers.article_social_image_url(@article, width: 1080, height: 1080),
ApplicationController.helpers.article_social_image_url(@article, width: 1280, height: 720),
ApplicationController.helpers.article_social_image_url(@article, width: 1600, height: 900),
],
"image": seo_optimized_images,
"publisher": {
"@context": "http://schema.org",
"@type": "Organization",
@ -400,6 +396,15 @@ class StoriesController < ApplicationController
}
end
def seo_optimized_images
# This array of images exists for SEO optimization purposes.
# For more info on this structure, please refer to this documentation:
# https://developers.google.com/search/docs/data-types/article
[ApplicationController.helpers.article_social_image_url(@article, width: 1080, height: 1080),
ApplicationController.helpers.article_social_image_url(@article, width: 1280, height: 720),
ApplicationController.helpers.article_social_image_url(@article, width: 1600, height: 900)]
end
def set_organization_json_ld
@organization_json_ld = {
"@context": "http://schema.org",

14
spec/requests/stories_show_spec.rb
View file

@ -33,7 +33,7 @@ RSpec.describe "StoriesShow", type: :request do
expect(response.body).to include html_variant.html
end
it "Does not render variant when no variants published" do
it "does not render variant when no variants published" do
html_variant = create(:html_variant, published: false, approved: true)
get article.path + "?variant_version=1"
expect(response.body).not_to include html_variant.html
@ -54,14 +54,14 @@ RSpec.describe "StoriesShow", type: :request do
expect(response.body).to include html_variant.html
end
it "Does not render below article html variant for short article" do
it "does not render below article html variant for short article" do
html_variant = create(:html_variant, published: true, approved: true, group: "article_show_below_article_cta")
article.update_column(:body_markdown, rand(36**100).to_s(36).to_s) # ensure too short
get article.path + "?variant_version=0"
expect(response.body).not_to include html_variant.html
end
it "Does not render below article variant when no variants published" do
it "does not render below article variant when no variants published" do
html_variant = create(:html_variant, published: false, approved: true, group: "article_show_below_article_cta")
get article.path + "?variant_version=0"
expect(response.body).not_to include html_variant.html
@ -85,14 +85,14 @@ RSpec.describe "StoriesShow", type: :request do
expect(response.body).to include "title"
end
it "redirect to appropriate page if user changes username" do
it "redirects to appropriate page if user changes username" do
old_username = user.username
user.update(username: "new_hotness_#{rand(10_000)}")
get "/#{old_username}/#{article.slug}"
expect(response.body).to redirect_to("/#{user.username}/#{article.slug}")
end
it "redirect to appropriate page if user changes username twice" do
it "redirects to appropriate page if user changes username twice" do
old_username = user.username
user.update(username: "new_hotness_#{rand(10_000)}")
user.update(username: "new_new_username_#{rand(10_000)}")
@ -100,7 +100,7 @@ RSpec.describe "StoriesShow", type: :request do
expect(response.body).to redirect_to("/#{user.username}/#{article.slug}")
end
it "redirect to appropriate page if user changes username twice and go to middle username" do
it "redirects to appropriate page if user changes username twice and go to middle username" do
user.update(username: "new_hotness_#{rand(10_000)}")
middle_username = user.username
user.update(username: "new_new_username_#{rand(10_000)}")
@ -114,7 +114,7 @@ RSpec.describe "StoriesShow", type: :request do
expect(response.body).to include('"canonical" href="' + article.canonical_url.to_s + '"')
end
it "shodoes not render canonical url when not on article model" do
it "does not render canonical url when not on article model" do
article = create(:article, with_canonical_url: false)
get article.path
expect(response.body).not_to include('"canonical" href="' + article.canonical_url.to_s + '"')