Commit graph

3199 commits

Author SHA1 Message Date
Dhananjay
81b171efa8 Fix Lints in initializeBaseUserData (#4612) [ci skip] 2019-10-31 14:44:34 -04:00
Molly Struve
cbc85100e3 Create RedisRailsCache Object to Mimic Rails.cache And Apply (#4667)
* Create RedisRailsCache object to mimic Rails.cache

* Do not use prefix _ for a variable that is used

* dont shadow outer local variable
2019-10-31 12:12:21 -04:00
Nadiya Karachevska
24a02fd695 Change SimpleCov to be on by default (#4666) [ci skip] 2019-10-31 11:18:32 -04:00
Huynh Tan
b6a731276e Fix answers from other stackexchange sites have the wrong link (#4615) [ci skip] 2019-10-30 15:01:29 -04:00
garethx
fba9446e17 Update _codesandbox.html.erb (#4575) [ci skip]
* Update _codesandbox.html.erb

Adding 'allow-popups' to enable 'open sandbox' and link buttons to work, so folks can open the sandbox in a new tab.

* Update app/views/liquids/_codesandbox.html.erb

Co-Authored-By: Michaël De Boey <info@michaeldeboey.be>
2019-10-30 14:44:59 -04:00
Ahmad Mahmoud
d3dfc70f5a Fix lint errors in pulltorefresh.js (#4594) [ci skip] 2019-10-30 14:21:09 -04:00
Jenna Pederson
77270290da Use named function so duplicate event handlers are discarded (#4655) [ci skip] 2019-10-30 13:26:14 -04:00
rhymes
75f1d142fe Add focus styling to SAVE button (#4664) [ci skip] 2019-10-30 13:14:45 -04:00
Brad Pauly
b59aba415d ArticlesController#feed refactor (#4498)
* Move query details into model.
Reorganize filtering initial results by params.

* Fixups from feedback.
2019-10-30 12:35:53 -04:00
WenYu
b162e8b848 Refactor app/services/notifications/new_comment#send (#4642) 2019-10-30 12:21:56 -04:00
dependabot-preview[bot]
574aecf0e5 Bump factory_bot_rails from 4.11.1 to 5.1.1 (#4631)
Bumps [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails) from 4.11.1 to 5.1.1.
- [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases)
- [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/master/NEWS.md)
- [Commits](https://github.com/thoughtbot/factory_bot_rails/compare/v4.11.1...v5.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-30 12:08:09 -04:00
Molly Struve
dc72b4f1fa Add Honeycomb beeline gem for monitoring and observability (#4649) 2019-10-30 12:02:31 -04:00
Omar Bahareth
41463a7264 Deduplicate giphy_img? function and add tests (#4590)
* De-duplicate giphy_img? function in favor of a tested service.
Add a tested `GiphyService` and move `giphy_img?` function to it.
Make `labor/markdown_parser.rb` and `models/html_variant.rb` use the service version of the function.

* Refactor GiphyService into Giphy::Image class
Based on comments from @rhymes, I've changed this into a `Giphy::Image` class sincethe repo is currently being moved away from `XYZService` objects for namespacing and organization purposes.

* Fix typo

Update describe case to mention the current method name.
2019-10-30 11:40:17 -04:00
Cameron Yick
a4750005cb [offline] Add Paul Tol Color Palette #3448 (#4186) 2019-10-30 11:29:33 -04:00
rhymes
36d1df7f49 Routine rubocop lint fixes (#4638) [ci skip] 2019-10-30 10:46:57 -04:00
Molly Struve
fd3d87c759 Select path when loading buffered article urls (#4651) [ci skip] 2019-10-30 10:37:22 -04:00
Molly Struve
095df7df27 Increase STATEMENT_TIMEOUT when running migrations (#4648) [ci skip] 2019-10-30 10:34:51 -04:00
Molly Struve
69e35dc1b3 Add Redis gem and Create RedisClient (#4582)
* Add redis gem and client

* use keyword arguments in redis initializer

* check for REDISCLOUD_URL and fallback on REDIS_URL when connecting to redis

* dont parse Redis url in initializer
2019-10-30 10:32:59 -04:00
Andy Stabler
198efec024 Refactor collection spec (#4597) [ci skip] 2019-10-30 10:32:41 -04:00
Julianna Tetreault
e9eb085ee7 Update CONTRIBUTING.md (#4654) [ci skip] 2019-10-30 10:25:02 -04:00
dependabot-preview[bot]
e5d14492e1 Bump aws-sdk-lambda from 1.30.0 to 1.31.0 (#4635)
Bumps [aws-sdk-lambda](https://github.com/aws/aws-sdk-ruby) from 1.30.0 to 1.31.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-lambda/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/compare/1.30.0...1.31.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-30 09:50:43 -04:00
Ben Halpern
ec6d66018f
Add some html to internal articles and new internal view (#4636)
* Add some html to internal articles and new internal view

* Add check for article existence for buffer updates

* Change arrays to unions
2019-10-28 19:09:24 -04:00
Molly Struve
bb55efb775 Add index to feed source url column on articles (#4595) 2019-10-28 16:32:19 -04:00
Molly Struve
da45790e2e Add guard clause to migration to check for index before attempting to add or remove it (#4644) 2019-10-28 15:27:31 -04:00
dependabot-preview[bot]
b1899b7e2e Bump chart.js from 2.8.0 to 2.9.1 (#4627) [ci skip]
Bumps [chart.js](https://github.com/chartjs/Chart.js) from 2.8.0 to 2.9.1.
- [Release notes](https://github.com/chartjs/Chart.js/releases)
- [Commits](https://github.com/chartjs/Chart.js/compare/v2.8.0...v2.9.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-28 14:14:11 -04:00
dependabot-preview[bot]
9dc2d89da2 Bump gibbon from 3.2.0 to 3.3.0 (#4628) [ci skip]
Bumps [gibbon](https://github.com/amro/gibbon) from 3.2.0 to 3.3.0.
- [Release notes](https://github.com/amro/gibbon/releases)
- [Changelog](https://github.com/amro/gibbon/blob/master/CHANGELOG.md)
- [Commits](https://github.com/amro/gibbon/compare/v3.2.0...v3.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-28 14:13:15 -04:00
Mac Siri
e3b8bc3d2b Remove deploy condition 2019-10-28 10:47:22 -04:00
Ryan Palo
4156f1f9de [deploy] Extract DEV specifics to Env variables (#4561)
* [WIP] Extract DEV specifics to Env variables

* [WIP] Fix sendgrid url that I accidentally changed.  Womp.

* Remove extra colon from 'variable' calls

* Trim :// off of app protocol

* Update Envfile TIMBER_LOGS default comment for accuracy

* Add API doc links for each service
2019-10-28 10:29:57 -04:00
Mac Siri
13a5963181
Update .travis.yml and .codeclimate.yml (#4639) [deploy] 2019-10-28 10:24:37 -04:00
Mehdi Vasigh
42771beb5d add heading and clear all btn to tag filters (#4620) 2019-10-28 09:39:47 -04:00
WenYu
e3e4a29ac8 Add ImageMagick as one of the dependencies to be installed inside Docker (#4618) 2019-10-28 09:38:18 -04:00
dependabot-preview[bot]
f327d95dcd Bump dry-struct from 1.0.0 to 1.1.1 (#4630)
Bumps [dry-struct](https://github.com/dry-rb/dry-struct) from 1.0.0 to 1.1.1.
- [Release notes](https://github.com/dry-rb/dry-struct/releases)
- [Changelog](https://github.com/dry-rb/dry-struct/blob/master/CHANGELOG.md)
- [Commits](https://github.com/dry-rb/dry-struct/compare/v1.0.0...v1.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-28 09:36:12 -04:00
dependabot-preview[bot]
8ec55e4f73 Bump rack-timeout from 0.5.1 to 0.5.2 (#4629)
Bumps [rack-timeout](https://github.com/sharpstone/rack-timeout) from 0.5.1 to 0.5.2.
- [Release notes](https://github.com/sharpstone/rack-timeout/releases)
- [Changelog](https://github.com/sharpstone/rack-timeout/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sharpstone/rack-timeout/compare/v0.5.1...v0.5.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-28 09:34:55 -04:00
dependabot-preview[bot]
201956d7fb Bump rouge from 3.11.0 to 3.12.0 (#4633)
Bumps [rouge](https://github.com/rouge-ruby/rouge) from 3.11.0 to 3.12.0.
- [Release notes](https://github.com/rouge-ruby/rouge/releases)
- [Changelog](https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rouge-ruby/rouge/compare/v3.11.0...v3.12.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-28 09:33:48 -04:00
dependabot-preview[bot]
a4481db118 Bump eslint-config-prettier from 6.4.0 to 6.5.0 (#4624)
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 6.4.0 to 6.5.0.
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-config-prettier/compare/v6.4.0...v6.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-28 08:39:13 -04:00
WenYu
6665c2cdc1 Remove ChartDecorator (#4622)
Removing it as it is no longer used in the codebase. There is no specs
related to ChartDecorator
2019-10-28 08:26:12 -04:00
dependabot-preview[bot]
dea5e62dbd Bump rubocop from 0.75.0 to 0.75.1 (#4632)
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.75.0 to 0.75.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.75.0...v0.75.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-28 08:21:44 -04:00
Nick Taylor
22991239bf Ran all markdown files through prettier to fix a handful. (#4599) 2019-10-28 08:20:53 -04:00
dependabot-preview[bot]
a8e0b3e31c Bump scout_apm from 2.6.1 to 2.6.2 (#4634)
Bumps [scout_apm](https://github.com/scoutapp/scout_apm_ruby) from 2.6.1 to 2.6.2.
- [Release notes](https://github.com/scoutapp/scout_apm_ruby/releases)
- [Changelog](https://github.com/scoutapp/scout_apm_ruby/blob/master/CHANGELOG.markdown)
- [Commits](https://github.com/scoutapp/scout_apm_ruby/compare/v2.6.1...v2.6.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-28 08:19:39 -04:00
Yash Dave
3fde5b810f [deploy] Fix Image Overflow in Comment Preview - #4382 (#4466)
* Update CSS for img in .comment-preview-div

- Enforces `max-width:100%` on images in .comment-preview-div to prevent them from overflowing their container.

* Implement Recommended Changes

- Enforces `max-width:100%` on images in .comment-preview-div to prevent them from overflowing their container.
2019-10-26 13:34:16 -04:00
James Vanderburg
2d373c2de3 README updates for clarification (#4584)
* Update README to clarify Algolia setup

Added a little bit to the line about Algolia environment variable setup
to clarify things for users like me who don't read ahead a little bit
and forgot how env variables work :)

* Add ImageMagick to prerequisites section
2019-10-26 13:28:54 -04:00
Ron Tal
e226a8e70d removed irrelevant word from docs (#4601) 2019-10-26 12:15:13 -04:00
Ben Halpern
c0640ecbc6
Revert search placeholder text to just 'Search' (#4607) 2019-10-26 12:14:32 -04:00
Aleksandr
1808fb5b2b Pro - Stats view - Buttons are not dark-mode friendly (#4596) 2019-10-26 11:01:13 -04:00
Molly Struve
0b47ff67bc Add index for old_username and old_old_usernames (#4593) 2019-10-25 15:51:28 -04:00
Molly Struve
7943aa0280 Use current_user to avoid looking up the user again via the reaction (#4592) 2019-10-25 13:40:33 -04:00
Mac Siri
b70186af0b Add Condition for deployment (#4578)
* Add conditional deployment

* Update deployment doc
2019-10-25 12:25:44 -04:00
rhymes
d0bc58b133 API docs updates (#4585)
* Add operationId to all operations

* Add top level tags array

* Add users tag and cleanup /me descriptions

* Add beta to the title

* Update Article Index and Show examples after #4560

* Bump version

* Remove rendundant type object from refs
2019-10-25 10:30:33 -04:00
rhymes
e31128dcb7 Enforce ruby19_no_mixed_keys Style/HashSyntax (#4588) 2019-10-25 10:27:55 -04:00
aRtoo
05cfe16e1c Fix comment author being notified when mentioning itself (#4456)
* added a condition to check if owner of the comment is in mentions

* added a test to check if comment owner can mention self

* fixed metion test by:
  - adding a second user to simulate a owner of a comment
  - change the user on comment to owned by newly created user
2019-10-25 10:23:45 -04:00