maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use named function so duplicate event handlers are discarded (#4655) [ci skip]

Browse source
This commit is contained in:
Jenna Pederson 2019-10-30 12:26:14 -05:00 • committed by Mac Siri
parent 75f1d142fe
commit 77270290da
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/assets/javascripts/initializers/initializeTouchDevice.js
View file

@ -25,6 +25,10 @@ function removeShowingMenu() {
}, 150);
}
function toggleMenu() {
getClassList('navbar-menu-wrapper').toggle('showing');
}
function initializeTouchDevice() {
var isTouchDevice = /Android|webOS|iPhone|iPad|iPod|BlackBerry|IEMobile|Opera Mini|DEV-Native-ios/i.test(
navigator.userAgent,
@ -37,9 +41,8 @@ function initializeTouchDevice() {
setTimeout(() => {
removeShowingMenu();
if (isTouchDevice) {
getById('navigation-butt').addEventListener('click', e =>
getClassList('navbar-menu-wrapper').toggle('showing'),
);
// Use a named function instead of anonymous so duplicate event handlers are discarded
getById('navigation-butt').addEventListener('click', toggleMenu);
} else {
getClassList('navbar-menu-wrapper').add('desktop');
getById('navigation-butt').addEventListener('focus', e =>