Commit graph

3226 commits

Author SHA1 Message Date
Ridhwana
7bcacfa3a6
Update feedback messages to be general (#7373)
* feat: update feedback messages to be general

* spec: update the feedback test
2020-04-20 10:22:31 +02:00
ludwiczakpawel
d585c981db
[deploy] fixing svg (#7380) 2020-04-19 15:42:30 +02:00
Ben Halpern
2171fe3255
[deploy] Add missing parentheses to video html (#7379) 2020-04-18 16:34:48 -04:00
Ben Halpern
3d4944ebae
[deploy] Add video duration to search results (#7377) 2020-04-18 15:16:38 -04:00
Ben Halpern
803791e5b6
[deploy] Fix sort_by expectations with pagination (#7372)
* Fix sort_by expectations with pagination

* Add sort_direction to view

* Include sort_by in allowed json
2020-04-18 13:57:15 -04:00
Ben Halpern
a0504f5f77
[deploy] Include organization in feed_content results (#7374) 2020-04-18 13:07:59 -04:00
Ben Halpern
e0b932e569
[deploy] Fix response template non-logged-in navigation issue (#7370) 2020-04-17 17:53:28 -04:00
Ridhwana
6dbc838bae
[deploy] Update our mailers to be generalized (#7359)
* feat: make the from in the email to be dynamic

* feat: hardcoded mailer dev.to

* feat: oops hardcoded email addresses in the terms

* chore: remove some whitespace

* update editor guide

* feat: new reply email

* feat: new message mailer

* feat: new follower email

* feat: capitalize the button

* feat: rename the link

* feat: capitalize the button

* feat: generalize the urls

* feat: generalise the url

* feat: dynamic DEV

* feat: update the specs

* feat: DEV digest generalisation part 1

* fix: the method is accessed by tag_url and so the default parameter needs to be set at this level and not at self.tag

* fix: use the tag model instance instead of passing through just the tag name (so that we can use tag_url)

* chore: make code climate happy

* chore: more robocop

* feat: add a default url back for self.tag

* test: fix the feedback helper spec

* fix: spec to be general

* fix: oops :(

* refactor: user_settings_path

* chore: use code_of_conduct_path

* chore: robocop

* chore: use connect path

* chore; use the notifications symbol

* chore: misc path

* feat: simplify url

* feat/fix: change the order of the helpers and use user_url

* chore: user_url

* capitalise

* chore: update article path
2020-04-17 15:35:35 -04:00
Fernando Valverde
f2ee0378f9
[deploy] Decorator podcast episode metadata (#7303)
* Moves podcast episode metadata to decorator

* Updates the podcast episode metadata to use image_url

* Syntax tweaks, initializeMedia() fix for initialized audio & brought back use strict
2020-04-17 12:52:11 -06:00
Molly Struve
61b6f8ea3e
[deploy] record identity creation metrics (#7366) 2020-04-17 13:15:03 -05:00
Molly Struve
3832e9356d
rescue Addressable::URI::InvalidURIError and mark podcast ep unreachable (#7343) 2020-04-17 13:11:08 -05:00
rhymes
1b93666b3b
[deploy] Add user_id presence validation for Identity (#7365)
* Add user_id presence validation for Identity

* Remove duplicated validation

* Save user within build_user

* Fix typo

* Fix spec with in memory user
2020-04-17 20:02:26 +02:00
Molly Struve
8340051649
[deploy] properly parse params for feed content searching (#7367) 2020-04-17 12:23:24 -05:00
rhymes
f8a81956e2
Disable service worker on remaining hardcoded redirects (#7360)
* Disable service worker on shop redirect

* Add missing redirects exceptions
2020-04-17 18:53:44 +02:00
Nick Taylor
f0c4d56117
Added a theme switcher to Storybook. (#7364)
* Added the theme switcher to storybook.

* Renamed method to align it more with what it actually does.

* Renamed method to align it more with what it actually does.

* Changed order of themes in select to match order in UX settings.
2020-04-17 10:39:05 -04:00
rhymes
a2893056b6
Routine rubocop fixes (#7356)
* rubocop -a

* Fix stuff

* rubocop -a again

* autocorrect
2020-04-17 15:48:39 +02:00
Molly Struve
2c99424205
[deploy] Execute Feed Searches through Elasticsearch (Round 2) (#7231) 2020-04-17 08:38:07 -05:00
Molly Struve
2d40174a92
implement backend search functionality for readinglist Reactions (#7308) 2020-04-17 08:37:22 -05:00
rhymes
ccea13bc21
Hide the Shop in homepage if not present (#7358) 2020-04-17 13:28:27 +02:00
Molly Struve
7be90d1b4b
[deploy] overwrite name field for honeycomb when sending Elasticsearch requests (#7338) 2020-04-17 12:30:29 +02:00
Ben Halpern
2808a27c75
[deploy] Change window.currentUser to userData() (#7353) 2020-04-16 23:24:51 -04:00
Ben Halpern
13537fb8d4
[deploy] Fix connect edge cases (#7352) 2020-04-16 21:57:09 -04:00
Ben Halpern
2d978696c4
[deploy] Small connect js fixes (#7350) 2020-04-16 20:06:32 -04:00
Ben Halpern
697c0df5b1
[deploy] Manually create channel and add users for org channels (#7346) 2020-04-16 19:13:39 -04:00
Ben Halpern
03c28a5671
[deploy] Create private group chat channel for orgs (#7270)
* WIP chat channel for orgs

* Finalize

* Enable upsert functionality for role switch

* Private group chat

* Rearrange permissions code

* fix typo
2020-04-16 17:02:06 -04:00
Andy Zhao
f5ec83653c
[deploy] Finalize and add response templates feature (#7068) 2020-04-16 15:53:29 -04:00
Alex
cc6249beff
[deploy] Update whitelisted params on Fastly on deployments (#7279)
* Add Fastly whitelisted params

* Create FastlyVCL::WhitelistedParams.update service

* Add specs

* Create rake task to call new service

* Add rake task to setup script

* Add documentatoin

* Move sort inside params_to_array method

* Rename VCL_REGEX to VCL_DELIMITER

* Add PR URL to docs

* Move snippet name to SNIPPET_NAME constant

* Refactor setting content

* Rename params_to_array to params_to_sorted_array

* Change guard and log success on update

- Return early if params are equal
- Log success message to Rails.logger on update
- Log params diff to Datadog

* Return true explicitly

* Move rake task execution from to release-tasks

* Remove unnecessary environment guard in task

* Remove duplicate code param

* Refactor string from build_content

* Remove reliance on sort

* Reorder logging to implicitly return true

* Update docs to reference release-script.sh

* Update docs

* Update whitelisted params

* Fix params_updated? bug and add more specs

* Remove duplicate param...oopsie!
2020-04-16 15:11:57 -04:00
rhymes
0a6be8b967
[deploy] Improve some validations (#7335)
* Validations

* Fix specs

* Revert twitter tag change
2020-04-16 18:59:12 +02:00
Molly Struve
1024e47738
exempt new search endpoints from the service worker (#7334) 2020-04-16 09:35:45 -05:00
ludwiczakpawel
fe334d1de8
Snackbars Stacking (#7318)
* stacking snackbars

* stacking snackbars

* pre fix
2020-04-16 09:28:46 -04:00
rhymes
b830cdc5b8
Remove harcoded shop strings (#7319) 2020-04-16 14:51:23 +02:00
Ben Halpern
db4c9ef4b2
[deploy] Add user_signed_in to profile header cache key (#7315) 2020-04-15 20:08:25 -04:00
Ben Halpern
645920c09f
[deploy] Remove milestone sends (#7313) 2020-04-15 19:34:10 -04:00
Ben Halpern
3a22087383
[deploy] Adjust styling and rendering of campaign widget (#7311) 2020-04-15 18:36:29 -04:00
Vaidehi Joshi
bbe0bf970f
Split up content of EmailListTermsConditionsForm within onboarding (#7294) [deploy]
* Move Terms & Conditions, CoC into Intro slide of onboarding

Closes https://github.com/thepracticaldev/dev.to/issues/6545.

* Rename ClosingSlide in Onboarding tests

* Rename EmailListTermsConditionsForm to EmailPreferencesForm

* Proper lint and prepend `v2:` to some onboarding components

* Move email preferences to last slide

Closes https://github.com/thepracticaldev/dev.to/issues/6550.

* Use crayons variables for padding

* Remove backToSlide function, rename buttonIsDisabled function
2020-04-15 15:16:53 -07:00
Ben Halpern
d27471aac5
[deploy] Small ld+json fix (#7309) 2020-04-15 16:50:27 -04:00
Jitendra Rajpurohit
7656d10e2b
Generalized shop url by creating SiteConfig field for it (#7262)
* added shop_url to SiteConfig

* fixed issue in show config erb file

* add spec for shop_url SideConfig

* added spec

* handles blank shop_url case

* code review changes
2020-04-15 16:28:34 -04:00
Molly Struve
467e0a1b5e
[deploy] display link liquid tgs for articles that may have been deleted (#7305) 2020-04-15 16:28:01 -04:00
Molly Struve
223703f0d3
[deploy] Update URLSearchParams to handle arrays correctly for Rails (#7300) 2020-04-15 14:58:18 -05:00
Ben Halpern
2c6a4b4ecf
[deploy] Make adjustments in ld+json logic (#7307)
* Make adjustments in ld+json logic

* Add github url
2020-04-15 15:50:48 -04:00
Molly Struve
817f12c788
no need to use search_id for indexing worker (#7304) 2020-04-15 15:35:12 -04:00
Arit Amana
1d1a8456a5
Use StimulusJS for vomit confirmations in Internal (#7255)
This PR implements the async vomit-reaction functionality using StimulusJS. Prior to this, the JS lived in `_abuse-reports.html.erb`.

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-04-15 15:26:10 -04:00
Julianna Tetreault
fd9fdebc0b
[deploy] Migrate from Schema.org to JSON-LD (#6956)
* Add JSON-LD in place of schema.org in _video_player.html.erb

* Remove unnecessary tags around JSON-LD to clean up templates

* Fix indenatation and remove extra elements from show.html.erb and _profile_header.html.erb

* Remove empty line from articles/show.html.erb

* Clean up JSON-LD commas across erb templates

* Revert articleBody changes, adjust nesting, and remove extra quote

* Add application/ld+json to allowed_types in .erb-lint.yml

This addition makes it so that the no verify flag is no longer required

* Add additional data for Articles, Users, and Orgs to better SEO

* Add additional data to JSON-LD structures
*Add sameAs data to articles/show.html.erb
*Add sameAs data to users/show.html.erb
*Make adjustments to VideoObject data in _video_player
*Make adjustments to Org in _profile_header
*Add removed erb back to all erb templates

* Refactor code to fix syntax Google syntax errors
* Add missing double quotes to values
* Remove unnecessary meta tags from _video_player.html.erb
* Add additional key-value pairs to data structures
* General code clean up

* Clean up existing data structures
  *Remove useless meta tag and replace with a tag
  *Small refactor to users/show.html.erb data

* Extract user json-ld out of users/show.html.erb
  *Move json-ld logic to stories_controller
  *Use user_json_ld variable in place of entire data structure
  *Set user_json_ld as a before_action in the controller

* Add specs around JSON-LD data in templates
  *Add request spec for users/show.html.erb
  *Add request spec for articles/show.html.erb
  *Add request spec for _video_player.html.erb
  *Add request spec for _profile_header.html.erb
  *WIP: Fix pending specs for all templates

* Remove useless meta tags from users/show and _profile_header.html.erb

* Add additional test coverage to users/show.html.erb
  *Add additional tests to user_show_spec
  *Ensure that all tests pass
  *Small refactor to users/show.html.erb JSON data structure

* Add additional test coverage around JSON-LD data
  *Add more robust tests to template specs
  *Remove unnecessary comments from specs
  *Uncomment pending specs

* Adjust modified date to be more readable in article specs

* Refactor spec to be more readable and update GitHub username test

* Remove meta erb from articles/show.html.erb

* Remove meta data from _video_player.html.erb

* Clean up useless codeand whitespace for final review

* Extract users/show data structure from template into StoriesController
  * Remove JSON-LD object from users/show.html.erb
  * Place JSON-LD for users/show.html.erb in StoriesController
  * Store user_json_ld in set_json_ld method in StoriesController
  * Call user_json_ld variable in script tag in users/show
  * Clean up trailing commas and refactor articles/show.html.erb
  * Remove redundant user/profile_header_spec.rb

* Remove unnecessary code from _profile_header and articles/show
  * Remove Organization from articles/show.html.erb
  * Remove unnecessary comments from _profile_header.html.erb

* Extract user_json_ld into separate methods to fix Code Climate failures

* Rename user_profile_details and user_same_as methods to be more explicit

* Refactored user_json_ld methods to use symbols instead of strings
  * Use symbols to fetch keys from a hash instead of strings
  * Changed user_url in data structure

* Removal of erb tags and general clean up

* Revert schema changes

* Remove unnecessary quotation marks
2020-04-15 15:03:05 -04:00
Ben Halpern
2c28bcb2b2
[deploy] Bypass serviceworkers for /checkin (#7299) 2020-04-15 12:44:36 -04:00
rhymes
f5166e28a8
Nullify audit logs on users delete (#7275)
* Nullify audit logs on users delete

* Fix specs

* Set user as optional and test moderator audit log page

* Fix spec
2020-04-15 18:26:16 +02:00
ludwiczakpawel
db505fb4b3
Add Snackbar component (#7302) 2020-04-15 18:24:17 +02:00
Mac Siri
211ddb9613
[deploy] Add footer toggle to Onboarding's tag follow slide (#7293)
* Apply toggle logic to FollowTag

* Switch terminology and fix pluralization
2020-04-15 18:20:37 +02:00
ludwiczakpawel
d646b5e3f3
New sidebar navigation (#7212)
* new sidebar nav

* whoops

* update on reading list badge

* color

* titles + order

* themes

* remove unused images

* tests & fix

* Fix spec

* Fix specs

* sponsors update

Co-authored-by: rhymes <rhymesete@gmail.com>
2020-04-15 18:16:33 +02:00
rhymes
d6e47a03c7
[deploy] Authentication refactoring - step 1 (#7259)
* Add Authentication providers

* Making strides on refactoring

* New usr from Twitter

* Existing Twitter user

* Existing user Github

* Test skip_confirmation!

* Refactor a bit and add simplecov groups

* Test user already logged in

* Rename to Authentication::Authenticator

* Refactor to a common class

* Add existing user test for twitter login

* Refactor global handler

* Fix spec and comment Twitter provider

* Update comments and strategy TODO

* Move providers loading code to Authentication::Providers

* add SubclassResponsibility error

* Use delegation
2020-04-15 12:13:10 -04:00
Alex
83e92cbfd3
Rescue error and add specs (#7292) 2020-04-15 10:34:00 -04:00