Commit graph

3751 commits

Author SHA1 Message Date
serena
5e761fc570 remove unused welcome notification job (#5535) 2020-01-15 16:57:33 -05:00
Thomas Bnt
0c6e696f2d Changed user-metadata-details to overflow-y: auto (#5532) [deploy] 2020-01-15 16:47:10 -05:00
Michael Kohl
e946e2d7cf Update settings links + descriptions in editor guide (#5473) 2020-01-15 16:37:35 -05:00
Alex
e3d83896f0 Add Alex Smith to core team members [ci skip] (#5534) 2020-01-15 16:35:22 -05:00
Lucas Hiago
c09c65d7bf Fix missing redis server to gitpod configuration (#5528) 2020-01-15 15:12:18 -05:00
Molly Struve
5962d52a61
record background queue stats in a worker (#5533) [deploy] 2020-01-15 14:44:57 -05:00
Lucas Hiago
97aac4ef9b Change Notifications::MilestoneJob to Notifications::MilestoneWorker and move to sidekiq (#5454) [deploy] 2020-01-15 13:21:56 -05:00
rhymes
fd6758fa39 Enable Bullet in development mode (#5527) 2020-01-15 13:21:00 -05:00
Molly Struve
ddb54d0422
Halt Deploys With release script if ENV variable DEPLOY_STATUS is set to blocked (#5510) [deploy] 2020-01-15 12:36:05 -05:00
rhymes
7bfb255627 Remove unnecessary heroku slug commit values in cache keys (#5524) 2020-01-15 12:35:16 -05:00
Lucas Hiago
74f9decc56 Change Notifications::RemoveAllJob to Notifications::RemoveAllWorker and move to sidekiq (#5451) 2020-01-15 12:34:12 -05:00
Molly Struve
2e5a36e538
Log DB Table sizes in a Sidekiq Worker (#5518) 2020-01-15 12:33:14 -05:00
rhymes
4f9321e6f4 Fix spec that broke after we merged #4744 (#5529) [deploy] 2020-01-15 12:01:37 -05:00
Molly Struve
6726c62e94
Scrub unused data sent to Honeycomb to save space (#5512) [deploy] 2020-01-15 11:11:41 -05:00
rhymes
bcd85452e9 Comments API: fix caching issues (#4744) [deploy]
* Use ancestry in the index and add test

* Add tests for show action

* Return complete comments trees for index, kill n+1 and use correct edge cache key

* Return complete comments tree for show, kill n+1 and use correct edge cache key

* Refactor tests and add surrogate keys tests

* Preload users for the whole subtree

* Clarify explanation of the edge cache keys construction

* Refactor partials

* Remove action caching

* Replace .map.flatten with .flat_map

* Fix surrogate key prefix according to Fastly docs

* Add comment.purge to Comments::BustCacheJob to use Fastly-Rails

* Fix surrogate key spec
2020-01-15 10:45:56 -05:00
vladimirschneider
bbaa5902c7 Currect .menubg top position (#5505)
* Currect .menubg top position

Ben changed .top-bar height but do not changed .menubg top position

* Update top-bar.scss
2020-01-15 10:07:02 -05:00
ludwiczakpawel
06bf574e34 adding section for switching to free plan (#5514) 2020-01-15 08:38:58 -05:00
Ben Halpern
e9252bcd10
Fix podcast NaN time issue (#5513) [deploy] 2020-01-14 15:30:11 -05:00
rhymes
ff7532b3db Handle liquid tag errors in comments form (#5485) [deploy]
* Handle liquid tag errors in comments form
* Do not hide Pundit::NotAuthorizedError errors
2020-01-14 14:10:05 -05:00
Ben Halpern
c0a7c17054
Modify podcast design details and functionality (#5472) [deploy]
* Modify podcast design details and functionality

* Adjust play button size

* Add heroku slug commit to some cache keys
2020-01-14 13:56:47 -05:00
rhymes
760d5ef325 Use .execute to avoid any possibility of prepared statements (#5509) [deploy] 2020-01-14 13:23:32 -05:00
dependabot-preview[bot]
8f87f02978 Bump eslint-plugin-import from 2.19.1 to 2.20.0 (#5479) [deploy]
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.19.1 to 2.20.0.
- [Release notes](https://github.com/benmosher/eslint-plugin-import/releases)
- [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md)
- [Commits](https://github.com/benmosher/eslint-plugin-import/compare/v2.19.1...v2.20.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-14 12:05:48 -05:00
Michael Kohl
256448f1f3 Remove unused Envfile variables (#5474)
* Remove unused variables from Envfile

* Remove unused Twitter variables from Envfile

* Also remove GITHUB_TOKEN

* Change Twitter token screenshot URL
2020-01-14 12:05:35 -05:00
Jacob Herrington
65c9989cf9 Add visual indication for listing buffer actions (#5411)
Michael asked that this behavior be extended to the buffer actions on
internal/listings as well.

We should probably look for an opportunity to refactor the JS currently
living in article_script.erb.
2020-01-14 12:03:58 -05:00
rhymes
9b2886979a ActiveRecord count optimizations (#5478) [deploy]
* Do not load messages in memory, just to count them
* Add Model.estimated_count
* Use Model.estimated_count in task record_db_table_counts
* Use size and estimated_count
* Use table_name so that .estimated_count works with all models
* Add comment to explain the .load.size + .each pattern
2020-01-14 12:03:38 -05:00
Michael Kohl
dba7e6ca60 Move Twitch webhook registration from ActiveJob to Sidekiq (#5414) 2020-01-14 11:55:35 -05:00
Michael Kohl
92b5f113be Return 429 Too Many Requests instead of raising (#5504) 2020-01-14 11:53:33 -05:00
rhymes
c267526ed2 Remove temporary site config script and unused ENV var (#5455) [deploy] 2020-01-14 09:49:31 -06:00
rhymes
241c39344e Destroy messages if chat channels are destroyed (#5498) 2020-01-14 09:46:40 -06:00
Anna Buianova
05884acd19 Fixed rubocop issues (#5506) 2020-01-14 09:45:26 -06:00
Andy Zhao
2d99ddba2d Add self to codeowners (#5501) 2020-01-14 10:00:19 -05:00
dependabot-preview[bot]
0c305c3347 Bump husky from 3.1.0 to 4.0.7 (#5482) [deploy]
Bumps [husky](https://github.com/typicode/husky) from 3.1.0 to 4.0.7.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](https://github.com/typicode/husky/compare/v3.1.0...v4.0.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 16:18:02 -06:00
dependabot-preview[bot]
1fed89ed02 Bump redoc-cli from 0.9.4 to 0.9.5 (#5481)
Bumps [redoc-cli](https://github.com/Redocly/redoc) from 0.9.4 to 0.9.5.
- [Release notes](https://github.com/Redocly/redoc/releases)
- [Changelog](https://github.com/Redocly/redoc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Redocly/redoc/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 16:10:45 -06:00
dependabot-preview[bot]
39f1f584bb Bump yard from 0.9.23 to 0.9.24 (#5488)
Bumps [yard](https://github.com/lsegal/yard) from 0.9.23 to 0.9.24.
- [Release notes](https://github.com/lsegal/yard/releases)
- [Changelog](https://github.com/lsegal/yard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/lsegal/yard/compare/v0.9.23...v0.9.24)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 15:55:09 -06:00
dependabot-preview[bot]
b01b1a514b Bump shoulda-matchers from 4.1.2 to 4.2.0 (#5493)
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers) from 4.1.2 to 4.2.0.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases)
- [Changelog](https://github.com/thoughtbot/shoulda-matchers/blob/master/NEWS.md)
- [Commits](https://github.com/thoughtbot/shoulda-matchers/compare/v4.1.2...v4.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 15:39:16 -06:00
dependabot-preview[bot]
1b38ab9cd7 Bump recaptcha from 5.2.1 to 5.3.0 (#5496)
Bumps [recaptcha](https://github.com/ambethia/recaptcha) from 5.2.1 to 5.3.0.
- [Release notes](https://github.com/ambethia/recaptcha/releases)
- [Changelog](https://github.com/ambethia/recaptcha/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ambethia/recaptcha/compare/v5.2.1...v5.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 15:38:37 -06:00
serena
6e9539415e Move welcome notification job to worker for Sidekiq (#5465) [deploy] 2020-01-13 13:28:23 -06:00
Alain Mauri
faa696444b Add Mentions::CreateAllWorker for Sidekiq (#5463) 2020-01-13 13:23:30 -06:00
Asha Balasubramaniam
61acfcd4c9 Remove Comments::SendEmailNotificationJob to send email notification on comment creation (#5446)
Follow up to https://github.com/thepracticaldev/dev.to/pull/5427
2020-01-13 13:19:48 -06:00
Lucas Hiago
1ed6aca54a Change Webhook::DestroyJob to Wehook::DestroyWorker and move to sidekiq (#5424) [deploy] 2020-01-13 12:38:10 -06:00
dependabot-preview[bot]
cf88f93874 Bump ddtrace from 0.30.1 to 0.31.0 (#5491)
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb) from 0.30.1 to 0.31.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases)
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md)
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.30.1...v0.31.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 12:34:54 -06:00
dependabot-preview[bot]
b3802368bc Bump honeybadger from 4.5.4 to 4.5.6 (#5492)
Bumps [honeybadger](https://github.com/honeybadger-io/honeybadger-ruby) from 4.5.4 to 4.5.6.
- [Release notes](https://github.com/honeybadger-io/honeybadger-ruby/releases)
- [Changelog](https://github.com/honeybadger-io/honeybadger-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/honeybadger-io/honeybadger-ruby/compare/v4.5.4...v4.5.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 12:34:28 -06:00
dependabot-preview[bot]
467e837492 Bump test-prof from 0.10.1 to 0.10.2 (#5487)
Bumps [test-prof](https://github.com/palkan/test-prof) from 0.10.1 to 0.10.2.
- [Release notes](https://github.com/palkan/test-prof/releases)
- [Changelog](https://github.com/palkan/test-prof/blob/master/CHANGELOG.md)
- [Commits](https://github.com/palkan/test-prof/compare/v0.10.1...v0.10.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 10:18:46 -05:00
dependabot-preview[bot]
d22a80fa0c Bump pg from 1.2.1 to 1.2.2 (#5495)
Bumps [pg](https://github.com/ged/ruby-pg) from 1.2.1 to 1.2.2.
- [Release notes](https://github.com/ged/ruby-pg/releases)
- [Changelog](https://github.com/ged/ruby-pg/blob/master/History.rdoc)
- [Commits](https://github.com/ged/ruby-pg/compare/v1.2.1...v1.2.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 10:18:27 -05:00
Anna Buianova
851508f628 Fix a bug when user tries to delete an account while not having an email (#5486)
* Ask user to add email when deleting [WIP]

* Ask to provide an email before requesting account deletion

* Additional checks to make sure that user won't be deleted w/o an email

* Revert changes on confirm destroy view
2020-01-13 08:34:37 -05:00
Jacob Herrington
e8c623807c Add @jacobherrington to CODEOWNERS [ci skip] (#5449)
Just including myself for directories specifically pertaining to
internal and to the docs directory.
2020-01-11 13:03:07 -06:00
Lucas Hiago
9ed6a5add0 Fix hex color in seeds (#5452) 2020-01-11 11:24:08 -05:00
Molly Struve
5e6ca69e27
Check for follow before trying to send a notification (#5438) [deploy] 2020-01-10 13:59:38 -06:00
Asha Balasubramaniam
e5960810cc Migrate Comments::SendEmailNotificationJob to Sidekiq (#5427)
* Add sidekiq version of the corresponding delayed job
* Switch the invocation of the delayed job from `after_create` to
`after_create_commit` to avoid the race condition where the worker can
be executed before the comment is persisted. Added covering spec
for this change.
2020-01-10 13:59:12 -06:00
Pablo Ifrán
bac4b7fac4 Move Users::ResaveArticlesJob to Sidekiq (#5398)
Change Resave Articles job to worker, and add missing specs on the user
model when changing the trigger attributes
2020-01-10 13:56:39 -06:00