maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix podcast NaN time issue (#5513) [deploy]

Browse source
This commit is contained in:
Ben Halpern 2020-01-14 15:30:11 -05:00 • committed by GitHub
parent ff7532b3db
commit e9252bcd10
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/assets/javascripts/initializers/initializePodcastPlayback.js
View file

@ -240,7 +240,7 @@ function initializePodcastPlayback() {
setMediaState(audio)
}
}
if (progress) {
if (progress && time && currentTime > 0) {
progress.style.width = value + '%';
buffer.style.width = bufferValue + '%';
time.innerHTML =
@ -325,7 +325,8 @@ function initializePodcastPlayback() {
findAndApplyOnclickToRecords();
getMediaState();
var audio = getById('audio');
if (audio) {
var audioContent = getById('audiocontent')
if (audio && audioContent && audioContent.innerHTML.length < 25) { // audio not already loaded
audio.load();
}
}

2
app/views/podcast_episodes/_liquid.html.erb
View file

@ -69,7 +69,7 @@
<span class="buffer-wrapper" id="bufferwrapper">
<span id="buffer"></span>
<span id="progress"></span>
<span id="time"></span>
<span id="time">initializing...</span>
<span id="closebutt">×</span>
</span>
</div>

2
app/views/podcast_episodes/_podcast_bar.html.erb
View file

@ -35,7 +35,7 @@
<span class="buffer-wrapper" id="bufferwrapper">
<span id="buffer"></span>
<span id="progress"></span>
<span id="time"></span>
<span id="time">initializing...</span>
<span id="closebutt">×</span>
</span>
</div>