From e9252bcd10eec9b7243b29c84e598ac994ea0138 Mon Sep 17 00:00:00 2001 From: Ben Halpern Date: Tue, 14 Jan 2020 15:30:11 -0500 Subject: [PATCH] Fix podcast NaN time issue (#5513) [deploy] --- .../javascripts/initializers/initializePodcastPlayback.js | 5 +++-- app/views/podcast_episodes/_liquid.html.erb | 2 +- app/views/podcast_episodes/_podcast_bar.html.erb | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/app/assets/javascripts/initializers/initializePodcastPlayback.js b/app/assets/javascripts/initializers/initializePodcastPlayback.js index da65b31a4..7b086fe0e 100644 --- a/app/assets/javascripts/initializers/initializePodcastPlayback.js +++ b/app/assets/javascripts/initializers/initializePodcastPlayback.js @@ -240,7 +240,7 @@ function initializePodcastPlayback() { setMediaState(audio) } } - if (progress) { + if (progress && time && currentTime > 0) { progress.style.width = value + '%'; buffer.style.width = bufferValue + '%'; time.innerHTML = @@ -325,7 +325,8 @@ function initializePodcastPlayback() { findAndApplyOnclickToRecords(); getMediaState(); var audio = getById('audio'); - if (audio) { + var audioContent = getById('audiocontent') + if (audio && audioContent && audioContent.innerHTML.length < 25) { // audio not already loaded audio.load(); } } diff --git a/app/views/podcast_episodes/_liquid.html.erb b/app/views/podcast_episodes/_liquid.html.erb index 8d16456aa..3ce06d1d8 100644 --- a/app/views/podcast_episodes/_liquid.html.erb +++ b/app/views/podcast_episodes/_liquid.html.erb @@ -69,7 +69,7 @@ - + initializing... × diff --git a/app/views/podcast_episodes/_podcast_bar.html.erb b/app/views/podcast_episodes/_podcast_bar.html.erb index 7dad9a646..f3b1d7fd7 100644 --- a/app/views/podcast_episodes/_podcast_bar.html.erb +++ b/app/views/podcast_episodes/_podcast_bar.html.erb @@ -35,7 +35,7 @@ - + initializing... ×