Commit graph

3764 commits

Author SHA1 Message Date
Ben Halpern
4e41e4a2ac
Add more info to architecture.md doc (#5541) 2020-01-16 16:33:51 -05:00
Jacob Herrington
8db4808d2e Internal Reports: Searching and sorting with Ransack (#5447) [deploy]
* Add gem Ransack 2.3.0

* Add sorting and search to internal/reports

The UI here should probably be revisited sooner or later, I feel like
the vomit reactions might even need to be moved to their own view.

* Add system spec for internal reports search

* Remove filter for report_type
2020-01-16 15:02:09 -05:00
José Chaves Neto
eff7bac9d8 refact: refactor userDetails (#5467) 2020-01-16 14:02:49 -05:00
Ben Halpern
a4b86e3ff1
Add initial usage metrics for datatog (#5544) [deploy]
* Add initial usage metrics for datatog

* Make measurable name more clear

* Change name of daily usage worker

* Fix test names
2020-01-16 12:59:17 -05:00
Molly Struve
1a3d59c97f
Send Sidekiq data to Honeycomb (#5517) [deploy] 2020-01-16 12:30:43 -05:00
gverger
c7de0d762b Add let_it_be_readonly to avoid updating variables (#5407)
With let_it_be, we define variables that are created for the whole
context. In case we update them in an example, there might be a
discrepancy between the object and its value in the database, since the
database is cleaned between examples, but not the object itself.

This is what happened here with the `article` object. In one of the
tests, we update its organization, and in another, we reupdate it. The
problem is that the `article` object still thinks it has an
organization, but it has been cleaned in the database. So setting the
same organization id to the object doesn't trigger the SQL query, and
the article in the database still doesn't have an organization attached.

One solution is to use `reload: true` as a parameter of `let_it_be`: it
will reload the object from the database at the beginning of each test. To
make sure we don't have other dormant traps like this one, what I
propose is to either have `reload: true`, or to have the object
readonly to avoid getting to a difference between the object and its
database value.
2020-01-16 10:53:30 -05:00
Asha Balasubramaniam
81ead4935a Migrate Comments::BustCacheJob to Comments::BustCacheWorker and move to Sidekiq (#5502) 2020-01-16 10:20:13 -05:00
Molly Struve
29efdaf20a
Remove Comments::CreateIdCodeJob which is now done inline (#5536) 2020-01-16 09:31:11 -05:00
Michael Kohl
b89ebd133e Add myself to core team in README (#5540) 2020-01-16 08:47:17 -05:00
Alex
7d47c78e55 Fix typo in Skipping CI docs [ci skip] (#5538) 2020-01-15 18:53:01 -05:00
dependabot-preview[bot]
be39f8ad82 Bump reverse_markdown from 1.3.0 to 1.4.0 (#5494) 2020-01-15 18:04:06 -05:00
dependabot-preview[bot]
92310ee7f9 Bump derailed_benchmarks from 1.4.3 to 1.5.0 (#5489) 2020-01-15 17:49:35 -05:00
Molly Struve
7b63da2627
send screenshots to s3 after failed travis build (#5537) 2020-01-15 17:22:37 -05:00
serena
5e761fc570 remove unused welcome notification job (#5535) 2020-01-15 16:57:33 -05:00
Thomas Bnt
0c6e696f2d Changed user-metadata-details to overflow-y: auto (#5532) [deploy] 2020-01-15 16:47:10 -05:00
Michael Kohl
e946e2d7cf Update settings links + descriptions in editor guide (#5473) 2020-01-15 16:37:35 -05:00
Alex
e3d83896f0 Add Alex Smith to core team members [ci skip] (#5534) 2020-01-15 16:35:22 -05:00
Lucas Hiago
c09c65d7bf Fix missing redis server to gitpod configuration (#5528) 2020-01-15 15:12:18 -05:00
Molly Struve
5962d52a61
record background queue stats in a worker (#5533) [deploy] 2020-01-15 14:44:57 -05:00
Lucas Hiago
97aac4ef9b Change Notifications::MilestoneJob to Notifications::MilestoneWorker and move to sidekiq (#5454) [deploy] 2020-01-15 13:21:56 -05:00
rhymes
fd6758fa39 Enable Bullet in development mode (#5527) 2020-01-15 13:21:00 -05:00
Molly Struve
ddb54d0422
Halt Deploys With release script if ENV variable DEPLOY_STATUS is set to blocked (#5510) [deploy] 2020-01-15 12:36:05 -05:00
rhymes
7bfb255627 Remove unnecessary heroku slug commit values in cache keys (#5524) 2020-01-15 12:35:16 -05:00
Lucas Hiago
74f9decc56 Change Notifications::RemoveAllJob to Notifications::RemoveAllWorker and move to sidekiq (#5451) 2020-01-15 12:34:12 -05:00
Molly Struve
2e5a36e538
Log DB Table sizes in a Sidekiq Worker (#5518) 2020-01-15 12:33:14 -05:00
rhymes
4f9321e6f4 Fix spec that broke after we merged #4744 (#5529) [deploy] 2020-01-15 12:01:37 -05:00
Molly Struve
6726c62e94
Scrub unused data sent to Honeycomb to save space (#5512) [deploy] 2020-01-15 11:11:41 -05:00
rhymes
bcd85452e9 Comments API: fix caching issues (#4744) [deploy]
* Use ancestry in the index and add test

* Add tests for show action

* Return complete comments trees for index, kill n+1 and use correct edge cache key

* Return complete comments tree for show, kill n+1 and use correct edge cache key

* Refactor tests and add surrogate keys tests

* Preload users for the whole subtree

* Clarify explanation of the edge cache keys construction

* Refactor partials

* Remove action caching

* Replace .map.flatten with .flat_map

* Fix surrogate key prefix according to Fastly docs

* Add comment.purge to Comments::BustCacheJob to use Fastly-Rails

* Fix surrogate key spec
2020-01-15 10:45:56 -05:00
vladimirschneider
bbaa5902c7 Currect .menubg top position (#5505)
* Currect .menubg top position

Ben changed .top-bar height but do not changed .menubg top position

* Update top-bar.scss
2020-01-15 10:07:02 -05:00
ludwiczakpawel
06bf574e34 adding section for switching to free plan (#5514) 2020-01-15 08:38:58 -05:00
Ben Halpern
e9252bcd10
Fix podcast NaN time issue (#5513) [deploy] 2020-01-14 15:30:11 -05:00
rhymes
ff7532b3db Handle liquid tag errors in comments form (#5485) [deploy]
* Handle liquid tag errors in comments form
* Do not hide Pundit::NotAuthorizedError errors
2020-01-14 14:10:05 -05:00
Ben Halpern
c0a7c17054
Modify podcast design details and functionality (#5472) [deploy]
* Modify podcast design details and functionality

* Adjust play button size

* Add heroku slug commit to some cache keys
2020-01-14 13:56:47 -05:00
rhymes
760d5ef325 Use .execute to avoid any possibility of prepared statements (#5509) [deploy] 2020-01-14 13:23:32 -05:00
dependabot-preview[bot]
8f87f02978 Bump eslint-plugin-import from 2.19.1 to 2.20.0 (#5479) [deploy]
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.19.1 to 2.20.0.
- [Release notes](https://github.com/benmosher/eslint-plugin-import/releases)
- [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md)
- [Commits](https://github.com/benmosher/eslint-plugin-import/compare/v2.19.1...v2.20.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-14 12:05:48 -05:00
Michael Kohl
256448f1f3 Remove unused Envfile variables (#5474)
* Remove unused variables from Envfile

* Remove unused Twitter variables from Envfile

* Also remove GITHUB_TOKEN

* Change Twitter token screenshot URL
2020-01-14 12:05:35 -05:00
Jacob Herrington
65c9989cf9 Add visual indication for listing buffer actions (#5411)
Michael asked that this behavior be extended to the buffer actions on
internal/listings as well.

We should probably look for an opportunity to refactor the JS currently
living in article_script.erb.
2020-01-14 12:03:58 -05:00
rhymes
9b2886979a ActiveRecord count optimizations (#5478) [deploy]
* Do not load messages in memory, just to count them
* Add Model.estimated_count
* Use Model.estimated_count in task record_db_table_counts
* Use size and estimated_count
* Use table_name so that .estimated_count works with all models
* Add comment to explain the .load.size + .each pattern
2020-01-14 12:03:38 -05:00
Michael Kohl
dba7e6ca60 Move Twitch webhook registration from ActiveJob to Sidekiq (#5414) 2020-01-14 11:55:35 -05:00
Michael Kohl
92b5f113be Return 429 Too Many Requests instead of raising (#5504) 2020-01-14 11:53:33 -05:00
rhymes
c267526ed2 Remove temporary site config script and unused ENV var (#5455) [deploy] 2020-01-14 09:49:31 -06:00
rhymes
241c39344e Destroy messages if chat channels are destroyed (#5498) 2020-01-14 09:46:40 -06:00
Anna Buianova
05884acd19 Fixed rubocop issues (#5506) 2020-01-14 09:45:26 -06:00
Andy Zhao
2d99ddba2d Add self to codeowners (#5501) 2020-01-14 10:00:19 -05:00
dependabot-preview[bot]
0c305c3347 Bump husky from 3.1.0 to 4.0.7 (#5482) [deploy]
Bumps [husky](https://github.com/typicode/husky) from 3.1.0 to 4.0.7.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](https://github.com/typicode/husky/compare/v3.1.0...v4.0.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 16:18:02 -06:00
dependabot-preview[bot]
1fed89ed02 Bump redoc-cli from 0.9.4 to 0.9.5 (#5481)
Bumps [redoc-cli](https://github.com/Redocly/redoc) from 0.9.4 to 0.9.5.
- [Release notes](https://github.com/Redocly/redoc/releases)
- [Changelog](https://github.com/Redocly/redoc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Redocly/redoc/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 16:10:45 -06:00
dependabot-preview[bot]
39f1f584bb Bump yard from 0.9.23 to 0.9.24 (#5488)
Bumps [yard](https://github.com/lsegal/yard) from 0.9.23 to 0.9.24.
- [Release notes](https://github.com/lsegal/yard/releases)
- [Changelog](https://github.com/lsegal/yard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/lsegal/yard/compare/v0.9.23...v0.9.24)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 15:55:09 -06:00
dependabot-preview[bot]
b01b1a514b Bump shoulda-matchers from 4.1.2 to 4.2.0 (#5493)
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers) from 4.1.2 to 4.2.0.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases)
- [Changelog](https://github.com/thoughtbot/shoulda-matchers/blob/master/NEWS.md)
- [Commits](https://github.com/thoughtbot/shoulda-matchers/compare/v4.1.2...v4.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 15:39:16 -06:00
dependabot-preview[bot]
1b38ab9cd7 Bump recaptcha from 5.2.1 to 5.3.0 (#5496)
Bumps [recaptcha](https://github.com/ambethia/recaptcha) from 5.2.1 to 5.3.0.
- [Release notes](https://github.com/ambethia/recaptcha/releases)
- [Changelog](https://github.com/ambethia/recaptcha/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ambethia/recaptcha/compare/v5.2.1...v5.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 15:38:37 -06:00
serena
6e9539415e Move welcome notification job to worker for Sidekiq (#5465) [deploy] 2020-01-13 13:28:23 -06:00