Alireza Zekavat Fetrat
4d3203be82
Fixes inappropriate comment header background bug #3020 ( #3021 )
2019-06-01 10:01:22 -04:00
Ben Halpern
10151f9f4c
Fix close modal click action ( #3018 )
2019-06-01 10:00:42 -04:00
Mario See
8359ab555f
Add reading time to reading list ( #2929 )
...
* init
- add reading_time to reactions
- make migration
- add to algolia index in reaction model
- add method in reaction model to define reading time based on reactable reading time
* add time to front end
* Revert "Return errors instead of raising an exception on ArticleCreation (#2922 )"
This reverts commit 09a99d93a3 .
* Revert "init"
This reverts commit 53650ebcc3c93c54e396977f7c34f7aa35a589c4.
* Revert "Revert "Return errors instead of raising an exception on ArticleCreation (#2922 )""
This reverts commit e8cf1f3a290dd06b937247e3ff7593e7c7036553.
* Update reaction.rb
* remove duplicate searchableAttribute
2019-05-31 16:45:29 -04:00
Ben Halpern
1775f42cc4
Finalize DEV Connect for listings ( #3016 )
2019-05-31 15:22:59 -04:00
Mario See
19b46a86e2
Add messaging option in listings ( #2854 )
...
* add prop for message modal method
* clean up comments from open inbox method
* add inbox type to listing model author
* add sample methods for opening message modal in listings and listing modal
* only show for users with open inbox and hide for self
* use contact_via_connect instead of inbox_type
* fix edit listing to include contact via connect attribute
* wip send message method
* adjust message styling
* change id name
* update destination
* remove unused methods
2019-05-31 13:48:45 -04:00
rhymes
36ad407c1d
Fix zen mode's global key bug ( #2969 )
2019-05-31 13:33:29 -04:00
briwa
b301bf8def
fix(article): scroll to top when inserting image ( #2998 )
2019-05-31 10:29:42 -04:00
Mohammadjavad Raadi
2e8eda4974
Fixes Listing Items Spacing Inconsistency and Content Overflow Issue #2846 ( #3011 )
2019-05-31 09:02:32 -04:00
briwa
b35fc23a82
refactor(svgs): remove empty group tags ( #3002 )
...
* refactor(svgs): remove empty group tags
* fix(spec): update liquid tag twitter spec
2019-05-31 08:54:31 -04:00
Anna Buianova
a7332846df
Validate on creating a reaction notification ( #3010 )
2019-05-31 07:30:17 -04:00
Curtis Maloney
8d50956f1a
Optimise images ( #2966 )
2019-05-30 17:37:10 -04:00
briwa
b8908c5190
fix(README): link to the testing doc is broken ( #3006 )
...
[ci skip]
2019-05-30 17:36:22 -04:00
Ali Spittel
5dd0341a0c
refactor v2 editor guide ( #3007 )
2019-05-30 17:35:19 -04:00
Jess Lee
c3e2a0c5f1
Add missing instance var for /manage & Bust rails cache on comments ( #3004 )
2019-05-30 12:23:20 -04:00
cyrillefr
8c52d5c43f
Move remove_each notifications method in own job ( #2946 )
2019-05-29 16:26:18 -04:00
rhymes
a99c072525
Guard bust_comment against nil commentable ( #2991 )
2019-05-29 14:03:20 -04:00
Anna Buianova
c510f1510c
Fix a validation error when creating notifications #2525 ( #2999 )
...
* Use activerecord-import upsert to deal with the race condition
* Return a more consistent result form Notifications::Reactions::Send
2019-05-29 11:19:37 -04:00
briwa
4f31c6d07a
fix(reading-list): even spacing for Save and Bookmark span ( #3000 )
2019-05-29 11:19:01 -04:00
rhymes
38aa45c8e3
Cleanup bodyPreview component ( #2980 ) [ci skip]
2019-05-28 23:55:37 -04:00
dependabot-preview[bot]
d330883f6e
Bump timber from 2.6.2 to 3.0.1 & Add timber-rails gem ( #2894 ) [ci skip]
...
* Bump timber from 2.6.2 to 3.0.1
Bumps [timber](https://github.com/timberio/timber-ruby ) from 2.6.2 to 3.0.1.
- [Release notes](https://github.com/timberio/timber-ruby/releases )
- [Changelog](https://github.com/timberio/timber-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/timberio/timber-ruby/compare/v2.6.2...v3.0.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
* Add timber-rails gem
2019-05-28 23:45:56 -04:00
dependabot-preview[bot]
c15b2a2448
Bump skylight from 3.1.5 to 4.0.2 ( #2971 ) [ci skip]
...
Bumps [skylight](https://github.com/skylightio/skylight-ruby ) from 3.1.5 to 4.0.2.
- [Release notes](https://github.com/skylightio/skylight-ruby/releases )
- [Changelog](https://github.com/skylightio/skylight-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/skylightio/skylight-ruby/compare/v3.1.5...v4.0.2 )
2019-05-28 17:46:33 -04:00
rhymes
6a626e819d
Refactor: fix issues raised by bullet ( #2965 )
...
* Preload organization, not user
* Preload users only when needed
* Pre-load podcasts for podcast episodes in API
* Avoid eager loading error by loading rating votes separately
* Preload associations for moderation
* Preload user comments in trees
* Preload organization for non org dashboard and cleanup queries
* Optimize ArticleSuggester to only load N articles at need
* Remove eager loading and pass variables to partials for easier debug
* Reorganize tags validation code and ignore actsastaggableon eager loading issues
* Remove unused eager loading and bring up comments relation
* Preload podcasts when loading podcast episodes
* Fix views specs
* Make sure ArticleSuggester never returns duplicates
* Remove commented code
* Re-trigger build
* Move suggested articles back to view to respect fragment caching
2019-05-28 17:32:53 -04:00
dependabot-preview[bot]
72d118cf48
Bump stripe from 4.17.0 to 4.18.1 ( #2990 ) [ci skip]
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 4.17.0 to 4.18.1.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v4.17.0...v4.18.1 )
2019-05-28 17:32:11 -04:00
rhymes
6ea4b55658
Require only used parts of Rails ( #2988 )
...
Rails by defaults loads all its railties and engines, the current app does not use neither ActiveStorage, nor ActionCable nor TestUnit.
We can, hence, dispense of them.
2019-05-28 17:30:05 -04:00
dependabot-preview[bot]
ac6ba0f69b
Bump aws-sdk-lambda from 1.25.0 to 1.26.0 ( #2970 ) [ci skip]
...
Bumps [aws-sdk-lambda](https://github.com/aws/aws-sdk-ruby ) from 1.25.0 to 1.26.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-lambda/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/compare/1.25.0...1.26.0 )
2019-05-28 17:19:37 -04:00
Ben Halpern
d2f296114a
Modify cache key for article sidebar cta ( #2993 )
2019-05-28 17:18:31 -04:00
Vince Blom
bfc961b3f3
Codepen Links with Underscore Usernames ( #2985 )
...
- updates codepen liquid tag regex to allow underscores
- adds test to ensure an underscore in the username field of the link
is considered valid
2019-05-28 16:32:34 -04:00
Ben Halpern
e1d537c016
Fix css missing ( #2992 )
2019-05-28 15:24:56 -04:00
dependabot-preview[bot]
736916259e
Bump test-prof from 0.8.0 to 0.9.0 ( #2972 ) [ci skip]
...
Bumps [test-prof](https://github.com/palkan/test-prof ) from 0.8.0 to 0.9.0.
- [Release notes](https://github.com/palkan/test-prof/releases )
- [Changelog](https://github.com/palkan/test-prof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/palkan/test-prof/compare/v0.8.0...v0.9.0 )
2019-05-28 13:11:28 -04:00
dependabot-preview[bot]
2bbd594094
Bump google-api-client from 0.29.1 to 0.30.0 ( #2974 ) [ci skip]
...
Bumps [google-api-client](https://github.com/google/google-api-ruby-client ) from 0.29.1 to 0.30.0.
- [Release notes](https://github.com/google/google-api-ruby-client/releases )
- [Changelog](https://github.com/googleapis/google-api-ruby-client/blob/master/CHANGELOG.md )
- [Commits](https://github.com/google/google-api-ruby-client/compare/0.29.1...0.30.0 )
2019-05-28 13:03:44 -04:00
dependabot-preview[bot]
4a784d46c3
Bump bundler-audit from 0.6.0 to 0.6.1 ( #2977 ) [ci skip]
...
Bumps [bundler-audit](https://github.com/postmodern/bundler-audit ) from 0.6.0 to 0.6.1.
- [Release notes](https://github.com/postmodern/bundler-audit/releases )
- [Changelog](https://github.com/rubysec/bundler-audit/blob/master/ChangeLog.md )
- [Commits](https://github.com/postmodern/bundler-audit/compare/v0.6.0...v0.6.1 )
2019-05-28 13:00:28 -04:00
dependabot-preview[bot]
7950266a74
Bump rubocop from 0.69.0 to 0.70.0 ( #2975 ) [ci skip]
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 0.69.0 to 0.70.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.69.0...v0.70.0 )
2019-05-28 12:57:33 -04:00
dependabot-preview[bot]
d9190b297c
Bump eslint-plugin-import from 2.17.2 to 2.17.3 ( #2978 ) [ci skip]
...
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import ) from 2.17.2 to 2.17.3.
- [Release notes](https://github.com/benmosher/eslint-plugin-import/releases )
- [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md )
- [Commits](https://github.com/benmosher/eslint-plugin-import/compare/v2.17.2...v2.17.3 )
2019-05-28 12:47:38 -04:00
dependabot-preview[bot]
64bbba5176
Bump codemirror from 5.46.0 to 5.47.0 ( #2979 ) [ci skip]
...
Bumps [codemirror](https://github.com/codemirror/CodeMirror ) from 5.46.0 to 5.47.0.
- [Release notes](https://github.com/codemirror/CodeMirror/releases )
- [Changelog](https://github.com/codemirror/CodeMirror/blob/master/CHANGELOG.md )
- [Commits](https://github.com/codemirror/CodeMirror/compare/5.46.0...5.47.0 )
2019-05-28 12:46:17 -04:00
Kartikey Tanna
b16fa4f8cc
Implemented ActiveJob for badge_achievements#send_email_notification ( #2962 )
...
* Implemented ActiveJob for badge_achievements#send_email_notification
* Sending email only if record not nil
As per the review
2019-05-27 09:44:38 -04:00
Mac Siri
6d1638ed68
Unskip all skipped specs ( #2941 )
...
* Change all login_as to sign_in
* Unskip comment spec
* Create new specs
* Turn on Webdriver caching
* Set logger for Omniauth in test
* Update editor system spec
* Fix editor approval file
* Update video_controller
* Update TagAdjustmentUpdateService's spec
* Update users api spec
* Update stories_index_spec
* Remove redundant spec file
* Remove residual code
* Change ClassifiedListing spec
* Update NotificationsIndex spec
2019-05-25 11:04:38 -04:00
dependabot-preview[bot]
0548a45fa1
[Security] Bump tar from 2.2.1 to 2.2.2 ( #2954 )
...
Bumps [tar](https://github.com/npm/node-tar ) from 2.2.1 to 2.2.2. **This update includes security fixes.**
- [Release notes](https://github.com/npm/node-tar/releases )
- [Commits](https://github.com/npm/node-tar/compare/v2.2.1...v2.2.2 )
2019-05-24 14:01:52 -04:00
Thomas Ghysels
732d0e4450
Use consistent colors for inline code, including night theme ( #2947 )
2019-05-24 12:53:20 -04:00
Conor Fischer
2a57e43bcb
Fix broken doc links ( #2945 ) [ci skip]
2019-05-24 12:31:18 -04:00
Ben Halpern
37fabd08b1
Fix some connect bugs with wrong url and remove some dead code ( #2953 )
2019-05-24 12:19:59 -04:00
Anna Buianova
d3f9050be7
Move updating twitch username to a separate action #2784 ( #2866 )
...
* Move updating twitch username to a separate action #2784
* Fix the submit button on the integrations page
* Modify test according to the redirect
2019-05-24 11:13:33 -04:00
Clara
48b9d16e6e
Bug/markdown underscores in usernames ( #2948 )
...
* Add method into MardownFixer and call in Comment
* Add test
* Escape all underscores in usernames and adapt tests
* Rework regex [WIP]
* Add new idea
* Clean up method and add correct tests
2019-05-24 08:34:14 -04:00
Anna Buianova
a6091fe6c8
Moved notifying followers to a separate ActiveJob #1996 ( #2935 )
...
* Moved notifying followers to a service + specs
* Created an ActiveJob for notifiable action notifications
* Call the job from the Notification#send_to_followers
* Refactor creating notifiable action notification
* Handle possible nil followers while sending notifiable action notification
* Use activerecord import to bulk-create notifications
* Set notified_at for the bulk-created notifications
* Move compact to the appropriate place
2019-05-24 07:45:51 -04:00
Jess Lee
8765de85b4
Sort internal/listings by recently bumped listings ( #2938 )
2019-05-22 15:28:03 -04:00
Mohammadjavad Raadi
1a960cfb44
Fix TwitterTag's video control bug ( #2869 )
2019-05-22 13:32:37 -04:00
rhymes
3a45bfcc2d
API docs: Adjust document and add syntax highlight [skip ci] ( #2936 )
...
* Adjust document and add syntax highlight
* Add alt text to images
2019-05-22 12:24:52 -04:00
Jesse M. Holmes
d7975637c5
Fix wording in readme.md ( #2932 )
...
* Renamee "Basic Installation" to the correct "Standard Installation"
* Added link to Standard Installation
2019-05-22 09:44:08 -04:00
Jess Lee
65e3cf605c
Internal Listings View Enhancement ( #2931 )
...
* wip
* add username to listings list view
* add pagination
* small style adjustment on edit page
* add has_many relationship to users and orgs
* add search by username or listing title
2019-05-21 18:28:18 -04:00
Jess Lee
1678489a2b
Internal Updates - Bust Cache for Listings and Add Note for Credits ( #2908 )
...
* handle cache busting
* add required note when removing or adding credits
* only reindex if listing is published
2019-05-21 17:25:37 -04:00
rhymes
9e14ef2afd
Add a proper exception in case of XSS attempt ( #2927 )
...
Fixes the generic error message with a proper one
2019-05-21 17:20:39 -04:00