maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix TwitterTag's video control bug (#2869)

Browse source
This commit is contained in:
Mohammadjavad Raadi 2019-05-22 22:02:38 +04:30 • committed by Mac Siri
parent 3a45bfcc2d
commit 1a960cfb44
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/views/liquids/_tweet.html.erb
View file

@ -7,7 +7,7 @@
<img src="/assets/play-butt.svg" class="ltag__twitter-tweet__play-butt" alt="Play butt">
</div>
<div class='ltag__twitter-tweet__video'>
<video loop>
<video loop controls>
<source src="<%= tweet.extended_entities_serialized[:media].first[:video_info][:variants].last[:url] %>"
type="<%= tweet.extended_entities_serialized[:media].first[:video_info][:variants].last[:content_type] %>">
</video>

2
spec/support/fixtures/approvals/liquid_tweet_tag_spec.approved.html
View file

@ -6,7 +6,7 @@
<div class="ltag__twitter-tweet__media--video-preview">
<img src="https://pbs.twimg.com/tweet_video_thumb/DiPm8-WXcAI3_qS.jpg" alt="unknown tweet media content" /><img src="/assets/play-butt.svg" class="ltag__twitter-tweet__play-butt" alt="Play butt" /></div>
<div class="ltag__twitter-tweet__video">
<video loop=""><source src="https://video.twimg.com/tweet_video/DiPm8-WXcAI3_qS.mp4" type="video/mp4"></source></video></div>
<video loop="" controls=""><source src="https://video.twimg.com/tweet_video/DiPm8-WXcAI3_qS.mp4" type="video/mp4"></source></video></div>
</div>
<div class="ltag__twitter-tweet__main" data-url="https://twitter.com/thepracticaldev/status/1018911886862057472">