Ben Halpern
2c07b08514
Add low-value landing pages to robots.txt disallow ( #5944 ) [deploy]
...
* Add low-value landing pages to robots.txt disallow
* Update app/views/pages/robots.text.erb
* Update app/views/pages/robots.text.erb
2020-02-07 14:04:36 -05:00
Maykon Menezes
58b96f104e
create Users::EstimateDefaultLanguageWorker for Sidekiq ( #5697 ) [deploy]
2020-02-07 13:49:02 -05:00
Molly Struve
7115d7e3ed
Eager load users when handling chat channel memberships ( #5954 )
2020-02-07 13:45:16 -05:00
Molly Struve
e159217dce
Remove Unused ChatChannel Indexing ( #5907 ) [deploy]
...
* remove unused algolia code from chat channel
* remove new chat_channel index code and unused methods
2020-02-07 12:39:59 -05:00
rhymes
69b04d38aa
Refactor API Reactions controller and add specs ( #5936 )
...
* Add specs
* Check the object, not the ID
* Use permitted params and delete cache only after create
* Inherit from ApiController, bail if the reaction user does not exist, fix naming
* Remove superflous test
2020-02-07 12:39:24 -05:00
ludwiczakpawel
45f2a6b542
removing border-box from shecoded landing page ( #5949 )
2020-02-07 11:08:46 -05:00
Vaidehi Joshi
c7a1bd9449
Fix logging for dev and test environments ( #5922 )
...
* Fix logging for dev and test environments
We had some unused code for Timber in our config files for development and test.
However, this was completely clobbering Rails' default behavior of logging out to log/development.log and log/test.log. We should allow for logging in these environments in particular, and since we're not using Timber there, we can just revert to using the Rails default debugging log levels.
* Add Timber logger to specs that explicitly require it
* Restore default Rails.logger in specs using Timber logger
* Explicitly use Rails.logger in OmniauthCallbacksController
We seem to have different logger classes leaking into this controller in tests.
I'm not entirely sure why this is/haven't been able to investigate yet, but I do think we should be using the Rails.logger explicitly until we can figure that out.
2020-02-07 10:15:08 -05:00
Molly Struve
bbeb3fc79d
Ensure user is authenticated before doing onboarding Actions ( #5937 )
...
* ensure user is authenticated before doing onboarding checks
* add specs for authenticating users for onboarding updates
2020-02-07 09:56:29 -05:00
rhymes
6cd46ae2f9
Enable bullet during tests to catch N+1 early (and some cleanups) ( #5930 ) [deploy]
...
* Remove unused methods
* Small refactorings
* Enable bullet in testing mode
* Remove unused eager loading for notes
* Skip bullet on rolify method
* Use .present?
* Fix method name
2020-02-07 09:02:22 -05:00
Alex
7909d9825d
Remove .first query on notifications ( #5943 )
2020-02-07 08:58:51 -05:00
Sebastien
665f5aac0f
Refactor ProfileImage ( #5803 )
2020-02-07 08:56:16 -05:00
Ben Halpern
f3c86c6377
Add mod channel automation to tags ( #5731 ) [deploy]
...
* Add mod channel automation to tags
* Change mod_relations to mod_relations_admin
* Run migration properly
* Make queries consistent and fix test
2020-02-06 16:27:12 -05:00
Frederico Hasegawa
7436e70158
Onboarding JS: refactor function out of repetitive blocks ( #5564 ) [deploy]
2020-02-06 16:00:57 -05:00
Michael Kohl
4872422373
Remove extra whitespace from text inputs in Buffer share ( #5924 ) [deploy]
2020-02-06 15:18:58 -05:00
Andy Zhao
975a716e5e
Use simpler messaging for ghost account deletion ( #5906 )
...
* Use simpler messaging for ghost account deletion
* Add 'have questions' section
* Use same language for confirm destroy page
2020-02-06 14:31:18 -05:00
Deepu K Sasidharan
5194c009ce
Style: update height of speakerdeck tag to be avoid scaling ( #5818 )
...
* style: update height of speackerdeck tag to be avoid scaling
* style: remove incorrect padding and margin from speackerdeck tag
* add a comment
2020-02-06 14:29:34 -05:00
Nick Taylor
631867b30f
Refactored userData while working on hompage makeover. ( #5916 ) [deploy]
2020-02-06 11:18:52 -08:00
Maykon Menezes
01dc81afa9
Move Podcasts::GetEpisodesJob to Sidekiq ( #5443 ) [deploy]
...
* Refactored Podcast::GetEpisodesJob to sidekiq
* fixing specs
* removing env keys
* Change arguments to Hash
* Update specs and add spec for queue
* Update references for Hash argument
* Add comment to explain parameters of #perform
Co-authored-by: Alex <alexandersmith223@gmail.com>
2020-02-06 09:42:55 -08:00
Molly Struve
00fefe5865
Add Code To Setup the Elasticsearch Tag Index ( #5919 ) [deploy]
2020-02-06 11:46:11 -05:00
rhymes
92f6a9f007
Fix serialization error with video_thumbnail_url ( #5933 )
2020-02-06 10:50:44 -05:00
Molly Struve
a972c8b892
log Notification db table size ( #5920 ) [deploy]
2020-02-06 08:33:04 -05:00
rhymes
fd5643bc9d
Improve API controllers efficiency by selecting only columns needed for serialization ( #5805 ) [deploy]
2020-02-06 07:36:56 -05:00
Nick Taylor
f2b79a94dd
Removed isRequired for whole user entity ( #5902 )
...
This is already done in components that consume these PropTypes
2020-02-05 17:52:53 -05:00
Nick Taylor
261a4f9efa
Add common tag PropTypes ( #5882 )
2020-02-05 17:38:43 -05:00
Michael Kohl
52759c9427
Allow deleting comments if article has already been deleted ( #5889 ) [deploy]
2020-02-05 17:10:19 -05:00
Alex
662d62fe72
Remove Notifications::TagAdjustmentNotificationJob ( #5915 ) [deploy]
2020-02-05 13:33:20 -08:00
Alex
2f4ee09736
Remove UpdateMainImageBackgroundHexJob & spec ( #5911 )
2020-02-05 13:32:58 -08:00
Alex
8a46f4c701
Remove HtmlVariantTrialCreateJob & spec ( #5910 )
2020-02-05 13:32:45 -08:00
Alex
6a100415cc
Move Notifications::TagAdjustmentNotificationJob to Sidekiq ( #5909 ) [deploy]
...
* Create TagAdjustmentNotificationWorker
* Create TagAdjustmentNotificationWorker spec
* Update references and specs for new worker
* Future proof specs
2020-02-05 09:52:21 -08:00
Gonzalo Ricco
dd796aaef3
Fix raising validation if followable already exist(race condition) ( #5826 )
...
* Fix raising validation if followable already exist(race condition)
* Change Rails Logger for DataDogStatsClient and remove 'begin' keyword in follow method
Co-authored-by: Gonzalo Ricco <gonzalo.ricco@leniolabs.com>
2020-02-05 12:25:26 -05:00
Maja Komel
28440d1fa1
Return NotFound error if ChatChannelMembership is not found ( #5806 )
2020-02-05 12:24:40 -05:00
Michael Kohl
7270d5ab4c
Move user deletion by moderator to worker ( #5887 ) [deploy]
2020-02-05 08:27:07 -05:00
rhymes
a95877e8ff
Use cleverer patterns to fetch/iterate AR objects when checking presence ( #5833 ) [deploy]
2020-02-05 08:21:20 -05:00
Andy Zhao
be6aaf750c
Add user as reactable ( #5893 )
...
* Add user as reactable
* Make title method public
* Use constants for reactable_type and status
2020-02-04 21:25:56 -06:00
codekatas
bae7ee8b73
Migrate update main image background job to sidekiq ( #5345 ) [deploy]
...
* Add new UpdateMainImageBackgroundHexWorker worker class
This is a port of app/jobs/update_main_image_background_job.rb
that works with Sidekiq instead of DelayedJob.
* Update all references to UpdateMainImageBackgroundHexJob
This updates all references to UpdateMainImageBackgroundHexJob
so they now call UpdateMainImageBackgroundHexWorker, which works
with Sidekiq instead of DelayedJob.
* Move method call to after_commit callback
* Fix article specs with sidekiq helpers
Co-authored-by: Alex <alexandersmith223@gmail.com>
2020-02-04 17:51:09 -08:00
Alex
97ee0a804f
Move HtmlVariantTrial#create inline ( #5901 ) [deploy]
2020-02-04 17:29:46 -08:00
Alex
8261ab74d7
Remove Notifications::ModerationNotificationJob ( #5905 ) [deploy]
2020-02-04 17:03:08 -08:00
Alex
8578c78158
Remove Notifications::UpdateJob and spec ( #5903 )
2020-02-04 17:02:47 -08:00
Alex
15b4565ac8
Remove Articles::ScoreCalcJob and spec ( #5898 )
2020-02-04 17:01:59 -08:00
Alex
aa7bc6b7b2
Remove Tags::BustCacheJob and spec ( #5897 )
2020-02-04 17:01:06 -08:00
Vaidehi Joshi
e84dec1db6
Allow broadcasts to be created from internal/broadcast ( #5908 ) [deploy]
...
Also raise errors when necessary in all broadcast endpoints.
Clean up tests and add specs for POST /internal/broadcast
2020-02-04 15:57:17 -08:00
Michael Kohl
a26ea73771
Remove direct chat channels when banishing user ( #5784 ) [deploy]
...
* Remove direct chat channels when banishing user
* Also remove article's buffer updates
* Incorporate PR feedback and make deletion safer
2020-02-04 17:10:39 -05:00
Vaidehi Joshi
a396d024de
Remove quotes from broadcast options in internal form ( #5904 ) [deploy]
2020-02-04 12:37:28 -08:00
Michael Kohl
9e6a363cfc
Add readonly ApplicationConfig to /internal/config ( #5662 ) [deploy]
...
* Add readonly ApplicationConfig to /internal/config
* Incorporate PR feedback
* Remove spurious div
2020-02-04 15:13:34 -05:00
Alex
67894aa1f8
Move Articles::DetectHumanLanguage from background job to inline ( #5888 ) [deploy]
...
* Move DetectHumanLanguage inline
* Remove old DetectHumanLanguage job and spec
* Fix copy/pasta mixup...oopsie!
* Update article_spec for inline LanguageDetector
2020-02-04 10:45:42 -08:00
Alex
de3ee9ebec
Move HtmlVariantSuccessesCreate from job to inline ( #5879 ) [deploy]
2020-02-04 10:24:39 -08:00
Alex
8168a5e8f5
Move Articles::ScoreCalcJob to Sidekiq ( #5875 ) [deploy]
...
* Create Articles::ScoreCalcWorker
* Create Articles::ScoreCalcWorker spec
* Update references to the new ScoreCalcWorker
* Refactoring conditional callbacks and biz logic
- Move update_columns to a model method
- Move conditions on callback to guard clause in callback method
- Make article_destroy_spec more explicit
2020-02-04 10:01:46 -08:00
Alex
0c42ea2b43
Move Tags::BustCacheJob to Sidekiq ( #5870 ) [deploy]
...
* Create Tags::BustCacheWorker
* Create Tags::BustCacheWorker spec
* Update references to new worker
2020-02-04 09:24:37 -08:00
Vaidehi Joshi
267e08f6f0
Improve dropdown UX for internal/badges ( #5880 ) [deploy]
...
* Improve dropdown UX for internal/badges
Add a "blank" option to the dropdown to list of badges on internal/badges route.
Also add some checks to handle if an admin accidentally tries to award a "blank" badge.
* Ensure error is surfaced as flash message
2020-02-04 09:02:14 -08:00
Vaidehi Joshi
b09a0c60f3
Add comment to highlight difference between previewing in v1 and v2 editors ( #5894 )
...
A follow-up to https://github.com/thepracticaldev/dev.to/pull/5873 .
2020-02-04 08:32:06 -08:00
