Prior to this commit, our fallback HREF was using only the URL's
domain (e.g. `guides.rubyonrails.org/routing.html`) instead of the
provided URL (e.g. `https://guides.rubyonrails.org/routing.html`). This
resulted in the link resolving to
`<url-of-article>/guides.rubyonrails.org/routing.html`)
With this commit, we're using the given URL for the HREF.
An interesting side note, the Ruby on Rails guides includes an
`og:title` but not an `og:url` so we hit the fallback condition. Could
we use the given URL if `og:url` does not exist?
Fixesforem/forem#17679
* complete IG implementation of profile embed, refactors, update specs
* Follow redirects and check them for validity via recursion
* working out redirects
* add IG test links with params
Co-authored-by: Dwight Scott <dwight@forem.com>
* move script to packs, strip ids
* make sure userdata is available before determining ui
* stop working around old html, fix duplicate ID errors
* skip login modal
* remove DEV hard coding
* replace system spec with cypress spec
* update base_data to include apple auth info, add to cypress tests
* add initial version of DUS to resave HTML
* remove data update script
* new liquid tag - dotnetfiddle
* 1. Moved the hack into controller
2. Use URI to check if Widget keyword doesn't exist, then insert Widget using URI
* 1. Fixed tests
2. Updated code to eliminate xss_attacks
* Update app/liquid_tags/dotnet_fiddle_tag.rb to match pr comment
Co-authored-by: Michael Kohl <me@citizen428.net>
Co-authored-by: Michael Kohl <me@citizen428.net>
* Add a Liquid Tag specifically for Twitch clips.
These will embed Twitch Clips in articles and comments.
* Update documentation to incorporate Twitch clip liquid tags.
* Include Twitch Clips in video embed logic
* Making a small change to rebuild
* Add stackery liquid tag
* Refactor stackery liquid tag
* Docs for stackery liquid tag
* Add stackery liquid tag tests
* Remove Github API check from stackery liquid tag
* Minor PR comment tweaks
* Update user subscription user tag styling
* Update notice styling
* Refactor toggle visibility
* Update profile image styling
* Refactor JS & CSS updates
* Show state in Preview of liquid tag
* Implement Reddit liquid tag
* Set reddit content in locals
* Change Reddit liquid tag content layout
I decided a UI similar to the Stack Exchange tag would be better.
Now the Reddit tag looks a bit similar.
* Add tests for RedditTag
* Add reddit liquid tag example to docs
Also emphasize notice about compilation of article when using any
liquid tag
* Parse markdown text reddit content for RedditTag
* Display date RedditTag post was published
* Remove file location comments
* Change order of conditional for Reddit liquid tag
Sometimes the attribute `post_hint` might be null and neither condition
would apply.
* Add example to use Reddit liquid tag
* Change reddit svg icon for Reddit liquid tag
* handle and verify status of Reddit links
Here we make sure the passed link is a valid one in terms of URI composition (e.g. protocol)
but also that the URL is one that points to existing content in Reddit.
If the URL isn't returning anything but a successful response code (200) then
we treat it as an invalid one.
* Do not use VCR for RedditTag specs
The generated cassette for this tag was really huge (6000+ lines).
Using mocks (as in the MediumTag spec) still does the job and without
that huge VCR file.
* Remove index line from schema.db
* Improve RedditJsonFromUrlService
- Change User-Agent in requests to one read from app configuration
- Remove Reddit URL check by making a GET request
- Add regexp to validate URL looks like a Reddit URL
* Move RedditJsonFromUrlService methods to RedditTag
Also changed the way the request was being mocked. Previously, it was by
mocking the service class now I'm mocking HTTParty directly and returning
the JSON structure Reddit uses.
* Fix Runkit tags not being activated when comment is added
* Runkit tag activation was ran once, on page load. I've changed it to
run on on comment preview and submit.
* It was necessary to add a check to skip already activated Runkit
tags. The code didn't take into account that a tag could be already
processed, and would just crash.
* Fix Runkit tags and add tests
* Add test for previewing article with Runkit tag
* "Fix CodeClimate not finding waitForRunkitAndActivateTags()
* Refactor a test for readability
* Make Rubocop happy
* Improve test for previewing article with Runkit tag
* Use one method for determining active Runkit tags
* Defer loading of JS from embed.runkit.com
* Add utility function dynamicallyLoadScript(url)
* Switch to dynamic loading of Runkit
* parsed content code block is also hidden now to avoid displaying <code /> block before runkit iframe loads.
* Fix Runkit test
* Remove Runkit script caching in v2 form
* Use <%== instead of .html_safe in v2 form
* Update app/assets/javascripts/utilities/dynamicallyLoadScript.js
Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
* Request change
- Added specific error message
- changed jsitor to JSitor
- changed JSITOR_URL constant to URL_REGEXP
- added space between URL_REGEXP and initialize method
* created jsitor liquid tag
- created a jsitor_tag.rb for jsitor liquid core
- created partial (_jsitor.html.erb) for jsitor liquid tag
* created test for jsitor liquid tag
- created spec for jsitor liquid tag
- generated jsitor_liquid_tag.approved.html
* added suggestion change
- removed regex
- change the full link to embeddable id
- removed dead code(methods) due to change logic
- removed checking of link since embeddable id will be parse as string
- removed parts of the test
- change the guide explanation
* Added lazy loading on iframe
