maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix image assets in tweets and remove like/retweet counts (#12327)

Browse source
This commit is contained in:
Ben Halpern 2021-01-19 10:30:38 -05:00 • committed by GitHub
parent db335ff84b
commit ed04875074
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 49 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/views/liquids/_tweet.html.erb
View file

@ -60,16 +60,14 @@
<div class="ltag__twitter-tweet__actions">
<a href="https://twitter.com/intent/tweet?in_reply_to=<%= id %>" class="ltag__twitter-tweet__actions__button">
<img src="/assets/twitter-reply-action.svg" alt="Twitter reply action">
<img src="<%= ActionController::Base.helpers.asset_path("twitter-reply-action.svg") %>" alt="Twitter reply action">
</a>
<a href="https://twitter.com/intent/retweet?tweet_id=<%= id %>" class="ltag__twitter-tweet__actions__button">
<img src="/assets/twitter-retweet-action.svg" alt="Twitter retweet action">
<img src="<%= ActionController::Base.helpers.asset_path("twitter-retweet-action.svg") %>" alt="Twitter retweet action">
</a>
<%= tweet.retweet_count.to_s %>
<a href="https://twitter.com/intent/like?tweet_id=<%= id %>" class="ltag__twitter-tweet__actions__button">
<img src="/assets/twitter-like-action.svg" alt="Twitter like action">
<img src="<%= ActionController::Base.helpers.asset_path("twitter-like-action.svg") %>" alt="Twitter like action">
</a>
<%= tweet.favorite_count.to_s %>
</div>
</div>
</blockquote>

44
spec/support/fixtures/approvals/liquid_tweet_tag_spec.approved.html
View file

@ -1,44 +0,0 @@
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<body>
<blockquote class="ltag__twitter-tweet" data-url="https://twitter.com/thepracticaldev/status/1018911886862057472">
<div class="ltag__twitter-tweet__media ltag__twitter-tweet__media__video-wrapper">
<div class="ltag__twitter-tweet__media--video-preview">
<img src="https://pbs.twimg.com/tweet_video_thumb/DiPm8-WXcAI3_qS.jpg" alt="unknown tweet media content" /><img src="/assets/play-butt.svg" class="ltag__twitter-tweet__play-butt" alt="Play butt" /></div>
<div class="ltag__twitter-tweet__video">
<video loop="" controls=""><source src="https://video.twimg.com/tweet_video/DiPm8-WXcAI3_qS.mp4" type="video/mp4"></source></video></div>
</div>
<div class="ltag__twitter-tweet__main" data-url="https://twitter.com/thepracticaldev/status/1018911886862057472">
<div class="ltag__twitter-tweet__header">
<img class="ltag__twitter-tweet__profile-image" src="https://pbs.twimg.com/profile_images/1002604104194056192/IEoNsLNM_normal.jpg" alt="The Practical Dev profile image" /><div class="ltag__twitter-tweet__full-name">
The Practical Dev
</div>
<div class="ltag__twitter-tweet__username">
@thepracticaldev
</div>
<div class="ltag__twitter-tweet__twitter-logo">
<img src="/assets/twitter-99c56e7c338b4d5c17d78f658882ddf18b0bbde5b3f42f84e7964689e7e8fb15.svg" alt="twitter logo" /></div>
</div>
<div class="ltag__twitter-tweet__body">
When GitHub goes down
</div>
<div class="ltag__twitter-tweet__date">
02:34 AM - 17 Jul 2018
</div>
<div class="ltag__twitter-tweet__actions">
<a href="https://twitter.com/intent/tweet?in_reply_to=1018911886862057472" class="ltag__twitter-tweet__actions__button">
<img src="/assets/twitter-reply-action.svg" alt="Twitter reply action" /></a>
<a href="https://twitter.com/intent/retweet?tweet_id=1018911886862057472" class="ltag__twitter-tweet__actions__button">
<img src="/assets/twitter-retweet-action.svg" alt="Twitter retweet action" /></a>
91
<a href="https://twitter.com/intent/like?tweet_id=1018911886862057472" class="ltag__twitter-tweet__actions__button">
<img src="/assets/twitter-like-action.svg" alt="Twitter like action" /></a>
276
</div>
</div>
</blockquote>
</body>
</html>