maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
9005 commits 1 branch 0 tags 1.6 GiB
Commit graph

9005 commits

This branch
This branch
All branches
Author SHA1 Message Date
Ridhwana
27eda9ca3d
chore: uncomment the test (#13658) 2021-05-05 19:00:15 +02:00
Jamie Gaskins
a2da070ca4
Handle GitHub "Repository access blocked" error (#13648) 
* Handle GitHub "Repository access blocked" error

We've been seeing a lot of these errors on DEV, and it's a pretty
reasonable expectation that if we're being blocked from seeing them
using the user's OAuth access token that this isn't temporary.

* Re-raise so we don't swallow this error

* Constant name != company name???!?!?!
 2021-05-05 12:48:46 -04:00
Andy Zhao
9970b1c2d5
Auto generate profile image for email signups (#13635) 
* Add required tooltips and asterisks to fields

* Generate profile image for email signups

* Use be over eq

Co-authored-by: Michael Kohl <citizen428@dev.to>

* Use path helpers over hard-coded paths

Co-authored-by: Michael Kohl <citizen428@dev.to>

* Add labels to make it more accessible

* Stub it all... eek

* stub some more stuff

* stub stub stub

* Move aria label to proper label and fix tests

Co-authored-by: Michael Kohl <citizen428@dev.to>
 2021-05-05 12:08:24 -04:00
dependabot[bot]
d1bc35d0d2
Bump rubocop-performance from 1.11.1 to 1.11.2 (#13654) 
Bumps [rubocop-performance](https://github.com/rubocop/rubocop-performance) from 1.11.1 to 1.11.2.
- [Release notes](https://github.com/rubocop/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-performance/compare/v1.11.1...v1.11.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-05-05 16:53:04 +02:00
dependabot[bot]
1b21d90a90
Bump bootsnap from 1.7.4 to 1.7.5 (#13656) 
Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.7.4 to 1.7.5.
- [Release notes](https://github.com/Shopify/bootsnap/releases)
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.7.4...v1.7.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-05-05 16:51:22 +02:00
Fernando Valverde
121603a44b
Replace Pusher Beams with Rpush PN delivery ✂️ ✂️ (#13588) 
* Remove feature flag

* Remove Pusher Beams implementation

* Remove Pusher Beams require from initializer

* Adds consumer apps to sidebar + consider :admin_restructure

* Fix routes + PN target URL

* Remove old file that sneaked in

* Adds docs

* docs tweaks

* Apply suggestions from code review

Co-authored-by: rhymes <rhymes@hey.com>

Co-authored-by: rhymes <rhymes@hey.com>
 2021-05-05 08:37:20 -06:00
Ridhwana
355d510f88
refactor: inline the ERB template instead of passing via a data-path (#13657) 2021-05-05 16:00:39 +02:00
Alex
a0ddb6a848
Cleanup search classes and serializers (#13645) 2021-05-05 09:20:59 -04:00
Rafi
41cc771839
Refactoring help component (and fragmenting it too) (#10895) 
* Refactoring Help component

* Fixing typo

* Adding missing prop types

* Removing setCommonProps

* Moving show to parent component

* Renaming Format component

* Converting help component to functional component

* Removing html from state

* Fixing modal toggle and eslint errors

* Adding arria hidden

* Using optional chaining

* Fixing variable names

* Renaming state variable

* Adding jsdoc

Co-authored-by: Nick Taylor <nick@dev.to>
 2021-05-05 12:58:40 +07:00
Jacob Herrington
e8df3b0915
Add safe navigation operator to stop 500 errors (#13646) 2021-05-04 11:37:37 -04:00
dependabot[bot]
fc88db1f67
Bump stackprof from 0.2.16 to 0.2.17 (#13643) 
Bumps [stackprof](https://github.com/tmm1/stackprof) from 0.2.16 to 0.2.17.
- [Release notes](https://github.com/tmm1/stackprof/releases)
- [Changelog](https://github.com/tmm1/stackprof/blob/master/CHANGELOG.md)
- [Commits](https://github.com/tmm1/stackprof/compare/v0.2.16...v0.2.17)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-05-04 16:09:19 +02:00
Jamie Gaskins
956ddefbbd
Add M1 architecture to Gemfile.lock (#13636) 2021-05-04 10:00:26 -04:00
Alex
675b5fc5b6
Cleanup unused DataUpdateScripts (#13640) 2021-05-04 09:19:24 -04:00
Suzanne Aitchison
ad43dbe0b3
Add prefer object destructuring lint rule (#13183) 
* add prefer object destructuring lint rule

* fix typo

* sweep up lint errors missed in config controller

* Revert "fix typo"

This reverts commit 44f9d57e3f0dc4007ab9020c8c659c2f770230c2.

* Revert "sweep up lint errors missed in config controller"

This reverts commit 3f8d5d782fe110607c2172b713c74c08c883eda3.

* make this a warning rather than error for now

* undo auto change
 2021-05-04 12:10:32 +01:00
Michael Kohl
aee05b4597
Retain registration form data on failed submission (#13614) 
* Retain registration form data on failed submission

* Remove unnecessary command

* Apply suggestions from code review

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

* Fix e2e test

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
 2021-05-04 10:52:20 +07:00
Jacob Herrington
198f778b32
Rename profile header partial (#13639) 
This partial is not actually rendered on the user profile, it is only
used by organizations. Moving it to the directory where other
organization-specific partials live!
 2021-05-03 18:36:24 -05:00
dependabot[bot]
0e5c680cf8
Bump @babel/core from 7.13.16 to 7.14.0 (#13634) 
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.13.16 to 7.14.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.14.0/packages/babel-core)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-05-03 14:53:56 -07:00
Nick Taylor
eb9fdce52a
Disable Cypress's video feature (#13638) 
Co-authored-by: Mac Siri <krairit.siri@gmail.com>
 2021-05-03 17:43:19 -04:00
dependabot[bot]
17f2dd187a
Bump @testing-library/user-event from 13.1.5 to 13.1.8 (#13629) 
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event) from 13.1.5 to 13.1.8.
- [Release notes](https://github.com/testing-library/user-event/releases)
- [Changelog](https://github.com/testing-library/user-event/blob/master/CHANGELOG.md)
- [Commits](https://github.com/testing-library/user-event/compare/v13.1.5...v13.1.8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-05-03 14:23:32 -07:00
Daniel Uber
73529e71eb
Specify body and title of listings that shouldn't match a term (#13633) 
Noticed the Faker book title included "No Country for Old Men" which
caused a failure expecting search for "old" to be empty (you can set
the title in the let block to replicate this).

Choose title and body that do not include "old" in order to prevent
false failures.
 2021-05-03 15:47:12 -05:00
Mac Siri
25f6b3e9ed
Convert SMTP configs into environments vars (#13542) 
Co-authored-by: rhymes <rhymes@hey.com>
 2021-05-03 16:32:15 -04:00
Daniel Uber
4225819ae0
Fixes flaky spec (#13637) 
When we call Hash.dup the values pointed to by the keys are not
duplicated (the hash is, but the keys and values are the same).

Because the FeatureFlag enabled path is mutating the values, this is
interacting during tests.

`deep_dup` the ITEMS hash before mutating when the either of the two
menu item feature flags are enabled.
 2021-05-03 15:06:18 -05:00
dependabot[bot]
e96fad2c14
Bump core-js from 3.11.0 to 3.11.2 (#13625) 2021-05-03 15:29:14 -04:00
Suzanne Aitchison
ef70d1f92b
fix accessible names of sign up options (#13620) 2021-05-03 11:06:45 -07:00
dependabot[bot]
bd7c8b2f12
Bump ibm-openapi-validator from 0.43.0 to 0.44.0 (#13626) 
Bumps [ibm-openapi-validator](https://github.com/IBM/openapi-validator) from 0.43.0 to 0.44.0.
- [Release notes](https://github.com/IBM/openapi-validator/releases)
- [Changelog](https://github.com/IBM/openapi-validator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/IBM/openapi-validator/compare/v0.43.0...v0.44.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-05-03 11:05:54 -07:00
dependabot[bot]
66caddc2e9
Bump @babel/preset-env from 7.13.15 to 7.14.0 (#13618) 
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.13.15 to 7.14.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.14.0/packages/babel-preset-env)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-05-03 11:05:42 -07:00
dependabot[bot]
5752e878ed
Bump sass from 1.32.11 to 1.32.12 (#13615) 
Bumps [sass](https://github.com/sass/dart-sass) from 1.32.11 to 1.32.12.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/dart-sass/compare/1.32.11...1.32.12)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-05-03 11:05:30 -07:00
Alex
f071691b37
Add no-op Search::IndexWorker (#13630) 2021-05-03 12:45:41 -04:00
Rafi
ca50e5750e
Fixing dom structure of Tags to follow (#13184) 
* Using buttons instead of checkbox

* Adding svg icon

* Update app/javascript/onboarding/components/FollowTags.jsx

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

* Adding condition for crayons-btn-icon-left

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
 2021-05-03 17:20:26 +01:00
dependabot[bot]
1aebf4eb57
Bump eslint-plugin-no-only-tests from 2.5.0 to 2.6.0 (#13616) 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
 2021-05-03 11:16:29 -05:00
Jacob Herrington
bb9780ff3d
Remove references to social link profile fields (#13252) 
* Remove references to social link profile fields

* Add some dummy data

* Remove special display social links

* Remove unnecessary tests

* Add tests for profile social icons

* PR feedback

* Remove nil check from erb

* Move view method into helper

* Don't render links in user settings
 2021-05-03 10:16:02 -05:00
Alex
393ba00221
Remove Elasticsearch ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ ✂️ (#13606) 
* Attempt number 1

* Fix rack_attack specs

* Fix users_searches_users spec

* Fix display_users_search_spec

* Fix comment typo

* Remove search:destroy task from cypress

* Remove port 9300 from gitpod

* Stub response in attack_spec
 2021-05-03 11:09:45 -04:00
dependabot[bot]
b9ecfef149
Bump chart.js from 3.2.0 to 3.2.1 (#13624) 
Bumps [chart.js](https://github.com/chartjs/Chart.js) from 3.2.0 to 3.2.1.
- [Release notes](https://github.com/chartjs/Chart.js/releases)
- [Commits](https://github.com/chartjs/Chart.js/compare/v3.2.0...v3.2.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-05-03 09:28:30 -05:00
dependabot[bot]
89feb4ab8a
Bump test-prof from 1.0.2 to 1.0.3 (#13621) 
Bumps [test-prof](https://github.com/test-prof/test-prof) from 1.0.2 to 1.0.3.
- [Release notes](https://github.com/test-prof/test-prof/releases)
- [Changelog](https://github.com/test-prof/test-prof/blob/master/CHANGELOG.md)
- [Commits](https://github.com/test-prof/test-prof/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-05-03 09:06:12 -05:00
dependabot[bot]
20369e07b9
Bump rubocop-performance from 1.11.0 to 1.11.1 (#13622) 
Bumps [rubocop-performance](https://github.com/rubocop/rubocop-performance) from 1.11.0 to 1.11.1.
- [Release notes](https://github.com/rubocop/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-performance/compare/v1.11.0...v1.11.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-05-03 09:05:26 -05:00
Ridhwana
ba5c97de50
RFC 50 - Remove old admin routes and related code (#13579) 
* chore: remove current_admin routes file

* feat: move all the admin routes into the admin file

* chore: remove conditionals for the sidebar and tabbed navbar

* remove some more notes where we use the admin_restructure feature flag

* chore: amend the tests now that the old routes and the admin_restructure flag are removed

* chore: remove more references to the  admin_restructure flag

* chore: fix the tests

* chore: remove sidebar_spec

* chore: add slash back

* chore: comment it out for now whilst I try and figure out why its not passing
 2021-05-03 16:03:38 +02:00
dependabot[bot]
fb29a9cf54
Bump cypress-file-upload from 5.0.6 to 5.0.7 (#13619) 
Bumps [cypress-file-upload](https://github.com/abramenal/cypress-file-upload) from 5.0.6 to 5.0.7.
- [Release notes](https://github.com/abramenal/cypress-file-upload/releases)
- [Commits](https://github.com/abramenal/cypress-file-upload/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-05-03 14:02:12 +01:00
Suzanne Aitchison
024cf391d3
15 min fix try to stablise flakey test (#13609) 2021-05-03 13:41:28 +01:00
Olawale Oyeyipo
2be1073131
Improve bash info for windows user (#13607) 
* Improve bash info for windows user

* Update grammar

* Fix typo
 2021-05-03 11:42:15 +00:00
Suzanne Aitchison
4aebfb62f2
Improve keyboard accessibility of comment rate limit and error modals (#13536) 
* add modal code to Forem namespace, use showModal in the rate limit modal generator

* add cypress tests for both modals

* styling tweaks

* tidy up

* make sure modal trap selector is unique to page, update Modal JSDoc

* add additional jest test for focusTrapSelector
 2021-05-03 07:14:23 +01:00
Michael Kohl
c5598816ac
[15 minute fix] Remove secondary logo (#13595) 2021-05-03 09:35:10 +07:00
Suzanne Aitchison
1868537294
fix some landmark issues in listings (#13602) 2021-04-30 18:34:27 +02:00
Suzanne Aitchison
abe8492389
fix a timing issue in a cypress test (#13603) 2021-04-30 17:47:38 +02:00
dependabot[bot]
0c7cd1f3f8
Bump devise from 0cd72a5 to 4.8.0 (#13596) 
Bumps [devise](https://github.com/plataformatec/devise) from 0cd72a5 to 4.8.0. This release includes the previously tagged commit.
- [Release notes](https://github.com/plataformatec/devise/releases)
- [Changelog](https://github.com/heartcombo/devise/blob/master/CHANGELOG.md)
- [Commits](0cd72a56f9...v4.8.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-04-30 17:43:49 +02:00
Jamie Gaskins
8c9a0dc55a
Only migrate config vars that were explicitly set (#13593) 2021-04-30 10:15:33 -04:00
Jacob Herrington
69f4c039da
Add href for open reports (#13592) 2021-04-30 09:07:24 -05:00
Suzanne Aitchison
ce689ab0c7
15 min fix: make sure autocomplete dropdown occupies width (#13600) 
* 15 min fix: make sure dropdown occupies width

* set width instead, with comment to explain
 2021-04-30 14:11:31 +01:00
Alex
c88fc5d233
[Search 2.0] Remove remaining search_2 feature flags (#13591) 
* Remove remaining search_2 feature flags

* Fix specs

* Fix more specs

* Remove leftovers

Co-authored-by: rhymes <rhymes@hey.com>
 2021-04-30 09:02:35 -04:00
rhymes
5a1034cab6
[Search 2.0] Add index on articles.comments_count (#13599) 2021-04-30 09:02:27 -04:00
Suzanne Aitchison
2e9ba2334a
15 min fix for chart js errors (#13598) 2021-04-30 13:28:20 +01:00