maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

15 min fix for chart js errors (#13598)

Browse source
This commit is contained in:
Suzanne Aitchison 2021-04-30 13:28:20 +01:00 • committed by GitHub
parent 320eb86dc2
commit 2e9ba2334a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
app/javascript/analytics/dashboard.js
View file

@ -1,5 +1,7 @@
import { callHistoricalAPI, callReferrersAPI } from './client';
const activeCharts = {};
function resetActive(activeButton) {
const buttons = document.querySelectorAll(
'.crayons-tabs--analytics .crayons-tabs__item',
@ -40,7 +42,7 @@ function writeCards(data, timeRangeLabel) {
followerCard.innerHTML = cardHTML(follows, `Followers ${timeRangeLabel}`);
}
function drawChart({ canvas, title, labels, datasets }) {
function drawChart({ id, title, labels, datasets }) {
const options = {
plugins: {
legend: {
@ -82,8 +84,14 @@ function drawChart({ canvas, title, labels, datasets }) {
LineElement,
Legend,
);
const currentChart = activeCharts[id];
if (currentChart) {
currentChart.destroy();
}
const canvas = document.getElementById(id);
// eslint-disable-next-line no-new
new Chart(canvas, {
activeCharts[id] = new Chart(canvas, {
type: 'line',
data: {
labels,
@ -107,7 +115,7 @@ function drawCharts(data, timeRangeLabel) {
const readers = parsedData.map((date) => date.page_views.total);
drawChart({
canvas: document.getElementById('reactions-chart'),
id: 'reactions-chart',
title: `Reactions ${timeRangeLabel}`,
labels,
datasets: [
@ -147,7 +155,7 @@ function drawCharts(data, timeRangeLabel) {
});
drawChart({
canvas: document.getElementById('comments-chart'),
id: 'comments-chart',
title: `Comments ${timeRangeLabel}`,
labels,
datasets: [
@ -163,7 +171,7 @@ function drawCharts(data, timeRangeLabel) {
});
drawChart({
canvas: document.getElementById('followers-chart'),
id: 'followers-chart',
title: `New Followers ${timeRangeLabel}`,
labels,
datasets: [
@ -179,7 +187,7 @@ function drawCharts(data, timeRangeLabel) {
});
drawChart({
canvas: document.getElementById('readers-chart'),
id: 'readers-chart',
title: `Reads ${timeRangeLabel}`,
labels,
datasets: [