Commit graph

7263 commits

Author SHA1 Message Date
Yih Yang
24a4a421e1
removed envied docs (#11160)
* removed envied docs

* updated linux.md and windows.md

* removed envied documentation from windows.md and linux.md
2020-10-30 10:38:38 -04:00
rhymes
51a4a35448
Add Feeds::Import service class (#10998)
* Add the parallel gem

* Add prototype version of Feeds::Import with parallel URL fetching and parsing

* Tune Feeds::Import and add rake task for local tests

* Add rough measurer tool

* Add specs

* Apply suggestions by @citizen428

* Replace silence with silent

* No need for eager loading

* Add temporary Articles::DevFeedsImportWorker

* Remove temporary rake task

* Add basic error handling, copied from RssReader

* Fix error handling

* Remove temporary measuring rake task

* Remove logging added for development purposes

* Add info and error logging on error level
2020-10-30 15:01:44 +01:00
ludwiczakpawel
ca258a6f74
Profile dropdown updates (#11184)
* tooltips 1.0.1

* tooltips 1.0.1

* dropdown fun
2020-10-30 15:00:07 +01:00
ludwiczakpawel
4667821962
Notifications fixes (#11180)
* tooltips 1.0.1

* tooltips 1.0.1

* figure out cache..?

* text wrapping

* responsive avatars

* responsive avatars
2020-10-30 14:52:58 +01:00
Michael Kohl
32f2b2d58f
Automatically mark tag supported when adding mod (#11151)
* Automatically mark tag a supported when adding mod

* Add data update script
2020-10-30 09:46:10 -04:00
rhymes
caad342033
Small Rubocop fixes (#11182) 2020-10-30 14:45:55 +01:00
Rafal Trojanowski
4bc8b80a90
Introduce tweet_timeline liquid tag (#7605) (#10825) 2020-10-30 11:03:40 +01:00
Molly Struve
de94a3fb9d
[deploy] Schema Fix:Removed accidentally added changes (#11168) 2020-10-29 16:14:00 -05:00
Christina
473c2ccb8d
Removing ElasticSearch Brew instructions (#10370)
* Removing ElasticSearch Brew instructions

If you try to install brew as directed you get this Error:
Error: Calling Installation of elasticsearch-oss from a GitHub commit URL is disabled! Use 'brew extract elasticsearch-oss' to stable tap on GitHub instead.

Brew/ElasticSearch no longer allows you to tap as we previously have suggested in the doc. Also we can no longer grab the 7.5.2 version with brew. 

We have decided to remove the instructions for now until we upgrade ElasticSearch if possible.

* Adding recommended changes. 

Added back line 15 per Nicks recommendation
 (i.e. with rbenv: `rbenv install $(cat .ruby-version)`)

Line 65 
updated to  7.5 or higher for Elasticsearch per Rhymes recommendation
~Forem requires a version of Elasticsearch 7.5 or higher to be running.  We recommend version 7.5.2.~

Line 110 update:
Added back in the Homebrew instructions but updated commands to `install elastic/tap/elasticsearch-oss`

* Updating wording per Molly's suggestion

Updating "to be running " to "run" and adjusting line 64 to "Forem requires Elasticsearch 7.x to run. We recommend version 7.5.2."
2020-10-29 14:25:56 -06:00
ludwiczakpawel
5d3691bcc5
Notifications redesign (#11084)
* notifications

* fix

* .

* REVERT

* .

* drop ccss

* REVERT

* specs

* drop colons

* fixse

* fix

* spec 1

* eh

* Fix notification specs

Co-authored-by: Molly Struve <mollylbs@gmail.com>
2020-10-29 20:38:17 +01:00
Arit Amana
e00cb5df17
[Team Email Login] Genericize AdminConfig Modal (#11145)
* Genericize AdminConfig Modal

* Rename function, add JSDoc documentation

* Tests for modal-building function

* Still trying to get jest test to pass

* Fix failing jest test
2020-10-29 15:01:37 -04:00
Molly Struve
3c6b8adc3c
[deploy] Refactor:Remove Rails Env Prod Check when Setting Shell Version (#11162) 2020-10-29 12:44:01 -05:00
Yih Yang
01a57fed8f
fixed docs url (#11161) 2020-10-29 13:11:21 -04:00
Julianna Tetreault
6f4e600a4e
Refactor Admin Events Index (#11103) [deploy]
* Adds new and edit views for events and removes them from the index view

* Fixes formatting issues in /admin/pages/index.html.erb

* Refactors /admin/events partial, new, and edit forms

* Updates admin_events routes to include all routes except destroy

* Refactors Admin::EventsController and adds #new and #edit actions

* specs: Adjusts admin_creates_new_event_spec to work with /admin/event changes

* Refactors the Admin::EventsController, routes, and events index even further
  - Adds back placeholder text in Events form
  - Removes unnecessary code from controller
  - Reverts changes to routes
  - Adjusts event_cover_image size on index.html.erb

* specs: Adds tests around creating and updating events to events_spec

* Adds pagination to Admin::EventsController #index to cap events at 20 per page

* Removes .all from Admin::EventsController and adds a line to index.html.erb

* Uses crayons classes for _event_form.html.erb
2020-10-29 10:11:15 -06:00
WenYu
5a617f7340
Fix backend link (#11152)
Backend guide link currently leads to a Github 404 page. This commit fix the issue and redirects to the correct backend guide link
2020-10-29 10:14:44 -05:00
dependabot-preview[bot]
44a9bb2655
Bump @storybook/addon-storysource from 6.0.26 to 6.0.27 (#11068)
Bumps [@storybook/addon-storysource](https://github.com/storybookjs/storybook/tree/HEAD/addons/storysource) from 6.0.26 to 6.0.27.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.0.27/addons/storysource)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-29 15:36:55 +01:00
Alex
94cd9e246f
[deploy] Add default for main_social_image (#11126)
* Add default for main_social_image

* Fix image URL and add spec

* Fix spec

* Move image_url helper into image module

* Fix typo in comment

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Change URL helper logic

* Try something else

* Use ApplicationConfig

* Refactor

* Try again

* Try again with another approach

* Add specs for URL.local_image

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-10-29 10:07:14 -04:00
ludwiczakpawel
dc3bcd8913
Drop custom color pickers (#11154)
* tooltips 1.0.1

* tooltips 1.0.1

* drop custom js color picker
2020-10-29 14:35:47 +01:00
WenYu
e0e410e9e2
Refactor Reaction model (#11138)
Deleted unused methods that are not found/used across the repository in the Reaction model
2020-10-29 14:25:43 +01:00
Mac Siri
540bc1fd84
[deploy] Add Imgproxy docs (#11104)
Co-authored-by: Molly Struve <mollylbs@gmail.com>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-10-29 09:03:55 -04:00
ludwiczakpawel
1636bdf4c8
Autoresize on comment textarea + comment submit on CMD/CTRL+Return (#11115)
* .

* whoops

* revert typo

* Handle glitches and edge cases.

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-10-29 09:33:11 +01:00
Rafi
52f2627e6c
Refactoring EditorAction (#10894)
* Refactoring EditorAction

* Removing useCallback

* Renaming variables to isVersionX
2020-10-29 09:06:30 +01:00
Molly Struve
f97c822570
[deploy] Refactor: Run Display Ad Events Controller in all Envs (#11144) 2020-10-28 17:15:43 -05:00
WenYu
0067a2124c
Refactor UsersController (#11143)
* Refactor UsersController

Removed unused method #less_than_one_day_old? and refactor a few lines of code

* Undo reduce
2020-10-28 13:41:33 -06:00
Jacob Herrington
8f5954aeb8
[deploy] Improve error messages and validation for admin pages (#11141)
* Improve error messages and validation for pages

This could probably be cleaner, but I wanted to avoid changing behavior,
so there is a bit of redundancy.

In this commit, I also had to convert an if statement to a case
statement for Rubocop.

* Add system spec for editing pages

* Use errors_as_sentence
2020-10-28 13:54:38 -05:00
Mac Siri
8ba2c03360
[deploy] Encode domain name in pusher channels (#11136)
Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
2020-10-28 14:52:38 -04:00
Ben Halpern
034b049e3d
Add email to safe_params (#11135) 2020-10-28 13:46:54 -04:00
Arit Amana
1912ffdc46
[Team Email Login] Refactor the Email Authentication flow (#11090)
* Hooked "Enable" button to hidden checkbox

* Hooked "Close" button to close email settings and show "Enable/Edit" button

* Additional hookups

* Start building generalized Modal blocks

* Everything hooked up except styling and a few Qs

* last of the hookups; ensure logic flow

* clean up

* specs to cover email auth refactor

* Fix bug surfaced by Vaidehi

* Incorporate PR feedback

* prevent email auth disable if invite-only-mode

* adjust emailAuthModal body text

* Sundry improvements

* Last-mile tweaks

* Trying to get 3rd party auth deselect to work

* delete unnecssary function

* remove superfluous comment

* Move inline styling into CSS file

* Incorporate PR feedback

* Incorporate more PR feedback

* Make Confirm btn intent clearer

* Add TODO comment
2020-10-28 13:37:11 -04:00
y yam
fc22e2c4ae
Add admin config to always show manually selected users on "Suggested people to follow" list (#10917) [deploy]
* Fix missing spaces in description of suggested_users

* Add config to use suggested_users instead of auto-generated suggestions

* Improve determine_follow_suggestions method

* Update app/lib/constants/site_config.rb

Improve the wording of the description of prefer_manual_suggested_users

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Apply new style to prefer_manual_suggested_users checkbox

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-10-28 10:36:49 -07:00
Ben Halpern
531f26bad6
Add admin shortcut to tag page (#11092)
* Add admin shortcut to tag page

* Fix spec

* Add more check

* Change admin location
2020-10-28 12:19:21 -04:00
Ben Halpern
0847c38196
[deploy] Enable Puma's nakayoshi_fork feature (#11121)
* Run GC.compact before fork

* Change to nakayoshi_fork
2020-10-28 09:22:44 -04:00
Molly Struve
ea156a201d
[deploy] Optimization:Remove more_tag_weight_experiment From Feed Tests (#11089) 2020-10-27 16:36:53 -05:00
WenYu
b0ee1c3905
Refactor articles_controller (#11122)
Refactor unless statement and remove unused variables from controller
2020-10-27 17:34:52 -04:00
Krzysztof Rybka
75fe6fd245
Extract dashboard posts sort options to a constant (#11123) 2020-10-27 16:09:08 -04:00
Jacob Herrington
d479834344
Do not set SiteConfig values in specs (#11125) 2020-10-27 15:56:31 -04:00
Rafi
c9014a7835
Removing email prop and fixing test (#11108) 2020-10-27 15:38:31 -04:00
dependabot-preview[bot]
651f55b331
Bump @babel/plugin-transform-react-jsx from 7.10.4 to 7.12.1 (#11066)
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-27 13:15:00 -04:00
Molly Struve
9af35bed0a
[deploy] Optimization:Limit Tags Searched For Follow Suggestions (#11095) 2020-10-27 11:58:54 -05:00
Jacob Herrington
c91c07920f
Add config option for Forem collective noun (#11107)
Not everyone will want to use "Community" to describe their Forem, so
now they have some flexibility there.
2020-10-27 12:45:52 -04:00
ludwiczakpawel
7f08ff2b93
zen mode fix (#11114) 2020-10-27 12:44:28 -04:00
Robin Gagnon
10d7da2878
feat: Add shortcut to bookmark an article (#11116) 2020-10-27 12:44:03 -04:00
Antony Garand
963f4da743
Updated gitdocs.json links to https (#11118) 2020-10-27 12:19:03 -04:00
Lisa Sy
126c2401e3
Improve small screen display of Mod Center (#10621) [deploy]
* Add page-header padding and overflow-x for tabs

* Split into two moderator files and move into Views folder

* Add page-header padding style

* Increase font size of crayons-tag on small screen

* Improve small screen view of menu and grid rows in mod center

* Fix date alignment

* Update after first PR revision

* Re-update

* Fix stylesheet reference
2020-10-27 07:46:52 -07:00
ludwiczakpawel
125584d354
Tooltips & Required fields (#11112)
* add tooltip component

* crayons doc

* z-index

* one less call

* doc
2020-10-27 15:24:22 +01:00
dependabot-preview[bot]
5992be2201
Bump @babel/preset-env from 7.11.5 to 7.12.1 (#11072)
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.11.5 to 7.12.1.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.1/packages/babel-preset-env)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-27 14:54:01 +01:00
dependabot-preview[bot]
9b7926cea2
Bump @storybook/addon-a11y from 6.0.22 to 6.0.27 (#11079)
Bumps [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/addons/a11y) from 6.0.22 to 6.0.27.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.0.27/addons/a11y)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-27 14:53:30 +01:00
Ben Halpern
d822d8d7d9
Fall back to configured social image instead of hardcoded (#9747)
* Fall back to configured social image instead of hardcoded

* Move from constant to method for config inclusion

* Fix spec

* Fix test
2020-10-27 08:54:45 -04:00
dependabot-preview[bot]
b8f6779ade
Bump @storybook/addon-actions from 6.0.26 to 6.0.27 (#11077)
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-26 23:05:23 -04:00
dependabot-preview[bot]
76af6b5e30
Bump jest from 26.5.3 to 26.6.1 (#11065)
Bumps [jest](https://github.com/facebook/jest) from 26.5.3 to 26.6.1.
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md)
- [Commits](https://github.com/facebook/jest/compare/v26.5.3...v26.6.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-26 20:28:27 -04:00
dependabot-preview[bot]
639939ed6f
Bump markdown-loader from 5.1.0 to 6.0.0 (#11078)
Bumps [markdown-loader](https://github.com/peerigon/markdown-loader) from 5.1.0 to 6.0.0.
- [Release notes](https://github.com/peerigon/markdown-loader/releases)
- [Changelog](https://github.com/peerigon/markdown-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/peerigon/markdown-loader/compare/v5.1.0...v6.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-10-26 20:26:59 -04:00