Commit graph

3723 commits

Author SHA1 Message Date
rhymes
241c39344e Destroy messages if chat channels are destroyed (#5498) 2020-01-14 09:46:40 -06:00
Anna Buianova
05884acd19 Fixed rubocop issues (#5506) 2020-01-14 09:45:26 -06:00
Andy Zhao
2d99ddba2d Add self to codeowners (#5501) 2020-01-14 10:00:19 -05:00
dependabot-preview[bot]
0c305c3347 Bump husky from 3.1.0 to 4.0.7 (#5482) [deploy]
Bumps [husky](https://github.com/typicode/husky) from 3.1.0 to 4.0.7.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](https://github.com/typicode/husky/compare/v3.1.0...v4.0.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 16:18:02 -06:00
dependabot-preview[bot]
1fed89ed02 Bump redoc-cli from 0.9.4 to 0.9.5 (#5481)
Bumps [redoc-cli](https://github.com/Redocly/redoc) from 0.9.4 to 0.9.5.
- [Release notes](https://github.com/Redocly/redoc/releases)
- [Changelog](https://github.com/Redocly/redoc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Redocly/redoc/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 16:10:45 -06:00
dependabot-preview[bot]
39f1f584bb Bump yard from 0.9.23 to 0.9.24 (#5488)
Bumps [yard](https://github.com/lsegal/yard) from 0.9.23 to 0.9.24.
- [Release notes](https://github.com/lsegal/yard/releases)
- [Changelog](https://github.com/lsegal/yard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/lsegal/yard/compare/v0.9.23...v0.9.24)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 15:55:09 -06:00
dependabot-preview[bot]
b01b1a514b Bump shoulda-matchers from 4.1.2 to 4.2.0 (#5493)
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers) from 4.1.2 to 4.2.0.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases)
- [Changelog](https://github.com/thoughtbot/shoulda-matchers/blob/master/NEWS.md)
- [Commits](https://github.com/thoughtbot/shoulda-matchers/compare/v4.1.2...v4.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 15:39:16 -06:00
dependabot-preview[bot]
1b38ab9cd7 Bump recaptcha from 5.2.1 to 5.3.0 (#5496)
Bumps [recaptcha](https://github.com/ambethia/recaptcha) from 5.2.1 to 5.3.0.
- [Release notes](https://github.com/ambethia/recaptcha/releases)
- [Changelog](https://github.com/ambethia/recaptcha/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ambethia/recaptcha/compare/v5.2.1...v5.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 15:38:37 -06:00
serena
6e9539415e Move welcome notification job to worker for Sidekiq (#5465) [deploy] 2020-01-13 13:28:23 -06:00
Alain Mauri
faa696444b Add Mentions::CreateAllWorker for Sidekiq (#5463) 2020-01-13 13:23:30 -06:00
Asha Balasubramaniam
61acfcd4c9 Remove Comments::SendEmailNotificationJob to send email notification on comment creation (#5446)
Follow up to https://github.com/thepracticaldev/dev.to/pull/5427
2020-01-13 13:19:48 -06:00
Lucas Hiago
1ed6aca54a Change Webhook::DestroyJob to Wehook::DestroyWorker and move to sidekiq (#5424) [deploy] 2020-01-13 12:38:10 -06:00
dependabot-preview[bot]
cf88f93874 Bump ddtrace from 0.30.1 to 0.31.0 (#5491)
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb) from 0.30.1 to 0.31.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases)
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md)
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.30.1...v0.31.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 12:34:54 -06:00
dependabot-preview[bot]
b3802368bc Bump honeybadger from 4.5.4 to 4.5.6 (#5492)
Bumps [honeybadger](https://github.com/honeybadger-io/honeybadger-ruby) from 4.5.4 to 4.5.6.
- [Release notes](https://github.com/honeybadger-io/honeybadger-ruby/releases)
- [Changelog](https://github.com/honeybadger-io/honeybadger-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/honeybadger-io/honeybadger-ruby/compare/v4.5.4...v4.5.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 12:34:28 -06:00
dependabot-preview[bot]
467e837492 Bump test-prof from 0.10.1 to 0.10.2 (#5487)
Bumps [test-prof](https://github.com/palkan/test-prof) from 0.10.1 to 0.10.2.
- [Release notes](https://github.com/palkan/test-prof/releases)
- [Changelog](https://github.com/palkan/test-prof/blob/master/CHANGELOG.md)
- [Commits](https://github.com/palkan/test-prof/compare/v0.10.1...v0.10.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 10:18:46 -05:00
dependabot-preview[bot]
d22a80fa0c Bump pg from 1.2.1 to 1.2.2 (#5495)
Bumps [pg](https://github.com/ged/ruby-pg) from 1.2.1 to 1.2.2.
- [Release notes](https://github.com/ged/ruby-pg/releases)
- [Changelog](https://github.com/ged/ruby-pg/blob/master/History.rdoc)
- [Commits](https://github.com/ged/ruby-pg/compare/v1.2.1...v1.2.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 10:18:27 -05:00
Anna Buianova
851508f628 Fix a bug when user tries to delete an account while not having an email (#5486)
* Ask user to add email when deleting [WIP]

* Ask to provide an email before requesting account deletion

* Additional checks to make sure that user won't be deleted w/o an email

* Revert changes on confirm destroy view
2020-01-13 08:34:37 -05:00
Jacob Herrington
e8c623807c Add @jacobherrington to CODEOWNERS [ci skip] (#5449)
Just including myself for directories specifically pertaining to
internal and to the docs directory.
2020-01-11 13:03:07 -06:00
Lucas Hiago
9ed6a5add0 Fix hex color in seeds (#5452) 2020-01-11 11:24:08 -05:00
Molly Struve
5e6ca69e27
Check for follow before trying to send a notification (#5438) [deploy] 2020-01-10 13:59:38 -06:00
Asha Balasubramaniam
e5960810cc Migrate Comments::SendEmailNotificationJob to Sidekiq (#5427)
* Add sidekiq version of the corresponding delayed job
* Switch the invocation of the delayed job from `after_create` to
`after_create_commit` to avoid the race condition where the worker can
be executed before the comment is persisted. Added covering spec
for this change.
2020-01-10 13:59:12 -06:00
Pablo Ifrán
bac4b7fac4 Move Users::ResaveArticlesJob to Sidekiq (#5398)
Change Resave Articles job to worker, and add missing specs on the user
model when changing the trigger attributes
2020-01-10 13:56:39 -06:00
Ben Halpern
150e31bbf0
Add oauth to list of skipped paths for service workers (#5441)
* Add oauth to list of skipped paths for service workers

* Fix comment
2020-01-10 13:41:10 -05:00
Ben Halpern
f78b89e763
Add suggested tags to SiteConfig (#5426) [deploy]
* Initial base work

* Add suggested tags config

* Downcase suggested tag input
2020-01-10 12:33:37 -05:00
Michael Kohl
1cea7a1ef1 Remove env variables handled by SiteConfig (#5400) 2020-01-10 11:42:55 -05:00
Maykon Menezes
cf4dc80250 Move Podcast Episode Bust Cache Job to Sidekiq (#5416) [deploy] 2020-01-10 10:08:59 -06:00
serena
00fd2f4518 Remove Unused NewBadgeAchievementJob (#5437) 2020-01-10 10:07:36 -06:00
Lucas Hiago
9ddc02cd14 Remove password verification (#5304) 2020-01-10 10:45:18 -05:00
Mukesh Chaudhary
d479a77aab Remove New Reaction Job and Spec (#5422) [deploy] 2020-01-10 08:44:23 -06:00
Jenna Pederson
5c9302f5f1 Migrate subscribe to mailchimp newsletter job to sidekiq worker (#5423)
* Start migrating job to sidekiq worker
* Only check for badge jobs queued to sidekiq
2020-01-10 08:43:13 -06:00
Michael Kohl
47c77dbee9 Fix typo (#5428) 2020-01-10 08:42:22 -05:00
Jacob Herrington
0fd8172f86 Resize textarea to fill parent (#5420) 2020-01-10 08:38:46 -05:00
Alain Mauri
c013079359 Move Classified Listing Cache Buster to Sidekiq (#5408) [deploy]
* Created the worker to bust cache for classified listings
* Created the related tests
* Removed the old job
2020-01-09 17:23:23 -05:00
Lucas Hiago
a86371e772 Remove TouchJob and do it Inline (#5410) 2020-01-09 17:22:09 -05:00
Jacob Herrington
2a8b133d82 Remove call to publish method on non-articles (#5418) [deploy] 2020-01-09 12:07:39 -05:00
leewynne
fcc6cfb72f Updated application_helper.rb with Cloudinary env variable to fix images on stand alone platform. (#5374) [deploy] 2020-01-09 11:50:16 -05:00
Nick Schwaderer
74da1ffc59 No longer hide reactions and follows after 24 hours (#5314)
* No longer hide reactions and follows after 24 hours
* Removes unused scope without_past_aggregations

Co-authored-by: Molly Struve <mollylbs@gmail.com>
2020-01-09 11:49:55 -05:00
rhymes
7dd2ae9fe0 Remove notifiable access from articles and comments notifications (#5415) [deploy]
* Add created_at to comment notification data

* Remove notifiable usage from notifications partials

* Fix typo
2020-01-09 10:19:45 -05:00
Jacob Herrington
41c3164553 Skip negative reactions for unpublished content (#5392) [deploy]
If content is unpublished it shouldn't be immediately necessary for
negative reactions to be acted on.

There is a higher touch solution here, but I'm not sure it's warranted.
2020-01-09 10:06:45 -05:00
Mukesh Chaudhary
48edaab5bc Migrate new reaction job 5305 (#5401)
* Add New Reaction Worker

* Add Specs for the New Reaction Worker

* Update Worker Calls in Notification Model

* Update Notification Model Specs

* Fix Code Climate Issues

* Fix notification specs to remove instance variable and complex logic

* Fix Worker Spec

* Fix Review Comments

* Undo Job Specs

Co-authored-by: Mukesh Chaudhary <45253983+mukeshchdy@users.noreply.github.com>
2020-01-09 09:51:56 -05:00
Mehdi Vasigh
29a734b698 fix totalCount getting an array instead of a number (#5359) 2020-01-09 09:47:55 -05:00
Jacob Herrington
373140d3d1 Add documentation for PR expectations [ci skip] (#5106)
This change ideally reminds contributors to take steps that make code
review easier on DEV maintainers.
2020-01-09 09:05:26 -05:00
Molly Struve
86e138662a
remove persist audit job and do it inline (#5355) [deploy] 2020-01-09 08:49:22 -05:00
Asha Balasubramaniam
91663231cc Remove delayed job that calculates comment score (#5412) [deploy]
Get rid of the delayed job and corresponding spec. Follow up to https://github.com/thepracticaldev/dev.to/pull/5382
2020-01-09 08:25:03 -05:00
rhymes
d2e96007c7 Fix (some) n+1/eager loading issues (#5294) [deploy]
* Remove mock from specs to test the actual Suggester

* Fix articles API top articles n+1

* Fix n+1 in articles API with state parameter

* Remove eager loading for organization dashboard

* Eager load notifiables in notifications only when needed

* Algolia does not like this
2020-01-08 18:48:24 -05:00
Michael Kohl
8006de06ea Add 'overflow-y: scroll' to .user-metadata-details (#4803)
Users with too much/too long profile information where overflowing the section which
made some of their information inaccessible.
2020-01-08 18:05:52 -05:00
Alain Mauri
5055121361 Remove Chat Channels Index Job (#5409) [deploy] 2020-01-08 16:33:40 -05:00
Pablo Ifrán
f5d3593d4f Change the way that id_code was created (#5348) [deploy]
The column id_code was created with a job in an after create callback,
that was replaced by an inline creation of the attribute
2020-01-08 16:21:39 -05:00
Anna Buianova
e09e46ec99 Creating podcasts by users (#3730) [deploy]
* Create podcast as a user [WIP]

* Sample css for podcast form

* Nicer podcasts suggesting form

* Validate podcast feed_url

* Validate podcast main_color_hex

* Fix podcasts specs

* Fix form appearance

* Placeholder for podcast main_color_hex

* Provide a link to suggest a podcast

* Add a checkbox and a role for when a podcast is added by an owner

* Prettier checkbox in the podcasts form

* Added creator to podcasts

* Set the podcast creator

* Fix the /pod spec

* Added creator information to the internal podcast page

* Added cta class to the podcasts submit button

* Global notice when a podcast was suggested

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-01-08 16:14:25 -05:00
rhymes
482a77a375 Restore default email from SiteConfig for mailers (#5399) [deploy]
* Restore default email from SiteConfig for mailers

* Fix broken email preview
2020-01-08 16:09:32 -05:00