Move Classified Listing Cache Buster to Sidekiq (#5408) [deploy]

* Created the worker to bust cache for classified listings
* Created the related tests
* Removed the old job

app/controllers/concerns/classified_listings_toolkit.rb

@@ -34,7 +34,7 @@ module ClassifiedListingsToolkit
   end
 
   def clear_listings_cache
-    ClassifiedListings::BustCacheJob.perform_now(@classified_listing.id)
+    ClassifiedListings::BustCacheWorker.perform_async(@classified_listing.id)
   end
 
   def set_classified_listing

app/jobs/classified_listings/bust_cache_job.rb

@@ -1,12 +0,0 @@
-module ClassifiedListings
-  class BustCacheJob < ApplicationJob
-    queue_as :classified_listings_bust_cache
-
-    def perform(classified_listing_id, cache_buster = CacheBuster)
-      classified_listing = ClassifiedListing.find_by(id: classified_listing_id)
-      return unless classified_listing
-
-      cache_buster.bust_classified_listings(classified_listing)
-    end
-  end
-end

app/workers/classified_listings/bust_cache_worker.rb

@@ -0,0 +1,14 @@
+module ClassifiedListings
+  class BustCacheWorker
+    include Sidekiq::Worker
+
+    sidekiq_options queue: :high_priority, retry: 10
+
+    def perform(classified_listing_id)
+      classified_listing = ClassifiedListing.find_by(id: classified_listing_id)
+      return unless classified_listing
+
+      CacheBuster.bust_classified_listings(classified_listing)
+    end
+  end
+end

spec/jobs/classified_listings/bust_cache_job_spec.rb

@@ -1,39 +0,0 @@
-require "rails_helper"
-
-RSpec.describe ClassifiedListings::BustCacheJob, type: :job do
-  include_examples "#enqueues_job", "classified_listings_bust_cache", 1
-
-  describe "#perform_now" do
-    let(:cache_buster) { double }
-
-    before do
-      allow(cache_buster).to receive(:bust_classified_listings)
-    end
-
-    context "with listing" do
-      let_it_be(:listing) { double }
-      let_it_be(:listing_id) { 1 }
-
-      before do
-        allow(ClassifiedListing).to receive(:find_by).with(id: listing_id).and_return(listing)
-      end
-
-      it "busts cache" do
-        described_class.perform_now(listing_id, cache_buster)
-
-        expect(cache_buster).to have_received(:bust_classified_listings).with(listing)
-      end
-    end
-
-    describe "when no listing is found" do
-      it "does not error" do
-        expect { described_class.perform_now(nil, cache_buster) }.not_to raise_error
-      end
-
-      it "does not bust cache" do
-        described_class.perform_now(nil, cache_buster)
-        expect(cache_buster).not_to have_received(:bust_classified_listings)
-      end
-    end
-  end
-end

spec/requests/internal/classified_listings_spec.rb

@@ -14,6 +14,7 @@ RSpec.describe "/internal/listings", type: :request do
       put "/internal/listings/#{classified_listing.id}", params: {
         classified_listing: { title: "updated" }
       }
+      sidekiq_perform_enqueued_jobs
       expect(CacheBuster).to have_received(:bust_classified_listings)
     end
   end

spec/workers/classified_listings/bust_cache_worker_spec.rb

@@ -0,0 +1,39 @@
+require "rails_helper"
+
+RSpec.describe ClassifiedListings::BustCacheWorker, type: :worker do
+  include_examples "#enqueues_on_correct_queue", "high_priority", 1
+
+  describe "#perform" do
+    let(:worker) { subject }
+
+    before do
+      allow(CacheBuster).to receive(:bust_classified_listings)
+    end
+
+    context "with listing" do
+      let(:listing) { double }
+      let(:listing_id) { 1 }
+
+      before do
+        allow(ClassifiedListing).to receive(:find_by).with(id: listing_id).and_return(listing)
+      end
+
+      it "busts cache" do
+        worker.perform(listing_id)
+
+        expect(CacheBuster).to have_received(:bust_classified_listings).with(listing)
+      end
+    end
+
+    describe "when no listing is found" do
+      it "does not error" do
+        expect { worker.perform(nil) }.not_to raise_error
+      end
+
+      it "does not bust cache" do
+        worker.perform(nil)
+        expect(CacheBuster).not_to have_received(:bust_classified_listings)
+      end
+    end
+  end
+end