Ben Halpern
1d62d30853
Consolidate and internationalize various 'contact us' prompts ( #14951 )
...
* Consolidate and internationalize various 'contact us' prompts
* Update spec/requests/user/user_settings_spec.rb
Co-authored-by: Michael Kohl <citizen428@forem.com>
Co-authored-by: Michael Kohl <citizen428@forem.com>
2021-10-07 12:05:21 -04:00
Pramod
ce4ba84184
fix: accessibility issue with feeds comment section ( #14958 )
...
* fix: accessibility issue with feeds comment section
* fix: comments section name for logged out scenario and search results
* fix: review changes for logged in scenario
* fix: updated comments section aria label
2021-10-07 17:01:42 +01:00
Andy Zhao
f5d0c3be31
Fix small bugs related to identities when merging a user ( #14885 )
...
* Only prevent merge user if 2+ more identities, not 1+ more
* Refactor error messages into constants
* Skip only if no identities on deleted user
* Raise standard error instead of a string
* Add test to confirm correct identity was merged
2021-10-07 10:08:02 -04:00
Daniel Uber
412fa09026
Rename jest test from spec.js to test.js, so it actually runs ( #14972 )
...
* Rename jest test from spec.js to test.js, so it actually runs
* rename snapshot from spec.js.snap to test.js.snap
2021-10-07 08:13:47 -05:00
Ben Halpern
d85f07c00d
Fix legacy sitemap logic ( #14926 )
...
* Fix legacy sitemap logic
* Add aggregate failures
* Fix formatting
* Adjust robots.txt spec
* Fix index minimum to >=
2021-10-07 08:59:16 -04:00
Tayllan
fc77376c1b
Translate actions in articles view ( #14911 )
...
* Translate actions in articles view
* Move reactions to core.reactions namespace
* Add quotes to share_to in yml file
* Fix wrong translation in english locale
Co-authored-by: rhymes <github@rhymes.dev>
2021-10-07 12:08:14 +07:00
Nick Taylor
7e947ff2ca
Enabled Intellisense for the Cypress API ( #14970 )
2021-10-06 16:36:11 -04:00
Andy Zhao
0c28781c47
Remove tag categories from admin UI and remove aliased tags from /tags page ( #14966 )
...
* Don't show aliased tags in top 100 tags page
* Remove tag category from admin UI and controller params
* Fix styling of checkbox
2021-10-06 14:45:51 -04:00
dependabot[bot]
f93aa1a2e0
Bump rubocop-rails from 2.12.2 to 2.12.3 ( #14967 )
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.12.2 to 2.12.3.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.12.2...v2.12.3 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-06 14:32:51 -04:00
Monica Mateiu
bd0b4f1117
Tokenize settings menu and add French translations ( #14905 )
...
* tokenize settings menu and add French translations
* add quotes around tokens
* add tokens in alphabetical order
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2021-10-06 17:53:58 +02:00
Mohamed Asan N
cceb175d5d
Use section instead of header in dashboard pages ( #14873 )
...
* Use section instead of header
* Trigger Build
* Move section inside main
* Fix test case
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2021-10-06 17:12:43 +02:00
Alex
eed3c12f4d
Auto register Forems on Discover ( #14962 )
2021-10-06 10:51:15 -04:00
Jamie Gaskins
8e220dc97f
Add Rails cache instrumentation to Honeycomb ( #14880 )
...
It looks like Honeycomb uses ActiveSupport notifications to instrument
applications, based on the names of the `notification_events`. I pulled
this event name from the Rails guides:
https://guides.rubyonrails.org/active_support_instrumentation.html#active-support
2021-10-06 10:46:24 -04:00
Ben Halpern
7ffb5aa0fd
Change preview card hover delay ( #14964 )
2021-10-06 09:26:58 -04:00
Takuma
baab2c0930
Subscribe the newsletter if email_newsletter is changed ( #14226 )
...
* Check if email_newsletter is changed
* Check if Settings::General.mailchimp_api_key is defined
* Add spec for Users::NotificationSetting
* Remove spec for boolean column
http://www.chrisrolle.com/en/blog/boolean-attribute-validation
* Check if email is set when changing newsletter subscription setting
* Make it easy to read
* Remove specs for a case never happening
2021-10-06 12:30:22 +07:00
dependabot[bot]
7e23dccece
Bump doorkeeper from 5.5.3 to 5.5.4 ( #14959 )
...
Bumps [doorkeeper](https://github.com/doorkeeper-gem/doorkeeper ) from 5.5.3 to 5.5.4.
- [Release notes](https://github.com/doorkeeper-gem/doorkeeper/releases )
- [Changelog](https://github.com/doorkeeper-gem/doorkeeper/blob/main/CHANGELOG.md )
- [Commits](https://github.com/doorkeeper-gem/doorkeeper/compare/v5.5.3...v5.5.4 )
---
updated-dependencies:
- dependency-name: doorkeeper
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-05 18:29:14 -04:00
Jeremy Friesen
aff4754ad0
Adding jeremyf to core team ( #14947 )
...
Jeremy started at Forem on October 4, 2021
2021-10-05 14:38:20 -04:00
rhymes
e5226b9951
Upgrade Stimulus to 3.0 ( #14869 )
...
* Upgrade Stimulus to 3.0
* Remove unused variable
* Bump postcss from 8.3.8 to 8.3.9 (#14956 )
Bumps [postcss](https://github.com/postcss/postcss ) from 8.3.8 to 8.3.9.
- [Release notes](https://github.com/postcss/postcss/releases )
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md )
- [Commits](https://github.com/postcss/postcss/compare/8.3.8...8.3.9 )
---
updated-dependencies:
- dependency-name: postcss
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-05 20:00:37 +02:00
dependabot[bot]
fb821cca41
Bump @rails/webpacker from 5.4.2 to 5.4.3 ( #14948 )
...
Bumps [@rails/webpacker](https://github.com/rails/webpacker ) from 5.4.2 to 5.4.3.
- [Release notes](https://github.com/rails/webpacker/releases )
- [Changelog](https://github.com/rails/webpacker/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rails/webpacker/compare/v5.4.2...v5.4.3 )
---
updated-dependencies:
- dependency-name: "@rails/webpacker"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-05 13:44:09 -04:00
dependabot[bot]
a4394cfd98
Bump postcss from 8.3.8 to 8.3.9 ( #14956 )
...
Bumps [postcss](https://github.com/postcss/postcss ) from 8.3.8 to 8.3.9.
- [Release notes](https://github.com/postcss/postcss/releases )
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md )
- [Commits](https://github.com/postcss/postcss/compare/8.3.8...8.3.9 )
---
updated-dependencies:
- dependency-name: postcss
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-05 13:29:29 -04:00
dependabot[bot]
9c8301a9b4
Bump eslint-plugin-react from 7.25.1 to 7.26.1 ( #14944 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-05 13:01:51 -04:00
dependabot[bot]
8b96f32f95
Bump jest-watch-typeahead from 0.6.4 to 1.0.0 ( #14952 )
...
Bumps [jest-watch-typeahead](https://github.com/jest-community/jest-watch-typeahead ) from 0.6.4 to 1.0.0.
- [Release notes](https://github.com/jest-community/jest-watch-typeahead/releases )
- [Changelog](https://github.com/jest-community/jest-watch-typeahead/blob/main/CHANGELOG.md )
- [Commits](https://github.com/jest-community/jest-watch-typeahead/compare/v0.6.4...v1.0.0 )
---
updated-dependencies:
- dependency-name: jest-watch-typeahead
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-05 10:18:51 -06:00
Nick Taylor
020829ab16
Fixed lint issue ( #14954 )
2021-10-05 12:07:20 -04:00
Jamie Gaskins
268ea66dcd
Optimize Article query in EdgeCache::BustArticle ( #14916 )
2021-10-05 11:58:34 -04:00
dependabot[bot]
a2712ffeb0
Bump @storybook/addon-docs from 6.3.8 to 6.3.9 ( #14946 )
...
Bumps [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/addons/docs ) from 6.3.8 to 6.3.9.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.9/addons/docs )
---
updated-dependencies:
- dependency-name: "@storybook/addon-docs"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-05 11:22:50 -04:00
dependabot[bot]
4cb7fd8701
Bump @testing-library/dom from 8.6.0 to 8.7.2 ( #14943 )
...
Bumps [@testing-library/dom](https://github.com/testing-library/dom-testing-library ) from 8.6.0 to 8.7.2.
- [Release notes](https://github.com/testing-library/dom-testing-library/releases )
- [Changelog](https://github.com/testing-library/dom-testing-library/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/dom-testing-library/compare/v8.6.0...v8.7.2 )
---
updated-dependencies:
- dependency-name: "@testing-library/dom"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-05 10:54:35 -04:00
Ben Halpern
5cc09767c5
Add conditional autovomits to user name and improve user score recalc ( #14858 )
...
* Add conditional autovomits to user name and improve user score recalc
* Remove puts
* Add missing ||
* Fix tests
* Update app/views/users/show.html.erb
Co-authored-by: Michael Kohl <citizen428@forem.com>
* Update app/models/user.rb
Co-authored-by: Michael Kohl <citizen428@forem.com>
* Add in-line score calc principles
Co-authored-by: Michael Kohl <citizen428@forem.com>
2021-10-05 10:11:41 -04:00
dependabot[bot]
820013baa4
Bump postcss-cli from 8.3.1 to 9.0.1 ( #14924 )
...
Bumps [postcss-cli](https://github.com/postcss/postcss-cli ) from 8.3.1 to 9.0.1.
- [Release notes](https://github.com/postcss/postcss-cli/releases )
- [Changelog](https://github.com/postcss/postcss-cli/blob/master/CHANGELOG.md )
- [Commits](https://github.com/postcss/postcss-cli/compare/8.3.1...9.0.1 )
---
updated-dependencies:
- dependency-name: postcss-cli
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-05 09:35:34 -04:00
praveen raghav ns
4b8576aec3
Use constants for Permitted params in controller ( #14895 )
...
* Use constants for controller permitted params
* User constants for controller set 2
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2021-10-05 09:00:14 -04:00
dependabot[bot]
68524069d0
Bump autoprefixer from 10.3.6 to 10.3.7 ( #14942 )
...
Bumps [autoprefixer](https://github.com/postcss/autoprefixer ) from 10.3.6 to 10.3.7.
- [Release notes](https://github.com/postcss/autoprefixer/releases )
- [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md )
- [Commits](https://github.com/postcss/autoprefixer/compare/10.3.6...10.3.7 )
---
updated-dependencies:
- dependency-name: autoprefixer
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-05 06:50:19 -06:00
dependabot[bot]
8a23b3d7e5
Bump core-js from 3.17.3 to 3.18.1 ( #14940 )
2021-10-05 08:31:53 -04:00
Ben Halpern
49247fdc8c
Remove organization dependency and improve display ad UX ( #14913 )
2021-10-05 08:29:08 -04:00
dependabot[bot]
9388ad2f37
Bump jest from 27.2.1 to 27.2.4 ( #14941 )
...
Bumps [jest](https://github.com/facebook/jest ) from 27.2.1 to 27.2.4.
- [Release notes](https://github.com/facebook/jest/releases )
- [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md )
- [Commits](https://github.com/facebook/jest/compare/v27.2.1...v27.2.4 )
---
updated-dependencies:
- dependency-name: jest
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-05 13:15:07 +01:00
dependabot[bot]
a10ac476a0
Bump lint-staged from 11.1.2 to 11.2.0 ( #14929 )
...
Bumps [lint-staged](https://github.com/okonet/lint-staged ) from 11.1.2 to 11.2.0.
- [Release notes](https://github.com/okonet/lint-staged/releases )
- [Commits](https://github.com/okonet/lint-staged/compare/v11.1.2...v11.2.0 )
---
updated-dependencies:
- dependency-name: lint-staged
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-05 13:14:32 +01:00
rhymes
eba0ddb240
Misc i18n fixes ( #14852 )
...
* Add i18n tasks spec
* Ignore storybook static folder
* Run i18n-tasks normalize
* Fix inconsistent interpolations flagged by i18n-tasks check-consistent-interpolations
* Update devise en translation and add devise_invitable fr translation
* Add missing keys, ignore those to be translated and normalize
* Temporarily ignore unused keys until we have a strategy for maintenance
* Add missing key
* Re-run normalize
* Disable normalize test temporarily
2021-10-05 13:22:33 +02:00
dependabot[bot]
ad513ebfc7
Bump sass from 1.39.2 to 1.42.1 ( #14925 )
...
Bumps [sass](https://github.com/sass/dart-sass ) from 1.39.2 to 1.42.1.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.39.2...1.42.1 )
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-05 13:01:51 +02:00
dependabot[bot]
75eab7e567
Bump @storybook/addon-links from 6.3.8 to 6.3.9 ( #14930 )
2021-10-05 06:42:36 -04:00
Papu Kumar(ReX)
6da90073f6
Fix Prop Types Error #14837 ( #14889 )
...
* Fix Prop Types Error #14837
Fixed prop types errors for Button, ButtonGroup, Modal and articlePage
* #added some checks into default children props
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2021-10-05 10:58:48 +02:00
Ben Halpern
e03f2435d9
Remove dead app shell code ( #14915 )
2021-10-05 10:09:54 +02:00
Jamie Gaskins
5d5dbaca95
Eager-load comment user data ( #14902 )
...
* Eager-load comment user data
Profiles and user settings are loaded for on each comment author. On
posts with many comments, this invokes a *lot* of DB queries. This
commit replaces 2 queries per comment with 2 queries for all comments.
* Fix where I misunderstood limit's purpose
This implementation is too clever. It looks like it should just be
getting all but the last, but it uses the fact that the default is 0 to
default to getting all of them. This isn't readily understandable to
someone reading the code.
I don't have a suggestion to fix it yet so I'm just going to leave it
as-is for now.
2021-10-05 10:05:01 +02:00
Monica Mateiu
322f7f4b16
Translate Following users page and loading text in sublist ( #14898 )
...
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2021-10-05 12:44:07 +07:00
dependabot[bot]
8b8fb93bd4
Bump @storybook/addon-storysource from 6.3.8 to 6.3.9 ( #14923 )
...
Bumps [@storybook/addon-storysource](https://github.com/storybookjs/storybook/tree/HEAD/addons/storysource ) from 6.3.8 to 6.3.9.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.9/addons/storysource )
---
updated-dependencies:
- dependency-name: "@storybook/addon-storysource"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-04 21:02:36 -04:00
dependabot[bot]
a73bba0b10
Bump babel-jest from 27.2.0 to 27.2.4 ( #14928 )
...
Bumps [babel-jest](https://github.com/facebook/jest/tree/HEAD/packages/babel-jest ) from 27.2.0 to 27.2.4.
- [Release notes](https://github.com/facebook/jest/releases )
- [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md )
- [Commits](https://github.com/facebook/jest/commits/v27.2.4/packages/babel-jest )
---
updated-dependencies:
- dependency-name: babel-jest
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-04 20:37:54 -04:00
dependabot[bot]
9c2387cebc
Bump focus-trap from 6.6.1 to 6.7.1 ( #14920 )
...
Bumps [focus-trap](https://github.com/focus-trap/focus-trap ) from 6.6.1 to 6.7.1.
- [Release notes](https://github.com/focus-trap/focus-trap/releases )
- [Changelog](https://github.com/focus-trap/focus-trap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/focus-trap/focus-trap/compare/v6.6.1...v6.7.1 )
---
updated-dependencies:
- dependency-name: focus-trap
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-04 20:33:23 -04:00
Monica Mateiu
c0a8211b74
use complementary landmarks on Tags page ( #14899 )
2021-10-04 19:05:17 -04:00
Gabriela Luhova
3595890fd7
Replace main tag inside another main tag with div ( #14896 )
...
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2021-10-04 16:00:19 -06:00
Thomas Bnt
685a069d79
Update some words already translated ( #14890 )
...
* Update some words already translated
* Edit log_in and see_all in french
* Update config/locales/fr.yml
Co-authored-by: Aurelie Verrot <aurelie+github@verrot.fr>
* Update fr.yml
Co-authored-by: Aurelie Verrot <aurelie+github@verrot.fr>
2021-10-04 17:18:30 -04:00
dependabot[bot]
0aa7407bac
Bump @storybook/addon-a11y from 6.3.8 to 6.3.9 ( #14921 )
2021-10-04 17:16:14 -04:00
dependabot[bot]
628dc61442
Bump autoprefixer from 10.3.4 to 10.3.6 ( #14919 )
...
Bumps [autoprefixer](https://github.com/postcss/autoprefixer ) from 10.3.4 to 10.3.6.
- [Release notes](https://github.com/postcss/autoprefixer/releases )
- [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md )
- [Commits](https://github.com/postcss/autoprefixer/compare/10.3.4...10.3.6 )
---
updated-dependencies:
- dependency-name: autoprefixer
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-04 15:27:34 -04:00
dependabot[bot]
94f63f56bd
Bump rubocop from 1.22.0 to 1.22.1 ( #14922 )
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.22.0 to 1.22.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.22.0...v1.22.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-04 14:56:12 -04:00
