Commit graph

4715 commits

Author SHA1 Message Date
Mac Siri
1cb51780cb
Update feed_spec's use of NON_DEFAULT_EXPERIMENTS (#6975) 2020-03-31 11:43:34 -04:00
Arit Amana
1310218633
Add my name to Core Team list (#6974) 2020-03-31 11:11:59 -04:00
Molly Struve
61ac8218dd
report only changes in master branch status (#6973) 2020-03-31 10:00:24 -05:00
swyx
c5e543591d
Hide API keys in details/summary tag (#6941) [deploy]
* hide api keys in details/summary tag

hide api keys in details/summary tag

* update to directly use summary tag
2020-03-31 16:58:08 +02:00
Ridhwana
577fda683c
chore: rename function name consistently with the other function names in the file (#6970) 2020-03-31 16:20:39 +02:00
Ridhwana
e74890680a
Generalize meta content and copyright year (#6887)
* chore: remove the description

* feat: change the meta og:site_name property from The Practical DEV to The <COMMUNITY_NAME> Community consistently

* refactor: change the canonical link to be more dynamic using the <%= ApplicationConfig["APP_PROTOCOL"] %><%= ApplicationConfig["APP_DOMAIN"] %>

* refactor: update the path to be dynamic

* refactor: change some other meta properties to be dynamic

* refactor: update the index

* refactor: update the sitename to just read <%= ApplicationConfig["COMMUNITY_NAME"] %> Community

* feat: copyright year should be dynamic

* feat: change the meta og:url content to be dynamic by using <%= ApplicationConfig["APP_PROTOCOL"] %><%= ApplicationConfig["APP_DOMAIN"] %> for the former part of the url

* feat: space

* refactor: move the copyright notice to a helper

* refactor: use the community_qualified_name helper!

* refactor: start year is already a string

* refactor: use app url helper instead of <%= ApplicationConfig["APP_PROTOCOL"] %><%= ApplicationConfig["APP_DOMAIN"] %> everywhere

* chore:oops

* refactor: Change  <meta name="twitter:image:src" content="http://i.imgur.com/B4JNl1w.png"> to `<meta name="twitter:image:src" content="<%= SiteConfig.main_social_image %>">` consistently.

* refactor: Replace  `<meta property="og:image" content="http://i.imgur.com/B4JNl1w.png" />` with `  <meta property="og:image" content="<%= SiteConfig.main_social_image %>" />`

* chore: update some other meta's

* feat: replace 'The Practical DEV' with 'DEV Community' and

* test: remove The :)

* test: copyright_notice

* fix: syntax error

* feat: name of community

* refactor: use app url

* fix: template strings

* fix: tag

* feat: update the app url parameters

* feat: add a community_name helper so we don't have to refer to an environment variable in the templates

* feat: take into account the case when the start year is a blank string

* feat: single quotes to double quotes

* test: add a test for the #community_name

* chore: update or codeclimate

* chore: amend the community helper

* refactor: use the community_name helper in here

* feat: update ApplicationConfig["COMMUNITY_NAME"]  with community_name

* fix: Time.current.year needs to be a string :(

* chore: extra space

* chore: change to use community_qualified_name
2020-03-31 16:15:57 +02:00
Michael Kohl
1ae9cfbdc6
Remove POST /api/reactions endpoint (#6968) [deploy] 2020-03-31 16:12:30 +02:00
Ben Halpern
22ffc7febc
Cache onboarding at edge (#6966) 2020-03-31 16:12:14 +02:00
Molly Struve
2c49b34ebf
Hotness Score for Tags Should Use Article positive_reactions_count (#6808) [deploy]
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-03-31 09:04:20 -05:00
Nick Taylor
f557c9d474
Created preact component for crayons dropdown (#6961)
* Created barrel files so we can import directly from @crayons.

* Added stories for Dropdown for JSX.

* Tweaked Dropdown Storybook stories.

* Tweaked <Dropdown /> component.

* Added module mapping to jest for @crayons.

* Added tests for <Dropdown /> component.

* Removed Storybook custom decorator that is no longer required.
2020-03-31 09:42:21 -04:00
Vaidehi Joshi
5b991fb402
Tweak /internal/broadcast form (#6965)
Ensure that "active" defaults to false.
Ensure that the broadcast type is set to "Welcome" by default.
2020-03-31 06:38:43 -07:00
Nick Taylor
5ba10c96a2
Add webpack aliases for Crayons components (#6958)
* Added webpack alias for @crayons.

* Added @crayons to eslint import/no-unresolved rule ignore list.

* Added path mappings for VS Code for webpack aliases.
2020-03-31 07:16:29 -04:00
Lucas Hiago
40310bbc59
Refactor method delete_activity (#6928) 2020-03-31 11:27:52 +02:00
rhymes
a58596f25f
Correctly save Tweet reply ids (#6951) 2020-03-31 11:09:19 +02:00
Ben Halpern
6d6a36f3dd
[deploy] Fix small onboarding issues (#6963)
* Fix small onboarding issues

* Fix whitespace
2020-03-30 20:43:33 -04:00
Vaidehi Joshi
28956d90a5
[deploy] Prompt new users to customize their experience (#6959)
* Rename find_broadcast to find_auth_broadcast

* Fix broken div rendering on /notifications tab

* Allow customize notification to be enqueued

* Add specs for customize welcome notification

Also clean up existing specs to match!

* Rename customization notification method for clarity

* Remove some redundant assertions in generator spec
2020-03-30 19:17:52 -04:00
Lisa Sy
b6fd02b70f
Improve onboarding UI and UX (P1) (#6901)
* Improve onboarding UI and UX (P1)

- Introduce Crayons variables
- Remove unnecessary CSS files to have just one CSS file

* Add new onboarding tests

* Update onboarding yarn test to reflect updated class names
2020-03-30 15:38:15 -07:00
Andy Zhao
ec371b4624
Fix response templates edit and delete buttons (#6952)
* Fix delete button with correct form_with options

* Use correct path for edit button

* Add test for edit and delete response templates

* Use old pattern to accept alert

* Check for text instead b/c weird timing issue with backend
2020-03-30 15:43:01 -04:00
rhymes
66515d1258
Ignore unused organizations columns (#6933) [deploy] 2020-03-30 19:00:31 +02:00
ludwiczakpawel
c0a9ff75b6
Button & color updates (#6948)
* notifications subscribe dropdown

* little documentation
2020-03-30 18:11:09 +02:00
Molly Struve
55fe5a40a8
Add Rack::Attack Gem to Throttle Requests, Only Search to start (#6841) [deploy]
* throttle requests made to search endpoints

* stub elasticsearch requests in rack attack specs and disable for running specs unless tagged

* use original client IP from fastly to throttle requests to search endpoints
2020-03-30 12:09:40 -04:00
rhymes
4baa9d3165
Remove job_opportunities table (#6932) 2020-03-30 12:08:10 -04:00
Molly Struve
ba4b6593bc
JS Bug Fix: Check that bodyClass is present before checking what it includes (#6920)
* check that bodyClass is present before checking what it includes

* refaactor method to return early if bodyClass if not present

* back to simple if statements
2020-03-30 12:07:44 -04:00
rhymes
e6fda5e444
Ignore unused tweets columns (#6950) [deploy] 2020-03-30 17:27:17 +02:00
Nick Taylor
e4fdbd1a30
Restructure Storybook stories in sidebar (#6915)
* Renamed designSystem to crayons.

* Restructured how Storybook stories are laid out in Storybook's sidebar.

* wip

* More folder restructuring for Storybook sidebar.

* Fixed Dropdown description story.

* There no longer is a Dropdown for no padding. Just add additional utility classes.

* Showing dropdowns by default in Storybook as they are hidden by default.
2020-03-30 17:26:04 +02:00
rhymes
466ec8bd17
Ignore unused tags columns (#6947) 2020-03-30 16:57:13 +02:00
Lucas Hiago
bc84c4473f
Refactor method in tweet models (#6929) 2020-03-30 16:10:17 +02:00
rhymes
6e1fabaadb
Ignore unused podcast_episodes columns (#6939) [deploy]
* Ignore unused podcast_episodes columns

* Remove featured from serializer
2020-03-30 15:38:22 +02:00
rhymes
863247049e
Ignore unused pages columns (#6934) 2020-03-30 15:35:12 +02:00
ludwiczakpawel
184e56f216
Buttons Group (#6946)
* crayons-btn-group + crayons-btn--icon-alone

* typos

* better padding on outlined buttons

* make ooutlined button border a variable

* hey, pawel - how about not being an idiot??
2020-03-30 15:19:58 +02:00
Catalin Pit
39d4386c3f
Themes: use default colors for links in notifications (#6912)
* 6907 Fixed the notification color from black to white

* Removed themeable altogether
2020-03-30 11:50:15 +02:00
briwa
604e76dd88
refactor(docker-setup): use bash instead of ruby (#6935)
* refactor(docker-setup): use bash instead of ruby

* refactor: use a proper header

* refactor: bash -> sh
2020-03-30 10:13:52 +02:00
briwa
56c11d3e0d
refactor(offline.html): allow paint over pallete (#6937) 2020-03-30 09:22:51 +02:00
briwa
09f0773c18
refactor(docker): move redis env config to docker (#6936)
instead of in config/application.yml
2020-03-30 10:48:38 +07:00
Keith Maxwell
6c302f712a
Add missing } to updateArticle code sample (#6924)
Before this change the example curl command returns 400 bad request with an appropriate API key and article ID.

After this change the example curl command does not return error 400 bad request.
2020-03-29 08:35:05 +02:00
Nick Taylor
a654d25009
Added bugFixes option to @babel/preset-env. (#6909) 2020-03-28 19:35:37 +01:00
Alex
efc08d9b74
[deploy] Add valiation for file name length to file uploads (#6918) 2020-03-27 18:54:27 -04:00
Michael Kohl
9b12080478
A docker_setup script (#6827) 2020-03-27 18:48:32 -04:00
Molly Struve
72f04e4a13
Create Reactions Index in Elasticsearch and Serializer (#6899)
* create index for reactions and their reactables, set up serializer

* use respond_to instead of checking type

* remove rubocop change

* add last_indexed_at to reactions index
2020-03-27 18:44:54 -04:00
Molly Struve
7d5bba1556
report only travis failures and first following success to slack (#6910) 2020-03-27 18:44:27 -04:00
Molly Struve
974ba032da
Add last_indexed_at Timestamp to all Elasticsearch indexes (#6913)
* add last_indexed_at to all Elasticsearch indexes

* use Time.zone.parse
2020-03-27 18:43:46 -04:00
dependabot-preview[bot]
4c158271b3
Bump @babel/plugin-transform-react-jsx from 7.8.3 to 7.9.4 (#6872) 2020-03-27 15:51:49 -04:00
Mac Siri
2c5e12268f
Implement authentication welcome notification (#6846) 2020-03-27 15:21:40 -04:00
dependabot-preview[bot]
263baeb2f6
Bump @babel/core from 7.8.7 to 7.9.0 (#6878)
Bumps [@babel/core](https://github.com/babel/babel) from 7.8.7 to 7.9.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/compare/v7.8.7...v7.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-03-27 14:00:06 -04:00
Ben Halpern
d0a5c93684
[deploy] Fix fragment caching bug for SEO tag pagination. (#6917)
* Fix pagination caching and adjust logic

* Adjust range logic
2020-03-27 13:23:54 -04:00
Anna Buianova
ad26176828
Removed unused pages code (#6908) 2020-03-27 13:22:40 -04:00
rhymes
9a0a6fbe8f
Remove unused columns from articles (#6860) [deploy]
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-03-27 17:04:13 +01:00
Ben Halpern
e35d55c422
Add pagination to tag pages for better SEO crawling (#6771) [deploy]
* Add pagination to tag pages for better SEO crawling

* Modify system specs

* Add some tests

* Finalize tests

* Fix things up

* Add url helpers
2020-03-27 10:34:42 -04:00
rhymes
d03c751c65
Rubocop fixes (#6904)
* Run rubocop -a

* Regenerate rubocop todo

* Fix Lint/UselessAssignment

* Fix RSpec/RepeatedDescription

* Fix Style/GuardClause

* Fix Style/NumericPredicate

* Regenerate rubocop todo
2020-03-27 15:30:59 +01:00
dependabot-preview[bot]
f2696b6c80
Bump prettier from 1.19.1 to 2.0.2 (#6874)
Bumps [prettier](https://github.com/prettier/prettier) from 1.19.1 to 2.0.2.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/prettier/compare/1.19.1...2.0.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-03-27 10:16:32 -04:00