maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove POST /api/reactions endpoint (#6968) [deploy]

Browse source
This commit is contained in:
Michael Kohl 2020-03-31 21:12:30 +07:00 • committed by GitHub
parent 22ffc7febc
commit 1ae9cfbdc6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 0 additions and 185 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
app/controllers/api/v0/reactions_controller.rb
View file

@ -1,50 +0,0 @@
module Api
module V0
class ReactionsController < ApiController
skip_before_action :verify_authenticity_token
def create
reaction_user = load_reaction_user
unless reaction_user
render json: { error: "invalid user" }, status: :unprocessable_entity
return
end
@reaction = Reaction.create!(
user: reaction_user,
reactable_id: reaction_params[:reactable_id],
reactable_type: reaction_params[:reactable_type],
category: reaction_params[:category] || "like",
)
delete_reactable_cache(reaction_params[:reactable_id], reaction_params[:reactable_type])
Notification.send_reaction_notification(@reaction, @reaction.reactable.user)
Notification.send_reaction_notification(@reaction, @reaction.reactable.organization) if org_article?(@reaction)
render json: { reaction: @reaction.to_json }
end
private
def load_reaction_user
user = User.find_by!(secret: params[:key])
user = nil unless user.has_role?(:super_admin)
user
end
def delete_reactable_cache(reactable_id, reactable_type)
key = "count_for_reactable-#{reactable_type}-#{reactable_id}"
Rails.cache.delete(key)
end
def reaction_params
params.permit(:reactable_id, :reactable_type, :category)
end
def org_article?(reaction)
reaction.reactable.is_a?(Article) && reaction.reactable.organization
end
end
end
end

1
config/routes.rb
View file

@ -117,7 +117,6 @@ Rails.application.routes.draw do
resources :comments, only: %i[index show]
resources :videos, only: [:index]
resources :podcast_episodes, only: [:index]
resources :reactions, only: [:create]
resources :users, only: %i[show] do
collection do
get :me

134
spec/requests/api/v0/reactions_spec.rb
View file

@ -1,134 +0,0 @@
require "rails_helper"
RSpec.describe "Api::V0::Reactions", type: :request do
let(:user) { create(:user, secret: "TEST_SECRET") }
let(:article) { create(:article) }
def create_reaction(user, reactable, category: "like")
post api_reactions_path(
reactable_id: reactable.id,
reactable_type: reactable.class.name,
category: category,
key: user.secret,
)
end
describe "POST /api/reactions" do
context "when authorized as a super admin" do
before do
user.add_role(:super_admin)
sign_in user
end
it "returns 422 if the reaction is invalid" do
create_reaction(user, create(:tag))
expect(response).to have_http_status(:unprocessable_entity)
end
it "returns 404 if the key is not found" do
post api_reactions_path(
reactable_id: article.id,
reactable_type: article.class.name,
category: "like",
key: "foobar",
)
expect(response).to have_http_status(:not_found)
end
end
end
describe "POST /api/reactions - articles" do
context "when authorized as a super admin" do
before do
user.add_role(:super_admin)
sign_in user
end
it "creates a new like reaction" do
expect do
create_reaction(user, article)
expect(response).to have_http_status(:ok)
end.to change(article.reactions, :count).by(1)
expect(article.reactions.last.category).to eq("like")
end
it "creates a new unicorn reaction" do
expect do
create_reaction(user, article, category: "unicorn")
expect(response).to have_http_status(:ok)
end.to change(article.reactions, :count).by(1)
expect(article.reactions.last.category).to eq("unicorn")
end
it "sends a reaction notification to the article's user" do
expect do
sidekiq_perform_enqueued_jobs do
create_reaction(user, article)
end
expect(response).to have_http_status(:ok)
end.to change(article.user.notifications, :count).by(1)
end
it "sends a reaction notification to the article's organization" do
article.update(organization: create(:organization))
expect do
sidekiq_perform_enqueued_jobs do
create_reaction(user, article)
end
expect(response).to have_http_status(:ok)
end.to change(article.organization.notifications, :count).by(1)
end
end
it "rejects non-authorized users" do
sign_in user
create_reaction(user, article)
expect(response).to have_http_status(:unprocessable_entity)
end
end
describe "POST /api/reactions - comments" do
let(:comment) { create(:comment, commentable: article) }
context "when authorized as a super admin" do
before do
user.add_role(:super_admin)
sign_in user
end
it "creates a new like reaction" do
expect do
create_reaction(user, comment)
expect(response).to have_http_status(:ok)
end.to change(comment.reactions, :count).by(1)
expect(comment.reactions.last.category).to eq("like")
end
it "sends a reaction notification to the comment's user" do
expect do
sidekiq_perform_enqueued_jobs do
create_reaction(user, comment)
end
expect(response).to have_http_status(:ok)
end.to change(comment.user.notifications, :count).by(1)
end
end
it "rejects non-authorized users" do
sign_in user
create_reaction(user, comment)
expect(response).to have_http_status(:unprocessable_entity)
end
end
end