Commit graph

7521 commits

Author SHA1 Message Date
Mac Siri
092ee4a425
Implement PageViewRollup (#20670)
* Refactor

* Create PageViewRollup WIP

* Create PageViewRollupWorker and specs

* Add spec WIP

* Write spec

* Refactor

* Add spec

* Prevent retry

* Update baseline date

* Improve specs

* Update ATTRIBUTES_

* Update spec again
2024-03-18 20:33:12 +00:00
Ben Halpern
a30b86a025
Allow billboards to target specific pages with "fixed bottom" placement (#20748)
* Add page fixed bottom billboard

* Add page fixed bottom billboard

* Fix schema
2024-03-15 14:32:30 -04:00
Anna Buianova
53f311b059
Add tag moderators by username w/o autocomplete (#20767) 2024-03-15 14:15:51 -04:00
Philip How
57c0078bd6
Allow admins to change reputation modifier (#20766)
* Allow admins to change reputation modifier

* locale + rubocop
2024-03-15 10:46:19 -04:00
Ben Halpern
a22172ec20
Add safe navigation to billboard.js conditionals (#20769) 2024-03-13 10:29:13 -04:00
Anna Buianova
f572275c9d
Admin access for spammers profiles and articles (#20721)
* Allow admins to visit spammers profiles and articles pages

* Added spam label to user profile and articles

* Unset cache control headers when providing admin access to spam content

* Removed unused comment
2024-03-12 13:25:59 -04:00
Ben Halpern
f4b94ce7f2
Early return from org follow check (#20761)
* Early return from org follow check

* Adjust podcast follow button

* Move early return to later
2024-03-11 18:24:19 -04:00
Ben Halpern
501b900108
Small digest style tweaks (#20763) 2024-03-11 18:09:17 -04:00
Ben Halpern
eb8006a841
Make ahoy_email default_options[:click] an env var (#20757)
* Make ahoy_email default_options[:click] an env var

* Also noted a typo here

* Manually mount AhoyEmail::Engine

* Disable by default

---------

Co-authored-by: Mac Siri <krairit.siri@gmail.com>
2024-03-11 15:43:55 -04:00
Ben Halpern
0d4f7c7e19
Add new simple a/b test for Digest subject and adjust config and design details (#20754)
* Adjust Digest Email design and configuration

* Adjust some tests

* Update tests

* More adjustments to markup and tests

* More adjustments to markup and tests

* Digest email feature flag

* Test title variants
2024-03-11 13:02:19 -04:00
Kim Emmanuel
04fb62a6f5
ignore code blocks when checking markdown for XSS (#20641)
Code blocks are rendered as raw strings and therefore don´t need to be
checked for XSS. Checking them for XSS disallow users to write articles about
XSS in markdown, for example.

Co-authored-by: Mac Siri <mac@forem.com>
2024-03-07 21:03:39 +00:00
Ben Halpern
fad28a1707
Allow feed billboards to be dismissable if dismissal_sku is present (#20737) 2024-03-06 15:16:23 -05:00
Ben Halpern
83878e9c10
Add classes to content wrapper for articles and pages (#20731)
* Add classes to content wrapper for articles and pages

* Add class name check

* Fix org check
2024-03-06 12:44:47 -05:00
Abhilash Gayen
be53be46f0
Fix hover style conflict in autocomplete dropdown (#20638)
Co-authored-by: Mac Siri <mac@forem.com>
2024-03-06 17:10:28 +00:00
Ben Halpern
f263e17a1f
Fix dataset check in JS (#20733)
* Fix dataset check in JS

* Email opt in quick fix

* Change test
2024-03-05 17:11:07 -05:00
Philip How
751e9d70d2
Show ⚠️ icon on /admin when an article is not indexed on search engines (#20713)
* Add in icon when an article is not indexed on admin

* tests

* rubocop

* rubocop
2024-03-05 21:34:20 +00:00
Philip How
7a873bd14c
Add a link icon to Mod Center to open article in new tab/window (#20672)
* add link icon to open article in new tab/window

* add label to icon

* add label to icon
2024-03-05 15:16:20 -05:00
Philip How
45a1bb20aa
Use request utility on actionsPanel (#20725) 2024-03-04 19:02:35 -05:00
Gabriel Quaresma
02459941a5
Profile bio does not recognize line breaks (#20572)
Co-authored-by: Mac Siri <mac@forem.com>
2024-03-04 20:37:16 +00:00
Ian Lourenço
bb6954bfb6
Fix: visual glitch with autocomplete component (#20611)
* fix: add display:block style to span and correct minor typo

* refactor: change posisiton and max-heigh on scss

* refactor: adapt message with conditional

---------

Co-authored-by: Mac Siri <mac@forem.com>
2024-03-04 19:47:32 +00:00
Gabriel Quaresma
ed584ff5dc
Fix successfully passing incorrect tests in actionsPanel.test.js (#20674)
* first commit

Co-authored-by: Guilherme Nunes <guilherme.nunes.lopes@gmail.com>

* feat: implementt rollbackReactionButtonsState

* test: write new test cases

* refactor: update rollbackReactionButtonsState

---------

Co-authored-by: Guilherme Nunes <guilherme.nunes.lopes@gmail.com>
Co-authored-by: Mac Siri <mac@forem.com>
2024-03-04 16:58:38 +00:00
Ben Halpern
0140a7631c
Adjust menu popup behavior contextually (#20718) 2024-03-01 17:27:50 -05:00
Ben Halpern
f2968baadb
Add optional client-side dismissal SKU for closable billboards (#20716)
* Add optional client-side dismissal SKU for closable billboards

* Safe nav
2024-03-01 16:13:19 -05:00
Anna Buianova
288c9ed31f
Fix articles counts based on display rules (#20669)
* Comment counts for signed in users

* Adjust comments count for articles

* Fixed counts for signed out users, added specs for Comments::Count

* Fixed counts for signed out and added specs for Comments::Count

* Removed debug info from the view

* Removed separate count for signed out users

* Remove irrelevant specs

* Remove unused scope
2024-03-01 07:54:15 -05:00
Philip How
fe213a81fa
Add Following Tags and Reconfigure Sidebar in Mod Center (#20694)
* reconfigure mod left sidebar, adding following tags

* add localization
2024-03-01 07:35:54 -05:00
Ben Halpern
c901eb48be
Apply efficiency adjustment to orgs as well (#20710) 2024-02-29 18:27:47 -05:00
Ben Halpern
2ad8b7a809
Fast follow on follow suggestion efficiency (#20709) 2024-02-29 18:05:21 -05:00
Ben Halpern
083732e2f3
Optimize and simplify onboarding recommendations (#20682)
* Improve performance of follow recs

* Finish and simplify

* Update tests

* Update tests

* Update tests

* Change onboardings_controller

* Adjust tests

* Change fallback to use score

* Adjust join
2024-02-29 15:57:52 -05:00
Anna Buianova
f8418a6415
Exclude articles from spammers and suspended users from /mod (#20692) 2024-02-28 17:36:56 +00:00
Ben Halpern
78f9bec3e7
Allow admin to declare whether to include the badge description in message (#20684)
* Allow admin to declare whether to include the badge description in badge achievement message

* Update spec/services/badges/award_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add proper acceptance to tests

* Tweak tests

* Switch to kwargs

* Clean up test acceptance

* Change interface

* Update spec/requests/admin/badge_achievements_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update app/services/badges/award.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Adjust interface

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-02-28 11:02:58 -05:00
Ben Halpern
585bea212d
Remove non-contextual content from signed-out version of page (#20686) 2024-02-27 15:15:05 -05:00
Ben Halpern
229c3fc3c0
Go to page you came from after onboarding when coming through billboard (#20675)
* Add proper location memory for onboarding

* Get test dates working as expected
2024-02-26 16:21:05 -05:00
Ben Halpern
4015b346e2
Finalize 'commnts to display' a/b test (#20679) 2024-02-26 11:06:17 -05:00
Ben Halpern
f88784cc35
Add configuration for admins to specify compliant email strategies (#20663)
* Add configuration for admins to specify compliant email strategies

* Add keys for test
2024-02-21 08:27:26 -08:00
Daniel M Brasil
406e3fec4d
Rremove de-indexing From Accounts With No Comments (#20660)
* remove de-indexing from accounts that have no comments

* add specs for Article#skip_indexing?
2024-02-21 10:54:02 +00:00
Ben Halpern
d8ed35a94e
Unwrap user before passing to field_test (#20667) 2024-02-20 16:28:52 -08:00
Ben Halpern
44809ce7e7
Add max style for fixed billboard (#20666) 2024-02-20 16:14:59 -08:00
Ben Halpern
223fb9cbfb
Add a/b test for feed style on new users (#20664)
* Add a/b test for feed style on new users

* Add current_user check

* Adjust to not look for current_user right away

* Move field test to the right place
2024-02-20 15:43:28 -08:00
Ben Halpern
17d81b6cb1
[Hotfix] Fix cache key (#20658)
* Fix cache key

* Small style tweak
2024-02-19 19:24:36 -08:00
Ben Halpern
caa7b5a63a
[Hot fix] Fix style bugs with registration page (#20656)
* Fix style bugs with registration page

* Small additonal style tweak

* Final style tweak
2024-02-19 18:48:50 -08:00
Ben Halpern
561bdb278c
Change value of signup in success score (#20647) 2024-02-18 10:30:59 -08:00
Ben Halpern
6ef9a83252
Make mobile runtime banner optional (#20637)
* Remove runtime banner

* Show/hide runtime banner setting

* Update app/views/layouts/application.html.erb

* Update app/views/layouts/application.html.erb

* Update app/views/layouts/application.html.erb
2024-02-16 10:45:41 -08:00
Anna Buianova
d0f3fb6fff
Optimize and test comments cache after score change (#20640)
* Add specs for caching article comments, use cache_key_with_version

* Optimize cache busting for spammer comments, reorganized related specs
2024-02-16 14:53:11 +00:00
Makar
c6cef39694
Persist selectedTag filtering of the reading list (#20601)
* persist selectedTag filtering of the reading list when coming back after reading an article

* bugfix -- could not filter back by all tags in mobile

* e2e tests for persisted filtering

---------

Co-authored-by: Mac Siri <mac@forem.com>
2024-02-16 13:06:21 +00:00
Ben Halpern
097057a8dc
New a/b tests for Feb 14 (#20632) 2024-02-14 15:57:41 -05:00
Ben Halpern
8eb41eef8e
Record billboard signup conversions (#20629)
* Record billboard signup conversions

* Update app/models/billboard_event.rb

* Modify click tracking
2024-02-14 14:18:57 -05:00
Ben Halpern
13c105a6b4
Use new_comment as the intersection object for delayed billboard (#20627) 2024-02-14 11:48:04 -05:00
Ben Halpern
205aee8c78
Add billboard for bottom of page with allowance to delay until after reading is finished. (#20616)
* Add delayed behavior

* Add special behavior to billboards

* Fix order for test

* Test clicking outside element when close event is present

* Update app/javascript/packs/billboardAfterRenderActions.js
2024-02-13 11:56:32 -05:00
Anna Buianova
fb09a75352
Update comment updated_at when changing score (#20622)
* Change comment updated_at when updating comment score

* Rubocop fixes
2024-02-13 13:17:24 +00:00
Mac Siri
248f0f55c0
Allow Slack::Messengers to be disabled (#20609) 2024-02-09 17:20:35 +00:00