Commit graph

7501 commits

Author SHA1 Message Date
dependabot-preview[bot]
04aefdf06c
Bump blazer from 2.2.8 to 2.3.0 (#11548)
* Bump blazer from 2.2.8 to 2.3.0

Bumps [blazer](https://github.com/ankane/blazer) from 2.2.8 to 2.3.0.
- [Release notes](https://github.com/ankane/blazer/releases)
- [Changelog](https://github.com/ankane/blazer/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/blazer/compare/v2.2.8...v2.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump blazer from 2.2.8 to 2.3.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 12:16:10 +01:00
dependabot-preview[bot]
9ba251fccb
Bump @babel/plugin-transform-react-jsx from 7.12.5 to 7.12.7 (#11537)
Bumps [@babel/plugin-transform-react-jsx](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-react-jsx) from 7.12.5 to 7.12.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.7/packages/babel-plugin-transform-react-jsx)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 05:59:49 -05:00
dependabot-preview[bot]
6f8511466e
Bump rubocop-performance from 1.8.1 to 1.9.0 (#11546)
* Bump rubocop-performance from 1.8.1 to 1.9.0

Bumps [rubocop-performance](https://github.com/rubocop-hq/rubocop-performance) from 1.8.1 to 1.9.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-performance/compare/v1.8.1...v1.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump rubocop-performance from 1.8.1 to 1.9.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:31:37 +01:00
dependabot-preview[bot]
fc744eea1e
Bump knapsack_pro from 2.8.0 to 2.9.0 (#11544)
* Bump knapsack_pro from 2.8.0 to 2.9.0

Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases)
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v2.8.0...v2.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump knapsack_pro from 2.8.0 to 2.9.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:16:12 +01:00
Oskar Janusz
39daa21add
Update Copy for Orgs Call-to-action Box (#11534) 2020-11-23 10:15:34 +01:00
dependabot-preview[bot]
f1b00f2376
Bump counter_culture from 2.6.2 to 2.7.0 (#11541)
* Bump counter_culture from 2.6.2 to 2.7.0

Bumps [counter_culture](https://github.com/magnusvk/counter_culture) from 2.6.2 to 2.7.0.
- [Release notes](https://github.com/magnusvk/counter_culture/releases)
- [Changelog](https://github.com/magnusvk/counter_culture/blob/master/CHANGELOG.md)
- [Commits](https://github.com/magnusvk/counter_culture/compare/v2.6.2...v2.7.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump counter_culture from 2.6.2 to 2.7.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:05:27 +01:00
dependabot-preview[bot]
9fe452fdb5
Bump prettier from 2.1.2 to 2.2.0 (#11545)
Bumps [prettier](https://github.com/prettier/prettier) from 2.1.2 to 2.2.0.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/prettier/compare/2.1.2...2.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:04:23 +01:00
dependabot-preview[bot]
8cceb1aaec
Bump eslint from 7.11.0 to 7.14.0 (#11542)
Bumps [eslint](https://github.com/eslint/eslint) from 7.11.0 to 7.14.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.11.0...v7.14.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:02:06 +01:00
dependabot-preview[bot]
54bf07a13e
Bump @babel/core from 7.12.3 to 7.12.7 (#11551)
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.12.3 to 7.12.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.7/packages/babel-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:01:45 +01:00
dependabot-preview[bot]
93baca9e64
Bump twilio-ruby from 5.42.0 to 5.43.0 (#11550)
* Bump twilio-ruby from 5.42.0 to 5.43.0

Bumps [twilio-ruby](https://github.com/twilio/twilio-ruby) from 5.42.0 to 5.43.0.
- [Release notes](https://github.com/twilio/twilio-ruby/releases)
- [Changelog](https://github.com/twilio/twilio-ruby/blob/main/CHANGES.md)
- [Commits](https://github.com/twilio/twilio-ruby/compare/5.42.0...5.43.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump twilio-ruby from 5.42.0 to 5.43.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 09:56:05 +01:00
dependabot-preview[bot]
c26221b025
Bump redis from 4.2.2 to 4.2.5 (#11555)
* Bump redis from 4.2.2 to 4.2.5

Bumps [redis](https://github.com/redis/redis-rb) from 4.2.2 to 4.2.5.
- [Release notes](https://github.com/redis/redis-rb/releases)
- [Changelog](https://github.com/redis/redis-rb/blob/master/CHANGELOG.md)
- [Commits](https://github.com/redis/redis-rb/compare/v4.2.2...v4.2.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump redis from 4.2.2 to 4.2.5 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 09:51:44 +01:00
Joe Doss
d7144ce787
Fix bundle issues and a few other things. (#11528)
* Fix bundle issues with the Multistage container
and adjusts a few other things:

- Disable ruby docs on bundler gem install
- Fix the bundle config
- chmod +x on scripts/build_containers.sh

* Add app/assets back into the builder image.

* Looks like running:

yarn install --frozen-lockfile \
&& RAILS_ENV=test NODE_ENV=test bundle exec rails webpacker:compile'

is super busted.

https://buildkite.com/forem/build-containers/builds/48#97451356-6552-40a1-8333-ac6fc0fccc3a

so let's just comment that out for now.
2020-11-21 17:25:09 -06:00
Mac Siri
f061b90316
Suppress Postcss warnings & Re-enable Benhalpern deploy (#11521) 2020-11-20 11:27:49 -05:00
Marcy Sutton
b9ae58816f
Accessibility: initial onboarding fixes (#11408)
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-11-20 11:13:39 -05:00
Molly Struve
e454772128
Update trusted role email Subject (#11519) 2020-11-20 09:54:21 -06:00
rhymes
2205f38261
Temporarily disable deploy to BenHalpern server (#11520) 2020-11-20 10:31:32 -05:00
Mac Siri
07287fa2bb
Replace podcast bar helpers with image_tag (#11502) 2020-11-20 09:45:56 -05:00
rhymes
90c12aa824
Attempt at disabling postcss-next warnings (#11518) 2020-11-20 14:19:32 +01:00
Michael Kohl
cd94fb2362
Update README (#11491)
* Update README

* Fix commit activity shield

* 🤦
2020-11-20 09:48:17 +07:00
Molly Struve
a07070e8bc
Update copy and links in Mod Sidebar (#11507) 2020-11-19 19:15:04 -06:00
Pat Hannon
151a2f53a6
Adds phannon as a Core contributor. (#11510) 2020-11-19 16:31:08 -06:00
Andy Zhao
827c9aa77c
Fix Facebook Login profile image download failure (#11478)
* Send a new request and use link in response for profile img

* Use fallback option and make method private

* Refactor and use constant template string

* Stub image_url method for tests

* Fix tests and mock response object properly

* Fix tests and mock response object properly

* Stub response for tests

* Refactor a bit and move into helper method

* Undo everything I did. today I will watch facebook burn.

* Use more foolproof string to gsub
2020-11-19 16:18:09 -05:00
Joe Doss
cd0647c757
Removes this dupe container block since we are going to run this pipeline (#11506)
on master branch pushes only in Buildkite specifically.
2020-11-19 15:05:49 -06:00
Molly Struve
cd0b90c67b
Update Trusted User Email Copy (#11505) 2020-11-19 14:54:06 -06:00
Joe Doss
b485ef2eb9
Jdoss/more buildkite container fixes (#11503)
* Fix bug on creating the testing container for PRs and create a function to
run docker image prune -f that will get run when the script exits cleanly or
uncleanly. This prevent junk containers from building up over time.

* Add in some labels and keys. Add in building containers on master branch.

* Let's also build on main branch for when we eventually move away from master.

* Let's use a previous builder image as a cache as it might speed things up.
2020-11-19 13:34:20 -06:00
Ben Halpern
4ecb7121e8
Fix menu dropdown disable issue (#11498)
* Fix menu dropdown disable issue

* Initial base work

* Remove wrongfully-included files
2020-11-19 13:55:29 -05:00
Joe Doss
3e2876da2c
I guess you can't use env vars for username and server. (#11499) 2020-11-19 12:14:30 -06:00
Joe Doss
1d4685219d
Multistage container builds (#11468)
* WIP multi-stage container build.

* Move to a multistage build process in the Containerfile.

* Enable testing container

* Finalize the multistage build script and Containerfile. Ooof!

I got blocked for a bit with this bugger:

Step 27/32 : COPY --from=builder --chown=${APP_USER}:${APP_USER} ${APP_HOME} ${APP_HOME}
failed to copy files: failed to copy directory: Error processing tar file(exit status 1): Container ID 100999 cannot be mapped to a host ID

but https://github.com/phusion/passenger-docker/issues/235#issuecomment-636318827

was a good shove in the right direction!

* Fix bugs on container build script.

* Adjust compose files to use multistage builds.

* Add in Buildkite pipeline for building containers.

* Update CODEOWNERS to claim ownership over things that Systems Eng cares about
2020-11-19 10:03:35 -06:00
Ben Halpern
c837834d6a
Remove under-used growth tab (#11495) 2020-11-19 10:53:36 -05:00
Jacob Herrington
77a35b378f
Fix seed values for ProfileFields (#11481)
These were all defaulting to "left_sidebar" which interfered with my
work some and doesn't really reflect how these will probably be used.
2020-11-19 09:13:49 -06:00
Manasa
b015690f4f
Podcast ownership join table (MLH Fellowship #81) (#11410)
* added podcast_ownership route

* added podcast_ownership table

* added podcast_ownership controller and pundit policy

* fixed codeclimate

* removed controller and pundit policy

* codeclimate

* codeclimate

* schema.rb

* schema.rb

* schema.rb

* user.rb

* made the suggested changes

* added validations

* fixed build error

* changed name to owned_podcasts

* added validation and tests

* added tests

* added tests

* changed spec

* added factory

* added factory

* merge conflict

* factory

* factory

* factory

* modified spec file

* modified spec file

* fix build error

* added class_name

* adjusted m2m relations

* made suggested changes

* fixed build error

* added subject

* schema

* ran migration

* removed index:true from singular fields

* changed schema file

* set index: false
2020-11-19 12:41:17 +01:00
rhymes
7c5794dcda
Remove boolean checks for validate_inclusion_of in specs (#11474) 2020-11-19 12:19:36 +01:00
Jacob Herrington
24b47029dd
Fix comment phrasing (#11480) 2020-11-18 21:52:33 -06:00
Ben Halpern
2ff7244c55
Add article cachebust backoff update script (#11472)
* Add article cachebust backoff update script

* ?i=i variant

* Change values

* Add select for optimization
2020-11-18 18:21:29 -05:00
ludwiczakpawel
70706d0a62
Comments UI update (#11283)
* tooltips 1.0.1

* tooltips 1.0.1

* init

* .

* drop not needed files

* .

* init

* init

* .

* comments

* border

* missing bits

* build comment JS

* .

* .

* specs

* sloan avatar fix

* bunch of fixes

* specs and fixes

* specs

* .

* swap order of links

* contrast

* js for dropdown

* icons

* op-author

* three dots icon

* reverts

* test: capybara- make sure that we click the dropdown before clicking on edit

* permalink --> link

* tiny fixes

* aria-label on form

* proper alt on user's avatar

* aria has popup

* use UL > LI instead of DIV

* add aria-labels to dropdown items

* another aria-label

* better links: nav

* contrast

Co-authored-by: Ridhwana <ridhwana.khan16@gmail.com>
2020-11-18 18:21:19 -05:00
Molly Struve
fd8f83dc7d
Feature:Backend Username Search Endpoint for Mention Completion (#11479)
* Feature:Backend Username Search Endpoint for Mention Completion

* ensure user is authenticated to use usernames endpoint

* update spec with authaa
2020-11-18 16:43:59 -06:00
Marcy Sutton
89e0ea79bb
Update PR template to prompt for accessibility (#11407)
* Add accessibility section to PR template

* Add accessibility section to Forem docs

* Incorporate PR review feedback
2020-11-18 11:52:57 -05:00
Akash Srivastava
2ee5ea69bd
Added published date as editable in admin articles list/show (#11124)
* Added published date as editable in admin articles list/show

* Added requests spec for articles published date update
2020-11-18 10:40:13 -06:00
rhymes
cb27662e8a
Recommend Redis 6 for Forem self installation (#11473) 2020-11-18 17:05:00 +01:00
Robin Gagnon
4fabc3a5e6
fix: Add hidden navigation link to article HTML (#11465) 2020-11-18 14:50:19 +01:00
Nick Taylor
8fabccec4e
Add Preact dev tools to development bundles (#11459)
* Now Preact dev tools are injected into development bundles.

* Updated frontend debugging documentation.

* Updated frontend debugging documentation wording.
2020-11-18 14:20:58 +01:00
rhymes
cbc461a850
Refactor RssReader and Feeds::Import common parts: take 1 (#11412)
* Extract Feeds::CheckMediumReplyItem service

* Extract Feeds::CheckItemPreviouslyImported

* Clarified comment on Feeds::CheckItemMediumReply (thanks @maestromac)

* Refactor a bit to be more Rubeyeyey
2020-11-18 14:17:53 +01:00
Nick Taylor
ed7f4561e3
Fixed <Snackbar /> component displayName property. (#11460) 2020-11-18 06:41:00 -05:00
Vaidehi Joshi
59ea42a372
Add community_emoji to SiteConfig (#11450)
* Add optional community_emoji to SiteConfig

* Remove hardcoded emojis, favor community_emoji instead

* Remove remaining hardcoded emojis

* Validate community_emoji field when updated
2020-11-17 14:02:04 -08:00
Fernando Valverde
449cf89737
Uses template literals to more clearly interpolate a complex string in buildArticleHTML.js (#11457) 2020-11-17 14:45:32 -06:00
Ben Halpern
f5670e6fa2
Add username to profile more info button (#11451)
* Add username to profile more info button

* Update spec/requests/user/user_profile_spec.rb

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

Co-authored-by: rhymes <rhymes@hey.com>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-11-17 10:07:47 -05:00
Ben Halpern
f3a69bbd84
Allow Forems to specify which domains are allowed for registration (#11442)
* Allow authors to restrict which emails can sign up

* Add form and tests

* Check for email presence in allowed email flow

* Fix test domains

* Fix codeclimate issue
2020-11-17 08:43:46 -05:00
Peter Frank
cc63725875
Change "use" to "Use" on Nav Link script (#11453)
Just noticed this on a brand new Forem and realized it was _probably_ a quick fix?
2020-11-17 14:40:13 +01:00
Molly Struve
6aa41bfba2
Optimization:Only Check Past Day for DataUpdateScript failures (#11448) 2020-11-17 06:39:58 -06:00
Molly Struve
cf619caf70
Refactor: Remove more_tag_weight_more_random_experiment (#11447) 2020-11-16 15:48:45 -06:00