maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
5087 commits 1 branch 0 tags 1.6 GiB
Commit graph

5087 commits

This branch
This branch
All branches
Author SHA1 Message Date
rhymes
0186fd9aee
Add Retry-After for API rate limit errors and document limits in API spec (#7444) 
* Add correct rate limit exception to Articles::Updater

* Send Retry-After with HTTP 429 back to the client

* Update API specs for error 429

* Test build

* Fix spec

* Add retry after to ImageUploadsController and fix specs

* Generalize a bit
 2020-04-24 17:35:28 +02:00
rhymes
1e5d831a3e
Remove unused markedjs (#7500) 2020-04-24 16:38:14 +02:00
Michael Kohl
f791e84f2d
Filter classified listings by published status for mods (#7432) 
* Filter classified listings by published status for mods

* Change checkbox label, invert logic, respect checked status
 2020-04-24 10:31:29 -04:00
Molly Struve
4ab202ab0a
[deploy] Execute Reading List searches in Elasticsearch (#7440) 
* Execute Reading List searches in Elasticsearch

* add additional readinglist front tests
 2020-04-24 10:30:17 -04:00
Mac Siri
57ae315c31
[deploy] Generalize Onboarding's task-card image (#7452) 
* Generalize Onboarding's task-card image

* Rename SiteConfig's onboarding_taskcard_sticker

* Add & reorganize #config_params

* Update Internal::Config's view

* Add spec
 2020-04-24 10:24:50 -04:00
Michael Kohl
02d23a0673
Refactor jbuilder (#7411) 
* Refactor jbuilder for articles

* Refactor remaining jbuilder files

* Fix specs

* Remove content_truncated from response template JSON

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
 2020-04-24 12:49:12 +02:00
Vaidehi Joshi
e19eb60d1f
Add skip/continue functionality to onboarding navigation (#7488) [deploy] 
* Dynamically render forward text in Navigation component

* Render either "Skip for now" or "Continue" on the FollowTags, ProfileForm, and FollowUsers components.
* Refactor the ProfileForm component to dynamically change the button text based on the form's state.

* Render specific button text for last onboarding slide

* Fix back arrow styles for accessibility

Also set an explicit width on the containing button around the svg.

* Use min-width to specify back-button size
 2020-04-23 16:30:48 -07:00
Julianna Tetreault
2a74f6f811
Refactor SEO Optimized Images (#7494) 
* Add seo_optimized_images method to article_json_ld
  * Add inline documentation for images in method
  * Add to stories_controller.rb with other JSON-LD

* Fix inconsistencies in stories_show_spec.rb tests
 2020-04-23 19:26:29 -04:00
rhymes
db9186043e
Removed yarn integrity check (#7478) 2020-04-23 19:23:12 -04:00
Alex
8b51d8e4b8
[deploy] Fix Fastly rake task spec and Travis CI (#7487) 
* Try changing exit to next

* Add breaking test

* Fix search.rake

* Remove test failure
 2020-04-23 16:06:57 -04:00
Alex
b6664456c0
[deploy] Validate filenames server-side (#7405) 2020-04-23 14:30:59 -05:00
dependabot-preview[bot]
5c6d811fa8
Bump ruby-prof from 1.3.1 to 1.3.2 (#7474) 
Bumps [ruby-prof](https://github.com/ruby-prof/ruby-prof) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/ruby-prof/ruby-prof/releases)
- [Changelog](https://github.com/ruby-prof/ruby-prof/blob/master/CHANGES)
- [Commits](https://github.com/ruby-prof/ruby-prof/compare/1.3.1...1.3.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-04-23 14:28:02 -05:00
dependabot-preview[bot]
04e8e8478c
Bump aws-sdk-lambda from 1.38.0 to 1.39.0 (#7473) 
Bumps [aws-sdk-lambda](https://github.com/aws/aws-sdk-ruby) from 1.38.0 to 1.39.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-lambda/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/compare/v1.38.0...v1.39.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-04-23 14:27:09 -05:00
dependabot-preview[bot]
905e4849b4
Bump eslint-config-prettier from 6.10.1 to 6.11.0 (#7462) 
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 6.10.1 to 6.11.0.
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-config-prettier/compare/v6.10.1...v6.11.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-04-23 15:19:52 -04:00
Alex
cc408d50e0
Fix Travis CI (#7486) 2020-04-23 13:23:34 -05:00
Ben Halpern
4a28f90b29
[deploy] Fix height/width mismatch (#7485) 2020-04-23 13:38:10 -04:00
dependabot-preview[bot]
07484361ec
Bump node-sass from 4.13.1 to 4.14.0 (#7464) 
Bumps [node-sass](https://github.com/sass/node-sass) from 4.13.1 to 4.14.0.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/compare/v4.13.1...v4.14.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
 2020-04-23 12:41:04 -04:00
dependabot-preview[bot]
f3213e964a
Bump lint-staged from 10.1.3 to 10.1.7 (#7461) 
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 10.1.3 to 10.1.7.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Commits](https://github.com/okonet/lint-staged/compare/v10.1.3...v10.1.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-04-23 12:40:16 -04:00
Molly Struve
7f98d7e54c
[deploy] Revert "Remove algolia from podcast episode model (#7453)" (#7481) 
This reverts commit b29671cb7f.
 2020-04-23 11:01:01 -05:00
rhymes
6d9ecb45e6
[deploy] Authentication refactoring: improve testing on OmniauthCallbacksController (#7439) 
* Improve testing on OmniauthCallbacksController

* Remove removal of legacy cookie and added validation comments
 2020-04-23 17:27:04 +02:00
Molly Struve
b29671cb7f
[deploy] Remove algolia from podcast episode model (#7453) 2020-04-23 10:21:37 -05:00
dependabot-preview[bot]
7e7a4db973
Bump stripe from 5.17.0 to 5.18.0 (#7477) 
Bumps [stripe](https://github.com/stripe/stripe-ruby) from 5.17.0 to 5.18.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases)
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/stripe/stripe-ruby/compare/v5.17.0...v5.18.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-04-23 10:20:35 -05:00
dependabot-preview[bot]
f0f08f1da4
Bump fog-aws from 3.6.2 to 3.6.3 (#7472) 
Bumps [fog-aws](https://github.com/fog/fog-aws) from 3.6.2 to 3.6.3.
- [Release notes](https://github.com/fog/fog-aws/releases)
- [Changelog](https://github.com/fog/fog-aws/blob/master/CHANGELOG.md)
- [Commits](https://github.com/fog/fog-aws/compare/v3.6.2...v3.6.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-04-23 10:20:15 -05:00
dependabot-preview[bot]
91b1ce17ea
Bump sidekiq from 6.0.6 to 6.0.7 (#7471) 
Bumps [sidekiq](https://github.com/mperham/sidekiq) from 6.0.6 to 6.0.7.
- [Release notes](https://github.com/mperham/sidekiq/releases)
- [Changelog](https://github.com/mperham/sidekiq/blob/master/Changes.md)
- [Commits](https://github.com/mperham/sidekiq/compare/v6.0.6...v6.0.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-04-23 10:19:00 -05:00
Julianna Tetreault
91e4cd26ed
Specify SEO-Optimized Width and Height for Cover Images (#7447) 
* Specify SEO optimized width and height for cover images in articles JSON-LD
  * Specify 1:1 ratio for cover images in stories_controller.rb
  * Specify 4:3 ratio for cover images in stories_controller.rb
  * Specify 16:9 ratio for cover images in stories_controller.rb
  * Optimize images for SEO purposes by specifying width and height

* Change aspect ratio to be 1600x900 in stories_controller.rb
  * Makes aspect ratio for article cover images smaller in JSON-LD

* Add options to social_image_helper.rb
  * Adds options to article_social_image_url call
 2020-04-23 08:30:28 -06:00
Molly Struve
edcd019e9c
[deploy] Throttle General Site Requests (#7418) 2020-04-23 08:58:27 -05:00
dependabot-preview[bot]
02264a234d
Bump dogstatsd-ruby from 4.7.0 to 4.8.0 (#7470) 
Bumps [dogstatsd-ruby](https://github.com/DataDog/dogstatsd-ruby) from 4.7.0 to 4.8.0.
- [Release notes](https://github.com/DataDog/dogstatsd-ruby/releases)
- [Changelog](https://github.com/DataDog/dogstatsd-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/DataDog/dogstatsd-ruby/compare/v4.7.0...v4.8.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-04-23 09:45:40 -04:00
dependabot-preview[bot]
1560f39147
Bump intersection-observer from 0.8.0 to 0.9.0 (#7468) 
Bumps [intersection-observer](https://github.com/w3c/IntersectionObserver) from 0.8.0 to 0.9.0.
- [Release notes](https://github.com/w3c/IntersectionObserver/releases)
- [Commits](https://github.com/w3c/IntersectionObserver/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-04-23 09:44:58 -04:00
dependabot-preview[bot]
c2872e0de5
Bump webpacker from 5.0.1 to 5.1.1 (#7469) 
Bumps [webpacker](https://github.com/rails/webpacker) from 5.0.1 to 5.1.1.
- [Release notes](https://github.com/rails/webpacker/releases)
- [Changelog](https://github.com/rails/webpacker/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rails/webpacker/compare/v5.0.1...v5.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-04-23 09:44:21 -04:00
dependabot-preview[bot]
75ec29aa5b
Bump @rails/webpacker from 5.0.1 to 5.1.1 (#7466) 
Bumps [@rails/webpacker](https://github.com/rails/webpacker) from 5.0.1 to 5.1.1.
- [Release notes](https://github.com/rails/webpacker/releases)
- [Changelog](https://github.com/rails/webpacker/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rails/webpacker/compare/v5.0.1...v5.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-04-23 09:44:03 -04:00
dependabot-preview[bot]
50bc3b189f
Bump jest from 25.3.0 to 25.4.0 (#7467) 
Bumps [jest](https://github.com/facebook/jest) from 25.3.0 to 25.4.0.
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md)
- [Commits](https://github.com/facebook/jest/compare/v25.3.0...v25.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-04-23 09:43:43 -04:00
Anna Buianova
bc8df2bb57
Replaced hardcoded 'the practical dev' with the community name (#7460) 
* Replaced hardcoded 'the practical dev' with the configurable community name
* Replaced url with url helper
 2020-04-23 16:09:50 +03:00
Nick Taylor
d3171fb3c8
Created Snackbar components (#7415) 
Created the Snackbar components.
 2020-04-23 08:27:50 -04:00
Ridhwana
17fdc556ee
Generalization: Replace static dev emails with configurable ones. (#7438) 
* feat: update the email addresses in the site config

* chore: update the default email address everywhere

* feat: update the template for the config

* chore: remove default_site_mail as an allowed parameter

* feat: change biz@dev.to to teh business email address and with a subject

* feat: update partners@dev.to to use SiteConfig.email_addresses[:business]

* feta: update to business email address

* feat: update members@dev.to to use the site config

* feat: update privacy email

* chore: Anna's suggestion to loop through object instead of keys
 2020-04-23 11:26:58 +02:00
Michael Kohl
9df68f3920
Use new classified listing categories (#7250) 
* Add ClassifiedListingCategoryModel

* Add data update script for classified listing categories

* Refactor and fix specs

* Resolve conflict

* Incorporate PR feedback
 2020-04-23 10:06:58 +07:00
Vaidehi Joshi
046ec2eaee
Use back button svg icon in onboarding slides (#7455) [deploy] 2020-04-22 16:54:46 -07:00
Vaidehi Joshi
5f67f7b2e3
Add a progress stepper to onboarding flow (#7450) [deploy] 2020-04-22 13:59:43 -07:00
Julianna Tetreault
8b6566da6b
Allow Height and Width to be Specified in Options (#7417) 
* Allow height and width to be specified in options in CloudCoverUrl

* Allow height and width to be specified in options in social_image.rb
  * Remove options from cloud_cover_url.rb in favor of social_image.rb

* Add double splat operator for height and width options in social_image.rb
  * Add double splat operator to options in application_helper.rb
  * Add options to call in article_serializer.rb

* Remove options from the CloudCOverUrl call in application_helper.rb

* Remove options from article_serializer.rb

* Add height and width variables to cl_image_path
  * Remove hardcoded height and width from social_image.rb

* Adjust width to be 500 rather than 420 in social_image.rb
 2020-04-22 15:04:32 -04:00
Ben Halpern
f677e7f4f0
[deploy] Fix task card unstyled issue for rollout (#7449) 2020-04-22 14:24:38 -04:00
Mac Siri
a181a3af3a
[deploy] Remove Onboarding's ClosingSlide (#7443) 2020-04-22 14:08:10 -04:00
Molly Struve
73120a67c9
[deploy] Bug Fix: Use strings with colons for all Datadog tags (#7442) 2020-04-22 12:24:57 -05:00
ludwiczakpawel
16560d9ef1
Settings style updates: Crayons! (#7393) 
* .

* .

* .

* snapshot

* whoops

* halifax

* tests

* little fixes

* little fixes

* test? i guess..

* .

* minor fixes

* Update schema.rb

* Use shared logo_design in new org partial

* little fix

* Fix org spec

* decrayonsifying rich-selector

* if statement

Co-authored-by: rhymes <rhymesete@gmail.com>
 2020-04-22 19:18:19 +02:00
Maja Komel
4499e5eb6e
[deploy] Add Wikipedia liquid tag (#7193) 2020-04-22 17:54:56 +02:00
Vaidehi Joshi
844c20b560
Reorder onboarding slides (#7429) 
Swap FollowTags with ProfileForm
 2020-04-22 11:51:34 -04:00
Alex
397734b29c
Generalize Fastly rake task (#7349) 
* Generalize Fastly rake task

- Update Rubocop to disable DescribeClass on rake task specs

* Change default Fastly ENV vars to ""

* Move snippet name to ENV

* Update ENV to FASTLY_WHITELIST_PARAMS_SNIPPET_NAME

* Add FASTLY_WHITELIST_PARAMS_SNIPPET_NAME to the docs

* Update docs

* Quick refactor
 2020-04-22 11:49:54 -04:00
Mac Siri
4edf1c5ada
[deploy] Create onboarding task card (#7369) 2020-04-22 11:46:49 -04:00
Vaidehi Joshi
638fd8f1ad
[deploy] Wrap user/identity coupled logic in a transaction (#7368) 
* Wrap user/identity coupled logic in a transaction

Creating a user and then setting an identiy should occur as an all-or-nothing step.
Wrapping this in an ActiveRecord::Transaction ensures that we don't update an identity
unless we succesfully create/update the user first in the same database transaction.

* Allow errors from authenticator service to bubble up

* Address some issues with logic in ActiveRecord::Base.transaction

* Pull out calls to DataDog from transaction.
* Add additional DataDog call in case something goes wrong in the transaction.
* Rename some methods, add some specs.

* Re-raise errors after notifying DataDog

* Add error message to DataDog tags in Authenticator
 2020-04-22 11:05:46 -04:00
Anna Buianova
983c3d28dd
Replaced remaining hardcoded DEV with the configurable community name (#7435) 
* Replaced hardcoded DEV and dev.to remainders with the configurable name
* Removed hardcoded dev.to from the rss feed
 2020-04-22 17:16:21 +03:00
Anna Buianova
40b5efa517
Make database url for test env different from the dev env one (#7437) 2020-04-22 17:14:26 +03:00
Molly Struve
de88a08ebd
[deploy] handle rate limit errors gracefully (#7422) 2020-04-22 08:55:26 -05:00