Fernando Valverde
010e0fc2db
Replace Ahoy metric logging with ForemStatsClient on Community Wellness Badge service ( #17542 )
...
* ForemStatsClient.increment
* Include ForemStatsClient check on spec
* Update app/services/badges/award_community_wellness.rb
2022-05-03 09:31:38 -06:00
dependabot[bot]
5a4c1df9b8
Bump autoprefixer from 10.4.5 to 10.4.7 ( #17554 )
...
Bumps [autoprefixer](https://github.com/postcss/autoprefixer ) from 10.4.5 to 10.4.7.
- [Release notes](https://github.com/postcss/autoprefixer/releases )
- [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md )
- [Commits](https://github.com/postcss/autoprefixer/compare/10.4.5...10.4.7 )
---
updated-dependencies:
- dependency-name: autoprefixer
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-03 09:07:06 -06:00
dependabot[bot]
9a8962eab2
Bump eslint from 8.13.0 to 8.14.0 ( #17558 )
...
Bumps [eslint](https://github.com/eslint/eslint ) from 8.13.0 to 8.14.0.
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/compare/v8.13.0...v8.14.0 )
---
updated-dependencies:
- dependency-name: eslint
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-03 08:24:13 -06:00
dependabot[bot]
b0c706afa7
Bump focus-trap from 6.8.1 to 6.9.0 ( #17551 )
...
Bumps [focus-trap](https://github.com/focus-trap/focus-trap ) from 6.8.1 to 6.9.0.
- [Release notes](https://github.com/focus-trap/focus-trap/releases )
- [Changelog](https://github.com/focus-trap/focus-trap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/focus-trap/focus-trap/compare/v6.8.1...v6.9.0 )
---
updated-dependencies:
- dependency-name: focus-trap
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-03 10:04:30 -04:00
dependabot[bot]
dbbb11af92
Bump @babel/core from 7.17.9 to 7.17.10 ( #17547 )
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.17.9 to 7.17.10.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.17.10/packages/babel-core )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-03 07:43:45 -06:00
Ridhwana
b598ece277
feat: remove unused partial ( #17537 )
2022-05-03 09:42:55 -04:00
dependabot[bot]
60b07b857d
Bump @faker-js/faker from 6.2.0 to 6.3.1 ( #17552 )
...
Bumps [@faker-js/faker](https://github.com/faker-js/faker ) from 6.2.0 to 6.3.1.
- [Release notes](https://github.com/faker-js/faker/releases )
- [Changelog](https://github.com/faker-js/faker/blob/main/CHANGELOG.md )
- [Commits](https://github.com/faker-js/faker/compare/v6.2.0...v6.3.1 )
---
updated-dependencies:
- dependency-name: "@faker-js/faker"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-03 09:42:19 -04:00
dependabot[bot]
e709f34ba5
Bump lint-staged from 12.3.8 to 12.4.1 ( #17553 )
...
Bumps [lint-staged](https://github.com/okonet/lint-staged ) from 12.3.8 to 12.4.1.
- [Release notes](https://github.com/okonet/lint-staged/releases )
- [Commits](https://github.com/okonet/lint-staged/compare/v12.3.8...v12.4.1 )
---
updated-dependencies:
- dependency-name: lint-staged
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-03 09:41:40 -04:00
dependabot[bot]
7696fdfffb
Bump recaptcha from 5.9.0 to 5.10.0 ( #17523 )
...
Bumps [recaptcha](https://github.com/ambethia/recaptcha ) from 5.9.0 to 5.10.0.
- [Release notes](https://github.com/ambethia/recaptcha/releases )
- [Changelog](https://github.com/ambethia/recaptcha/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ambethia/recaptcha/compare/v5.9.0...v5.10.0 )
---
updated-dependencies:
- dependency-name: recaptcha
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-03 06:59:50 -06:00
dependabot[bot]
f38badaa47
Bump stripe from 5.52.0 to 5.53.0 ( #17524 )
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 5.52.0 to 5.53.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v5.52.0...v5.53.0 )
---
updated-dependencies:
- dependency-name: stripe
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-03 06:59:31 -06:00
dependabot[bot]
c67b099298
Bump brakeman from 5.2.2 to 5.2.3 ( #17548 )
...
Bumps [brakeman](https://github.com/presidentbeef/brakeman ) from 5.2.2 to 5.2.3.
- [Release notes](https://github.com/presidentbeef/brakeman/releases )
- [Changelog](https://github.com/presidentbeef/brakeman/blob/main/CHANGES.md )
- [Commits](https://github.com/presidentbeef/brakeman/compare/v5.2.2...v5.2.3 )
---
updated-dependencies:
- dependency-name: brakeman
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-03 06:59:02 -06:00
dependabot[bot]
6e5b3eba3f
Bump core-js from 3.22.2 to 3.22.4 ( #17546 )
...
Bumps [core-js](https://github.com/zloirock/core-js ) from 3.22.2 to 3.22.4.
- [Release notes](https://github.com/zloirock/core-js/releases )
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zloirock/core-js/compare/v3.22.2...v3.22.4 )
---
updated-dependencies:
- dependency-name: core-js
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-03 06:58:43 -06:00
dependabot[bot]
1fdf99cb95
Bump postcss from 8.4.12 to 8.4.13 ( #17545 )
...
Bumps [postcss](https://github.com/postcss/postcss ) from 8.4.12 to 8.4.13.
- [Release notes](https://github.com/postcss/postcss/releases )
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md )
- [Commits](https://github.com/postcss/postcss/compare/8.4.12...8.4.13 )
---
updated-dependencies:
- dependency-name: postcss
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-03 06:58:22 -06:00
dependabot[bot]
b01ec6ec74
Bump babel-jest from 28.0.0 to 28.0.3 ( #17544 )
...
Bumps [babel-jest](https://github.com/facebook/jest/tree/HEAD/packages/babel-jest ) from 28.0.0 to 28.0.3.
- [Release notes](https://github.com/facebook/jest/releases )
- [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md )
- [Commits](https://github.com/facebook/jest/commits/v28.0.3/packages/babel-jest )
---
updated-dependencies:
- dependency-name: babel-jest
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-03 06:58:04 -06:00
dependabot[bot]
026de53830
Bump pghero from 2.8.2 to 2.8.3 ( #17549 )
...
Bumps [pghero](https://github.com/ankane/pghero ) from 2.8.2 to 2.8.3.
- [Release notes](https://github.com/ankane/pghero/releases )
- [Changelog](https://github.com/ankane/pghero/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ankane/pghero/compare/v2.8.2...v2.8.3 )
---
updated-dependencies:
- dependency-name: pghero
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-03 07:28:27 -04:00
Suzanne Aitchison
25bf8a0711
Remove name from invitation flow ( #17438 )
...
* remove name from invite user flow
* remove name from invitation instructions
* update invitations spec
* update specs and invitation actions overflow menu name
* allow users to set name when accepting invite
2022-05-03 09:33:12 +01:00
Daniel Uber
b2c7f7a5a3
Use Sidekiq::Job module alias for Sidekiq::Worker ( #17526 )
2022-05-02 11:12:58 -05:00
Daniel Uber
a9b2164be9
Don't modify environment global in tests ( #16943 )
2022-05-02 11:11:43 -05:00
Thomas Bnt
fd2614ea80
Edit URL deployment to GitPod ( #16795 )
...
* Edit URL deployment to GitPod
* Added Getting Started with Gitpod
2022-05-02 09:50:56 -04:00
dependabot[bot]
6d9f0b9d44
Bump sidekiq-unique-jobs from 7.1.19 to 7.1.21 ( #17525 )
...
Bumps [sidekiq-unique-jobs](https://github.com/mhenrixon/sidekiq-unique-jobs ) from 7.1.19 to 7.1.21.
- [Release notes](https://github.com/mhenrixon/sidekiq-unique-jobs/releases )
- [Changelog](https://github.com/mhenrixon/sidekiq-unique-jobs/blob/main/CHANGELOG.md )
- [Commits](https://github.com/mhenrixon/sidekiq-unique-jobs/compare/v7.1.19...v7.1.21 )
---
updated-dependencies:
- dependency-name: sidekiq-unique-jobs
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-02 07:26:51 -04:00
dependabot[bot]
df744cebb1
Bump sidekiq-cron from 1.3.0 to 1.4.0 ( #17518 )
...
Bumps [sidekiq-cron](https://github.com/ondrejbartas/sidekiq-cron ) from 1.3.0 to 1.4.0.
- [Release notes](https://github.com/ondrejbartas/sidekiq-cron/releases )
- [Changelog](https://github.com/ondrejbartas/sidekiq-cron/blob/master/Changes.md )
- [Commits](https://github.com/ondrejbartas/sidekiq-cron/compare/v1.3.0...v1.4.0 )
---
updated-dependencies:
- dependency-name: sidekiq-cron
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-29 15:57:35 -05:00
Daniel Uber
592f3c5f97
ignore CVE-2022-27311 ( #17527 )
...
The discussion on the gibbon PR (321) suggests the following:
- this would only be a problem if you accepted an API key via user
input
- That's correct, I implemented what I believe is a complete fix in
3.4.4.
This conflicts with the github advisory (and bundle audit).
We do accept mailchimp api keys from user input (restricted to
the admin area).
It looks like the underlying conflict is around domain
include?(api.mailchimp.com) permitting matches that aren't
authoritative (for example, api.mailchimp.completelyhijacked.xyz would
"include?" the right domain).
2022-04-29 15:27:11 -05:00
dependabot[bot]
6b58a70695
Bump ransack from 3.0.1 to 3.1.0 ( #17520 )
...
Bumps [ransack](https://github.com/activerecord-hackery/ransack ) from 3.0.1 to 3.1.0.
- [Release notes](https://github.com/activerecord-hackery/ransack/releases )
- [Changelog](https://github.com/activerecord-hackery/ransack/blob/main/CHANGELOG.md )
- [Commits](https://github.com/activerecord-hackery/ransack/compare/v3.0.1...v3.1.0 )
---
updated-dependencies:
- dependency-name: ransack
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-29 14:15:27 -05:00
dependabot[bot]
67595b2a19
Bump rubocop from 1.27.0 to 1.28.2 ( #17519 )
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.27.0 to 1.28.2.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.27.0...v1.28.2 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-29 14:13:54 -05:00
dependabot[bot]
195f7612c0
Bump rspec-rails from 5.1.1 to 5.1.2 ( #17521 )
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v5.1.1...v5.1.2 )
---
updated-dependencies:
- dependency-name: rspec-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-29 14:13:28 -05:00
dependabot[bot]
edc64f0576
Bump sidekiq from 6.4.1 to 6.4.2 ( #17522 )
...
Bumps [sidekiq](https://github.com/mperham/sidekiq ) from 6.4.1 to 6.4.2.
- [Release notes](https://github.com/mperham/sidekiq/releases )
- [Changelog](https://github.com/mperham/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/mperham/sidekiq/compare/v6.4.1...v6.4.2 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-29 14:12:25 -05:00
Fernando Valverde
c4df397fef
Community Wellness badge ( #17394 )
...
* First greedy algorithm approach to awarding community wellness badge
* Update app/services/badges/award_community_wellness.rb
I'm sorry I ignored you rubocop. It's still on draft for a reason 😅
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/badges/award_community_wellness.rb
Okay, whatever you say rubocop. This line will go away before merging anyways
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Use app/queries/comments/community_wellness_query.rb to replace greedy algorithm
* Query indenting + rename positive_reactions to negative_reactions in EXCEPT
* First step towards query spec
* Fix spec and make it more robust
* Slight cleanup/tweaks
* Badge reward & message
* copy edits + spec improvements + 3 days ago min for query
* Cron update to run daily + small tweak for FeatureFlag use
* inline comment tweaks
* Slight reorder of guard checks in service (FeatureFlag related)
* PR review feedback
* Fix specs from static method refactor
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-04-29 12:38:40 -06:00
Daniel Uber
37a82b8393
Update readme ( #17517 )
2022-04-29 14:14:49 -04:00
Daniel Uber
3b4e266e29
drop monthly dues from users ( #17515 )
...
* Drop monthly_dues column from users
After #17514 there are no uses of this legacy column.
* commit schema change after migration
2022-04-29 12:50:27 -05:00
Daniel Uber
d571231ea4
Remove sustaining member newsletter, and its settings ( #17514 )
...
* Remove sustaining member newsletter, and its settings
This removes the concept of sustaining memberships from the system,
and logic related to or dependent on it.
This does not remove the monthly_dues column from the users table (todo).
* Remove unused newsletter setting
Since nothing accesses the mailchimp_sustaining_members_id setting,
it's safe to remove.
* Use destroy rather than delete to ensure settings cache is cleared
We have a callback in Settings::Base to clear the cache after commit,
I assume it's useful to trigger that. This requires destroy, not
delete, to be called.
2022-04-29 11:47:12 -05:00
Jeremy Friesen
b2322a881a
Removing unused feature flag reference ( #17516 )
...
This PR does three things:
1. Removes a feature flag reference
2. Renames optimized to the large_forem_experimental (a value that
occurs in the code base)
3. Wraps two specs in a similar context as a later appearing spec (hence
the larger appearing change due to indentation adjustments)
Closes forem/forem#17510
2022-04-29 12:14:34 -04:00
Arit Amana
4b04d06adf
Show Series counts on all Dashboard Tabs ( #17513 )
...
* implementation and tests
* refactor specs
2022-04-29 11:58:06 -04:00
dependabot[bot]
18a2ce4e51
Bump cross-fetch from 3.1.4 to 3.1.5 ( #17505 )
...
Bumps [cross-fetch](https://github.com/lquixada/cross-fetch ) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/lquixada/cross-fetch/releases )
- [Commits](https://github.com/lquixada/cross-fetch/compare/v3.1.4...v3.1.5 )
---
updated-dependencies:
- dependency-name: cross-fetch
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-29 10:55:01 -05:00
Arit Amana
5648782ec0
Sharpen RegEx that matches Forem-specific links ( #17500 )
...
* first iteration of solution
* fix oversight
* cover pathless and invalid forem links
* more test cases
* more readable regex 🥳
2022-04-29 11:34:32 -04:00
Ridhwana
994a121c62
feat: add search by email back ( #17511 )
2022-04-29 09:59:10 -04:00
Jeremy Friesen
b808843564
Updating documentation for the relevancy feed ( #17503 )
...
* Updating documentation for the relevancy feed
This looks to remove the chatter of the document and instead point folks
to locations within the code.
Closes forem/forem#17245
* Update app/models/articles/feeds/README.md
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
* Update app/models/articles/feeds/README.md
Co-authored-by: Arit Amana <32520970+msarit@users.noreply.github.com>
* Update app/models/articles/feeds/README.md
Co-authored-by: Arit Amana <32520970+msarit@users.noreply.github.com>
* Update app/models/articles/feeds/README.md
Co-authored-by: Arit Amana <32520970+msarit@users.noreply.github.com>
* Update app/models/articles/feeds/README.md
Co-authored-by: Arit Amana <32520970+msarit@users.noreply.github.com>
* Update app/models/articles/feeds/README.md
Co-authored-by: Arit Amana <32520970+msarit@users.noreply.github.com>
* Update app/models/articles/feeds/README.md
Co-authored-by: Arit Amana <32520970+msarit@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Arit Amana <32520970+msarit@users.noreply.github.com>
* Update app/models/articles/feeds/README.md
Co-authored-by: Arit Amana <32520970+msarit@users.noreply.github.com>
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
Co-authored-by: Arit Amana <32520970+msarit@users.noreply.github.com>
2022-04-29 09:50:05 -04:00
Suzanne Aitchison
648c86c612
Add prop for user-defined selections in MultiSelectAutocomplete ( #17402 )
...
* add new prop and update specs
* update storybook
2022-04-29 09:39:25 +01:00
Arit Amana
0d023163ba
Hide 'Save' button on posts that belong to the current user ( #17293 )
...
* implement change
* struggling with tests
* extend implementation to relevant views
* update Article.test.jsx snapshot
* fix failing specs
* query userData more robustly
* default saveable value in SaveButton component
* fix spec
* fetch currentUser async
2022-04-28 12:33:01 -04:00
YOSHIDA Katsuhiko
89fcd84f9f
Replace git.io URL ( #17501 )
2022-04-28 07:34:33 -06:00
Jeremy Friesen
7e62d8098f
Removing conditional for AdminMenu's spaces ( #17162 )
...
When we merge this, Forem admins will see the "Admin > Content Manager >
Spaces" section in their Admin area. This will then allow them to
toggle on and off spaces.
Closes forem/forem#17161
2022-04-28 08:49:59 -04:00
Daniel Uber
42aad1d7e0
fix typo ( #17497 )
2022-04-27 16:52:28 -05:00
Mac Siri
4b37f2384c
Refactor OnboardingsController ( #17329 )
...
* Refactor OnboardingsController
* Fix broken spec
* Update policy
* Fix spec
* Update config/routes.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Touchup
* Update routes
* Screw it, let's move notification_settings too
* Revert "Screw it, let's move notification_settings too"
This reverts commit aead8c05f4dda62cbc46cdd033afd0acdef2ad73.
* Temp .travis.yml changes
* Revert "Temp .travis.yml changes"
This reverts commit c26109843ba027f9a524e66282a9b01f0341f836.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-04-27 16:17:02 -04:00
dependabot[bot]
8e9eb7dbb4
Bump jest-watch-typeahead from 1.0.0 to 1.1.0 ( #17427 )
...
Bumps [jest-watch-typeahead](https://github.com/jest-community/jest-watch-typeahead ) from 1.0.0 to 1.1.0.
- [Release notes](https://github.com/jest-community/jest-watch-typeahead/releases )
- [Changelog](https://github.com/jest-community/jest-watch-typeahead/blob/main/CHANGELOG.md )
- [Commits](https://github.com/jest-community/jest-watch-typeahead/compare/v1.0.0...v1.1.0 )
---
updated-dependencies:
- dependency-name: jest-watch-typeahead
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-27 13:05:27 -04:00
Daniel Uber
913ca720a8
Don't create podcast episodes without any media ( #17449 )
...
* Don't create podcast episodes without a media_url
There is an early return from add_media_url to prevent using an empty
enclosure_url, which avoids errors in
`GetMediaUrl.call(a_blank_value)`, however there's also a not null
constraint on podcast_episodes.media_url in the database, which causes
upsert to raise an error.
Returning early here avoids the error (which had halted the worker).
See also
https://app.honeybadger.io/projects/66984/faults/80833402
This error happens regularly, 96 times per day in DEV, it looks like at least
one podcast feed_url is for an rss feed filtered by /tag/podcast/,
(and at least one post was tagged "podcast" but didn't include any
media to get).
My understanding is at worst we'll ignore the error silently.
* Add test cases
given a blog post (not a podcast episode, no media url), don't raise
any error, don't create any episode.
Included codepunk.io feed that was showing this issue initially.
2022-04-27 11:21:03 -05:00
Mahmoud Harmouch
e4af0ad549
Fixed a grammatical error. ( #17413 )
...
* Fixed a grammatical error.
Signed-off-by: Harmouch101 <eng.mahmoudharmouch@gmail.com>
* Updated a test case.
Signed-off-by: Harmouch101 <eng.mahmoudharmouch@gmail.com>
2022-04-27 08:24:57 -06:00
dependabot[bot]
2bc63d6650
Bump focus-trap from 6.7.3 to 6.8.1 ( #17425 )
...
* Bump focus-trap from 6.7.3 to 6.8.1
Bumps [focus-trap](https://github.com/focus-trap/focus-trap ) from 6.7.3 to 6.8.1.
- [Release notes](https://github.com/focus-trap/focus-trap/releases )
- [Changelog](https://github.com/focus-trap/focus-trap/blob/master/CHANGELOG.md )
- [Commits](https://github.com/focus-trap/focus-trap/compare/v6.7.3...v6.8.1 )
---
updated-dependencies:
- dependency-name: focus-trap
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* mock tabbable in jest
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2022-04-27 08:09:21 -06:00
Daniel Uber
060e426389
validate sort direction ( #17439 )
...
* Prefer compact_blank! to delete_if blank
Rubocop suggested this. Why would I argue.
* When sort_direction is anything other than asc or desc, remove it
There is initializer code in the search/query classes that handles nil
sort_direction by adding a default value, so deleting the sort
direction is reasonable here.
* Set a default sort direction for articles of :desc
* Only sort if sort_direction and sort_by are present
* Add test case for article search with invalid parameter
2022-04-27 08:59:13 -05:00
Jeremy Friesen
4bc181503f
Removing WeightedQueryStrategy; use VariantQuery now ( #17420 )
...
You had a good ride, but your successor, the
`Articles::Feeds::VariantQuery`, is doing well in production. And has
been for quite awhile.
You helped us get to a better spot in regards to the feed algorithm, but
your time has come to rest as a memory in our git history.
2022-04-27 09:19:09 -04:00
Jeremy Friesen
daee1f95f4
Updating Rails dependency per CVE ( #17440 )
...
https://rubyonrails.org/2022/4/26/Rails-7-0-2-4-6-1-5-1-6-0-4-8-and-5-2-7-1-have-been-released
2022-04-27 07:33:14 -04:00
yheuhtozr
ef290a5120
controllers/admin i18n ( #17085 )
...
* admin controllers i18n
* remove ja.yml
* fix for spec
* fix for spec 2
* Apply suggestions from code review
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
* Update config/locales/controllers/admin/fr.yml
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
2022-04-26 09:40:09 -06:00
