Use Sidekiq::Job module alias for Sidekiq::Worker (#17526)

This commit is contained in:
Daniel Uber 2022-05-02 11:12:58 -05:00 committed by GitHub
parent a9b2164be9
commit b2c7f7a5a3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
76 changed files with 79 additions and 79 deletions

View file

@ -1,6 +1,6 @@
module Articles
class BustMultipleCachesWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10
def perform(article_ids)

View file

@ -1,6 +1,6 @@
module Articles
class EnrichImageAttributesWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority, retry: 5, lock: :until_executing

View file

@ -1,6 +1,6 @@
module Articles
class ScoreCalcWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority, lock: :until_executing

View file

@ -1,6 +1,6 @@
module Articles
class UpdateOrganicPageViewsWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority,
lock: :until_executing,

View file

@ -1,6 +1,6 @@
module Articles
class UpdatePageViewsWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority,
lock: :until_executing,

View file

@ -1,6 +1,6 @@
module BadgeAchievements
class BadgeAwardWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :high_priority, retry: 10

View file

@ -1,6 +1,6 @@
module BadgeAchievements
class SendEmailNotificationWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Broadcasts
class SendWelcomeNotificationsWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority, retry: 15

View file

@ -1,5 +1,5 @@
class BustCacheBaseWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :high_priority, retry: 15, lock: :until_executing
end

View file

@ -1,5 +1,5 @@
class CaptureQueryStatsWorker
include Sidekiq::Worker
include Sidekiq::Job
def perform
return unless ENV["PG_HERO_CAPTURE_QUERY_STATS"] == "true"

View file

@ -1,6 +1,6 @@
module Comments
class CalculateScoreWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority, lock: :until_executing

View file

@ -1,6 +1,6 @@
module Comments
class CreateFirstReactionWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :high_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Comments
class SendEmailNotificationWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :mailers

View file

@ -1,6 +1,6 @@
module Credits
class SyncCounterCache
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10

View file

@ -1,5 +1,5 @@
class DataUpdateWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :high_priority, retry: 5
def perform(id = nil)

View file

@ -1,6 +1,6 @@
module Discover
class RegisterWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 3

View file

@ -1,6 +1,6 @@
module Emails
class EnqueueDigestWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority, retry: 15

View file

@ -1,6 +1,6 @@
module Emails
class RemoveOldEmailsWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Emails
class SendUserDigestWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 15, lock: :until_executing

View file

@ -1,5 +1,5 @@
class ExportContentWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority, retry: 10, lock: :until_executed

View file

@ -1,6 +1,6 @@
module Feeds
class ImportArticlesWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority, retry: 10, lock: :until_and_while_executing
@ -34,7 +34,7 @@ module Feeds
end
class ForUser
include Sidekiq::Worker
include Sidekiq::Job
def perform(user_ids, earlier_than)
users_scope = User.where(id: user_ids)

View file

@ -1,6 +1,6 @@
module Follows
class SendEmailNotificationWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :mailers, retry: 10
def perform(follow_id, mailer = NotifyMailer.name)

View file

@ -1,6 +1,6 @@
module Follows
class UpdatePointsWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10, lock: :until_executing
def perform(article_id, user_id)

View file

@ -1,6 +1,6 @@
module GithubRepos
class RepoSyncWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10, lock: :until_executing

View file

@ -1,6 +1,6 @@
module GithubRepos
class UpdateLatestWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority, retry: 10

View file

@ -1,6 +1,6 @@
module HtmlVariants
class RemoveOldDataWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 15

View file

@ -1,6 +1,6 @@
module Listings
class ExpireOldListingsWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 5

View file

@ -1,7 +1,7 @@
module Mentions
# This worker is currently only used to create mentions on comments.
class CreateAllWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :default, retry: 10
def perform(notifiable_id, notifiable_type)

View file

@ -1,6 +1,6 @@
module Mentions
class SendEmailNotificationWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :default, retry: 10
def perform(mention_id)

View file

@ -1,6 +1,6 @@
module Metrics
class CheckDataUpdateScriptStatuses
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10
def perform

View file

@ -1,6 +1,6 @@
module Metrics
class RecordBackgroundQueueStatsWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :high_priority, retry: 10
def perform

View file

@ -1,6 +1,6 @@
module Metrics
class RecordDailyNotificationsWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10
EVENT_TITLES = %w[

View file

@ -1,6 +1,6 @@
module Metrics
class RecordDailyUsageWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10
def perform

View file

@ -1,6 +1,6 @@
module Metrics
class RecordDataCountsWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10
def perform

View file

@ -2,7 +2,7 @@
# and we gave self-hosters some time to run it to we should be able to remove
# this.
class MigrateDataToWorkFieldWorker
include Sidekiq::Worker
include Sidekiq::Job
def perform(profile_id)
profile = Profile.find_by(id: profile_id)

View file

@ -1,6 +1,6 @@
module Moderator
class BanishUserWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :high_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Moderator
class SinkArticlesWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Moderator
class UnpublishAllArticlesWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority, retry: 10

View file

@ -1,6 +1,6 @@
module NotificationSubscriptions
class UpdateWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority, retry: 10, lock: :until_executing

View file

@ -1,6 +1,6 @@
module Notifications
class MentionWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10
def perform(mention_id)

View file

@ -1,6 +1,6 @@
module Notifications
class MilestoneWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Notifications
class ModerationNotificationWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Notifications
class NewBadgeAchievementWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10
def perform(badge_achievement_id)

View file

@ -1,6 +1,6 @@
module Notifications
class NewFollowerWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Notifications
class NewReactionWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Notifications
class NotifiableActionWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10
def perform(notifiable_id, notifiable_type, action)

View file

@ -1,6 +1,6 @@
module Notifications
class RemoveAllWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Notifications
class RemoveOldNotificationsWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Notifications
class TagAdjustmentNotificationWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Notifications
class UpdateWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority, retry: 10, lock: :until_executing

View file

@ -1,6 +1,6 @@
module Notifications
class WelcomeNotificationWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10
def perform(receiver_id, broadcast_id)

View file

@ -1,6 +1,6 @@
module Organizations
class DeleteWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :high_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Organizations
class UpdateOrganizationArticlesPathsWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :high_priority

View file

@ -1,6 +1,6 @@
module PodcastEpisodes
class CreateWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :high_priority

View file

@ -1,6 +1,6 @@
module PodcastEpisodes
class UpdateMediaUrlWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority

View file

@ -1,6 +1,6 @@
module Podcasts
class EnqueueGetEpisodesWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Podcasts
class GetEpisodesWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :high_priority, retry: 10

View file

@ -1,6 +1,6 @@
module PushNotifications
class CleanupWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10, lock: :until_and_while_executing

View file

@ -1,6 +1,6 @@
module PushNotifications
class DeliverWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority,
retry: 10,

View file

@ -1,6 +1,6 @@
module RatingVotes
class AssignRatingWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10, lock: :until_executing

View file

@ -1,6 +1,6 @@
module Reactions
class BustHomepageCacheWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :high_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Reactions
class BustReactableCacheWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :high_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Reactions
class UpdateRelevantScoresWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :high_priority, retry: 10

View file

@ -1,7 +1,7 @@
module Slack
module Messengers
class Worker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :default, retry: 10

View file

@ -1,6 +1,6 @@
module Tags
class AliasRetagWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 5

View file

@ -1,6 +1,6 @@
module Tags
class ResaveSupportedTagsWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 5

View file

@ -1,6 +1,6 @@
module Users
class DeleteWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :high_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Users
class FollowWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :high_priority, retry: 10, lock: :until_executed
def perform(user_id, followable_id, followable_type)

View file

@ -1,6 +1,6 @@
module Users
class MergeSyncWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :high_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Users
class RecordFieldTestEventWorker
include Sidekiq::Worker
include Sidekiq::Job
include FieldTest::Helpers
sidekiq_options queue: :low_priority, retry: 10

View file

@ -1,6 +1,6 @@
module Users
class ResaveArticlesWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :medium_priority, retry: 10, lock: :until_executing

View file

@ -1,6 +1,6 @@
module Users
class SubscribeToMailchimpNewsletterWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority, retry: 10, lock: :until_executed
def perform(user_id)

View file

@ -1,7 +1,7 @@
require "rails_helper"
class TestSidekiqWorker
include Sidekiq::Worker
include Sidekiq::Job
sidekiq_options queue: :low_priority
def perform(arg = nil)

View file

@ -112,7 +112,7 @@ RSpec.configure do |config|
config.before do
# Worker jobs shouldn't linger around between tests
Sidekiq::Worker.clear_all
Sidekiq::Job.clear_all
# Disable SSRF protection for CarrierWave specs
# See: https://github.com/carrierwaveuploader/carrierwave/issues/2531
# rubocop:disable RSpec/AnyInstance

View file

@ -72,7 +72,7 @@ RSpec.shared_examples "valid notifiable and has mentions" do
expect do
set_markdown_and_save(notifiable, "Hello, you are cool.")
described_class.call(notifiable)
Sidekiq::Worker.drain_all
Sidekiq::Job.drain_all
end
.to change { Mention.all.size }.by(-1)
.and change { Notification.all.size }.by(-1)

View file

@ -10,7 +10,7 @@ module SidekiqTestHelpers
return Sidekiq::Queues.jobs_by_queue[queue.to_s] if queue
return Sidekiq::Queues.jobs_by_worker[worker.to_s] if worker
Sidekiq::Worker.jobs
Sidekiq::Job.jobs
end
# Asserts that the number of enqueued jobs matches the given number.
@ -89,7 +89,7 @@ module SidekiqTestHelpers
# Perform all Sidekiq jobs until there are no longer any in the queues
def drain_all_sidekiq_jobs
sidekiq_perform_enqueued_jobs while Sidekiq::Worker.jobs.any?
sidekiq_perform_enqueued_jobs while Sidekiq::Job.jobs.any?
end
class Utils
@ -108,7 +108,7 @@ module SidekiqTestHelpers
def enqueued_jobs_size(only: nil, except: nil, queue: nil)
validate_option(only: only, except: except)
Sidekiq::Worker.jobs.count do |job|
Sidekiq::Job.jobs.count do |job|
job_class = job.fetch("class")
if only
next false unless Array(only).include?(job_class.constantize)