maverick/flex-template-web
1
0
Fork 0
mirror of https://github.com/kingomarnajjar/flex-template-web.git synced 2026-07-26 06:47:17 +10:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #178 from sharetribe/disable-image-sorting

Browse source 
Disable image sorting
This commit is contained in:
Mikko Koski 2017-05-18 09:37:33 +03:00 • committed by GitHub
commit 496100f308
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/components/AddImages/AddImages.js
View file

@ -73,7 +73,20 @@ Thumbnail.propTypes = {
imageId: uuid,
};
const SortableImage = SortableElement(Thumbnail);
// Sorting is disabled temporarily.
//
// The issue with sorting is that in touch devices it makes
// scrolling the page really hard. The image takes 100% of the width
// of the device (minus margin) and thus the whole screen is filled
// up with the sortable images. When the user tries to scroll by dragging
// the finger on the device, it actually start to sort the images and
// not scroll.
//
// TODO Think what to do with the scrolling issue when sorting is in use
//
// TODO Enable me:
// const SortableImage = SortableElement(Thumbnail);
const SortableImage = Thumbnail;
// Create container where there are sortable images and passed children like "Add image" input etc.
const SortableImages = SortableContainer(props => {