From 920e204b9e77775bacab1a1337837130d3007b78 Mon Sep 17 00:00:00 2001 From: Mikko Koski Date: Thu, 18 May 2017 09:34:23 +0300 Subject: [PATCH] Disable image sorting --- src/components/AddImages/AddImages.js | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/components/AddImages/AddImages.js b/src/components/AddImages/AddImages.js index 44ffa487..722363bd 100644 --- a/src/components/AddImages/AddImages.js +++ b/src/components/AddImages/AddImages.js @@ -73,7 +73,20 @@ Thumbnail.propTypes = { imageId: uuid, }; -const SortableImage = SortableElement(Thumbnail); +// Sorting is disabled temporarily. +// +// The issue with sorting is that in touch devices it makes +// scrolling the page really hard. The image takes 100% of the width +// of the device (minus margin) and thus the whole screen is filled +// up with the sortable images. When the user tries to scroll by dragging +// the finger on the device, it actually start to sort the images and +// not scroll. +// +// TODO Think what to do with the scrolling issue when sorting is in use +// +// TODO Enable me: +// const SortableImage = SortableElement(Thumbnail); +const SortableImage = Thumbnail; // Create container where there are sortable images and passed children like "Add image" input etc. const SortableImages = SortableContainer(props => {