* Add dual booting logic to Gemfile This might be helpful for the Rails 6.0 upgrade project. * Add more than one gemfile to Travis' configuration We want to see how the application behaves with more than one Rails versions: - Gemfile -> Rails 5.2 - Gemfile.next -> Rails 6.0 This will help us figure out what needs to be addressed before migrating to Rails 6.0. If you want to read more about this technique (dual booting) you can check out this page: https://www.fastruby.io/blog/upgrade-rails/dual-boot/dual-boot-with-rails-6-0-beta.html * Fix joins * Upgrade Gemfile.next.lock * Make sure we're installing the correct versions of gems * Add Rails 6 notes * Update rubocop in Gemfile.next.lock * Fix organization spec * Fix page_views_spec * Add Rails 6 and run rails app:update * Remove some tricks * Remove Gemfile.next for now * Fix .content_type deprecation * Fix deprecation of .where.not NAND/NOR behavior * Fix deprecation of parameterized emails * Fix specs * Remove next flag for now * Fix spec (hopefully) * Add wait_for_javascript * Fix spec, thanks @maestromac! * Try without wait for javascript hack * Remove unnecessary bin/update * Remove file that snuck in the rebase * Update the vendored gems * Replace migrate+db:setup with db:prepare * Update vendored gems * Fix Gemfile.lock and update vendored stuff * Fix Gemfile.lock to be the same as master's minus the changes Co-authored-by: rhymes <rhymesete@gmail.com>
116 lines
4.2 KiB
Ruby
116 lines
4.2 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe "Api::V0::PodcastEpisodes", type: :request do
|
|
let(:podcast) { create(:podcast) }
|
|
|
|
describe "GET /api/podcast_episodes" do
|
|
it "returns json response" do
|
|
get api_podcast_episodes_path
|
|
|
|
expect(response.media_type).to eq("application/json")
|
|
end
|
|
|
|
it "does not return unreachable podcasts" do
|
|
create(:podcast_episode, reachable: false, podcast: podcast)
|
|
|
|
get api_podcast_episodes_path
|
|
|
|
expect(response.parsed_body.size).to eq(0)
|
|
end
|
|
|
|
it "does not return reachable podcast episodes belonging to unpublished podcasts" do
|
|
pe = create(:podcast_episode, reachable: true, podcast: create(:podcast, published: false))
|
|
|
|
get api_podcast_episodes_path
|
|
|
|
expect(response.parsed_body.map { |e| e["id"] }).not_to include(pe.id.to_s)
|
|
end
|
|
|
|
it "returns correct attributes for an episode", :aggregate_failures do
|
|
podcast_episode = create(:podcast_episode, podcast: podcast)
|
|
|
|
get api_podcast_episodes_path
|
|
|
|
response_episode = response.parsed_body.first
|
|
expect(response_episode.keys).to match_array(%w[class_name type_of id path image_url title podcast])
|
|
|
|
expect(response_episode["type_of"]).to eq("podcast_episodes")
|
|
expect(response_episode["class_name"]).to eq("PodcastEpisode")
|
|
%w[id path title].each do |attr|
|
|
expect(response_episode[attr]).to eq(podcast_episode.public_send(attr))
|
|
end
|
|
expect(response_episode["image_url"]).to eq(podcast_episode.podcast.image_url)
|
|
end
|
|
|
|
it "returns the episode's podcast json representation" do
|
|
podcast_episode = create(:podcast_episode, podcast: podcast)
|
|
|
|
get api_podcast_episodes_path
|
|
|
|
response_episode = response.parsed_body.first
|
|
expect(response_episode["podcast"]["title"]).to eq(podcast_episode.podcast.title)
|
|
expect(response_episode["podcast"]["slug"]).to eq(podcast_episode.podcast.slug)
|
|
expect(response_episode["podcast"]["image_url"]).to eq(podcast_episode.podcast.image_url)
|
|
end
|
|
|
|
it "returns episodes in reverse publishing order" do
|
|
pe1 = create(:podcast_episode, published_at: 1.day.ago, podcast: podcast)
|
|
pe2 = create(:podcast_episode, published_at: 1.day.from_now, podcast: podcast)
|
|
|
|
get api_podcast_episodes_path
|
|
expect(response.parsed_body.map { |pe| pe["id"] }).to eq([pe2.id, pe1.id])
|
|
end
|
|
|
|
it "supports pagination" do
|
|
create_list(:podcast_episode, 3, podcast: podcast)
|
|
|
|
get api_podcast_episodes_path, params: { page: 1, per_page: 2 }
|
|
expect(response.parsed_body.length).to eq(2)
|
|
|
|
get api_podcast_episodes_path, params: { page: 2, per_page: 2 }
|
|
expect(response.parsed_body.length).to eq(1)
|
|
end
|
|
|
|
it "sets the correct edge caching surrogate key for all tags" do
|
|
podcast_episode = create(:podcast_episode, reachable: true, podcast: podcast)
|
|
|
|
get api_podcast_episodes_path
|
|
|
|
expected_key = ["podcast_episodes", podcast_episode.record_key].to_set
|
|
expect(response.headers["surrogate-key"].split.to_set).to eq(expected_key)
|
|
end
|
|
|
|
context "when given a username parameter" do
|
|
it "returns only podcasts for a given username" do
|
|
pe1 = create(:podcast_episode, podcast: podcast)
|
|
create(:podcast_episode, podcast: create(:podcast))
|
|
|
|
get api_podcast_episodes_path(username: podcast.slug)
|
|
expect(response.parsed_body.map { |pe| pe["id"] }).to eq([pe1.id])
|
|
end
|
|
|
|
it "returns not found if the episode belongs to an unpublished podcast" do
|
|
unavailable_podcast = create(:podcast, published: false)
|
|
create(:podcast_episode, podcast: unavailable_podcast)
|
|
|
|
get api_podcast_episodes_path(username: unavailable_podcast.slug)
|
|
|
|
expect(response).to have_http_status(:not_found)
|
|
end
|
|
|
|
it "returns not found if the podcast episode is unreachable" do
|
|
create(:podcast_episode, reachable: false, podcast: podcast)
|
|
|
|
get api_podcast_episodes_path(username: podcast.slug)
|
|
|
|
expect(response).to have_http_status(:not_found)
|
|
end
|
|
|
|
it "returns not found if the username does not exist" do
|
|
get api_podcast_episodes_path(username: "foobar")
|
|
|
|
expect(response).to have_http_status(:not_found)
|
|
end
|
|
end
|
|
end
|
|
end
|