maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
docbrown/spec/requests
History
Jeremy Friesen d055613676
Adjusting ArticlePolicy for admin only posting (#16614) 
* Adjusting ArticlePolicy for admin only posting

The goal of this commit is actually two fold:

1) To add documentation regarding my current emerging understanding of
   our caching implementation as it relates to our authorization and
   authentication.
2) Flippiing "on" the feature's core authorization check.

Buried within this is the desired normalization of the authorization
between the `ArticlePolicy`'s `#create?`, `#preview?`, `#new?`.

My testing plan for this is to ask for SRE to spin-up a canary, then
test.  What does that look like?  I'm uncertain because this is nudge
closer towards our edge-caching strategy.  Which makes robust testing
more difficult.

Closes forem/forem#16483
Related to #16529, #16571, #16536, #16529
Informs #16490, #16606

* Update spec/requests/editor_spec.rb

Co-authored-by: Jamie Gaskins <jgaskins@hey.com>

Co-authored-by: Jamie Gaskins <jgaskins@hey.com>
2022-02-21 10:09:13 -05:00
..
admin Require profile fields to belong to a group (#16390) 2022-02-15 09:27:18 -06:00
api/v0 Revert "Only make one network call to fetch all existing tags in editor (#16610)" (#16641) 2022-02-18 11:54:38 +00:00
articles Small win: Add "Feature post" button alongside new "admin actions" drawer in mod panel. (#16544) 2022-02-17 12:43:27 -05:00
incoming_webhooks/mailchimp Use new UserSetting and UserNotificationSettings and Ignore Related User Table Fields (#14121) 2021-07-08 09:31:34 -05:00
notifications [deploy] Remove All Notification Count Helper Classes (#8221) 2020-06-02 09:48:02 -05:00
podcasts Refactoring questions asked of user (#15762) 2021-12-21 12:45:12 -05:00
shared_examples Hiding comments: an option to hide or keep children (#15178) 2021-11-18 11:57:40 +03:00
stories Bump rubocop from 1.24.1 to 1.25.0 (#16171) 2022-01-18 19:46:42 -05:00
user Add a contact email address to the /admin/customization/config (#16497) 2022-02-15 17:37:08 +02:00
api_secrets_create_spec.rb Rubocop: move dot in multi-line calls to leading position (#9262) 2020-07-16 15:51:11 +02:00
api_secrets_destroy_spec.rb Fix access token revoking (#3131) 2019-06-11 15:53:58 -04:00
article_approvals_spec.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
async_info_spec.rb Remove Creator Onboarding Feature Flags from Codebase (#15982) 2022-01-31 11:30:43 -07:00
badges_spec.rb Add badges index page. (#4236) 2019-10-06 17:34:52 -04:00
collections_spec.rb Show correct number in series truncation. (#13799) 2021-05-24 15:47:06 -06:00
comments_create_spec.rb When a user is blocked from commenting on an article, show correct error message (#15009) 2021-10-14 07:42:08 -06:00
comments_destroy_spec.rb Rubocop: Enable and fix Style/StringConcatenation (#9844) 2020-08-18 14:50:15 +02:00
comments_spec.rb Adjusting ArticlePolicy for admin only posting (#16614) 2022-02-21 10:09:13 -05:00
comments_update_spec.rb [deploy] Remove redirect on comments#update (#10337) 2020-09-29 15:33:51 -04:00
credits_spec.rb [deploy] Rename classified listings (#7910) 2020-05-27 13:35:09 +00:00
dashboard_spec.rb Spelling (#15702) 2021-12-07 06:59:10 -07:00
devices_spec.rb ForemMobile namespaced functions (#15212) 2021-11-23 15:25:29 -06:00
discussion_locks_spec.rb Spelling (#15702) 2021-12-07 06:59:10 -07:00
display_ad_events_spec.rb Extracting constants and tidying tests (#15946) 2022-01-05 09:19:39 -05:00
editor_spec.rb Adjusting ArticlePolicy for admin only posting (#16614) 2022-02-21 10:09:13 -05:00
email_subscriptions_spec.rb Use new UserSetting and UserNotificationSettings and Ignore Related User Table Fields (#14121) 2021-07-08 09:31:34 -05:00
feedback_messages_spec.rb ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
followings_spec.rb Refactoring to add helper method (#16064) 2022-01-12 11:21:44 -05:00
follows_bulk_show_spec.rb Spelling (#15702) 2021-12-07 06:59:10 -07:00
follows_bulk_update_spec.rb Update all followed tag with one click (#11454) 2021-01-05 16:15:37 +01:00
follows_create_spec.rb Clear the cached settings before testing the rate limiter (#13669) 2021-05-05 14:34:22 -05:00
follows_show_spec.rb Rubocop: enable and fix Style/Send and Style/Next (#9366) 2020-07-20 16:28:00 +02:00
ga_events_spec.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
github_repos_spec.rb ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
html_variant_successes_spec.rb Replace peform_enqueued_jobs with sidekiq_perform_enqueued_jobs in specs (#6454) 2020-03-04 11:39:48 -07:00
html_variant_trials_spec.rb Replace peform_enqueued_jobs with sidekiq_perform_enqueued_jobs in specs (#6454) 2020-03-04 11:39:48 -07:00
image_uploads_spec.rb Refactor:Change Image Article Upload Path to uploads/articles (#12668) 2021-02-15 11:52:00 -06:00
invitations_spec.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
liquid_embeds_spec.rb Move work from template to controller (#16092) 2022-01-18 11:21:25 -05:00
liquid_tags_request_spec.rb [deploy] Add LiquidTagsController (#10241) 2020-09-08 12:07:33 -04:00
listings_spec.rb A suspended user returns 403 instead of 500 (#16408) 2022-02-04 09:42:23 -05:00
moderations_spec.rb Spelling (#15702) 2021-12-07 06:59:10 -07:00
notification_counts_spec.rb [deploy] Optimization:Use Scope and current_user to Get Notification Count (#8177) 2020-06-01 09:27:46 -05:00
notification_subscriptions_spec.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
notifications_spec.rb Rename User.dev_account to User.staff_account (#14321) 2021-07-26 10:46:26 -04:00
onboardings_spec.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
open_search_spec.rb Clean up SiteConfig (#13738) 2021-05-18 09:38:31 +07:00
organizations_update_spec.rb Upgrade Rails to 6.1.3.1 (#11333) 2021-04-05 10:39:48 -04:00
page_views_spec.rb Extract page view updates into workers (#12686) 2021-02-17 09:24:05 +07:00
pages_spec.rb Remove hardcoded /badge page that is DEV-only ✂️✂️✂️ (#16303) 2022-01-27 13:29:05 -05:00
poll_skips_spec.rb Small ActiveRecord optimizations: begone race conditions and hello bulk insert (#8436) 2020-06-15 17:57:14 +02:00
poll_votes_spec.rb Fix rubocop detected offenses (#4552) 2019-10-24 11:53:03 -04:00
profile_field_groups_request_spec.rb Deployment Task: Update onboarding fields prior to #11629 (#11704) 2020-12-07 14:57:18 -05:00
profile_pins_spec.rb [deploy] Finalize deleting user associations (#5624) 2020-01-23 11:29:47 -05:00
profile_preview_cards_spec.rb Profile generalization cleanup phase 2 (#14555) 2021-08-27 09:17:26 +07:00
profiles_request_spec.rb Drop profile columns from user (#10707) 2020-12-03 08:14:38 +07:00
rating_votes_spec.rb Add experience level averaging to articles (#1922) 2019-02-28 08:17:29 -08:00
reactions_spec.rb Don't try to create invalid RatingVote (#14706) 2021-09-14 09:41:59 +07:00
reading_list_items_spec.rb [deploy] Fix Reading List Counter Without last_reacted_at Default (#10933) 2020-10-19 13:26:19 -05:00
registrations_spec.rb Remove Creator Onboarding Feature Flags from Codebase (#15982) 2022-01-31 11:30:43 -07:00
response_templates_spec.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
search_spec.rb Added "Tags" category to search results (#16265) 2022-01-26 20:51:15 +03:00
sidebars_spec.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
sitemaps_spec.rb Fix legacy sitemap logic (#14926) 2021-10-07 08:59:16 -04:00
social_previews_spec.rb Remove SheCoded Specific Code (#13363) 2021-04-12 11:04:58 -07:00
stories_index_spec.rb Re-enable stories specs (#16182) 2022-01-19 13:14:31 -05:00
stories_show_spec.rb Moved setting old_username from before_validation to Users::Update (#15782) 2021-12-20 11:08:09 +03:00
stripe_active_cards_spec.rb Abstract DatadogStatsClient to ForemStatsClient (#12304) 2021-01-27 11:25:44 -05:00
tag_adjustments_spec.rb [deploy] Rubocop: fix violations of Layout/LineLength (#9197) 2020-07-08 08:36:36 -05:00
tags_spec.rb Added search feature to tags index to search all tags (#16292) 2022-01-28 08:00:11 -05:00
universal_links_spec.rb Add exclusion to AASA supported paths (#14593) 2021-08-26 10:17:39 -06:00
user_blocks_spec.rb ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
user_subscriptions_spec.rb Improve error message of User Subscriptions (#11689) 2020-12-01 08:41:49 -08:00
users_onboarding_spec.rb Onboarding "improvements" (#16210) 2022-01-21 10:58:05 -06:00
video_states_update_spec.rb Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
videos_spec.rb Videos UI update (#15177) 2021-10-28 09:34:44 +02:00