Bump rubocop from 1.24.1 to 1.25.0 (#16171)

* Bump rubocop from 1.24.1 to 1.25.0

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.24.1 to 1.25.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop/compare/v1.24.1...v1.25.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Appeasing rubocop

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Friesen <jeremy.n.friesen@gmail.com>

Gemfile

@@ -140,7 +140,7 @@ group :development, :test do
   gem "pry", "~> 0.14" # An IRB alternative and runtime developer console
   gem "pry-rails", "~> 0.3" # Use Pry as your rails console
   gem "rspec-rails", "~> 5.0" # rspec-rails is a testing framework for Rails 3+
-  gem "rubocop", "~> 1.24", require: false # Automatic Ruby code style checking tool
+  gem "rubocop", "~> 1.25", require: false # Automatic Ruby code style checking tool
   gem "rubocop-performance", "~> 1.13", require: false # A collection of RuboCop cops to check for performance optimizations in Ruby code
   gem "rubocop-rails", "~> 2.13", require: false # Automatic Rails code style checking tool
   gem "rubocop-rspec", "~> 2.7", require: false # Code style checking for RSpec files

Gemfile.lock

@@ -688,9 +688,9 @@ GEM
     rspec-support (3.10.2)
     rss (0.2.9)
       rexml
-    rubocop (1.24.1)
+    rubocop (1.25.0)
       parallel (~> 1.10)
-      parser (>= 3.0.0.0)
+      parser (>= 3.1.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml
@@ -1008,7 +1008,7 @@ DEPENDENCIES
   rspec-rails (~> 5.0)
   rspec-retry (~> 0.6)
   rss (~> 0.2.9)
-  rubocop (~> 1.24)
+  rubocop (~> 1.25)
   rubocop-performance (~> 1.13)
   rubocop-rails (~> 2.13)
   rubocop-rspec (~> 2.7)

spec/requests/stories/tagged_articles_spec.rb

@@ -63,7 +63,7 @@ RSpec.describe "Stories::TaggedArticlesIndex", type: :request do
 
         it "renders page when tag is not supported but has at least one approved article" do
           unsupported_tag = create(:tag, supported: false)
-          article = create(:article, published: true, approved: true, tags: unsupported_tag)
+          create(:article, published: true, approved: true, tags: unsupported_tag)
 
           get "/t/#{unsupported_tag.name}/top/week"
           expect(response.body).to include(unsupported_tag.name)