maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Select max from a subquery of two things (#16177)

Browse source 
* Select max from a subquery of two things

max(int, int) not a function, says postgres, once it stopped yelling
about parenthesis balancing.

* prefer greatest to select max from subquery
This commit is contained in:
Daniel Uber 2022-01-18 17:21:14 -06:00 • committed by GitHub
parent 06f6573436
commit 394d33e134
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/services/articles/feeds/weighted_query_strategy.rb
View file

@ -462,7 +462,7 @@ module Articles
when "final_order_by_random_weighted_to_last_comment_at"
# rubocop:disable Layout/LineLength
articles
.order(Arel.sql("RANDOM() ^ (1.0 / (max(1, (extract(epoch from now() - articles.last_comment_at)::integer)) ASC"))
.order(Arel.sql("RANDOM() ^ (1.0 / greatest( 1, (extract(epoch from now() - articles.last_comment_at)::integer))) ASC"))
# rubocop:enable Layout/LineLength
else # original
articles