docbrown/spec
Bolarinwa Balogun e04d84bc4c Improve Gist Link Regex (#2592)
* Improve Gist Link Regex

While working with the gist liquid tag, I noticed that valid gist links
were resulting in errors. After looking at `gist_tag.rb`, I noticed
that for a link to be considered valid the gist-id had to be exactly 32
characters which is not always true.

I changed the regex so links with a gist-id of at least one character and
at most 32 characters is considered valid. I decided to continue with
the 32 characters that had previously been used as the upper bound. I
also made a change so links with a github username that starts or ends
with hypens or contains consecutive hypens are considered invalid. The
aforementioned change was based on the validation message from the
create new GitHub account form.

* Change gist_link to gist_links in spec file for Gist tag
2019-04-29 12:24:52 -04:00
..
black_box BlackBox specs #2524 (#2542) 2019-04-25 10:19:11 -04:00
decorators Display comment published timestamp according to user's locale (#1970) 2019-03-08 15:19:37 -05:00
factories Fix lints (#2553) [ci skip] 2019-04-25 07:56:15 -04:00
fixtures/approvals/rssreader Upgrade Honeycomb gem, fix and improve RssReader tests (#2319) 2019-04-07 15:27:53 -04:00
helpers Fix community name (#2415) 2019-04-13 16:12:21 -04:00
jobs Move send new badge achievement notification to ActiveJob (#2474) 2019-04-29 10:51:08 -04:00
labor BlackBox specs #2524 (#2542) 2019-04-25 10:19:11 -04:00
lib Social Card upgrade - Part 1 (#2090) 2019-03-22 16:28:02 -04:00
liquid_tags Improve Gist Link Regex (#2592) 2019-04-29 12:24:52 -04:00
mailers Add mailers specs for tracking (#2523) 2019-04-23 12:38:11 -04:00
models Move send new badge achievement notification to ActiveJob (#2474) 2019-04-29 10:51:08 -04:00
observers Enable random order for specs (#2466) [ci skip] 2019-04-17 11:30:23 -04:00
policies Upgrade factory_bot_rails to 5.2.0 (#2532) [ci skip] 2019-04-23 13:21:22 -04:00
requests Move send new badge achievement notification to ActiveJob (#2474) 2019-04-29 10:51:08 -04:00
routing Enabled rubocop/lint (#2130) 2019-03-21 10:53:44 -04:00
services Move send new badge achievement notification to ActiveJob (#2474) 2019-04-29 10:51:08 -04:00
support Remove unused code (#2567) [ci skip] 2019-04-26 12:16:16 -04:00
system Enable random order for specs (#2466) [ci skip] 2019-04-17 11:30:23 -04:00
views Migrate feature test to system test (#2301) 2019-04-04 12:15:10 -04:00
rails_helper.rb Add mailers specs for tracking (#2523) 2019-04-23 12:38:11 -04:00
spec_helper.rb Temporarily comment out random (#2486) 2019-04-18 11:56:38 -04:00