maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix community name (#2415)

Browse source 
* Add community_qualified_name helper for the homepage

* Fix more community names
This commit is contained in:
rhymes 2019-04-13 22:12:21 +02:00 • committed by Ben Halpern
parent d27874adc9
commit 1d9ef3afa7
9 changed files with 63 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/helpers/application_helper.rb
View file

@ -207,4 +207,8 @@ module ApplicationHelper
end
logo
end
def community_qualified_name
"The #{ApplicationConfig['COMMUNITY_NAME']} Community"
end
end

11
app/views/articles/index.html.erb
View file

@ -11,20 +11,21 @@
<meta property="og:type" content="website" />
<meta property="og:url" content="https://dev.to<%= request.path %>" />
<meta property="og:title" content="<%= title_with_timeframe(page_title: "The #{ApplicationConfig['COMMUNITY_NAME']} Community", timeframe: params[:timeframe]) %>" />
<meta property="og:title" content="<%= title_with_timeframe(page_title: community_qualified_name, timeframe: params[:timeframe]) %>" />
<meta property="og:image" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png">
<meta property="og:description" content="Where programmers share ideas and help each other grow." />
<meta property="og:site_name" content="The #{ApplicationConfig['COMMUNITY_NAME']} Community" />
<meta property="og:site_name" content="<%= community_qualified_name %>" />
<meta name="twitter:site" content="@ThePracticalDev">
<meta name="twitter:title" content="<%= title_with_timeframe(page_title: "The #{ApplicationConfig['COMMUNITY_NAME']} Community", timeframe: params[:timeframe]) %>">
<meta name="twitter:title" content="<%= title_with_timeframe(page_title: community_qualified_name, timeframe: params[:timeframe]) %>">
<meta name="twitter:description" content="Where programmers share ideas, experiences, and help each other grow.">
<meta name="twitter:image:src" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png">
<meta name="twitter:card" content="summary_large_image">
<%= auto_discovery_link_tag(:rss, "https://dev.to/feed", title: "#{ApplicationConfig['COMMUNITY_NAME']} RSS Feed") %>
<% end %>
<% params.delete(:i) %>
<% cache("main-stories-index-#{params.to_s}-#{user_signed_in?}", expires_in: 4.minutes) do %>
<% cache("main-stories-index-#{params}-#{user_signed_in?}", expires_in: 4.minutes) do %>
<div class="home" id="index-container"
data-params="<%= params.to_json(only: %i[tag username q]) %>" data-which="<%= @list_of %>"
data-algolia-tag=""
@ -149,4 +150,4 @@
<%= render "stories/narrow_nav_menu" %>
<%= render "stories/stories_list_script" %>
<% end %>
<% end %>

2
app/views/layouts/_signup_modal.html.erb
View file

@ -15,7 +15,7 @@
sign_url: true), class: "sloan", alt: "sloth-mascot") %>
<h1>Join our <%= ApplicationConfig["COMMUNITY_NAME"] %> Community :)</h1>
<p>
We’re a place where coders share, stay up-to-date and grow their careers.
We're a place where coders share, stay up-to-date and grow their careers.
</p>
<a href="/users/auth/twitter?callback_url=<%= ApplicationConfig["APP_PROTOCOL"] %><%= ApplicationConfig["APP_DOMAIN"] %>/users/auth/twitter/callback" class="sign-up-link cta" data-no-instant>
<img src="<%= asset_path("twitter-logo.svg") %>" class="icon-img" alt="Twitter" /> Auth With Twitter

2
app/views/layouts/application.html.erb
View file

@ -68,7 +68,7 @@
<%= csrf_meta_tags %>
<% end %>
<link rel="manifest" href="/manifest.json" />
<link rel="search" href="https://dev.to/search.xml" type="application/opensearchdescription+xml" title="The <%= ApplicationConfig["COMMUNITY_NAME"] %> Community" />
<link rel="search" href="https://dev.to/search.xml" type="application/opensearchdescription+xml" title="<%= community_qualified_name %>" />
<% end %>
</head>
<body data-user-status="<%= user_logged_in_status %>" data-pusher-key="<%= ApplicationConfig["PUSHER_KEY"] %>">

3
app/views/videos/index.html.erb
View file

@ -10,7 +10,7 @@
<meta property="og:title" content="<% title "Videos" %>" />
<meta property="og:image" content="https://thepracticaldev.s3.amazonaws.com/i/g355ol6qsrg0j2mhngz9.png">
<meta property="og:description" content="All videos on DEV" />
<meta property="og:site_name" content="The #{ApplicationConfig['COMMUNITY_NAME']} Community" />
<meta property="og:site_name" content="<%= community_qualified_name %>" />
<meta name="twitter:site" content="@ThePracticalDev">
<meta name="twitter:title" content="<% title "Videos" %>">
@ -19,7 +19,6 @@
<meta name="twitter:card" content="summary_large_image">
<% end %>
<div class="home video-page-title" id="index-container" data-which="videos" data-params="<%= params.to_json(only: %i[tag username q]) %>">
<header>
<h1>DEV on Video</h1>

10
spec/helpers/application_helper_spec.rb Normal file
View file

@ -0,0 +1,10 @@
require "rails_helper"
RSpec.describe ApplicationHelper, type: :helper do
describe "#community_qualified_name" do
it "equals to the full qualified community name" do
expected_name = "The #{ApplicationConfig['COMMUNITY_NAME']} Community"
expect(helper.community_qualified_name).to eq(expected_name)
end
end
end

19
spec/system/homepage/user_visits_homepage_articles_spec.rb
View file

@ -43,5 +43,24 @@ RSpec.describe "User visits a homepage", type: :system do
include_examples "no sign_in invitation"
end
describe "meta tags" do
before { visit "/" }
it "contains the qualified community name in og:title" do
selector = "meta[property='og:title'][content='#{community_qualified_name}']"
expect(page).to have_selector(selector, visible: false)
end
it "contains the qualified community name in og:site_name" do
selector = "meta[property='og:site_name'][content='#{community_qualified_name}']"
expect(page).to have_selector(selector, visible: false)
end
it "contains the qualified community name in twitter:title" do
selector = "meta[name='twitter:title'][content='#{community_qualified_name}']"
expect(page).to have_selector(selector, visible: false)
end
end
end
end

7
spec/system/homepage/user_visits_homepage_spec.rb
View file

@ -22,6 +22,13 @@ RSpec.describe "User visits a homepage", type: :system do
end
expect(page).to have_text("design your experience")
end
describe "link tags" do
it "contains the qualified community name in the search link" do
selector = "link[rel='search'][title='#{community_qualified_name}']"
expect(page).to have_selector(selector, visible: false)
end
end
end
context "when logged in user" do

14
spec/system/videos/user_visits_videos_spec.rb Normal file
View file

@ -0,0 +1,14 @@
require "rails_helper"
RSpec.describe "User visits the videos page", type: :system do
context "when user hasn't logged in" do
before { visit "/videos" }
describe "meta tags" do
it "contains the qualified community name in og:site_name" do
selector = "meta[property='og:site_name'][content='#{community_qualified_name}']"
expect(page).to have_selector(selector, visible: false)
end
end
end
end